ibandit 0.11.18 → 0.11.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 681cc7c463a9465cdc62bff2314b751318613dfa
-  data.tar.gz: 4a8b95e46e1bfa8c2f5be42b1d868b191fd3e189
+  metadata.gz: 917798c3e0f8eefb8cafc1a8f186929df14f86b3
+  data.tar.gz: c93a617949e9e5e416346f06f42ddda5aeb598af
 SHA512:
-  metadata.gz: e56290b46969a74e25558b7645ae83d3ff1e2b7fc37a2db95ad7b91b22c5b58d8b98837db5a60b7a871f97cc49ec286db4b1c2e75208c920d8dce7d8ebae70d1
-  data.tar.gz: abcdec76c9a7c3395539236e6c6f2fc6d702fed76ae4bcf01aa3cecea6c024e1bb0c4987c38395a2bf9dec4b7400f1efd6d15a343389a4bf12451d4fae584243
+  metadata.gz: 78bb3acc74a5b854d26f58fc137d5153a03ae12b566d6a12786c218175eb2f57a54e0b3a0cdd681703408b2e79a022988040494c2ce6fc9343cc562d9eb8c327
+  data.tar.gz: c5c18c90d395431e0d553f5ca7e6aa6d7af1eef20ee28755ada3135bed83183ed1085d1f88efd8797737a05979ceff7e44d4de7f56ce02cdd250c93c1591d22b

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.11.19 - October 15, 2018
+
+- Add support for CA pseudo-IBANs
+
 ## 0.11.18 - October 9, 2018
 
 - Improve existing error message translations and add support for

data/README.md

@@ -27,6 +27,7 @@ For example:
 | Belgium         | :white_check_mark:           | :white_check_mark: |                    |
 | Bulgaria        | :white_check_mark:           | :white_check_mark: |                    |
 | Croatia         | :white_check_mark:           | :white_check_mark: |                    |
+| Canada          |                              |                    | :white_check_mark: |
 | Cyprus          | :white_check_mark:           | :white_check_mark: |                    |
 | Czech Republic  | :white_check_mark:           | :white_check_mark: |                    |
 | Denmark         | :white_check_mark:           | :white_check_mark: |                    |

data/data/structures.yml

@@ -886,3 +886,13 @@ TL:
   :bban_format: "\\d{3}\\d{14}\\d{2}"
   :bank_code_format: "\\d{3}"
   :account_number_format: " \\d{14} \\d{2}"
+CA:
+  :bank_code_length: 4
+  :branch_code_length: 5
+  :account_number_length: 12
+  :bank_code_format: "\\d{4}"
+  :branch_code_format: "\\d{5}"
+  :account_number_format: "\\d{7,12}"
+  :pseudo_iban_bank_code_length: 4
+  :pseudo_iban_branch_code_length: 5
+  :pseudo_iban_account_number_length: 12

data/lib/ibandit/constants.rb

@@ -4,7 +4,7 @@ module Ibandit
                                           HR HU IE IS IT LT LU LV MC MT NL NO PL
                                           PT RO SE SI SK SM].freeze
 
-    PSEUDO_IBAN_COUNTRY_CODES = %w[AU SE NZ].freeze
+    PSEUDO_IBAN_COUNTRY_CODES = %w[AU SE NZ CA].freeze
     DECONSTRUCTABLE_IBAN_COUNTRY_CODES =
       CONSTRUCTABLE_IBAN_COUNTRY_CODES - PSEUDO_IBAN_COUNTRY_CODES
 
@@ -14,6 +14,7 @@ module Ibandit
       "SE" => "X", # Using X for backwards compatibility
       "AU" => "_", # Using _ because AU account numbers are alphanumeric
       "NZ" => "_",
+      "CA" => "_",
     }.freeze
 
     SUPPORTED_COUNTRY_CODES = (

data/lib/ibandit/local_details_cleaner.rb

@@ -84,6 +84,10 @@ module Ibandit
       }
     end
 
+    def self.clean_ca_details(local_details)
+      local_details
+    end
+
     def self.clean_bg_details(local_details)
       # Bulgarian national bank details were replaced with IBANs in 2006.
       local_details

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = "0.11.18".freeze
+  VERSION = "0.11.19".freeze
 end

data/spec/ibandit/iban_spec.rb

@@ -358,6 +358,96 @@ describe Ibandit::IBAN do
       end
     end
 
+    context "when the IBAN was created with local details for Canada" do
+      let(:arg) do
+        {
+          country_code: "CA",
+          bank_code: "0036",
+          branch_code: "00063",
+          account_number: account_number,
+        }
+      end
+
+      context "and a 7 digit account number" do
+        let(:account_number) { "0123456" }
+
+        its(:country_code) { is_expected.to eq("CA") }
+        its(:bank_code) { is_expected.to eq("0036") }
+        its(:branch_code) { is_expected.to eq("00063") }
+        its(:account_number) { is_expected.to eq("0123456") }
+        its(:swift_bank_code) { is_expected.to eq("0036") }
+        its(:swift_branch_code) { is_expected.to eq("00063") }
+        its(:swift_account_number) { is_expected.to eq("0123456") }
+        its(:pseudo_iban) { is_expected.to eq("CAZZ003600063_____0123456") }
+
+        # ibandit account number length validation can check for maximum
+        # length but not against a range, say, 7 to 12 digits, allowed in CA.
+        #
+        # given we are only going to deal with pseudo-IBANs in CA, choosing to
+        # not complete IBAN validation unless we need it.
+        #
+        its(:iban) { is_expected.to be_nil }
+        its(:valid?) { is_expected.to eq(false) }
+        its(:to_s) { is_expected.to eq("") }
+      end
+
+      context "and a 12 digit account number" do
+        let(:account_number) { "012345678900" }
+
+        its(:country_code) { is_expected.to eq("CA") }
+        its(:bank_code) { is_expected.to eq("0036") }
+        its(:branch_code) { is_expected.to eq("00063") }
+        its(:account_number) { is_expected.to eq("012345678900") }
+        its(:swift_bank_code) { is_expected.to eq("0036") }
+        its(:swift_branch_code) { is_expected.to eq("00063") }
+        its(:swift_account_number) { is_expected.to eq("012345678900") }
+        its(:pseudo_iban) { is_expected.to eq("CAZZ003600063012345678900") }
+
+        # ibandit account number length validation can check for maximum
+        # length but not against a range, say, 7 to 12 digits, allowed in CA.
+        #
+        # given we are only going to deal with pseudo-IBANs in CA, choosing to
+        # not complete IBAN validation unless we need it.
+        #
+        its(:iban) { is_expected.to be_nil }
+        its(:valid?) { is_expected.to eq(true) }
+        its(:to_s) { is_expected.to eq("") }
+      end
+    end
+
+    context "when the IBAN was created from an Canadian pseudo-IBAN" do
+      let(:arg) { "CAZZ0036000630123456" }
+
+      its(:country_code) { is_expected.to eq("CA") }
+      its(:bank_code) { is_expected.to eq("0036") }
+      its(:branch_code) { is_expected.to eq("00063") }
+      its(:account_number) { is_expected.to eq("0123456") }
+      its(:swift_bank_code) { is_expected.to eq("0036") }
+      its(:swift_branch_code) { is_expected.to eq("00063") }
+      its(:swift_account_number) { is_expected.to eq("0123456") }
+      its(:pseudo_iban) { is_expected.to eq("CAZZ003600063_____0123456") }
+
+      # ibandit account number length validation can check for maximum
+      # length but not against a range, say, 7 to 12 digits, allowed in CA.
+      #
+      # given we are only going to deal with pseudo-IBANs in CA, choosing to
+      # not complete IBAN validation unless we need it.
+      #
+      its(:iban) { is_expected.to be_nil }
+      its(:valid?) { is_expected.to eq(false) }
+      its(:to_s) { is_expected.to eq("") }
+    end
+
+    context "when the input is an invalid Canadan pseudo-IBAN" do
+      let(:arg) { "CAZZ00360006301234" }
+
+      it "is invalid and has the correct errors" do
+        expect(subject.valid?).to eq(false)
+        expect(subject.errors).
+          to eq(account_number: "is the wrong length (should be 12 characters)")
+      end
+    end
+
     context "when the IBAN was created with local details for New Zealand" do
       let(:arg) do
         {

data/spec/ibandit/pseudo_iban_assembler_spec.rb

@@ -138,6 +138,57 @@ describe Ibandit::PseudoIBANAssembler do
     end
   end
 
+  context "for Canada" do
+    context "with valid parameters" do
+      let(:local_details) do
+        {
+          country_code: "CA",
+          bank_code: "0036",
+          branch_code: "00063",
+          account_number: "0123456",
+        }
+      end
+
+      it { is_expected.to eq("CAZZ003600063_____0123456") }
+    end
+
+    context "without a bank_code" do
+      let(:local_details) do
+        {
+          country_code: "CA",
+          branch_code: "00063",
+          account_number: "0123456",
+        }
+      end
+
+      it { is_expected.to be_nil }
+    end
+
+    context "without a branch code" do
+      let(:local_details) do
+        {
+          country_code: "CA",
+          bank_code: "0036",
+          account_number: "0123456",
+        }
+      end
+
+      it { is_expected.to be_nil }
+    end
+
+    context "without an account number" do
+      let(:local_details) do
+        {
+          country_code: "CA",
+          bank_code: "0036",
+          branch_code: "00063",
+        }
+      end
+
+      it { is_expected.to be_nil }
+    end
+  end
+
   context "for a country that does not have pseudo-IBANs" do
     let(:local_details) do
       {

data/spec/ibandit/pseudo_iban_splitter_spec.rb

@@ -68,5 +68,32 @@ describe Ibandit::PseudoIBANSplitter do
       its([:branch_code]) { is_expected.to eq("123456") }
       its([:account_number]) { is_expected.to eq("X123456789") }
     end
+
+    context "for a canadian pseudo-IBAN without padding" do
+      let(:pseudo_iban) { "CAZZ0036000630123456" }
+
+      its([:country_code]) { is_expected.to eq("CA") }
+      its([:bank_code]) { is_expected.to eq("0036") }
+      its([:branch_code]) { is_expected.to eq("00063") }
+      its([:account_number]) { is_expected.to eq("0123456") }
+    end
+
+    context "for a canadian pseudo-IBAN with padding" do
+      let(:pseudo_iban) { "CAZZ003600063_____0123456" }
+
+      its([:country_code]) { is_expected.to eq("CA") }
+      its([:bank_code]) { is_expected.to eq("0036") }
+      its([:branch_code]) { is_expected.to eq("00063") }
+      its([:account_number]) { is_expected.to eq("0123456") }
+    end
+
+    context "for a canadian pseudo-IBAN with a 12-digit account number" do
+      let(:pseudo_iban) { "CAZZ003600063012345678900" }
+
+      its([:country_code]) { is_expected.to eq("CA") }
+      its([:bank_code]) { is_expected.to eq("0036") }
+      its([:branch_code]) { is_expected.to eq("00063") }
+      its([:account_number]) { is_expected.to eq("012345678900") }
+    end
   end
 end

metadata

@@ -1,125 +1,125 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.11.18
+  version: 0.11.19
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-09 00:00:00.000000000 Z
+date: 2018-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.10'
 - !ruby/object:Gem::Dependency
   name: pry-nav
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.2'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.3'
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.2'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.52.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.52.0
 - !ruby/object:Gem::Dependency
   name: sax-machine
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Ibandit is a Ruby library for manipulating and validating IBANs. It allows
@@ -131,10 +131,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rubocop.yml"
-- ".rubocop_todo.yml"
-- ".travis.yml"
+- .gitignore
+- .rubocop.yml
+- .rubocop_todo.yml
+- .travis.yml
 - CHANGELOG.md
 - Gemfile
 - LICENSE
@@ -200,17 +200,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.0.14.1
 signing_key: 
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.