ibandit 0.11.10 → 0.11.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a9a33af92874b7a40f4a8696b7cd25eb59590094
-  data.tar.gz: 3cdd502edd0f62bc40119f3863b8711a21bd6669
+  metadata.gz: 7cf488eed67769ff39b6249be1b7689359f9eb4a
+  data.tar.gz: 0f32aaf43214999c417badf26c730a334bdd3610
 SHA512:
-  metadata.gz: 062edcac1e201a30ea007c6dacf131d611fd679bf74c711d290ea18e91246c933cd4cc55a9e523c9bbdd810aa6dcde80b11af092adbdcbb110c3d736b3638126
-  data.tar.gz: d00da8559f97e04603bed2dac82fc66792bff1ed3d95510f4cfc3d8c0480581dd3f0c13e0b901efc4f1ddce1b0568e7cf119706143f60f25f490b11cc0316e80
+  metadata.gz: 20202b4dd9710f4912bbef1b0c7f108c1c65aa6c1fc6c279e9b4538df4e204e1aade6dd4c2ce5b28fe8351c46d24363c75125e2c1f7c75e57ce3dce2d6a54bac
+  data.tar.gz: f918279bb0f3943d334ae6f1fbc67f38357d3902a0e09af53f8187c7879232137a54b45ae0660f82472c30411a40519a6087f00414dee02e4ca6678c8d6e4ed7

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.11.11 - March 1, 2018
+
+- Fix padding for Australian pseudo-IBANs
+
 ## 0.11.10 - February 21, 2018
 
 - Fix support for Australian bank accounts

data/lib/ibandit/constants.rb

@@ -10,6 +10,11 @@ module Ibandit
 
     PSEUDO_IBAN_CHECK_DIGITS = "ZZ".freeze
 
+    PSEUDO_IBAN_PADDING_CHARACTER_FOR = {
+      "SE" => "X", # Using X for backwards compatibility
+      "AU" => "_", # Using _ because AU account numbers are alphanumeric
+    }.freeze
+
     SUPPORTED_COUNTRY_CODES = (
       CONSTRUCTABLE_IBAN_COUNTRY_CODES +
       DECONSTRUCTABLE_IBAN_COUNTRY_CODES +

data/lib/ibandit/pseudo_iban_assembler.rb

@@ -35,6 +35,10 @@ module Ibandit
       Constants::PSEUDO_IBAN_COUNTRY_CODES.include?(@country_code)
     end
 
+    def padding_character
+      Constants::PSEUDO_IBAN_PADDING_CHARACTER_FOR[@country_code]
+    end
+
     def bank_code_valid?
       param_valid?(@bank_code, :pseudo_iban_bank_code_length)
     end
@@ -67,7 +71,7 @@ module Ibandit
 
     def pad(number, length_key)
       return if number.nil?
-      number.rjust(structure[length_key], "X")
+      number.rjust(structure[length_key], padding_character)
     end
 
     def structure

data/lib/ibandit/pseudo_iban_splitter.rb

@@ -65,12 +65,17 @@ module Ibandit
       Constants::PSEUDO_IBAN_COUNTRY_CODES.include?(country_code)
     end
 
+    def padding_character
+      Constants::PSEUDO_IBAN_PADDING_CHARACTER_FOR[country_code]
+    end
+
     def structure
       Ibandit.structures[country_code]
     end
 
     def remove_leading_padding(input)
-      input.gsub(/\AX+/, "")
+      return unless padding_character
+      input.gsub(/\A#{padding_character}+/, "")
     end
   end
 end

data/lib/ibandit/version.rb

@@ -1,3 +1,3 @@
 module Ibandit
-  VERSION = "0.11.10".freeze
+  VERSION = "0.11.11".freeze
 end

data/spec/ibandit/constants_spec.rb

@@ -0,0 +1,14 @@
+require "spec_helper"
+
+describe Ibandit::Constants do
+  Ibandit::Constants::PSEUDO_IBAN_COUNTRY_CODES.each do |country_code|
+    context country_code do
+      it "has padding character" do
+        padding =
+          Ibandit::Constants::PSEUDO_IBAN_PADDING_CHARACTER_FOR[country_code]
+        expect(padding).to_not be_nil
+        expect(padding.length).to eq(1)
+      end
+    end
+  end
+end

data/spec/ibandit/iban_spec.rb

@@ -202,19 +202,53 @@ describe Ibandit::IBAN do
         its(:to_s) { is_expected.to eq("") }
       end
 
-      context "and a 10 characters alphanumeric account number" do
-        let(:account_number) { "AB1234567" }
+      context "and a 10 characters account number" do
+        let(:account_number) { "ABC1234567" }
 
         its(:country_code) { is_expected.to eq("AU") }
         its(:bank_code) { is_expected.to be_nil }
         its(:branch_code) { is_expected.to eq("123456") }
-        its(:account_number) { is_expected.to eq("0AB1234567") }
+        its(:account_number) { is_expected.to eq("ABC1234567") }
         its(:swift_bank_code) { is_expected.to be_nil }
         its(:swift_branch_code) { is_expected.to eq("123456") }
-        its(:swift_account_number) { is_expected.to eq("0AB1234567") }
+        its(:swift_account_number) { is_expected.to eq("ABC1234567") }
         its(:swift_national_id) { is_expected.to eq("123456") }
         its(:iban) { is_expected.to be_nil }
-        its(:pseudo_iban) { is_expected.to eq("AUZZ1234560AB1234567") }
+        its(:pseudo_iban) { is_expected.to eq("AUZZ123456ABC1234567") }
+        its(:valid?) { is_expected.to eq(true) }
+        its(:to_s) { is_expected.to eq("") }
+      end
+
+      context "and a 9 characters account number starting with X" do
+        let(:account_number) { "XX1234567" }
+
+        its(:country_code) { is_expected.to eq("AU") }
+        its(:bank_code) { is_expected.to be_nil }
+        its(:branch_code) { is_expected.to eq("123456") }
+        its(:account_number) { is_expected.to eq("0XX1234567") }
+        its(:swift_bank_code) { is_expected.to be_nil }
+        its(:swift_branch_code) { is_expected.to eq("123456") }
+        its(:swift_account_number) { is_expected.to eq("0XX1234567") }
+        its(:swift_national_id) { is_expected.to eq("123456") }
+        its(:iban) { is_expected.to be_nil }
+        its(:pseudo_iban) { is_expected.to eq("AUZZ1234560XX1234567") }
+        its(:valid?) { is_expected.to eq(true) }
+        its(:to_s) { is_expected.to eq("") }
+      end
+
+      context "and a 10 characters account number starting with X" do
+        let(:account_number) { "XX12345678" }
+
+        its(:country_code) { is_expected.to eq("AU") }
+        its(:bank_code) { is_expected.to be_nil }
+        its(:branch_code) { is_expected.to eq("123456") }
+        its(:account_number) { is_expected.to eq("XX12345678") }
+        its(:swift_bank_code) { is_expected.to be_nil }
+        its(:swift_branch_code) { is_expected.to eq("123456") }
+        its(:swift_account_number) { is_expected.to eq("XX12345678") }
+        its(:swift_national_id) { is_expected.to eq("123456") }
+        its(:iban) { is_expected.to be_nil }
+        its(:pseudo_iban) { is_expected.to eq("AUZZ123456XX12345678") }
         its(:valid?) { is_expected.to eq(true) }
         its(:to_s) { is_expected.to eq("") }
       end
@@ -235,6 +269,23 @@ describe Ibandit::IBAN do
       its(:pseudo_iban) { is_expected.to eq("AUZZ1234560123456789") }
       its(:valid?) { is_expected.to eq(true) }
       its(:to_s) { is_expected.to eq("") }
+
+      context "with a leading X on the account number" do
+        let(:arg) { "AUZZ123456XABCD12345" }
+
+        its(:country_code) { is_expected.to eq("AU") }
+        its(:bank_code) { is_expected.to be_nil }
+        its(:branch_code) { is_expected.to eq("123456") }
+        its(:account_number) { is_expected.to eq("XABCD12345") }
+        its(:swift_bank_code) { is_expected.to be_nil }
+        its(:swift_branch_code) { is_expected.to eq("123456") }
+        its(:swift_account_number) { is_expected.to eq("XABCD12345") }
+        its(:swift_national_id) { is_expected.to eq("123456") }
+        its(:iban) { is_expected.to be_nil }
+        its(:pseudo_iban) { is_expected.to eq("AUZZ123456XABCD12345") }
+        its(:valid?) { is_expected.to eq(true) }
+        its(:to_s) { is_expected.to eq("") }
+      end
     end
 
     context "when the input is an invalid Australian pseudo-IBAN" do

data/spec/ibandit/pseudo_iban_assembler_spec.rb

@@ -52,6 +52,18 @@ describe Ibandit::PseudoIBANAssembler do
       it { is_expected.to eq("AUZZ123456A123456789") }
     end
 
+    context "with valid parameters and padding" do
+      let(:local_details) do
+        {
+          country_code: "AU",
+          branch_code: "123456",
+          account_number: "XABC",
+        }
+      end
+
+      it { is_expected.to eq("AUZZ123456______XABC") }
+    end
+
     context "without a branch code" do
       let(:local_details) do
         {

data/spec/ibandit/pseudo_iban_splitter_spec.rb

@@ -23,5 +23,41 @@ describe Ibandit::PseudoIBANSplitter do
       its([:branch_code]) { is_expected.to eq("123456") }
       its([:account_number]) { is_expected.to eq("123456789") }
     end
+
+    context "for an australian pseudo-IBAN with padding" do
+      let(:pseudo_iban) { "AUZZ123456______XABC" }
+
+      its([:country_code]) { is_expected.to eq("AU") }
+      its([:bank_code]) { is_expected.to be_nil }
+      its([:branch_code]) { is_expected.to eq("123456") }
+      its([:account_number]) { is_expected.to eq("XABC") }
+    end
+
+    context "for an australian 10 character alphanumeric pseudo-iban" do
+      let(:pseudo_iban) { "AUZZ12345601234567AB" }
+
+      its([:country_code]) { is_expected.to eq("AU") }
+      its([:bank_code]) { is_expected.to be_nil }
+      its([:branch_code]) { is_expected.to eq("123456") }
+      its([:account_number]) { is_expected.to eq("01234567AB") }
+    end
+
+    context "for an australian 10 character pseudo-iban with an X" do
+      let(:pseudo_iban) { "AUZZ1234560X12345678" }
+
+      its([:country_code]) { is_expected.to eq("AU") }
+      its([:bank_code]) { is_expected.to be_nil }
+      its([:branch_code]) { is_expected.to eq("123456") }
+      its([:account_number]) { is_expected.to eq("0X12345678") }
+    end
+
+    context "for an australian 10 character pseudo-iban with a leading X" do
+      let(:pseudo_iban) { "AUZZ123456X123456789" }
+
+      its([:country_code]) { is_expected.to eq("AU") }
+      its([:bank_code]) { is_expected.to be_nil }
+      its([:branch_code]) { is_expected.to eq("123456") }
+      its([:account_number]) { is_expected.to eq("X123456789") }
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.11.10
+  version: 0.11.11
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-21 00:00:00.000000000 Z
+date: 2018-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -174,6 +174,7 @@ files:
 - lib/ibandit/version.rb
 - spec/fixtures/germany_integration_test_cases.json
 - spec/fixtures/germany_unit_test_cases.json
+- spec/ibandit/constants_spec.rb
 - spec/ibandit/german_details_converter_spec.rb
 - spec/ibandit/iban_assembler_spec.rb
 - spec/ibandit/iban_spec.rb
@@ -205,7 +206,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Convert national banking details into IBANs, and vice-versa.