ibandit 0.1.1 → 0.2.0

data/spec/ibandit/german_details_converter_spec.rb

@@ -0,0 +1,101 @@
+require 'spec_helper'
+
+describe Ibandit::GermanDetailsConverter do
+  shared_examples 'json based fixture' do |json_fixture_file|
+    json_fixture(json_fixture_file).each do |convertor|
+      context "Rule #{convertor['convertor']}" do
+        let(:klass) do
+          described_class.const_get("Rule#{convertor['convertor']}")
+        end
+
+        subject { test_subject }
+
+        before do
+          expect_any_instance_of(klass).to receive(:converted_details).
+            and_call_original
+        end
+
+        convertor.fetch('valid', []).each do |tuple|
+          context "bank code: #{tuple['bank_code']} account number " \
+            "#{tuple['account_number']}" do
+            let(:bank_code) do
+              tuple['bank_code']
+            end
+            let(:account_number) do
+              tuple['account_number']
+            end
+            let(:converted_bank_code) do
+              tuple['converted_bank_code'] || bank_code
+            end
+            let(:converted_account_number) do
+              tuple['converted_account_number'] || account_number
+            end
+            it do
+              is_expected.to eq(
+                bank_code: converted_bank_code,
+                account_number: converted_account_number)
+            end
+          end
+        end
+
+        convertor.fetch('invalid', []).each do |tuple|
+          context "bank code: #{tuple['bank_code']} account number " \
+            "#{tuple['account_number']}" do
+            let(:bank_code) { tuple['bank_code'] || '00000000' }
+            let(:account_number) { tuple['account_number'] }
+            it 'raises UnsupportedAccountDetails' do
+              expect { subject }.
+                to raise_error(Ibandit::UnsupportedAccountDetails)
+            end
+          end
+        end
+      end
+    end
+  end
+
+  describe 'integration tests' do
+    include_examples 'json based fixture', 'germany_integration_test_cases' do
+      let(:test_subject) do
+        described_class.
+          convert(bank_code: bank_code, account_number: account_number)
+      end
+    end
+  end
+
+  describe 'unit tests' do
+    include_examples 'json based fixture', 'germany_unit_test_cases' do
+      let(:test_subject) do
+        klass.new(bank_code, account_number).converted_details
+      end
+    end
+  end
+
+  describe Ibandit::GermanDetailsConverter::Rule002002::Check63 do
+    subject { described_class.new(account_number) }
+
+    # Test cases taken from the IBAN Rules definitions document
+    valid_account_numbers = %w(
+      38150900 600103660 39101181 5600200 75269100 3700246 6723143
+      5719083 571908300 8007759 800775900 350002200 900004300
+    )
+
+    invalid_account_numbers = %w(
+      370024600 672314300 3500022 9000043 123456700 94012341 94012341
+      5073321010 1234517892 987614325
+    )
+
+    valid_account_numbers.each do |number|
+      context "#{number}" do
+        let(:account_number) { number }
+        it { is_expected.to be_valid }
+      end
+    end
+
+    invalid_account_numbers.each do |number|
+      context "#{number}" do
+        let(:account_number) { number }
+        it { is_expected.to_not be_valid }
+      end
+    end
+  end
+end

data/spec/ibandit/iban_builder_spec.rb

@@ -167,6 +167,13 @@ describe Ibandit::IBANBuilder do
             to raise_error(ArgumentError, /account_number is a required field/)
         end
       end
+
+      context 'with a pseudo account number' do
+        before { args[:bank_code] = '37080040' }
+        before { args[:account_number] = '111' }
+
+        its(:iban) { is_expected.to eq('DE69370800400215022000') }
+      end
     end
 
     context 'with EE as the country_code' do

data/spec/spec_helper.rb

@@ -1,7 +1,12 @@
 require 'ibandit'
 require 'rspec/its'
+require 'json'
 
 RSpec.configure do |config|
   config.mock_with(:rspec) { |mocks| mocks.verify_partial_doubles = true }
   config.raise_errors_for_deprecations!
 end
+
+def json_fixture(filename)
+  JSON.parse(File.read("spec/fixtures/#{filename}.json"))
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ibandit
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-08 00:00:00.000000000 Z
+date: 2015-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -98,19 +98,26 @@ files:
 - LICENSE
 - README.md
 - TODO.md
+- bin/build_german_iban_rules.rb
 - bin/build_structure_file.rb
-- data/IBANSTRUCTURE.xml
-- data/IBAN_Registry.txt
-- data/structure_additions.yml
+- data/german_iban_rules.yml
+- data/raw/BLZ2.txt
+- data/raw/IBANSTRUCTURE.xml
+- data/raw/IBAN_Registry.txt
+- data/raw/structure_additions.yml
+- data/structures.yml
 - ibandit.gemspec
 - lib/ibandit.rb
 - lib/ibandit/check_digit.rb
 - lib/ibandit/errors.rb
+- lib/ibandit/german_details_converter.rb
 - lib/ibandit/iban.rb
 - lib/ibandit/iban_builder.rb
-- lib/ibandit/structures.yml
 - lib/ibandit/version.rb
+- spec/fixtures/germany_integration_test_cases.json
+- spec/fixtures/germany_unit_test_cases.json
 - spec/ibandit/check_digit_spec.rb
+- spec/ibandit/german_details_converter_spec.rb
 - spec/ibandit/iban_builder_spec.rb
 - spec/ibandit/iban_spec.rb
 - spec/spec_helper.rb