ibancom 0.0.12 → 0.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 47cb70450c2d3171087a946ac9bb141c8d24fd23355bbaa3f281b1f0ff843b30
-  data.tar.gz: 18b1bb8d814c8688543a44175e90d480dd2bd31ed9a2a32a1aa38c074218e2bb
+  metadata.gz: 54d6fa3948be90af76726483f89f6c2ff3ee757c667e6237eb36e49a9d88dbf0
+  data.tar.gz: 105cd00ab0ba02c17047bf31498f834de1f0e80e1ba4003160180259a6f4b5a7
 SHA512:
-  metadata.gz: 193f5a9634022ee954039f7287d3ac1532a8f73adba28eae1890dfc0de4fb4660f9c115959dae12ac83532b566889464665f3da9c3ea3caeb13b524329924356
-  data.tar.gz: e1de0d21ad7bc55b7a473fc987211286ff2487339a98ee459860a050758dc08e2d722800168c3b3b20de527671c06d783f981eab7aa187c7c3c684013b11d40f
+  metadata.gz: 363250ed2fa326fb30881dc155abe4b89550de9c76f2e5ab2286a669128541ac028aaa9f81a1b85a6049d553ad274898e76ce076ec9d663c027018dd7cd89a23
+  data.tar.gz: ee486af17f4d92eb70b5f37f6270fe7fb33cea298590153a278568db0cd28a3e2e8410263c2c6689b026083babf181558161fd1325e0c7dcebf4f3630811e40b

data/.rubocop.yml

@@ -1,5 +1,3 @@
 ---
 inherit_from:
   - .rubocop_devengo.yml
-AllCops:
-  TargetRubyVersion: 2.6

data/.rubocop_devengo.yml

@@ -1,7 +1,7 @@
 ---
 AllCops:
   DisplayCopNames: true
-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 3.2
   SuggestExtensions: false
   NewCops: enable
   Exclude:
@@ -11,8 +11,8 @@ AllCops:
     - node_modules/**/*
     - Procfile
 
-require:
-  - "test_prof/rubocop"
+plugins:
+  - test-prof
   - rubocop-rspec
   - rubocop-performance
   - rubocop-rake

data/.ruby-version

@@ -0,0 +1 @@
+3.4.12

data/CODE_OF_CONDUCT.md

@@ -55,7 +55,7 @@ further defined and clarified by project maintainers.
 ## Enforcement
 
 Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported by contacting the project team at aitor@linkingpaths.com. All
+reported by contacting the project team at <dev@devengo.com>. All
 complaints will be reviewed and investigated and will result in a response that
 is deemed necessary and appropriate to the circumstances. The project team is
 obligated to maintain confidentiality with regard to the reporter of an incident.

data/Gemfile

@@ -4,3 +4,16 @@ source "https://rubygems.org"
 
 # Specify your gem's dependencies in ibancom.gemspec
 gemspec
+
+gem "guard", "~> 2.19"
+gem "guard-rspec", "~> 4.7"
+gem "rake", "~> 13.3"
+gem "rspec", "~> 3.13"
+gem "rubocop", "~> 1.81"
+gem "rubocop-performance", "~> 1.26"
+gem "rubocop-rake", "~> 0.7"
+gem "rubocop-rspec", "~> 3.7"
+# 1.3 requires Ruby 3.3; this gem still supports 3.2.
+gem "simplecov", "~> 1.2.0", require: false
+gem "test-prof", "~> 1.4"
+gem "webmock", "~> 3.26"

data/Gemfile.lock

@@ -1,28 +1,37 @@
 PATH
   remote: .
   specs:
-    ibancom (0.0.12)
-      faraday (>= 0.15)
+    ibancom (0.0.14)
+      faraday (>= 2.14.3, < 3)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.9.0)
+    addressable (2.9.2)
       public_suffix (>= 2.0.2, < 8.0)
-    ast (2.4.2)
+    ast (2.4.3)
+    bigdecimal (4.1.3)
     coderay (1.1.3)
-    crack (0.4.5)
+    crack (1.0.1)
+      bigdecimal
       rexml
-    diff-lcs (1.5.0)
-    faraday (2.7.4)
-      faraday-net_http (>= 2.0, < 3.1)
-      ruby2_keywords (>= 0.0.4)
-    faraday-net_http (3.0.2)
-    ffi (1.15.5)
-    formatador (1.1.0)
-    guard (2.18.0)
+    diff-lcs (1.6.2)
+    faraday (2.15.1)
+      faraday-net_http (>= 2.0, < 3.6)
+      json
+      logger
+    faraday-net_http (3.5.0)
+      net-http (~> 0.5)
+    ffi (1.17.4)
+    ffi (1.17.4-arm64-darwin)
+    ffi (1.17.4-x86_64-darwin)
+    ffi (1.17.4-x86_64-linux-gnu)
+    formatador (1.2.3)
+      reline
+    guard (2.20.2)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
+      logger (~> 1.6)
       lumberjack (>= 1.0.12, < 2.0)
       nenv (~> 0.1)
       notiffany (~> 0.0)
@@ -34,94 +43,120 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    hashdiff (1.0.1)
-    json (2.6.3)
-    listen (3.8.0)
+    hashdiff (1.2.1)
+    io-console (0.9.5)
+    json (3.1.0)
+    language_server-protocol (3.17.0.6)
+    lint_roller (1.1.0)
+    listen (3.10.1)
+      logger
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
-    lumberjack (1.2.8)
-    method_source (1.0.0)
+    logger (1.7.0)
+    lumberjack (1.4.2)
+    method_source (1.1.0)
     nenv (0.3.0)
+    net-http (0.10.0)
+      net-protocol (>= 0.3.0)
+      uri (>= 0.11.1)
+    net-protocol (0.4.0)
+      timeout
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    parallel (1.22.1)
-    parser (3.2.1.1)
+    parallel (1.28.0)
+    parser (3.3.13.0)
       ast (~> 2.4.1)
-    pry (0.14.2)
+      racc
+    prism (1.9.0)
+    pry (0.16.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    public_suffix (5.1.1)
+      reline (>= 0.6.0)
+    public_suffix (7.0.5)
+    racc (1.8.1)
     rainbow (3.1.1)
-    rake (12.3.3)
+    rake (13.4.2)
     rb-fsevent (0.11.2)
-    rb-inotify (0.10.1)
+    rb-inotify (0.11.1)
       ffi (~> 1.0)
-    regexp_parser (2.7.0)
-    rexml (3.4.2)
-    rspec (3.12.0)
-      rspec-core (~> 3.12.0)
-      rspec-expectations (~> 3.12.0)
-      rspec-mocks (~> 3.12.0)
-    rspec-core (3.12.1)
-      rspec-support (~> 3.12.0)
-    rspec-expectations (3.12.2)
+    regexp_parser (2.13.1)
+    reline (0.7.0)
+      io-console (~> 0.5)
+    rexml (3.4.4)
+    rspec (3.13.2)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.6)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-mocks (3.12.4)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.8)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-support (3.12.0)
-    rubocop (1.48.1)
-      json (~> 2.3)
-      parallel (~> 1.10)
-      parser (>= 3.2.0.0)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.7)
+    rubocop (1.92.2)
+      json (>= 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
+      parallel (>= 1.10)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.26.0, < 2.0)
+      regexp_parser (>= 2.11.3, < 3.0)
+      rubocop-ast (>= 1.49.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.27.0)
-      parser (>= 3.2.1.0)
-    rubocop-capybara (2.17.1)
-      rubocop (~> 1.41)
-    rubocop-performance (1.16.0)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
-    rubocop-rake (0.6.0)
-      rubocop (~> 1.0)
-    rubocop-rspec (2.19.0)
-      rubocop (~> 1.33)
-      rubocop-capybara (~> 2.17)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.50.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.7)
+    rubocop-performance (1.27.0)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.89.0, < 2.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
+    rubocop-rake (0.7.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
+    rubocop-rspec (3.10.2)
+      lint_roller (~> 1.1)
+      regexp_parser (>= 2.0)
+      rubocop (~> 1.86, >= 1.86.2)
     ruby-progressbar (1.13.0)
-    ruby2_keywords (0.0.5)
     shellany (0.0.1)
-    test-prof (1.2.1)
-    thor (1.2.1)
-    unicode-display_width (2.4.2)
-    webmock (3.18.1)
+    simplecov (1.2.0)
+    test-prof (1.6.4)
+      logger
+    thor (1.5.0)
+    timeout (0.6.1)
+    unicode-display_width (3.3.0)
+      unicode-emoji (~> 4.3)
+    unicode-emoji (4.3.0)
+    uri (1.1.2)
+    webmock (3.34.0)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
 
 PLATFORMS
-  arm64-darwin-22
-  arm64-darwin-25
+  arm64-darwin
+  ruby
+  x86_64-darwin
   x86_64-linux
 
 DEPENDENCIES
-  guard (~> 2.0)
-  guard-rspec (~> 4.0)
+  guard (~> 2.19)
+  guard-rspec (~> 4.7)
   ibancom!
-  rake (~> 12.0)
-  rspec (~> 3.0)
-  rubocop (~> 1.2)
-  rubocop-performance (~> 1.0)
-  rubocop-rake (~> 0.6)
-  rubocop-rspec (~> 2.0)
-  test-prof (~> 1.0)
-  webmock (~> 3.0)
+  rake (~> 13.3)
+  rspec (~> 3.13)
+  rubocop (~> 1.81)
+  rubocop-performance (~> 1.26)
+  rubocop-rake (~> 0.7)
+  rubocop-rspec (~> 3.7)
+  simplecov (~> 1.2.0)
+  test-prof (~> 1.4)
+  webmock (~> 3.26)
 
 BUNDLED WITH
-   2.4.1
+   2.7.2

data/README.md

@@ -145,7 +145,7 @@ git tag vX.X.X main
 git push origin vX.X.X
 ```
 
-The tagging will trigger the GitHub action defined in `release.yml`, pushing the gem to [rubygems.org](https://rubygems.org).
+The tag triggers `release.yml`: it runs CI, checks the tag is on `main` and publishes the gem to [rubygems.org](https://rubygems.org) through [trusted publishing](https://guides.rubygems.org/trusted-publishing/), with no API key.
 
 ## Contributing
 

data/ibancom.gemspec

@@ -6,7 +6,7 @@ Gem::Specification.new do |spec|
   spec.name = "ibancom"
   spec.version = Ibancom::VERSION
   spec.authors = ["Aitor García Rey"]
-  spec.email = ["aitor@devengo.com"]
+  spec.email = ["dev@devengo.com"]
 
   spec.summary = "Ruby client for iban.com APIs"
   spec.description = "Ruby client for iban.com APIs"
@@ -28,17 +28,6 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = ">= 2.6.0"
-  spec.add_dependency "faraday", ">= 0.15"
-
-  spec.add_development_dependency "guard", "~> 2.0"
-  spec.add_development_dependency "guard-rspec", "~> 4.0"
-  spec.add_development_dependency "rake", "~> 12.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "rubocop", "~> 1.2"
-  spec.add_development_dependency "rubocop-performance", "~> 1.0"
-  spec.add_development_dependency "rubocop-rake", "~> 0.6"
-  spec.add_development_dependency "rubocop-rspec", "~> 2.0"
-  spec.add_development_dependency "test-prof", "~> 1.0"
-  spec.add_development_dependency "webmock", "~> 3.0"
+  spec.required_ruby_version = ">= 3.2"
+  spec.add_dependency "faraday", ">= 2.14.3", "< 3"
 end

data/lib/ibancom/client.rb

@@ -3,7 +3,6 @@
 require "faraday"
 require "securerandom"
 
-# require "faraday_middleware"
 require_relative "api/services"
 require_relative "resources/base"
 
@@ -20,12 +19,17 @@ module Ibancom
       @user_agent = options[:user_agent] || default_user_agent
       @proxy = options[:proxy]
       @apikey = options[:apikey] || ENV["IBANCOM_APIKEY"]
-      @logger_enabled = options[:logger_enabled].nil? ? true : options[:logger_enabled]
+      @logger_enabled = options[:logger_enabled].nil? || options[:logger_enabled]
       @logger_middleware = options.fetch(:logger_middleware, Faraday::Response::Logger)
       @logger_options = options.fetch(:logger_options, {})
       @services = {}
     end
 
+    # The default prints every instance variable, the API key included.
+    def inspect
+      "#<#{self.class.name}>"
+    end
+
     def connection
       @connection ||= Faraday.new do |builder|
         builder.request :url_encoded
@@ -38,6 +42,7 @@ module Ibancom
         if @logger_enabled
           builder.use @logger_middleware, nil, { headers: true, bodies: true }.merge(@logger_options) do |logger|
             logger.filter(/("password":)"(\w+)"/, '\1[FILTERED]')
+            logger.filter(/(api_key=)[^&\s]+/, '\1[FILTERED]')
           end
         end
         builder.adapter :net_http
@@ -99,7 +104,6 @@ module Ibancom
     end
 
     def handle_error_response(error)
-      puts "ERROR #{error.response}"
       raise error
     end
 

data/lib/ibancom/resources/base.rb

@@ -8,7 +8,7 @@ module Ibancom
       def initialize(response, attributes = {})
         @response = response
         attributes.each do |key, value|
-          m = "#{key}=".to_sym
+          m = :"#{key}="
           send(m, value) if respond_to?(m)
         end
       end

data/lib/ibancom/resources/collection.rb

@@ -4,6 +4,7 @@ module Ibancom
   module Resources
     class Collection
       include Enumerable
+
       attr_reader :response
 
       def initialize(response, item_klass, attributes_collection = [])
@@ -12,8 +13,8 @@ module Ibancom
         @items = attributes_collection.map { |attributes_item| item_klass.new(nil, attributes_item) }
       end
 
-      def each(&block)
-        @items.each(&block)
+      def each(&)
+        @items.each(&)
       end
     end
   end

data/lib/ibancom/resources/iban/validation.rb

@@ -9,7 +9,7 @@ module Ibancom
                     :schemes
 
         def initialize(response, attributes = {})
-          super(response, attributes)
+          super
           @bank = Bank.new(response, attributes[:bank_data])
           @checks = Checks.new(response, attributes[:validations])
           @schemes = Schemes.new(response, attributes[:sepa_data])

data/lib/ibancom/resources/scan/validation.rb

@@ -10,7 +10,7 @@ module Ibancom
                     :schemes
 
         def initialize(response, attributes = {})
-          super(response, attributes)
+          super
           @bank = Bank.new(response, attributes[:bank_data])
           @account = Account.new(response, attributes[:account_data])
           @checks = Checks.new(response, attributes[:validations])

data/lib/ibancom/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ibancom
-  VERSION = "0.0.12"
+  VERSION = "0.0.14"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ibancom
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.14
 platform: ruby
 authors:
 - Aitor García Rey
@@ -15,157 +15,23 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.15'
+        version: 2.14.3
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.15'
-- !ruby/object:Gem::Dependency
-  name: guard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: guard-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '12.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '12.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.2'
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.6'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.6'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: test-prof
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
+        version: 2.14.3
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3'
 description: Ruby client for iban.com APIs
 email:
-- aitor@devengo.com
+- dev@devengo.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -174,6 +40,7 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_devengo.yml"
+- ".ruby-version"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
@@ -220,7 +87,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.0
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="