iban_calculator 0.1.1 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dcc664a899ba82d49e767966619eea8ea8940e14
-  data.tar.gz: abd9e3ed0a5a19d11bb3059671a2390258021c86
+  metadata.gz: 8f9d8247ec70deaea3ad00409ad0fff286c12ed3
+  data.tar.gz: 8351ce3d19b71e9f374f9cc38adb2335e6f84524
 SHA512:
-  metadata.gz: e026ee6df2aaf18a0f7b0303e9bdf913c2c2d4104939dda87e239f3a787d0a8fe1000c00d1d09731d0e09bd05d52f7ae0b650a71fba76d29ca6409c19a7aa073
-  data.tar.gz: 50ade0dd48e46ceede0b8e83e45de038547b45c2e611cc6cd2d72832131b774400ac38e9a019b3fce673f7a1dc2c12531e310b7217dcdd592be200957c131404
+  metadata.gz: 32dc7daebab254668bb75e6033d7402a652cb972a6a375b20df6be913edf16859916ef3835869b026af73a5f67e6ed2b2fd839df82d9dad6ce99d1363411bb73
+  data.tar.gz: 67bc127a1c0aee343876467836543f1312e5de1fd166e631e77f18a63f51be76dc34d7bf3a4c924ae1445bc4bbf10106830510ba3a2a6dde7e8de35122a1c8d8

data/.travis.yml

@@ -0,0 +1,6 @@
+language: ruby
+rvm:
+  - 2.0.0
+  - 2.1.2
+  - 2.2.0
+script: rspec

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+0.2.1
+-----
+* make it work with newer version of active_support too
+
+0.2.0
+-----
+* [lower active_support dependency](https://github.com/railslove/iban_calculator/pull/7)
+
 0.1.1
 -----
 

data/README.md

@@ -1,3 +1,5 @@
+[![Build Status](https://travis-ci.org/railslove/iban_calculator.svg?branch=master)](https://travis-ci.org/railslove/iban_calculator)
+
 # IbanCalculator
 
 A wrapper for ibanrechner.de API. It allows converting bank account data from legacy syntax to new SEPA IBAN/BIC.

data/iban_calculator.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activesupport", "~> 4"
+  spec.add_dependency "activesupport", ">= 3"
   spec.add_dependency "savon", "~> 2"
 
   spec.add_development_dependency "bundler", "~> 1.6"

data/lib/iban_calculator.rb

@@ -1,4 +1,5 @@
 require 'iban_calculator/version'
+require 'active_support/version'
 require 'active_support/configurable'
 require 'active_support/core_ext/hash'
 require 'logger'
@@ -8,22 +9,25 @@ require 'iban_calculator/bic_candidate'
 require 'iban_calculator/iban_bic'
 require 'iban_calculator/iban_validator_response'
 require 'iban_calculator/invalid_data'
+require 'iban_calculator/active_support' if ActiveSupport::VERSION::MAJOR == 3
 
 module IbanCalculator
   # Extensions
   include ActiveSupport::Configurable
 
   # Configuration
-  config_accessor(:url) { 'https://ssl.ibanrechner.de/soap/?wsdl' }
-  config_accessor(:user) { '' }
-  config_accessor(:password) { '' }
-  config_accessor(:logger) { Logger.new(STDOUT) }
+  config_accessor(:url)          { 'https://ssl.ibanrechner.de/soap/?wsdl' }
+  config_accessor(:user)         { '' }
+  config_accessor(:password)     { '' }
+  config_accessor(:logger)       { Logger.new(STDOUT) }
+  config_accessor(:read_timeout) { 5 }
+  config_accessor(:open_timeout) { 5 }
 
   # Errors
   ServiceError = Class.new(StandardError)
 
   def self.calculate_iban(attributes = {})
-    client = IbanBic.new(config.user, config.password, config.url, config.logger)
+    client = IbanBic.new(config)
     client.calculate_iban(attributes)
   end
 
@@ -33,7 +37,7 @@ module IbanCalculator
   end
 
   def self.execute(method, options = {})
-    client = Savon.client(wsdl: config.url, logger: config.logger)
+    client = Savon.client(wsdl: config.url, logger: config.logger, read_timeout: config.read_timeout, open_timeout: config.open_timeout)
     client.call(method, message: options).tap do |response|
       status = response.body[:"#{method}_response"][:return][:result]
       fail(ServiceError, status) unless response.body[:"#{method}_response"][:return][:return_code]

data/lib/iban_calculator/active_support.rb

@@ -0,0 +1,35 @@
+# these are methods implemented in active_support 4 which
+# are required to run this gem with active_support 3
+
+module IbanCalculator
+  include ActiveSupport::Configurable
+
+  # taken from: activesupport/lib/active_support/core_ext/hash/keys.rb
+  Hash.class_eval do
+    def deep_stringify_keys!
+      deep_transform_keys!{ |key| key.to_s }
+    end
+
+    def deep_transform_keys!(&block)
+      keys.each do |key|
+        value = delete(key)
+        self[yield(key)] = value.is_a?(Hash) ? value.deep_transform_keys!(&block) : value
+      end
+      self
+    end
+  end
+end
+
+class << IbanCalculator
+  alias_method :old_config_accessor, :config_accessor
+
+  def config_accessor(*names)
+    old_config_accessor(*names)
+
+    return unless block_given?
+
+    names.each do |name|
+      send("#{name}=", yield)
+    end
+  end
+end

data/lib/iban_calculator/iban_bic.rb

@@ -27,13 +27,14 @@ module IbanCalculator
     PROBABLY_VALID_RESPONSE_CODE = 32..127
     SERVICE_ERROR_RESPONSE_CODE = 65536
 
-    attr_accessor :user, :password, :url, :logger
+    attr_accessor :user, :password, :url, :logger, :config
 
-    def initialize(user, password, url, logger)
-      self.user = user
-      self.password = password
-      self.url = url
-      self.logger = logger
+    def initialize(config)
+      self.user = config.user
+      self.password = config.password
+      self.url = config.url
+      self.logger = config.logger
+      self.config = config
     end
 
     # You should provide country, bank_code, and account_number. (cin, abi, and cab for Italian accounts)
@@ -98,7 +99,7 @@ module IbanCalculator
     end
 
     def client
-      @client ||= Savon.client(wsdl: url)
+      @client ||= Savon.client(wsdl: url, read_timeout: config.read_timeout, open_timeout: config.open_timeout)
     end
   end
 end

data/lib/iban_calculator/version.rb

@@ -1,3 +1,3 @@
 module IbanCalculator
-  VERSION = "0.1.1"
+  VERSION = "0.2.1"
 end

data/spec/iban_bic_spec.rb

@@ -1,5 +1,18 @@
+require 'ostruct'
+
 describe IbanCalculator::IbanBic do
-  subject { described_class.new('user', 'pass', 'url', Logger.new(STDOUT) ) }
+  let(:config) {
+    OpenStruct.new(
+      user: 'user',
+      password: 'pass',
+      url: 'url',
+      logger: Logger.new(STDOUT),
+      read_timeout: 5,
+      open_timeout: 5
+    )
+  }
+
+  subject { described_class.new(config) }
 
   before { allow(subject.logger).to receive(:info) }
 

data/spec/iban_calculator_spec.rb

@@ -49,6 +49,16 @@ describe IbanCalculator do
     end
   end
 
+  describe '.calculate_iban' do
+    let(:error_message) { 'Service could not handle the request' }
+    let(:response) { { calculate_iban_response: { return: { return_code: '65536' } } } }
+
+    before { allow_any_instance_of(Savon::Client).to receive(:call) { double(body: response) } }
+
+    it 'raises a generic exception' do
+      expect { IbanCalculator.calculate_iban({}) }.to raise_error(IbanCalculator::ServiceError, error_message)
+    end
+  end
 
   describe '.execute' do
     context 'invalid username and password' do

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: iban_calculator
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.1
 platform: ruby
 authors:
 - Maximilian Schulz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-02 00:00:00.000000000 Z
+date: 2018-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: savon
   requirement: !ruby/object:Gem::Requirement
@@ -89,6 +89,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -96,6 +97,7 @@ files:
 - Rakefile
 - iban_calculator.gemspec
 - lib/iban_calculator.rb
+- lib/iban_calculator/active_support.rb
 - lib/iban_calculator/bank.rb
 - lib/iban_calculator/bic_candidate.rb
 - lib/iban_calculator/iban_bic.rb
@@ -128,7 +130,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Calculate IBAN and BIC for countries of Single European Payments Area (SEPA).