iban_calculator 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 97954991695b71a07275c823e1cecff9bd92097e
-  data.tar.gz: e484b233037768da5cc1504f5345f2f9600d686a
+  metadata.gz: dcc664a899ba82d49e767966619eea8ea8940e14
+  data.tar.gz: abd9e3ed0a5a19d11bb3059671a2390258021c86
 SHA512:
-  metadata.gz: c962478d7712809d708fad843081d06d7a80df7d0e7f98f88b48dd203eff7ba64df054de600c6cbf1beca314deece7a6a5ad4ebe6956c267ae677270e1369a96
-  data.tar.gz: adb62ab31cb19096726beb7a763f902a3baf355c415d95b31374ad9668b41696fd3a9b34dbe91ddb39cd841acb84af5a5ff61db94c61054efd0578c1747619ac
+  metadata.gz: e026ee6df2aaf18a0f7b0303e9bdf913c2c2d4104939dda87e239f3a787d0a8fe1000c00d1d09731d0e09bd05d52f7ae0b650a71fba76d29ca6409c19a7aa073
+  data.tar.gz: 50ade0dd48e46ceede0b8e83e45de038547b45c2e611cc6cd2d72832131b774400ac38e9a019b3fce673f7a1dc2c12531e310b7217dcdd592be200957c131404

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+0.1.1
+-----
+
+* added missing failure code for iban checksum
+* fixed error condition, so not every request is concidered an error ;)
+* `#as_json` will have stringified keys
+* `#valdiate_iban` and `#calculate_iban` should respond with mostly the same format
+* rescue from `ArgumentError` happening when the date is present but not valid
+
 0.1.0
 -----
 

data/lib/iban_calculator.rb

@@ -36,7 +36,7 @@ module IbanCalculator
     client = Savon.client(wsdl: config.url, logger: config.logger)
     client.call(method, message: options).tap do |response|
       status = response.body[:"#{method}_response"][:return][:result]
-      fail(ServiceError, status) unless response.body[:"#{method}_response"][:return_code]
+      fail(ServiceError, status) unless response.body[:"#{method}_response"][:return][:return_code]
     end
   end
 end

data/lib/iban_calculator/bic_candidate.rb

@@ -25,7 +25,7 @@ module IbanCalculator
         city: city,
         sample_url: sample_url,
         www_count: www_count,
-      }
+      }.deep_stringify_keys!
     end
 
     private

data/lib/iban_calculator/iban_validator_response.rb

@@ -50,6 +50,8 @@ module IbanCalculator
 
     def updated_at
       @data_created_at ||= Date.parse(raw_response[:data_age]) if string_or_default(raw_response[:data_age], nil)
+    rescue ArgumentError
+      nil
     end
 
     def errors
@@ -61,11 +63,12 @@ module IbanCalculator
         valid: valid?,
         errors: errors,
         account_number: account_number,
-        bank: bank.as_json(opts),
-        bic_candidates: bic_candidates.map { |c| c.as_json(opts) },
+        bank: bank.name,
+        bank_code: bank.code,
+        bics: bic_candidates.map { |c| c.as_json(opts) },
         updated_at: updated_at,
         checks: checks,
-      }
+      }.deep_stringify_keys!
     end
 
     private

data/lib/iban_calculator/invalid_data.rb

@@ -5,6 +5,7 @@ module IbanCalculator
       256  => [:bank_code,      [:not_found]],
       512  => [:account_number, [:invalid_length]],
       1024 => [:bank_code,      [:invalid_length]],
+      2048 => [:iban,           [:checksum_failed]],
       4096 => [:base,           [:data_missing]],
       8192 => [:country,        [:not_supported]],
     }

data/lib/iban_calculator/version.rb

@@ -1,3 +1,3 @@
 module IbanCalculator
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/bic_candidate_spec.rb

@@ -3,7 +3,7 @@ RSpec.describe IbanCalculator::BicCandidate do
   subject { described_class.new(single_candidate[:item]) }
 
   describe '.build_list' do
-    it 'returns an array if one item is added' do
+     it 'returns an array if one item is added' do
       expect(described_class.build_list(single_candidate).size).to eq(1)
     end
 
@@ -57,11 +57,11 @@ RSpec.describe IbanCalculator::BicCandidate do
 
     it 'returns all attributes' do
       expect(subject.as_json).to eq({
-        bic: 'BOFIIE2D',
-        zip: 'zip',
-        city: 'city',
-        sample_url: 'sample_url',
-        www_count: 0
+        "bic" => 'BOFIIE2D',
+        "zip" => 'zip',
+        "city" => 'city',
+        "sample_url" => 'sample_url',
+        "www_count" => 0
       })
     end
   end

data/spec/iban_validator_response_spec.rb

@@ -116,25 +116,27 @@ RSpec.describe IbanCalculator::IbanValidatorResponse do
   describe '#as_json' do
     it 'returns an hash with all attributes' do
       expect(valid.as_json).to eq({
-        valid: true,
-        errors: {},
-        account_number: '10027952',
-        bank: { code: '90-00-17', name: 'Bank of Ireland', country: 'IE', address: 'Dublin 2', url: '', branch: '', branch_code: '' },
-        bic_candidates: [{ bic: 'BOFIIE2D', zip: '', city: '', sample_url: '', www_count: 0 }],
-        checks: { length: 'passed', account_number: 'passed', bank_code: 'passed', iban_checksum: 'passed' },
-        updated_at: Date.new(2014, 7, 6)
+        "valid" => true,
+        "errors" => {},
+        "account_number" => '10027952',
+        "bank" => "Bank of Ireland",
+        "bank_code" => '90-00-17',
+        "bics" => [{ "bic" => 'BOFIIE2D', "zip" => '', "city" => '', "sample_url" => '', "www_count" => 0 }],
+        "checks" => { "length" => 'passed', "account_number" => 'passed', "bank_code" => 'passed', "iban_checksum" => 'passed' },
+        "updated_at" => Date.new(2014, 7, 6)
       })
     end
 
     it 'also returns errors for invalid response' do
       expect(invalid.as_json).to eq({
-        valid: false,
-        errors: {:account_number=>[:invalid_length]},
-        account_number: nil,
-        bank: { code: '', name: '', country: 'IE', address: '', url: '', branch: '', branch_code: '' },
-        bic_candidates: [],
-        checks: { length: 'failed', account_number: 'not_checked', bank_code: 'not_checked', iban_checksum: 'not_checked' },
-        updated_at: nil
+        "valid" => false,
+        "errors" => { "account_number" => [:invalid_length]},
+        "account_number" => nil,
+        "bank" => '',
+        "bank_code" => '',
+        "bics" => [],
+        "checks" => { "length" => 'failed', "account_number" => 'not_checked', "bank_code" => 'not_checked', "iban_checksum" => 'not_checked' },
+        "updated_at" => nil
       })
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iban_calculator
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Maximilian Schulz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-27 00:00:00.000000000 Z
+date: 2015-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport