iban_calculator 0.0.3 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 179e94a9310e590bdbe6b16fb6f3fa6e49535c5d
-  data.tar.gz: 5b727e33c86f8a30b724ea6435b47d0258731497
+  metadata.gz: 97954991695b71a07275c823e1cecff9bd92097e
+  data.tar.gz: e484b233037768da5cc1504f5345f2f9600d686a
 SHA512:
-  metadata.gz: 33bcc32cc39d265627e8bac2d04abc4f29f2ec6d14e7dd062e55e77f2999f3184fa16da203e7a4fc101ca5f6df9eedfb61f90d126fd34380ff8db2180deb4c1e
-  data.tar.gz: 9ff76bf3659848efd836707db1e5bc391c9fe12c41f5482f29a0dbc3c2c09f2519bb3211db41432ddb1943778f740e66fa247387f76310dd6697c6e47b78fc11
+  metadata.gz: c962478d7712809d708fad843081d06d7a80df7d0e7f98f88b48dd203eff7ba64df054de600c6cbf1beca314deece7a6a5ad4ebe6956c267ae677270e1369a96
+  data.tar.gz: adb62ab31cb19096726beb7a763f902a3baf355c415d95b31374ad9668b41696fd3a9b34dbe91ddb39cd841acb84af5a5ff61db94c61054efd0578c1747619ac

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+0.1.0
+-----
+
+* Allow invalid IBANs to bubble though and not to fail spectacular
+
 0.0.3
 -----
 

data/lib/iban_calculator.rb

@@ -36,7 +36,7 @@ module IbanCalculator
     client = Savon.client(wsdl: config.url, logger: config.logger)
     client.call(method, message: options).tap do |response|
       status = response.body[:"#{method}_response"][:return][:result]
-      fail(ServiceError, status) unless status == 'passed'
+      fail(ServiceError, status) unless response.body[:"#{method}_response"][:return_code]
     end
   end
 end

data/lib/iban_calculator/iban_validator_response.rb

@@ -39,7 +39,7 @@ module IbanCalculator
     end
 
     def account_number
-      @account_number ||= raw_response[:account_number]
+      @account_number ||= string_or_default(raw_response[:account_number], nil)
     end
 
     def checks
@@ -49,7 +49,7 @@ module IbanCalculator
     end
 
     def updated_at
-      @data_created_at ||= Date.parse(raw_response[:data_age])
+      @data_created_at ||= Date.parse(raw_response[:data_age]) if string_or_default(raw_response[:data_age], nil)
     end
 
     def errors
@@ -58,6 +58,8 @@ module IbanCalculator
 
     def as_json(opts = {})
       {
+        valid: valid?,
+        errors: errors,
         account_number: account_number,
         bank: bank.as_json(opts),
         bic_candidates: bic_candidates.map { |c| c.as_json(opts) },

data/lib/iban_calculator/version.rb

@@ -1,3 +1,3 @@
 module IbanCalculator
-  VERSION = "0.0.3"
+  VERSION = "0.1.0"
 end

data/spec/iban_validator_response_spec.rb

@@ -93,6 +93,10 @@ RSpec.describe IbanCalculator::IbanValidatorResponse do
     it 'returns a proper date object' do
       expect(valid.updated_at).to eq(Date.new(2014, 07, 06))
     end
+
+    it 'is nil for invalid response' do
+      expect(invalid.updated_at).to eq(nil)
+    end
   end
 
   describe '#errors' do
@@ -112,6 +116,8 @@ RSpec.describe IbanCalculator::IbanValidatorResponse do
   describe '#as_json' do
     it 'returns an hash with all attributes' do
       expect(valid.as_json).to eq({
+        valid: true,
+        errors: {},
         account_number: '10027952',
         bank: { code: '90-00-17', name: 'Bank of Ireland', country: 'IE', address: 'Dublin 2', url: '', branch: '', branch_code: '' },
         bic_candidates: [{ bic: 'BOFIIE2D', zip: '', city: '', sample_url: '', www_count: 0 }],
@@ -119,6 +125,18 @@ RSpec.describe IbanCalculator::IbanValidatorResponse do
         updated_at: Date.new(2014, 7, 6)
       })
     end
+
+    it 'also returns errors for invalid response' do
+      expect(invalid.as_json).to eq({
+        valid: false,
+        errors: {:account_number=>[:invalid_length]},
+        account_number: nil,
+        bank: { code: '', name: '', country: 'IE', address: '', url: '', branch: '', branch_code: '' },
+        bic_candidates: [],
+        checks: { length: 'failed', account_number: 'not_checked', bank_code: 'not_checked', iban_checksum: 'not_checked' },
+        updated_at: nil
+      })
+    end
   end
 
   def valid_response

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iban_calculator
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.1.0
 platform: ruby
 authors:
 - Maximilian Schulz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-23 00:00:00.000000000 Z
+date: 2015-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -128,7 +128,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.3
 signing_key: 
 specification_version: 4
 summary: Calculate IBAN and BIC for countries of Single European Payments Area (SEPA).
@@ -139,4 +139,3 @@ test_files:
 - spec/iban_validator_response_spec.rb
 - spec/invalid_data_spec.rb
 - spec/spec_helper.rb
-has_rdoc: