iban_calculator 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3967a9c57971d2941311ac3669ab2b440f1e4aed
-  data.tar.gz: e639752002e485025b6255f9592a62b9900ee763
+  metadata.gz: 179e94a9310e590bdbe6b16fb6f3fa6e49535c5d
+  data.tar.gz: 5b727e33c86f8a30b724ea6435b47d0258731497
 SHA512:
-  metadata.gz: 57c403612b7adb97f2240c89411186d186c35c30f7c027580b06be44fd42b19ee394a2dbbb8157556f5e31986a6be9f8018c8a14b90941698316290fe4df931f
-  data.tar.gz: 6ab47c60821c888040d2989a2c22817cf23a22dd4a6731a9cfbe9440961b95f8baec156824b374e5607751ab3f438ae20f49b394bb0b4d6e73fef3aa9fe392c7
+  metadata.gz: 33bcc32cc39d265627e8bac2d04abc4f29f2ec6d14e7dd062e55e77f2999f3184fa16da203e7a4fc101ca5f6df9eedfb61f90d126fd34380ff8db2180deb4c1e
+  data.tar.gz: 9ff76bf3659848efd836707db1e5bc391c9fe12c41f5482f29a0dbc3c2c09f2519bb3211db41432ddb1943778f740e66fa247387f76310dd6697c6e47b78fc11

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+0.0.3
+-----
+
+* Raise an exception when an unexpected response is returned (i.e. invalid user and password)
+
 0.0.2
 -----
 

data/lib/iban_calculator/version.rb

@@ -1,3 +1,3 @@
 module IbanCalculator
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/iban_calculator.rb

@@ -28,8 +28,15 @@ module IbanCalculator
   end
 
   def self.validate_iban(iban)
-    client = Savon.client(wsdl: config.url, logger: config.logger)
-    response = client.call(:validate_iban, message: { iban: iban, user: config.user, password: config.password })
+    response = execute(:validate_iban, iban: iban, user: config.user, password: config.password)
     IbanValidatorResponse.new(response.body[:validate_iban_response][:return])
   end
+
+  def self.execute(method, options = {})
+    client = Savon.client(wsdl: config.url, logger: config.logger)
+    client.call(method, message: options).tap do |response|
+      status = response.body[:"#{method}_response"][:return][:result]
+      fail(ServiceError, status) unless status == 'passed'
+    end
+  end
 end

data/spec/iban_calculator_spec.rb

@@ -48,4 +48,18 @@ describe IbanCalculator do
       IbanCalculator.logger = old_logger
     end
   end
+
+
+  describe '.execute' do
+    context 'invalid username and password' do
+      let(:error_message) { 'User someone, password test: invalid username-password combination' }
+      let(:response) { { failing_response: { return: { result: error_message } } } }
+
+      before { allow_any_instance_of(Savon::Client).to receive(:call) { double(body: response) } }
+
+      it 'raises a generic exception' do
+        expect { IbanCalculator.execute(:failing) }.to raise_error(IbanCalculator::ServiceError, error_message)
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iban_calculator
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Maximilian Schulz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-11 00:00:00.000000000 Z
+date: 2014-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport