iban_bic 1.4.0 → 1.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f7b2f833a71bf207363496a6140a16d97de02395
-  data.tar.gz: d35302a1fdd34187d969477b0205eabd45ba795d
+  metadata.gz: f2651f4f3ff003d3c6e37078d480f835358165dd
+  data.tar.gz: cd2a59c0312bc577ff3f569c3de46b65f0025257
 SHA512:
-  metadata.gz: 45b4e30101e361d6f92d0d9441574a3d0d03cbea192667194cee19935822d90b325257eb446e083b8411b0ce13d2455ea1915dc8e2b5b3c6c4434f356a61b770
-  data.tar.gz: 3ecf0d1ec09baf2850ac0b8fe640e8c6ee66e67947886b42854327186bcad59a17f927ebbd37c71c4b93928204889d62ba0a40acc2874047b0c93a2f375f76b9
+  metadata.gz: 331416989965fa9b86b67f362e56aff8e84eda9830be2a3b81223b503ae4440ef90b1e582cd23df1153f0eb05fc338f11b070a44129a9f9e5439a1bedbc15242
+  data.tar.gz: 4bd37ec79d8a815369e41d044f159a466cce55376eeb18ff795e339602e33374caa1abf887a45b04700c9f810dda5c1118bdb53bf4e5b5be90a821be605e42bd

data/README.md

@@ -47,52 +47,52 @@ validates :bic, bic: { country: :pais }
 3. IBAN control digits calculation
 
 ```ruby
-2.4.1 :001 > IbanBic.calculate_check("ES0000030000300000000000")
+IbanBic.calculate_check("ES0000030000300000000000")
  => 87
 ```
 
 4. IBAN parsing
 
 ```ruby
-2.4.1 :001 > IbanBic.parse("ES8700030000300000000000")
+IbanBic.parse("ES8700030000300000000000")
 => {"country"=>"ES", "iban_check"=>"87", "bank"=>"0003", "branch"=>"0000", "check"=>"30", "account"=>"0000000000"}
 ```
 
 5. IBAN fixing (IBAN control digits and country control digits, if that code is available)
 
 ```ruby
-2.4.1 :001 > IbanBic.fix("ES0000030000200000000000")
+IbanBic.fix("ES0000030000200000000000")
  => "ES8700030000300000000000"
 ```
 
 6. BIC calculation (bank code must be in the static file or in the database)
 
 ```ruby
-2.4.1 :001 > IbanBic.calculate_bic("ES8700030000300000000000")
+IbanBic.calculate_bic("ES8700030000300000000000")
  => "BDEPESM1XXX"
 ```
 
 7. Pattern generation for SQL LIKE queries.
 
 ```ruby
-2.4.1 :001 > IbanBic.like_pattern("ES8700030000300000000000", :country, :bank)
+IbanBic.like_pattern("ES8700030000300000000000", :country, :bank)
  => "ES__0003________________"
-2.4.1 :002 > IbanBic.like_pattern_from_parts(country: "ES", bank: "0003")
+IbanBic.like_pattern_from_parts(country: "ES", bank: "0003")
  => "ES__0003________________"
 ```
 
 8. Random IBAN generation
 
 ```ruby
-2.4.1 :001 > require "iban_bic/random"
+require "iban_bic/random"
  => true
-2.4.1 :002 > IbanBic.random_iban
+IbanBic.random_iban
  => "MU52BOIR2768144336487102000AWQ"
-2.4.1 :003 > IbanBic.random_iban country: "ES"
+IbanBic.random_iban country: "ES"
  => "ES6111051493192369291292"
-2.4.1 :004 > IbanBic.random_iban tags: [:sepa]
+IbanBic.random_iban tags: [:sepa]
  => "FI5584518206233159"
-2.4.1 :005 > IbanBic.random_iban not_tags: [:sepa]
+IbanBic.random_iban not_tags: [:sepa]
  => "IL317532867920826062774"
 ```
 
@@ -132,7 +132,7 @@ $ bundle exec rake iban_bic:load_data
 3.b. Using static data from YAML files
 
 Create an initializer file for configuration:
-  
+
 ```bash
 $ bundle exec rails generate iban_bic:install --with-static-data
 ```
@@ -140,6 +140,22 @@ $ bundle exec rails generate iban_bic:install --with-static-data
 4. Customize initializer if needed, adding validations for new countries, or overriding YAML files.
 
 ## Changelog
+#### 1.4.4
+
+* Support for Rails 5.2.
+
+#### 1.4.3
+
+* Fixed validators to avoid failing when values are `nil`.
+
+#### 1.4.2
+
+* Dependencies security update.
+
+#### 1.4.1
+
+* Fixed BIC validation, don't allow less 1 or 2 characters for the office code and don't allow to add extra characters at the begining or at the end of the string.
+
 #### 1.4.0
 
 * BIC validation moved from BIC model to an independent validator.

data/lib/active_model/validations/bic_validator.rb

@@ -9,10 +9,10 @@ module ActiveModel
   module Validations
     class BicValidator < ActiveModel::EachValidator
       def validate_each(record, attribute, value)
+        return unless value.present?
+
         country_field = options[:country] ? record[options[:country]] : "[A-Z]{2}"
-        unless /[A-Z]{4}#{country_field}[0-9A-Z]{2,5}/.match? value.upcase
-          record.errors.add(attribute, :invalid_format)
-        end
+        record.errors.add(attribute, :invalid_format) unless /^[A-Z]{4}#{country_field}[0-9A-Z]{2}([0-9A-Z]{3})?$/.match? value.upcase
       end
     end
   end

data/lib/active_model/validations/iban_validator.rb

@@ -9,6 +9,8 @@ module ActiveModel
   module Validations
     class IbanValidator < ActiveModel::EachValidator
       def validate_each(record, attribute, value)
+        return unless value.present?
+
         if !IbanBic.parse(value)
           record.errors.add(attribute, :invalid_format)
         elsif !IbanBic.valid_check?(value)

data/lib/generators/iban_bic/install_generator.rb

@@ -8,7 +8,7 @@ module IbanBic
   class InstallGenerator < ::Rails::Generators::Base
     include ::Rails::Generators::Migration
 
-    source_root File.expand_path("../templates", __FILE__)
+    source_root File.expand_path("templates", __dir__)
 
     class_option(
       :with_static_bics,

data/lib/iban_bic/configuration.rb

@@ -4,8 +4,8 @@ module IbanBic
   class Configuration
     attr_accessor :iban_meta_path, :use_static_bics, :bics_table_name, :static_bics_path
 
-    def add(country)
-      IbanBic.country_validators[country] = Proc.new
+    def add(country, &block)
+      IbanBic.country_validators[country] = block
     end
 
     def static_bics?

data/lib/iban_bic/core.rb

@@ -15,8 +15,8 @@ module IbanBic
     @configuration ||= Configuration.new
   end
 
-  def configure
-    configuration.instance_eval(&Proc.new)
+  def configure(&block)
+    configuration.instance_eval(&block)
   end
 
   def parse(iban)

data/lib/iban_bic/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IbanBic
-  VERSION = "1.4.0"
+  VERSION = "1.4.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iban_bic
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.5
 platform: ruby
 authors:
 - Leonardo Diez
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-27 00:00:00.000000000 Z
+date: 2021-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: regexp-examples
   requirement: !ruby/object:Gem::Requirement
@@ -72,42 +72,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: '5.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.50'
+        version: 0.63.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.50'
+        version: 0.63.0
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 1.4.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 1.4.2
 - !ruby/object:Gem::Dependency
   name: virtus
   requirement: !ruby/object:Gem::Requirement
@@ -169,7 +169,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.5.2.1
 signing_key: 
 specification_version: 4
 summary: IBAN and BIC tools for Rails applications