iban-lookup 1.0.0 → 1.0.1

data/lib/iban-lookup.rb

@@ -1,6 +1,6 @@
 require 'active_support/all'
 require 'faraday'
-require 'devnull'
+# require 'devnull'
 
 # Lookup a new iban number
 #
@@ -13,7 +13,7 @@ module IbanLookup
     attr_accessor :api_key, :service, :cache, :logger
 
     def initialize
-      @logger ||= Logger.new(DevNull.new)
+      @logger ||= Logger.new(STDOUT)
     end
   end
 
@@ -29,71 +29,140 @@ module IbanLookup
 
   class IbanCom
     URL = 'https://www.iban.com'
-    ENDPOINT = 'clients/api/ibanv2.php'
 
-    attr_reader :params
+    attr_reader :object
 
-    def initialize(iban)
-      @params = {
-        api_key: IbanLookup.configuration.api_key,
-        format: :json,
-        iban: iban,
-      }
+    def initialize(iban = nil, options = {})
+      @object = if iban
+                  IbanChecker.new(iban)
+                else
+                  IbanCalc.new(options)
+                end
     end
 
-    def valid?
-      valid_codes = %w(001 002 003 004 005)
-      json.fetch('validations', []).all? { |v| valid_codes.include? v['code'] }
-    rescue => e
-      logger.error "Unable to validate IBAN from IBAN json response (#{e.class}): #{e.message}"
-      logger.debug e.backtrace.join("\n")
-      false
-    end
+    class IbanCalc
+      attr_reader :params
 
-    def json
-      @json ||= begin
-        logger.info "Looking up #{params[:iban]}"
-        body = if cache
-                 cache.get(params[:iban]).presence ||
-                 response.body.presence.tap { |j| cache.set(params[:iban], j) }
-               else
-                 response.body.presence
-               end
-
-        JSON.parse(body.presence || '{}')
+      def initialize(options = {})
+        @params = options.merge({
+          :api_key => IbanLookup.configuration.api_key,
+          :format => :json,
+        })
+      end
+
+      def json
+        @json ||= begin
+          logger.info "Looking up #{params.to_query}"
+          body = if cache
+                   cache.get(params.to_query).presence ||
+                   response.body.presence.tap { |j| cache.set(params.to_query, j) }
+                 else
+                   response.body.presence
+                 end
+
+          JSON.parse(body.presence || '{}')
+        end
+      rescue => e
+        logger.error "Unable to extract JSON from IBAN response (#{e.class}): #{e.message}"
+        logger.debug e.backtrace.join("\n")
+        {}
+      end
+
+      def response
+        url = "#{URL.chomp('/')}/clients/api/calc-api.php?#{params.to_query}"
+        logger.debug "IBAN url: #{url}"
+        Faraday.get(url).tap do |res|
+          logger.debug "IBAN response status: #{res.status}"
+          logger.debug "IBAN response body: #{res.body}"
+        end
       end
-    rescue => e
-      logger.error "Unable to extract JSON from IBAN response (#{e.class}): #{e.message}"
-      logger.debug e.backtrace.join("\n")
-      {}
-    end
 
-    def response
-      url = "#{URL.chomp('/')}/#{ENDPOINT.chomp('/')}?#{params.to_query}"
-      logger.debug "IBAN url: #{url}"
-      Faraday.get(url).tap do |res|
-        logger.debug "IBAN response status: #{res.status}"
-        logger.debug "IBAN response body: #{res.body}"
+      def cache
+        IbanLookup.configuration.cache
       end
+
+      private
+
+        def method_missing(name, *args)
+          json.fetch(String(name), nil)
+        end
+
+        def logger
+          @logger ||= IbanLookup.configuration.logger
+        end
     end
 
-    def cache
-      IbanLookup.configuration.cache
+    class IbanChecker
+      attr_reader :params
+
+      def initialize(iban)
+        @params = {
+          :api_key => IbanLookup.configuration.api_key,
+          :format => :json,
+          :iban => iban,
+        }
+      end
+
+      def valid?
+        valid_codes = %w(001 002 003 004 005)
+        json.fetch('validations', []).all? { |v| valid_codes.include? v['code'] }
+      rescue => e
+        logger.error "Unable to validate IBAN from IBAN json response (#{e.class}): #{e.message}"
+        logger.debug e.backtrace.join("\n")
+        false
+      end
+
+      def json
+        @json ||= begin
+          logger.info "Looking up #{params[:iban]}"
+          body = if cache
+                   cache.get(params[:iban]).presence ||
+                   response.body.presence.tap { |j| cache.set(params[:iban], j) }
+                 else
+                   response.body.presence
+                 end
+
+          JSON.parse(body.presence || '{}')
+        end
+      rescue => e
+        logger.error "Unable to extract JSON from IBAN response (#{e.class}): #{e.message}"
+        logger.debug e.backtrace.join("\n")
+        {}
+      end
+
+      def response
+        url = "#{URL.chomp('/')}/clients/api/ibanv2.php?#{params.to_query}"
+        logger.debug "IBAN url: #{url}"
+        Faraday.get(url).tap do |res|
+          logger.debug "IBAN response status: #{res.status}"
+          logger.debug "IBAN response body: #{res.body}"
+        end
+      end
+
+      def cache
+        IbanLookup.configuration.cache
+      end
+
+      private
+
+        def method_missing(name, *args)
+          json.fetch('bank_data', {}).fetch(String(name), nil)
+        end
+
+        def logger
+          @logger ||= IbanLookup.configuration.logger
+        end
     end
 
     private
 
       def method_missing(name, *args)
-        json.fetch('bank_data', {}).fetch(String(name), nil)
-      end
-
-      def logger
-        @logger ||= IbanLookup.configuration.logger
+        object.send(name, *args)
       end
   end
 
-  def lookup(iban)
-    "IbanLookup::#{configuration.service.classify}".constantize.new(iban)
+  def lookup(*args)
+    "IbanLookup::#{configuration.service.classify}".constantize.new(*args)
   end
   module_function :lookup
 end

data/lib/iban-lookup/version.rb

@@ -1,5 +1,5 @@
 module Iban
   module Lookup
-    VERSION = "1.0.0"
+    VERSION = "1.0.1"
   end
 end

metadata

@@ -1,143 +1,101 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: iban-lookup
-version: !ruby/object:Gem::Version
-  version: 1.0.0
+version: !ruby/object:Gem::Version 
+  hash: 21
+  prerelease: 
+  segments: 
+  - 1
+  - 0
+  - 1
+  version: 1.0.1
 platform: ruby
-authors:
+authors: 
 - Emil Kampp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-07 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
+
+date: 2016-12-01 00:00:00 +01:00
+default_executable: 
+dependencies: 
+- !ruby/object:Gem::Dependency 
   name: faraday
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
-  type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.2'
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 59
+        segments: 
+        - 0
+        - 9
+        - 0
+        version: 0.9.0
   type: :runtime
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
+  name: activesupport
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.2'
-- !ruby/object:Gem::Dependency
-  name: devnull
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.1'
+  requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 7
+        segments: 
+        - 3
+        - 0
+        version: "3.0"
   type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.1'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.4'
-- !ruby/object:Gem::Dependency
-  name: vcr
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.24'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.24'
-- !ruby/object:Gem::Dependency
-  name: memcache_mock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.0'
+  version_requirements: *id002
 description: IBAN Lookup wrapper for iban.com
-email:
+email: 
 - emil@kampp.me
 executables: []
+
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - lib/iban-lookup.rb
 - lib/iban-lookup/version.rb
+has_rdoc: true
 homepage: https://github.com/Inpay-Services/iban-lookup
-licenses: []
-metadata: {}
+licenses: 
+- MIT
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
-  requirements:
-  - - ">="
-    - !ruby/object:Gem::Version
-      version: '1.9'
-required_rubygems_version: !ruby/object:Gem::Requirement
-  requirements:
+required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
+  requirements: 
+  - - "="
+    - !ruby/object:Gem::Version 
+      hash: 57
+      segments: 
+      - 1
+      - 8
+      - 7
+      version: 1.8.7
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
+  requirements: 
   - - ">="
-    - !ruby/object:Gem::Version
-      version: '0'
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
 requirements: []
+
 rubyforge_project: 
-rubygems_version: 2.6.4
+rubygems_version: 1.6.2
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: IBAN Lookup wrapper for iban.com
 test_files: []
+

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: 2779f14a38bcc176964da975b11e28b8190105cb
-  data.tar.gz: 5c03b6f7467831bbeb7f4cc63c5170a8e3b5c81e
-SHA512:
-  metadata.gz: ae19345b58137c90c3a18ef8eaf94d545b20e914a10587c3501302a744669dda9fd83fe1f31b66669a77e83d82872d6c155687058fa187dd6b8f0ce2784b774f
-  data.tar.gz: ada1d285be36850b296c09302d901064832dd494f23539972cd66fb6ddf9a90a600ad081daccd78838fbdd151a48f263d64563869d0a7728648142eb7cef7dfb