iban-lookup 0.0.4 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a8b7733d28ed617952917053f247a28fa737fa67
-  data.tar.gz: 9f33173ccd290ad234debc076a97d8a4d0ec0a08
+  metadata.gz: fc2a0ad9e87dfbea8dd627048773654c8ca7195e
+  data.tar.gz: 3b46c945d1f56819f7a4de73943a9c6fcdd9cbc7
 SHA512:
-  metadata.gz: de0c3e32f4e14c2283855938785060711eb9c5e88302bf5ca511995383f6c2dfe4629550a01f985c13880621e4fabdac02c56a03e69dc6118abf777dbf600f63
-  data.tar.gz: a1370925b097d710f4d83ca5802aaee51d82b07c8720fe1a15b0ee723fef3b6a6641491d06378fcc7478fba2a283a490b765660ebeee989791bbcc4800d81be9
+  metadata.gz: 4f1e2821274d471b05e900c8a836a21fef71fd359ee286e8e962791d744f270a0fbb88b31b6098a2bf15021f06be2bad558db2d02be7c98e7ca56799212f2d5c
+  data.tar.gz: e9b7bdfcb3ae5d4b04dc822639786709849761168d9f228c8fadbc7637ecb65710c3127da3dfc15404014d76818813f91f828841f3c910513b13c65694aca394

data/lib/iban-lookup.rb

@@ -1,5 +1,6 @@
 require 'active_support/all'
 require 'faraday'
+require 'devnull'
 
 # Lookup a new iban number
 #
@@ -9,9 +10,10 @@ require 'faraday'
 #
 module IbanLookup
   class Configuration
-    attr_accessor :api_key, :service, :cache
+    attr_accessor :api_key, :service, :cache, :logger
 
     def initialize
+      @logger ||= Logger.new(DevNull.new)
     end
   end
 
@@ -32,6 +34,7 @@ module IbanLookup
     attr_reader :params
 
     def initialize(iban)
+      logger.info "Looking up #{iban}"
       @params = {
         api_key: IbanLookup.configuration.api_key,
         format: :json,
@@ -41,7 +44,11 @@ module IbanLookup
 
     def valid?
       valid_codes = %w(001 002 003 004 005)
-      json.fetch('validations', []).all? { valid_codes.include? v['code'] }
+      json.fetch('validations', []).all? { |v| valid_codes.include? v['code'] }
+    rescue => e
+      logger.error "Unable to validate IBAN from IBAN json response (#{e.class}): #{e.message}"
+      logger.debug e.backtrace.join("\n")
+      false
     end
 
     def json
@@ -52,12 +59,17 @@ module IbanLookup
                else
                  response.body.presence
                end
-        JSON.parse(body || '{}')
+        JSON.parse(body || '{}').tap do |j|
+          logger.debug "IBAN response: #{j}"
+        end
       end
+    rescue => e
+      logger.error "Unable to extract JSON from IBAN response (#{e.class}): #{e.message}"
+      logger.debug e.backtrace.join("\n")
+      {}
     end
 
     def response
-      p 'hello'
       Faraday.get("#{URL.chomp('/')}/#{ENDPOINT.chomp('/')}?#{params.to_query}")
     end
 
@@ -70,6 +82,10 @@ module IbanLookup
       def method_missing(name, *args)
         json.fetch('bank_data', {}).fetch(String(name), nil)
       end
+
+      def logger
+        @logger ||= IbanLookup.configuration.logger
+      end
   end
 
   def lookup(iban)

data/lib/iban-lookup/version.rb

@@ -1,5 +1,5 @@
 module Iban
   module Lookup
-    VERSION = "0.0.4"
+    VERSION = "0.0.6"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iban-lookup
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.6
 platform: ruby
 authors:
 - Emil Kampp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-30 00:00:00.000000000 Z
+date: 2016-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '4.2'
+- !ruby/object:Gem::Dependency
+  name: devnull
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement