ianfleeton-paypal-express 0.8.4 → 0.8.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 860b0d8f5a56c23d0d48d2306949be8ab7687e93cb8c54d57c875f5d44ebb349
-  data.tar.gz: d36695184583cef8c027cfab2b150fcb9b348a5a2d8de0823b6b6b017bc59d45
+  metadata.gz: 71ac73ad025a882ac48652beda11a73a210542510a68bd78241d703d63e4c247
+  data.tar.gz: da4b3eb65c1cec27cd472be7ad76a90e8ca613036e2d1a22c6bf21b20e2b68f1
 SHA512:
-  metadata.gz: c703ea1e91682f791c9adac0babfa33282a721380ebd082d65c3a0967c4c3cd3f14b5d12ea90ba2d12c7d5f5a59f6c9e189adf4ef2b6915945bd669694c7abe8
-  data.tar.gz: 3e9de3ff947c7d5fd75bfb7c21e4aa16c70d857ec64f7a6eb8172fd05b98fd209c514b5f4ca74a1c6f105344ba507201b0a02f342a0c81a357972f74b386cc31
+  metadata.gz: ceb6a50e6b03db89ab182df3e0a1956f950c17dcc32471375552b521d8d13c095b08874b2569bb25a0ebd0dbb88c8bc6c1873f7f7a363c322bbb3a83f7a7d162
+  data.tar.gz: eeee0431bbf8f9b714444d1c869688488a6cef87e45c89146390a1bb45ce2357fa2d3f6aaf0b0c5c276828d82f4f1a162ad84fb28aad6515b2c80f1532f89d6a

data/.travis.yml

@@ -2,11 +2,11 @@ before_install:
   - gem install bundler
 
 rvm:
-  - 2.2.9
-  - 2.3.6
-  - 2.4.3
-  - 2.5.0
+  - 2.7.2
+  - 3.0.0
+  - 3.1.0
 
 env:
-  - RAILS_VERSION="~> 4.2"
-  - RAILS_VERSION="~> 5.0"
+  - RAILS_VERSION="~> 5.2"
+  - RAILS_VERSION="~> 6.0"
+  - RAILS_VERSION="~> 7.0"

data/README.rdoc

@@ -6,6 +6,11 @@ Express Checkout for Digital Goods is also supported.
 
 {<img src="https://travis-ci.org/ianfleeton/paypal-express.svg" />}[https://travis-ci.org/ianfleeton/paypal-express]
 
+== Deprecation warning
+
+Many, or perhaps all, of the APIs used in this gem have been {deprecated}[https://developer.paypal.com/docs/archive/express-checkout/] since January 2017.
+Exercise caution with the values returned by the APIs.
+For example, it has been {reported}[https://github.com/ianfleeton/paypal-express/issues/21] that GetTransaction can return incorrect values for a payer's verification status.
 
 == Why this fork?
 

data/VERSION

@@ -1 +1 @@
-0.8.4
+0.8.7

data/ianfleeton-paypal-express.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |s|
   s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.files = `git ls-files`.split("\n")
   s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.add_dependency 'activesupport', '>= 2.3', '< 6'
+  s.add_dependency 'activesupport', '>= 2.3', '< 8'
   s.add_dependency 'rest-client', '~> 2.0'
   s.add_dependency 'attr_required', '~> 1.0'
   s.add_development_dependency 'rake', '~> 12.0', '>= 12.0.0'

data/lib/paypal/payment/request.rb

@@ -59,7 +59,7 @@ module Paypal
 
       def items_amount
         self.items.sum do |item|
-          item.quantity * BigDecimal.new((item.amount || 0).to_s)
+          item.quantity * BigDecimal((item.amount || 0).to_s)
         end
       end
     end

data/lib/paypal/util.rb

@@ -5,7 +5,7 @@ module Paypal
 
     def self.formatted_amount(x)
       x = '0' if x == '' || x.nil?
-      sprintf '%0.2f', BigDecimal.new(x.to_s).round(2)
+      sprintf '%0.2f', BigDecimal(x.to_s)
     end
 
     def self.to_numeric(x)
@@ -14,7 +14,12 @@ module Paypal
 
       decimal = BigDecimal(string)
 
-      if decimal == x.to_i
+      if decimal != BigDecimal(string).round(2)
+        raise ArgumentError.new(
+          'Precision cannot be higher than two decimal places. ' \
+          'Truncate or round first.'
+        )
+      elsif decimal == x.to_i
         x.to_i
       else
         decimal

data/spec/fake_response/DoCapture/success.txt

@@ -1 +1 @@
-ACK=Success&AMT=440.00&AUTHORIZATIONID=2RG78938NK8989844&BUILD=8334781&CORRELATIONID=311611c111b48&CURRENCYCODE=BRL&EXCHANGERATE=0.426354&FEEAMT=13.16&ORDERTIME=2013-11-05T17%3A34%3A56Z&PARENTTRANSACTIONID=2RG78938NK8989844&PAYMENTSTATUS=Completed&PAYMENTTYPE=instant&PENDINGREASON=None&PROTECTIONELIGIBILITY=Ineligible&PROTECTIONELIGIBILITYTYPE=None&REASONCODE=None&SETTLEAMT=181.98&TAXAMT=0.00&TIMESTAMP=2013-11-05T17%3A34%3A56Z&TRANSACTIONID=9VW4495267708531S&TRANSACTIONTYPE=expresscheckout&VERSION=88.0
+ACK=Success&AMT=440.00&AUTHORIZATIONID=2RG78938NK8989844&BUILD=8334781&CORRELATIONID=311611c111b48&CURRENCYCODE=BRL&EXCHANGERATE=0.426354&FEEAMT=13.16&ORDERTIME=2013-11-05T17%3A34%3A56Z&PARENTTRANSACTIONID=2RG78938NK8989844&PAYMENTSTATUS=Completed&PAYMENTTYPE=instant&PENDINGREASON=None&PROTECTIONELIGIBILITY=Ineligible&PROTECTIONELIGIBILITYTYPE=None&REASONCODE=None&SETTLEAMT=181.98&TIMESTAMP=2013-11-05T17%3A34%3A56Z&TRANSACTIONID=9VW4495267708531S&VERSION=88.0

data/spec/paypal/util_spec.rb

@@ -28,5 +28,14 @@ describe Paypal::Util do
       expect(Paypal::Util.to_numeric('10.24')).to eq(BigDecimal('10.24'))
       expect(Paypal::Util.to_numeric('10.25')).to eq(BigDecimal('10.25'))
     end
+
+    it 'returns zero for blank values' do
+      expect(Paypal::Util.to_numeric(nil)).to be_zero
+      expect(Paypal::Util.to_numeric('')).to be_zero
+    end
+
+    it 'raises an ArgumentError when precision is higher than 2 decimals' do
+      expect { Paypal::Util.to_numeric('1.234') }.to raise_error(ArgumentError)
+    end
   end
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: ianfleeton-paypal-express
 version: !ruby/object:Gem::Version
-  version: 0.8.4
+  version: 0.8.7
 platform: ruby
 authors:
 - Ian Fleeton
 - nov matake
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-04-19 00:00:00.000000000 Z
+date: 2022-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -20,7 +20,7 @@ dependencies:
         version: '2.3'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -30,7 +30,7 @@ dependencies:
         version: '2.3'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '8'
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
@@ -237,7 +237,7 @@ homepage: http://github.com/ianfleeton/paypal-express
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--charset=UTF-8"
 require_paths:
@@ -253,9 +253,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
-signing_key: 
+rubygems_version: 3.2.32
+signing_key:
 specification_version: 4
 summary: PayPal Express Checkout API Client for Instance, Recurring and Digital Goods
   Payment.