ianfleeton-paypal-express 0.8.4 → 0.8.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 860b0d8f5a56c23d0d48d2306949be8ab7687e93cb8c54d57c875f5d44ebb349
-  data.tar.gz: d36695184583cef8c027cfab2b150fcb9b348a5a2d8de0823b6b6b017bc59d45
+  metadata.gz: 2fd05e90f23d32893f2c0283c883597c54cc6e544614e188cb82902251fd4be7
+  data.tar.gz: 5f4305a6844151eac4cdb378aa659c453b86d38a3eb33af5877380c98be67b72
 SHA512:
-  metadata.gz: c703ea1e91682f791c9adac0babfa33282a721380ebd082d65c3a0967c4c3cd3f14b5d12ea90ba2d12c7d5f5a59f6c9e189adf4ef2b6915945bd669694c7abe8
-  data.tar.gz: 3e9de3ff947c7d5fd75bfb7c21e4aa16c70d857ec64f7a6eb8172fd05b98fd209c514b5f4ca74a1c6f105344ba507201b0a02f342a0c81a357972f74b386cc31
+  metadata.gz: 61dc26f99f5cb71635462bda528a36ac1766f6ee99be13a9b7d02e0e89bb8c27bbe82ee846106352953dda81d180b27265366c74dd6a8b16e63f422d6172b276
+  data.tar.gz: 4f2c99598e1a73491c0c3bd8bc210de5a4437d0c022b32825ba6c734d2c31e7f76852f65c58bec099ddf9b50bf37bcc82c8b17af96f036651153f0493e90174d

data/.travis.yml

@@ -2,10 +2,9 @@ before_install:
   - gem install bundler
 
 rvm:
-  - 2.2.9
-  - 2.3.6
-  - 2.4.3
-  - 2.5.0
+  - 2.4.6
+  - 2.5.5
+  - 2.6.3
 
 env:
   - RAILS_VERSION="~> 4.2"

data/VERSION

@@ -1 +1 @@
-0.8.4
+0.8.5

data/lib/paypal/payment/request.rb

@@ -59,7 +59,7 @@ module Paypal
 
       def items_amount
         self.items.sum do |item|
-          item.quantity * BigDecimal.new((item.amount || 0).to_s)
+          item.quantity * BigDecimal((item.amount || 0).to_s)
         end
       end
     end

data/lib/paypal/util.rb

@@ -5,7 +5,7 @@ module Paypal
 
     def self.formatted_amount(x)
       x = '0' if x == '' || x.nil?
-      sprintf '%0.2f', BigDecimal.new(x.to_s).round(2)
+      sprintf '%0.2f', BigDecimal(x.to_s)
     end
 
     def self.to_numeric(x)
@@ -14,7 +14,12 @@ module Paypal
 
       decimal = BigDecimal(string)
 
-      if decimal == x.to_i
+      if decimal != BigDecimal(string).round(2)
+        raise ArgumentError.new(
+          'Precision cannot be higher than two decimal places. ' \
+          'Truncate or round first.'
+        )
+      elsif decimal == x.to_i
         x.to_i
       else
         decimal

data/spec/fake_response/DoCapture/success.txt

@@ -1 +1 @@
-ACK=Success&AMT=440.00&AUTHORIZATIONID=2RG78938NK8989844&BUILD=8334781&CORRELATIONID=311611c111b48&CURRENCYCODE=BRL&EXCHANGERATE=0.426354&FEEAMT=13.16&ORDERTIME=2013-11-05T17%3A34%3A56Z&PARENTTRANSACTIONID=2RG78938NK8989844&PAYMENTSTATUS=Completed&PAYMENTTYPE=instant&PENDINGREASON=None&PROTECTIONELIGIBILITY=Ineligible&PROTECTIONELIGIBILITYTYPE=None&REASONCODE=None&SETTLEAMT=181.98&TAXAMT=0.00&TIMESTAMP=2013-11-05T17%3A34%3A56Z&TRANSACTIONID=9VW4495267708531S&TRANSACTIONTYPE=expresscheckout&VERSION=88.0
+ACK=Success&AMT=440.00&AUTHORIZATIONID=2RG78938NK8989844&BUILD=8334781&CORRELATIONID=311611c111b48&CURRENCYCODE=BRL&EXCHANGERATE=0.426354&FEEAMT=13.16&ORDERTIME=2013-11-05T17%3A34%3A56Z&PARENTTRANSACTIONID=2RG78938NK8989844&PAYMENTSTATUS=Completed&PAYMENTTYPE=instant&PENDINGREASON=None&PROTECTIONELIGIBILITY=Ineligible&PROTECTIONELIGIBILITYTYPE=None&REASONCODE=None&SETTLEAMT=181.98&TIMESTAMP=2013-11-05T17%3A34%3A56Z&TRANSACTIONID=9VW4495267708531S&VERSION=88.0

data/spec/paypal/util_spec.rb

@@ -28,5 +28,14 @@ describe Paypal::Util do
       expect(Paypal::Util.to_numeric('10.24')).to eq(BigDecimal('10.24'))
       expect(Paypal::Util.to_numeric('10.25')).to eq(BigDecimal('10.25'))
     end
+
+    it 'returns zero for blank values' do
+      expect(Paypal::Util.to_numeric(nil)).to be_zero
+      expect(Paypal::Util.to_numeric('')).to be_zero
+    end
+
+    it 'raises an ArgumentError when precision is higher than 2 decimals' do
+      expect { Paypal::Util.to_numeric('1.234') }.to raise_error(ArgumentError)
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ianfleeton-paypal-express
 version: !ruby/object:Gem::Version
-  version: 0.8.4
+  version: 0.8.5
 platform: ruby
 authors:
 - Ian Fleeton
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-19 00:00:00.000000000 Z
+date: 2019-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -63,22 +63,22 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '12.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: 12.0.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '12.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: 12.0.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -97,22 +97,22 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.5'
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.5.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.5'
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.5.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.5'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -253,8 +253,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: PayPal Express Checkout API Client for Instance, Recurring and Digital Goods