i_wonder 0.0.9 → 0.1.1

data/test/factories/ab_test_factory.rb

@@ -0,0 +1,15 @@
+FactoryGirl.define do
+  factory :ab_test, :class => IWonder::AbTest do
+    sequence(:name) {|n| "Test #{n}" }
+    sequence(:sym) {|n| "test_#{n}" }
+    test_group_names ["Options 1", "Options 2"]
+    test_applies_to "session"
+    
+    ab_test_goals {|ab_test_goals|  [ab_test_goals.association(:test_goal)]  }
+  end
+  
+  factory :test_goal, :class => IWonder::AbTestGoal do
+    event_type "success"
+  end
+
+end

data/test/functional/ab_controller_mixins_test.rb

@@ -14,7 +14,7 @@ class ABControllerMixinsTest < ActionController::TestCase
   end
 
   test "fetching the correct group" do
-    @ab_test = IWonder::AbTest.create(:name => "Blah Test", :sym => "blah", :test_group_names => ["Options 1", "Options 2"], :ab_test_goals_attributes => {"0" => {:event_type => "success"}})
+    @ab_test = Factory(:ab_test)
     @ab_test.update_attribute(:test_applies_to, "session")
     assert_valid @ab_test
     
@@ -40,7 +40,7 @@ class ABControllerMixinsTest < ActionController::TestCase
   end  
   
   test "adding to test groups" do
-    @ab_test = IWonder::AbTest.create(:name => "Blah Test", :sym => "blah", :test_group_names => ["Options 1", "Options 2"], :ab_test_goals_attributes => {"0" => {:event_type => "success"}})
+    @ab_test = Factory(:ab_test)
     @ab_test.update_attribute(:test_applies_to, "session")
     assert_valid @ab_test
     
@@ -60,21 +60,35 @@ class ABControllerMixinsTest < ActionController::TestCase
   end
 
   test "if which_test_group works" do
-    @ab_test = IWonder::AbTest.create(:name => "Blah Test", :sym => "blah", :test_group_names => ["Options 1", "Options 2"], :ab_test_goals_attributes => {"0" => {:event_type => "success"}})
+    @ab_test = Factory(:ab_test)
     @ab_test.update_attribute(:test_applies_to, "session")
     
     assert_equal 0, @ab_test.test_group_memberships.count
     
     # first time shouldn't be in a group yet. Will get placed in one.
-    first_group = @controller.which_test_group?("blah")
+    first_group = @controller.which_test_group?(@ab_test.sym)
     assert_include @ab_test.test_group_names, first_group
     assert_equal 1, @ab_test.test_group_memberships.count
     
-    second_group = @controller.which_test_group?("blah")
+    second_group = @controller.which_test_group?(@ab_test.sym)
     assert_include first_group, second_group
     assert_equal 1, @ab_test.test_group_memberships.count
   end
   
+  test "which_test_group doesn't barf on missing member" do
+    @ab_test = Factory(:ab_test)
+    @ab_test.update_attribute(:test_applies_to, "session")
+    
+    @controller.instance_eval do
+      cookies[IWonder::COOKIE_KEY+IWonder::Logging::SESSION_KEY_NAME] = nil
+      cookies.delete(IWonder::COOKIE_KEY+IWonder::Logging::SESSION_KEY_NAME)
+    end
+    
+    assert_equal 0, @ab_test.test_group_memberships.count
+    assert @controller.which_test_group?(@ab_test.sym).present?, "something should still be returned"
+    assert_equal 0, @ab_test.test_group_memberships.count, "Shuold not have made a memberhsip"
+  end
+  
   test "the element the test applies to is not available" do
     pending
   end
@@ -84,7 +98,7 @@ class ABControllerMixinsTest < ActionController::TestCase
   end
   
   test "forcing a choice with paramteres" do
-    @ab_test = IWonder::AbTest.create(:name => "Override Test", :sym => "override_test", :test_group_names => ["Options 1", "Options 2"], :ab_test_goals_attributes => {"0" => {:event_type => "success"}}, :test_applies_to => "session")
+    @ab_test = Factory(:ab_test, :sym => "override_test")
     assert_valid @ab_test
     
     @controller.params[:_force_ab_test] = "override_test"

data/test/integration/i_wonder/ab_tests_controller_test.rb

@@ -0,0 +1,46 @@
+require File.expand_path("../../test_helper.rb", File.dirname(__FILE__))
+
+# This is an integration test because I couldn't get the routes to find the controller on functional tests
+
+module IWonder
+  class AbTestsControllerTest < ActionDispatch::IntegrationTest
+
+    # test "index works" do
+    #   AbTest.destroy_all
+    #   get "i_wonder/ab_tests"
+    #   assert_response :success
+    # end
+    # 
+    
+    test "update works" do
+      AbTest.delete_all
+      AbTestGoal.delete_all
+      
+      @ab_test = Factory(:ab_test)
+      @ab_test.ab_test_goals.create(:goal_type => "Event", :event_type => "random event")
+      
+      goal_1 = @ab_test.ab_test_goals.first
+      goal_2 = @ab_test.ab_test_goals.last
+      
+      
+      put "i_wonder/ab_tests/#{@ab_test.id}", {:ab_test => {:name => "new name", :ab_test_goals_attributes => {
+          "0" => {:id => goal_1.id, :goal_type => "Event", :event_type => "success 2" },
+          "1" => {:id => goal_2.id, :goal_type => "Event", :event_type => "random_event", "_destroy" => true },
+          "2" => {:goal_type => "Event", :event_type => "new_event" }
+          }}}
+      assert_valid assigns(:ab_test)
+      @ab_test.reload
+      assert_redirected_to @ab_test
+      
+      # puts "after:"
+      #   puts @ab_test.ab_test_goals.collect(&:inspect).join("\n")
+      #   
+      #   
+      assert_equal "new name", @ab_test.name
+      assert_equal 2, @ab_test.ab_test_goals.count, @ab_test.ab_test_goals.collect(&:inspect).join("\n")
+      assert_equal "success 2", @ab_test.ab_test_goals.first.event_type
+      assert_equal "new_event", @ab_test.ab_test_goals.last.event_type
+    end
+
+  end
+end

data/test/unit/i_wonder/ab_test_test.rb

@@ -6,12 +6,17 @@ module IWonder
   class AbTestTest < ActiveSupport::TestCase
   
     test "counting results" do
-      @ab_test = IWonder::AbTest.create(:name => "Unique Test 1", :sym => "unique_sym_1", :test_group_names => ["Options 1", "Options 2"], :ab_test_goals_attributes => {"0" => {:event_type => "success"}}, :test_applies_to => "session")
+      AbTest.delete_all
+      
+      @ab_test = Factory(:ab_test)
+      @ab_test.ab_test_goals.create(:goal_type => "Page View", :page_view_controller => "TestController", :page_view_action => "test")
       assert_valid @ab_test
-      ab_test_goal = @ab_test.ab_test_goals.first
+      ab_test_goal_1 = @ab_test.ab_test_goals[0]
+      ab_test_goal_2 = @ab_test.ab_test_goals[1]
+      assert_equal "test", ab_test_goal_2.page_view_controller
 
       Timecop.travel(Time.zone.now - 1.day) do
-        assert IWonder::Event.create(:event_type => "success", :session_id => "5") # this should be ignored
+        assert Event.create(:event_type => "success", :session_id => "5") # this should be ignored
       end
 
       assert @ab_test.test_group_memberships.create(:member_type => "session", :member_id => "1", :test_group_name => "Option 1")
@@ -20,17 +25,21 @@ module IWonder
       assert @ab_test.test_group_memberships.create(:member_type => "session", :member_id => "4", :test_group_name => "Option 2")
       assert @ab_test.test_group_memberships.create(:member_type => "session", :member_id => "5", :test_group_name => "Option 1")
       
-      assert IWonder::Event.create(:event_type => "success", :session_id => "1")
-      assert IWonder::Event.create(:event_type => "random",  :session_id => "2")
-      assert IWonder::Event.create(:event_type => "success", :session_id => "2")
-      assert IWonder::Event.create(:event_type => "success", :session_id => "3")
-      assert IWonder::Event.create(:event_type => "random",  :session_id => "4")
-      assert IWonder::Event.create(:event_type => "success", :session_id => "6")
+      assert Event.create(:event_type => "success", :session_id => "1")
+      assert Event.create(:event_type => "success", :session_id => "1") # duplicate shouldn't be counted
+      assert Event.create(:event_type => "hit",     :session_id => "1", :controller => "test", :action => "test")
+      assert Event.create(:event_type => "random",  :session_id => "2")
+      assert Event.create(:event_type => "success", :session_id => "2")
+      assert Event.create(:event_type => "success", :session_id => "3")
+      assert Event.create(:event_type => "random",  :session_id => "4")
+      assert Event.create(:event_type => "success", :session_id => "6")
       
       assert_equal 2, @ab_test.assigned_count("Option 1")
       assert_equal 3, @ab_test.assigned_count("Option 2")
-      assert_equal 1, @ab_test.get_results_for("Option 1", ab_test_goal)
-      assert_equal 2, @ab_test.get_results_for("Option 2", ab_test_goal)
+      assert_equal 1, @ab_test.get_results_for("Option 1", ab_test_goal_1)
+      assert_equal 2, @ab_test.get_results_for("Option 2", ab_test_goal_1)
+      
+      assert_equal 1, @ab_test.get_results_for("Option 1", ab_test_goal_2)
     end
     
   end

data/test/unit/i_wonder/loader_test.rb

@@ -34,7 +34,7 @@ module IWonder
     test "Saves Correctly" do
       assert !File.exists?(AbTesting::Loader.send(:file_name, "save_test"))
       
-      @ab_test = IWonder::AbTest.create(:name => "Blah Test", :sym => "save_test", :test_group_names => ["Options 1", "Options 2"], :ab_test_goals_attributes => {"0" => {:event_type => "success"}}, :test_applies_to => "session")
+      @ab_test = Factory(:ab_test, :name => "Blah Test", :sym => "save_test")
       AbTesting::Loader.save_ab_test(@ab_test)
       
       assert File.exists?(AbTesting::Loader.send(:file_name, "save_test"))
@@ -48,7 +48,7 @@ module IWonder
     end
     
     test "Updates existing test" do
-      @ab_test = IWonder::AbTest.create(:name => "Different name", :sym => "save_test", :test_group_names => ["Options 2", "Options 3"], :ab_test_goals_attributes => {"0" => {:event_type => "fail"}}, :test_applies_to => "user")
+      @ab_test = Factory(:ab_test, :sym => "save_test")
       `cp #{TEST_ASSETS + "/i_wonder/save_test.xml"} #{AbTesting::Loader::AB_TEST_DATA_DIR + "/save_test.xml"}`
       
       AbTesting::Loader.load_all
@@ -67,7 +67,7 @@ module IWonder
     
     test "Test Destruction removes files" do
       assert !File.exists?(AbTesting::Loader.send(:file_name, "save_test"))
-      @ab_test = IWonder::AbTest.create(:name => "Blah Test", :sym => "save_test", :test_group_names => ["Options 2", "Options 3"], :ab_test_goals_attributes => {"0" => {:event_type => "fail"}}, :test_applies_to => "user")
+      @ab_test = Factory(:ab_test, :sym => "save_test")
       assert File.exists?(AbTesting::Loader.send(:file_name, "save_test"))
       @ab_test.destroy
       assert !File.exists?(AbTesting::Loader.send(:file_name, "save_test"))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: i_wonder
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-10-31 00:00:00.000000000Z
+date: 2011-11-01 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &2156708860 !ruby/object:Gem::Requirement
+  requirement: &2156187460 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 3.1.1
   type: :runtime
   prerelease: false
-  version_requirements: *2156708860
+  version_requirements: *2156187460
 - !ruby/object:Gem::Dependency
   name: jquery-rails
-  requirement: &2156882260 !ruby/object:Gem::Requirement
+  requirement: &2156185140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2156882260
+  version_requirements: *2156185140
 - !ruby/object:Gem::Dependency
   name: delayed_job
-  requirement: &2157011100 !ruby/object:Gem::Requirement
+  requirement: &2156184220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '2.1'
   type: :runtime
   prerelease: false
-  version_requirements: *2157011100
+  version_requirements: *2156184220
 - !ruby/object:Gem::Dependency
   name: hash_accessor
-  requirement: &2157129820 !ruby/object:Gem::Requirement
+  requirement: &2156177420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: '1.0'
   type: :runtime
   prerelease: false
-  version_requirements: *2157129820
+  version_requirements: *2156177420
 - !ruby/object:Gem::Dependency
   name: factory_girl_rails
-  requirement: &2157267000 !ruby/object:Gem::Requirement
+  requirement: &2156174740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2157267000
+  version_requirements: *2156174740
 - !ruby/object:Gem::Dependency
   name: pg
-  requirement: &2157427760 !ruby/object:Gem::Requirement
+  requirement: &2156169580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2157427760
+  version_requirements: *2156169580
 - !ruby/object:Gem::Dependency
   name: pry
-  requirement: &2157507260 !ruby/object:Gem::Requirement
+  requirement: &2156157320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2157507260
+  version_requirements: *2156157320
 - !ruby/object:Gem::Dependency
   name: sass
-  requirement: &2157509260 !ruby/object:Gem::Requirement
+  requirement: &2156151100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,10 +98,10 @@ dependencies:
         version: '3.1'
   type: :development
   prerelease: false
-  version_requirements: *2157509260
+  version_requirements: *2156151100
 - !ruby/object:Gem::Dependency
   name: timecop
-  requirement: &2157508820 !ruby/object:Gem::Requirement
+  requirement: &2156148020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -109,10 +109,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2157508820
+  version_requirements: *2156148020
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &2157508360 !ruby/object:Gem::Requirement
+  requirement: &2156146280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -120,7 +120,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2157508360
+  version_requirements: *2156146280
 description: Analytics and AB Testing awesomeness for rails.
 email:
 - development@forrestzeisler.com
@@ -291,12 +291,14 @@ files:
 - test/dummy/tmp/cache/assets/DF9/5C0/sprockets%2Fd711a81a91fcc3cd1a30798dd94fdcbd
 - test/dummy/tmp/cache/assets/E04/890/sprockets%2F2f5173deea6c795b8fdde723bb4b63af
 - test/dummy/tmp/cache/assets/E8D/B70/sprockets%2Fd62ab1e993c1edcadba5317fe8c7dffb
+- test/factories/ab_test_factory.rb
 - test/factories/metric_factory.rb
 - test/factories/report_factory.rb
 - test/factories/snapshot_factory.rb
 - test/functional/ab_controller_mixins_test.rb
 - test/functional/logging_controller_mixins_test.rb
 - test/i_wonder_test.rb
+- test/integration/i_wonder/ab_tests_controller_test.rb
 - test/integration/i_wonder/dashboard_controller_test.rb
 - test/integration/i_wonder/events_controller_test.rb
 - test/integration/i_wonder/metrics_controller_test.rb
@@ -428,12 +430,14 @@ test_files:
 - test/dummy/tmp/cache/assets/DF9/5C0/sprockets%2Fd711a81a91fcc3cd1a30798dd94fdcbd
 - test/dummy/tmp/cache/assets/E04/890/sprockets%2F2f5173deea6c795b8fdde723bb4b63af
 - test/dummy/tmp/cache/assets/E8D/B70/sprockets%2Fd62ab1e993c1edcadba5317fe8c7dffb
+- test/factories/ab_test_factory.rb
 - test/factories/metric_factory.rb
 - test/factories/report_factory.rb
 - test/factories/snapshot_factory.rb
 - test/functional/ab_controller_mixins_test.rb
 - test/functional/logging_controller_mixins_test.rb
 - test/i_wonder_test.rb
+- test/integration/i_wonder/ab_tests_controller_test.rb
 - test/integration/i_wonder/dashboard_controller_test.rb
 - test/integration/i_wonder/events_controller_test.rb
 - test/integration/i_wonder/metrics_controller_test.rb