i18n_proofreading 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1dba859df20dd5bc929a6c3bbde753b36591b8dfd92fb24547272ab9d1137d72
-  data.tar.gz: 284954216db75a99209bb72248c2b447ac62dbd3d28b550c996015392422c4ac
+  metadata.gz: 9a73bed80d485e35617f3ea214165c0ffcfc296721ac896f09d389cbf3a1b6e8
+  data.tar.gz: 4cc2e32bf3420c01ea3af58c33582ffaa37c9fd26cf6e7425db1b554c4652c84
 SHA512:
-  metadata.gz: 47cf7fd0e919c0f1be04b1b27804238da759b955339ee316d4fb522bdfd2e34b96aa661739bd9e8dff324d0a61d7127e155a2322f99b48d8d24736c69aac4003
-  data.tar.gz: ff614c4482c8c9ee666d6a636f46cc84d724e75289925dabf8aa10b27b004d98e31ce539715476faf7f155b6d2cf3d4b26a86899e281d255a449824c05f816fd
+  metadata.gz: 1c884b9b47f7e5712ab618fc663f5160ed7d7eabd571b295818efe445f11111f2bbb81e7110336594c7885d79c032479241623a33bb81d170309165ccb522f40
+  data.tar.gz: 7c939c1e63d708c6772dcd4e703816967942b1ca2400a05027cbd8fa200ec1c446de390daf2bca70cf5313eccaa4615dc132464ffbe395a3a8cfb19d84ba04f0

data/CHANGELOG.md

@@ -2,6 +2,33 @@
 
 ## [Unreleased]
 
+## [1.1.1] - 2026-10-30
+
+### Fixed
+
+- **A Turbo visit to a page without the tool now switches the widget off.**
+  Before, the widget kept the previous page's config when the new page carried
+  none, so the pill survived a sign-out or `enabled` turning false until a hard
+  reload, and a visit made while in suggest mode (Back, `Turbo.visit`) kept
+  every click on the new page frozen. A host that worked around this with a
+  `data-turbo-track="reload"` element can drop it.
+- **The pill comes back after a Turbo render that has no `turbo:load`**, such
+  as a form answered with a 422 or a morph refresh. The widget's per-page setup
+  now runs on `turbo:render` as well as `turbo:load`; it is idempotent, so a
+  normal visit runs it twice at the cost of rebuilding one button.
+- Costs: a page with a malformed config block now gets no widget instead of the
+  previous page's; a host that injects the tag in only some layouts sees the
+  pill only on those pages. No configuration, migration, or server-side change.
+- Close a suggestion dialog that a custom render preserves after suggest mode
+  becomes unavailable or inactive, releasing its scroll and focus locks. Any
+  unsent draft in that dialog is discarded when leaving suggest mode.
+
+### Changed
+
+- Exercise real Turbo visits, cached history, 422 responses, and morph refreshes
+  in browser tests. Turbo is a development/test dependency only; the installed
+  gem still has no Turbo dependency or asset build step.
+
 ## [1.1.0] - 2026-10-18
 
 - Add Rails edge CI and experimental Ruby 4.0+ Ractor request support. The host

data/README.md

@@ -314,6 +314,9 @@ configure Action View during initialization can boot reliably.
   `script-src` including `strict-dynamic`. Runtime config ships as
   `<script type="application/json">` (data, not code), so it needs no nonce and
   survives Turbo visits.
+- **The browser follows the server's gate across Turbo visits.** A page the
+  middleware injected nothing into (signed out, `enabled` false) turns the
+  widget off: no pill and no suggest mode, even when the previous page had them.
 - **Rate-limited per IP** on the submission endpoint (30/min by default,
   Rails 7.2+).
 - **Host-owned review data.** A row may contain translated text, proposed text,

data/lib/i18n_proofreading/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module I18nProofreading
-  VERSION = '1.1.0'
+  VERSION = '1.1.1'
 end

data/lib/i18n_proofreading/widget.js

@@ -20,6 +20,12 @@
   if (!config || window.__i18nProofreadingLoaded) return;
   window.__i18nProofreadingLoaded = true;
 
+  // The state of a page without a config block: the middleware injected
+  // nothing, so the tool is not available there (signed out, `enabled` false,
+  // a layout without the tag). Handlers read `config.active`, so this keeps
+  // them inert instead of acting on the last page's config.
+  var UNAVAILABLE = { active: false, showPill: false };
+
   var LEFT = "⟦"; // ⟦
   var RIGHT = "⟧"; // ⟧
   var TOKEN = new RegExp(LEFT + "([^" + RIGHT + "]+)" + RIGHT);
@@ -56,9 +62,13 @@
 
     // Everything else lives in <body>, which Turbo replaces on every visit —
     // taking the pill and the active-mode highlighting with it. Re-run the
-    // per-page setup on each visit so the widget keeps working without a hard
-    // reload. render() also runs now for the initial (or non-Turbo) load.
+    // per-page setup after every body swap so the widget keeps working without
+    // a hard reload. render() also runs now for the initial (or non-Turbo) load.
+    // turbo:render covers swaps with no turbo:load after them (a form answered
+    // with a 422 or 500, a morph refresh); turbo:load covers the rest. render()
+    // is idempotent, so a visit that fires both only rebuilds one button.
     render();
+    document.addEventListener("turbo:render", render);
     document.addEventListener("turbo:load", render);
     document.addEventListener("turbo:frame-load", function () { strip(); });
 
@@ -88,18 +98,23 @@
 
   function render() {
     // Re-read on each visit: the injected config is data (not an executed
-    // script), so it reflects the page Turbo just rendered.
-    config = readConfig() || config;
-    // A Turbo body swap can drop the overlay without close(); documentElement
-    // survives the swap, so release the scroll lock or the new page is frozen.
-    if (overlay && !document.body.contains(overlay)) {
-      overlay = null;
-      unwatchViewport();
-      unlockScroll();
-    }
+    // script), so it reflects the page Turbo just rendered. No config means the
+    // tool is not available on this page, so the widget switches off rather
+    // than keep the previous page's pill or suggest mode across the visit.
+    config = readConfig() || UNAVAILABLE;
+    // A body swap can detach the dialog; a custom render can preserve it even
+    // after suggest mode is disabled. Both must release its scroll/focus lock.
+    if (overlay && (!config.active || !document.body.contains(overlay))) close();
+    // A cached snapshot or a morph can carry the previous page's pill; the
+    // current config alone decides whether one is shown.
+    removePill();
+    // <html> survives a Turbo visit, so the suggest-mode class must be cleared
+    // as well as set.
+    document.documentElement.classList.toggle("i18np-active", !!config.active);
+    if (config === UNAVAILABLE) return;
+
     injectStyles();
     if (config.showPill !== false) buildPill();
-    document.documentElement.classList.toggle("i18np-active", !!config.active);
     if (config.active) strip();
   }
 
@@ -199,10 +214,13 @@
 
   // --- pill -----------------------------------------------------------------
 
-  function buildPill() {
-    var existing = document.querySelector(".i18np-pill");
-    if (existing) existing.remove();
+  function removePill() {
+    document.querySelectorAll(".i18np-pill").forEach(function (pill) {
+      pill.remove();
+    });
+  }
 
+  function buildPill() {
     var pill = document.createElement("button");
     pill.type = "button";
     pill.className = "i18np-pill" + (config.active ? " i18np-pill-on" : "");

data/lib/i18n_proofreading/widget.rb

@@ -46,8 +46,10 @@ module I18nProofreading
       # The config rides in a `type="application/json"` block: it is *data*, not
       # code, so the browser never executes it and Turbo never tries to re-run it
       # on a soft visit — which means it needs no CSP nonce and, crucially, the
-      # widget can re-read the *current* page's config on every `turbo:load`
-      # instead of being stuck with whatever the last full load evaluated.
+      # widget can re-read the *current* page's config after every Turbo render
+      # instead of being stuck with whatever the last full load evaluated. A
+      # page without the block is a page the tool is off for, and the widget
+      # switches itself off there.
       #
       # The code is a same-origin `src` script served by the engine — NOT
       # inlined. Under a nonce-based CSP, Turbo Drive body swaps re-run body

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: i18n_proofreading
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Yaroslav Shmarov