i18n_feedback 0.8.1 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7961f050a8f18c3136f8bac4be58014c6d137b408539d9bbb589e3756c024674
-  data.tar.gz: eb772bb6ca0dbd76d2638f6d5de2fb455a3c1ac737b640856fff79677f50f873
+  metadata.gz: 46eee60f6c5765728de028eb4cc020adf87c05fbfa1250a2b3bb9eccc5d66ad2
+  data.tar.gz: d7732101bdf49c68868f4f3580309ac0cb9e040024bdbd33e4c9598cb7a1dd0a
 SHA512:
-  metadata.gz: a586da5d40cda89a58312e02bdeaaa27af64bc9c7013fca26cbd94bf7dd01da8109dfb2ce7417bf07fae3525837740d85441a6e47e3c65cebcb85dfe4125c53f
-  data.tar.gz: 1978b54ebb78dadfbc90d09e97d4a8e656c2f77d34d134301e0844efbcf3848c13d95f8b2ea5311ef8f872f21439852c6c67564c981b3b42d08f2eee085376bc
+  metadata.gz: 93b6367c3e3b3479333152301dd6ab44e39d2fe734b10374fef7193d32652d18d1a13042820fa484d0e187061a6f0bda4a15ce3830f97ed409eeea25dfc02137
+  data.tar.gz: 9eb009039394424338293e77e1b5d684e75528508a5889856b710935ea34029300347218563a033025783fe46ffc100f5dd4e86cf5a62c3f788858474ad14a90

data/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 ## [Unreleased]
 
+## [0.8.2]
+
+- Fix the dashboard's locale filter doing nothing under a strict (nonce-based)
+  Content-Security-Policy: it relied on an inline `onchange` handler, which such
+  a CSP blocks. The filter now has an always-visible **Filter** submit button, so
+  it works with JS off or inline handlers blocked (the `onchange` stays as a
+  nicety where allowed).
+- Give the locale filter a visible **Locale** label.
+
 ## [0.8.1]
 
 - Make the dashboard **read-only**. Apply / Reject / Reopen / Delete only ever

data/app/views/i18n_feedback/suggestions/index.html.erb

@@ -16,14 +16,16 @@
 <% if @locales.many? %>
   <form class="filters" method="get">
     <input type="hidden" name="status" value="<%= @status %>">
-    <select name="locale" onchange="this.form.requestSubmit()"
-            aria-label="<%= t('i18n_feedback.dashboard.filter', default: 'Filter by locale') %>">
+    <label for="i18nf-locale"><%= t('i18n_feedback.dashboard.locale', default: 'Locale') %></label>
+    <select id="i18nf-locale" name="locale" onchange="this.form.submit()">
       <option value=""><%= t('i18n_feedback.dashboard.all_locales', default: 'All locales') %></option>
       <% @locales.each do |locale| %>
         <option value="<%= locale %>" <%= 'selected' if locale == @locale %>><%= locale %></option>
       <% end %>
     </select>
-    <noscript><button><%= t('i18n_feedback.dashboard.filter', default: 'Filter') %></button></noscript>
+    <%# Inline onchange auto-submits where allowed; this button is the reliable
+        path where a strict CSP blocks inline handlers, or with JS off. %>
+    <button><%= t('i18n_feedback.dashboard.filter', default: 'Filter') %></button>
   </form>
 <% end %>
 

data/app/views/layouts/i18n_feedback/application.html.erb

@@ -43,6 +43,7 @@
       }
 
       .filters { margin-bottom: 16px; display: flex; gap: 8px; align-items: center; }
+      .filters label { color: var(--muted); font-size: 13px; }
       .filters select {
         padding: 6px 8px; border: 1px solid var(--border); border-radius: 8px;
         background: var(--surface); color: var(--text); font: inherit;

data/config/locales/i18n_feedback.en.yml

@@ -24,7 +24,8 @@ en:
     dashboard:
       title: "Translation suggestions"
       subtitle: "Review what reviewers proposed, then apply it to your locale files."
-      filter: "Filter by locale"
+      locale: "Locale"
+      filter: "Filter"
       all_locales: "All locales"
       current: "Current"
       suggested: "Suggested"

data/lib/i18n_feedback/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module I18nFeedback
-  VERSION = '0.8.1'
+  VERSION = '0.8.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: i18n_feedback
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.2
 platform: ruby
 authors:
 - Yaroslav Shmarov