i18n_feedback 0.8.0 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 675e56ff8164412361ecd15886a56ef5eb7a97fdda9a766246b0d690c602d2e1
-  data.tar.gz: 36c511550f1b042de8052e995afeab43c27645410d0dea5246a4ffde9e9d598f
+  metadata.gz: 46eee60f6c5765728de028eb4cc020adf87c05fbfa1250a2b3bb9eccc5d66ad2
+  data.tar.gz: d7732101bdf49c68868f4f3580309ac0cb9e040024bdbd33e4c9598cb7a1dd0a
 SHA512:
-  metadata.gz: fc37ff253e157cc2c2b619e8007bdbe698a1669a96c19c5243b5e326db8185344ee1fa49bdaf40f355240fb6322d90d84bc2e7944bef84b19c77bc381bdcf859
-  data.tar.gz: f9136776bb4abeb8bb1a6271e8f924178486fad4ab3923eed3e9826110daa56501ca8773962ffc8caee9b340c9b294c6747b500c38b989ed6e412ada137d6237
+  metadata.gz: 93b6367c3e3b3479333152301dd6ab44e39d2fe734b10374fef7193d32652d18d1a13042820fa484d0e187061a6f0bda4a15ce3830f97ed409eeea25dfc02137
+  data.tar.gz: 9eb009039394424338293e77e1b5d684e75528508a5889856b710935ea34029300347218563a033025783fe46ffc100f5dd4e86cf5a62c3f788858474ad14a90

data/CHANGELOG.md

@@ -2,6 +2,25 @@
 
 ## [Unreleased]
 
+## [0.8.2]
+
+- Fix the dashboard's locale filter doing nothing under a strict (nonce-based)
+  Content-Security-Policy: it relied on an inline `onchange` handler, which such
+  a CSP blocks. The filter now has an always-visible **Filter** submit button, so
+  it works with JS off or inline handlers blocked (the `onchange` stays as a
+  nicety where allowed).
+- Give the locale filter a visible **Locale** label.
+
+## [0.8.1]
+
+- Make the dashboard **read-only**. Apply / Reject / Reopen / Delete only ever
+  flipped the stored `status` — they never touched the host's locale files, so
+  offering them implied a capability the gem doesn't have. The buttons and their
+  `update` / `destroy` routes and actions are removed; the dashboard now just
+  lists suggestions for review, and you make the edits in your own locale files.
+  A suggestion's `status` still exists on the model for out-of-band tracking and
+  as groundwork for a future "apply to locale file" feature.
+
 ## [0.8.0]
 
 - Add a built-in **triage dashboard**, mounted at the engine root (your

data/README.md

@@ -237,13 +237,19 @@ blue accent stays the same in both.
 
 ## Reviewing suggestions
 
-### Triage dashboard
+### Review dashboard
 
 Mounted at your `mount_path` (default `/i18n_feedback`), the engine root is a
-built-in triage dashboard: pending / applied / rejected tabs with counts, a
-per-locale filter, each suggestion shown as current-vs-proposed, and one-click
-**Apply** / **Reject** / **Reopen** / **Delete**. It's plain server-rendered
-HTML with its own styling — no host assets or JS framework needed.
+built-in **read-only** review board: pending / applied / rejected tabs with
+counts, a per-locale filter, and each suggestion shown as current-vs-proposed
+with its comment and author. It's plain server-rendered HTML with its own
+styling — no host assets or JS framework needed.
+
+It is deliberately read-only. The gem never writes to your locale files, so it
+doesn't pretend to: you review the suggestions here, then make the edits in your
+own `config/locales/*.yml`. (A suggestion's `status` still exists on the model
+for your own tracking — set it from the console — and is the groundwork for a
+future "apply to locale file" feature.)
 
 It has its own gate, `config.authorize_admin`, **defaulting to development
 only** — so a fresh install never exposes it in production. Point it at your own

data/app/controllers/i18n_feedback/suggestions_controller.rb

@@ -4,10 +4,9 @@ module I18nFeedback
   class SuggestionsController < ApplicationController
     PER_PAGE = 50
 
-    # Public widget API is available-gated; the triage dashboard is admin-gated.
+    # Public widget API is available-gated; the read-only dashboard is admin-gated.
     before_action :require_available, only: %i[context create]
-    before_action :require_admin, only: %i[index update destroy]
-    before_action :set_suggestion, only: %i[update destroy]
+    before_action :require_admin, only: :index
 
     layout 'i18n_feedback/application', only: :index
 
@@ -40,19 +39,6 @@ module I18nFeedback
       @suggestions = rows.first(PER_PAGE)
     end
 
-    def update
-      # status arrives from a dashboard button; ignore anything not a real state
-      # (an AR enum would otherwise raise on an unknown value).
-      status = params[:status].to_s
-      @suggestion.update!(status: status) if Suggestion::STATUSES.include?(status)
-      redirect_back fallback_location: root_path, status: :see_other
-    end
-
-    def destroy
-      @suggestion.destroy!
-      redirect_back fallback_location: root_path, status: :see_other
-    end
-
     # --- widget API (public) -------------------------------------------------
 
     # Pending suggestions for one key/locale, shown as read-only context when the
@@ -81,10 +67,6 @@ module I18nFeedback
 
     private
 
-    def set_suggestion
-      @suggestion = Suggestion.find(params[:id])
-    end
-
     def attribute_author(suggestion)
       author = current_author
       return unless author

data/app/views/i18n_feedback/suggestions/index.html.erb

@@ -16,14 +16,16 @@
 <% if @locales.many? %>
   <form class="filters" method="get">
     <input type="hidden" name="status" value="<%= @status %>">
-    <select name="locale" onchange="this.form.requestSubmit()"
-            aria-label="<%= t('i18n_feedback.dashboard.filter', default: 'Filter by locale') %>">
+    <label for="i18nf-locale"><%= t('i18n_feedback.dashboard.locale', default: 'Locale') %></label>
+    <select id="i18nf-locale" name="locale" onchange="this.form.submit()">
       <option value=""><%= t('i18n_feedback.dashboard.all_locales', default: 'All locales') %></option>
       <% @locales.each do |locale| %>
         <option value="<%= locale %>" <%= 'selected' if locale == @locale %>><%= locale %></option>
       <% end %>
     </select>
-    <noscript><button><%= t('i18n_feedback.dashboard.filter', default: 'Filter') %></button></noscript>
+    <%# Inline onchange auto-submits where allowed; this button is the reliable
+        path where a strict CSP blocks inline handlers, or with JS off. %>
+    <button><%= t('i18n_feedback.dashboard.filter', default: 'Filter') %></button>
   </form>
 <% end %>
 
@@ -53,24 +55,6 @@
       <% if suggestion.comment.present? %>
         <div class="comment" dir="auto"><%= suggestion.comment %></div>
       <% end %>
-
-      <div class="actions">
-        <% unless suggestion.status_applied? %>
-          <%= button_to t('i18n_feedback.dashboard.apply', default: 'Apply'),
-                        suggestion_path(suggestion, status: 'applied'), method: :patch, class: 'primary' %>
-        <% end %>
-        <% unless suggestion.status_rejected? %>
-          <%= button_to t('i18n_feedback.dashboard.reject', default: 'Reject'),
-                        suggestion_path(suggestion, status: 'rejected'), method: :patch %>
-        <% end %>
-        <% unless suggestion.status_pending? %>
-          <%= button_to t('i18n_feedback.dashboard.reopen', default: 'Reopen'),
-                        suggestion_path(suggestion, status: 'pending'), method: :patch %>
-        <% end %>
-        <%= button_to t('i18n_feedback.dashboard.delete', default: 'Delete'),
-                      suggestion_path(suggestion), method: :delete, class: 'danger',
-                      form: { data: { turbo_confirm: t('i18n_feedback.dashboard.delete_confirm', default: 'Delete this suggestion?') } } %>
-      </div>
     </article>
   <% end %>
 

data/app/views/layouts/i18n_feedback/application.html.erb

@@ -43,6 +43,7 @@
       }
 
       .filters { margin-bottom: 16px; display: flex; gap: 8px; align-items: center; }
+      .filters label { color: var(--muted); font-size: 13px; }
       .filters select {
         padding: 6px 8px; border: 1px solid var(--border); border-radius: 8px;
         background: var(--surface); color: var(--text); font: inherit;
@@ -75,15 +76,11 @@
       dd .new { font-weight: 600; }
       .comment { margin-top: 10px; padding: 8px 10px; background: var(--code); border-radius: 8px; font-size: 14px; overflow-wrap: anywhere; }
 
-      .actions { display: flex; gap: 8px; flex-wrap: wrap; margin-top: 14px; }
-      .actions form { display: inline; margin: 0; }
       button {
         padding: 7px 13px; border: 1px solid var(--border); border-radius: 8px; cursor: pointer;
         background: var(--surface); color: var(--text); font: inherit; font-size: 14px; font-weight: 600;
       }
       button:hover { border-color: var(--muted); }
-      button.primary { background: var(--accent); border-color: var(--accent); color: var(--accent-text); }
-      button.danger { color: var(--rejected); border-color: transparent; }
       :focus-visible { outline: 2px solid var(--accent); outline-offset: 2px; }
 
       .empty { padding: 48px 16px; text-align: center; color: var(--muted); border: 1px dashed var(--border); border-radius: 12px; }

data/config/locales/i18n_feedback.en.yml

@@ -24,16 +24,12 @@ en:
     dashboard:
       title: "Translation suggestions"
       subtitle: "Review what reviewers proposed, then apply it to your locale files."
-      filter: "Filter by locale"
+      locale: "Locale"
+      filter: "Filter"
       all_locales: "All locales"
       current: "Current"
       suggested: "Suggested"
       ago: "ago"
-      apply: "Apply"
-      reject: "Reject"
-      reopen: "Reopen"
-      delete: "Delete"
-      delete_confirm: "Delete this suggestion?"
       empty: "Nothing here yet."
       newer: "← Newer"
       older: "Older →"

data/config/routes.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
 
 I18nFeedback::Engine.routes.draw do
-  # index/update/destroy are the admin triage dashboard; create + the `context`
-  # collection route are the widget's public API (see SuggestionsController).
-  resources :suggestions, only: %i[index create update destroy] do
+  # index is the read-only admin dashboard; create + the `context` collection
+  # route are the widget's public API (see SuggestionsController). There is
+  # deliberately no update/destroy — the tool never mutates suggestions from the
+  # UI, since it can't write to the host's locale files.
+  resources :suggestions, only: %i[index create] do
     get :context, on: :collection
   end
 

data/lib/i18n_feedback/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module I18nFeedback
-  VERSION = '0.8.0'
+  VERSION = '0.8.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: i18n_feedback
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.2
 platform: ruby
 authors:
 - Yaroslav Shmarov