i18n_checker 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ef286c1f99f8169740f4bae2e43bf3aa95b93eca
-  data.tar.gz: 9149ed553dc95e8337b54e011d8380890d457f9f
+  metadata.gz: e08756c40c9973e96273b947878ea07a69a3b21a
+  data.tar.gz: d417195a6885d7fb64148d352f938300d1f6ece9
 SHA512:
-  metadata.gz: 05b957fb37202dda939b7e4ff3da6b9b64a9e434f32f6f23f7534b4cf5a4300ccb164250dcd081db31ae4b2f6d49ec9f04b52c5821b6916a9140fe3355338157
-  data.tar.gz: d78ffb732b787bd20df54b3f5a63dc95db99ddbf054f25eac979802f98ea69efecb4ca631d7329bc93b672b1eb56986206f78cece6e382050f6f1a4f31b87e10
+  metadata.gz: 89c3096213692740b547721a0786fa83451c0ee4413ceb74de005d0a5e52fc20f20cda19f2fa5273d99326e49a7e01072443f93ef7b7314472d6162d0d43e197
+  data.tar.gz: 01f3a8b758ae009f4aae289c47e524ffdbed18cdb768733af8bff92c0c94620e6a2f1b0616590b5f5d316d88c2261507f9035fa4f05b89a1834092b910394e76

data/.rubocop.yml

@@ -0,0 +1,16 @@
+inherit_gem:
+  onkcop:
+    - "config/rubocop.yml"
+    # uncomment if use rails cops
+    # - "config/rails.yml"
+    # uncomment if use rspec cops
+    # - "config/rspec.yml"
+
+AllCops:
+  TargetRubyVersion: 2.4
+
+Style/PreferredHashMethods:
+  EnforcedStyle: short
+
+Style/StringLiterals:
+  EnforcedStyle: single_quotes

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    i18n_checker (0.4.1)
+    i18n_checker (0.4.2)
       colorator (~> 1.1.0)
       haml_parser (~> 0.4)
       parser
@@ -23,8 +23,13 @@ GEM
     haml_parser (0.4.1)
     hirb (0.7.3)
     json (2.0.3)
+    onkcop (0.47.1.2)
+      rubocop (~> 0.47.1)
+      rubocop-rspec (>= 1.12.0)
     parser (2.4.0.0)
       ast (~> 2.2)
+    powerpack (0.1.1)
+    rainbow (2.2.1)
     rake (10.5.0)
     rspec (3.5.0)
       rspec-core (~> 3.5.0)
@@ -39,6 +44,15 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.5.0)
     rspec-support (3.5.0)
+    rubocop (0.47.1)
+      parser (>= 2.3.3.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    rubocop-rspec (1.13.0)
+      rubocop (>= 0.42.0)
+    ruby-progressbar (1.8.1)
     simplecov (0.12.0)
       docile (~> 1.1.0)
       json (>= 1.8, < 3)
@@ -52,6 +66,7 @@ GEM
       tins (~> 1.0)
     thor (0.19.4)
     tins (1.13.2)
+    unicode-display_width (1.1.3)
 
 PLATFORMS
   ruby
@@ -60,6 +75,7 @@ DEPENDENCIES
   bundler (~> 1.14)
   coveralls
   i18n_checker!
+  onkcop
   rake (~> 10.0)
   rspec
   simplecov

data/i18n-checker.gemspec

@@ -4,13 +4,14 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'i18n_checker/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "i18n_checker"
+  spec.name          = 'i18n_checker'
   spec.version       = I18nChecker::VERSION
-  spec.authors       = ["holyshared"]
-  spec.email         = ["holy.shared.design@gmail.com"]
-  spec.summary       = "Verification of translation of Ruby source and Haml template"
-  spec.description   = "Verification of translation of Ruby source and Haml template"
-  spec.homepage      = "https://github.com/holyshared/i18n-checker"
+  spec.licenses      = ['MIT']
+  spec.authors       = ['holyshared']
+  spec.email         = ['holy.shared.design@gmail.com']
+  spec.summary       = 'Verification of translation of Ruby source and Haml template'
+  spec.description   = 'Verification of translation of Ruby source and Haml template'
+  spec.homepage      = 'https://github.com/holyshared/i18n-checker'
 
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
@@ -21,10 +22,11 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'haml_parser', '~> 0.4'
   spec.add_dependency 'colorator', '~> 1.1.0'
   spec.add_dependency 'parser'
-  spec.add_development_dependency 'bundler','~> 1.14'
+  spec.add_development_dependency 'bundler', '~> 1.14'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'simplecov'
   spec.add_development_dependency 'simplecov-console'
   spec.add_development_dependency 'coveralls'
+  spec.add_development_dependency 'onkcop'
 end

data/lib/i18n_checker/cache.rb

@@ -17,7 +17,7 @@ module I18nChecker
 
       def read(file)
         return files[file] if files.key?(file)
-        files[file] = I18nChecker::Cache::File::of(file)
+        files[file] = I18nChecker::Cache::File.of(file)
         files[file]
       end
     end
@@ -27,7 +27,7 @@ module I18nChecker
 
       class << self
         def of(file)
-          new(file, Lines::of(::File.read(file)))
+          new(file, Lines.of(::File.read(file)))
         end
       end
 
@@ -72,8 +72,8 @@ module I18nChecker
       end
 
       def [](scope)
-        return lines_of(scope) if scope.kind_of?(Range)
-        return line_of(scope) if scope.kind_of?(Integer)
+        return lines_of(scope) if scope.is_a?(Range)
+        return line_of(scope) if scope.is_a?(Integer)
       end
 
       def line_of(line_number)

data/lib/i18n_checker/detector/locale_text_not_found.rb

@@ -12,16 +12,16 @@ module I18nChecker
 
       private
 
-      def detect_not_found(locale_text)
-        locale_files = @locale_files.dup
-        locale_files.delete_if { |locale_file| locale_file.include?(locale_text) }
-        locale_files.map do |locale_file|
-          TextResult.new(
-            locale_text: locale_text,
-            locale_file: locale_file
-          )
+        def detect_not_found(locale_text)
+          locale_files = @locale_files.dup
+          locale_files.delete_if { |locale_file| locale_file.include?(locale_text) }
+          locale_files.map do |locale_file|
+            TextResult.new(
+              locale_text: locale_text,
+              locale_file: locale_file
+            )
+          end
         end
-      end
     end
   end
 end

data/lib/i18n_checker/detector/text_result.rb

@@ -15,7 +15,7 @@ module I18nChecker
 
       private
 
-      attr_reader :locale_file, :locale_text
+        attr_reader :locale_file, :locale_text
     end
   end
 end

data/lib/i18n_checker/locale/collector/haml.rb

@@ -23,39 +23,39 @@ module I18nChecker
 
         private
 
-        def read_template_file(template_file)
-          file_caches.read(template_file).to_s
-        end
-
-        def collect_locale_texts(ast)
-          locale_texts = []
-          locale_texts << collect_locale_text(ast)
-          return unless ast.respond_to?(:children)
-          locale_texts << ast.children.map { |child| collect_locale_texts(child) }
-          locale_texts.flatten.compact
-        end
-
-        def collect_locale_text(ast)
-          return locale_text_from_script(ast) if ast.kind_of?(HamlParser::Ast::Script)
-          return unless ast.respond_to?(:oneline_child)
-          return unless ast.oneline_child.kind_of?(HamlParser::Ast::Script)
-          locale_text_from_script(ast.oneline_child)
-        end
-
-        def locale_text_from_script(script_node)
-          return unless translate_script = script_node.script.match(/^t\(\'+(.+)\'+\)$/)
-
-          locale_text = translate_script[1]
-          file_cache = file_caches.read(script_node.filename)
-          column = file_cache[script_node.lineno].start_of(locale_text)
-
-          I18nChecker::Locale::Text.new(
-            file: script_node.filename,
-            line: script_node.lineno,
-            column: column,
-            text: locale_text
-          )
-        end
+          def read_template_file(template_file)
+            file_caches.read(template_file).to_s
+          end
+
+          def collect_locale_texts(ast)
+            locale_texts = []
+            locale_texts << collect_locale_text(ast)
+            return unless ast.respond_to?(:children)
+            locale_texts << ast.children.map { |child| collect_locale_texts(child) }
+            locale_texts.flatten.compact
+          end
+
+          def collect_locale_text(ast)
+            return locale_text_from_script(ast) if ast.is_a?(HamlParser::Ast::Script)
+            return unless ast.respond_to?(:oneline_child)
+            return unless ast.oneline_child.is_a?(HamlParser::Ast::Script)
+            locale_text_from_script(ast.oneline_child)
+          end
+
+          def locale_text_from_script(script_node)
+            return unless translate_script = script_node.script.match(/^t\(\'+(.+)\'+\)$/)
+
+            locale_text = translate_script[1]
+            file_cache = file_caches.read(script_node.filename)
+            column = file_cache[script_node.lineno].start_of(locale_text)
+
+            I18nChecker::Locale::Text.new(
+              file: script_node.filename,
+              line: script_node.lineno,
+              column: column,
+              text: locale_text
+            )
+          end
       end
     end
   end

data/lib/i18n_checker/locale/collector/ruby.rb

@@ -22,23 +22,23 @@ module I18nChecker
 
         private
 
-        def buffer_of(source_file)
-          source = file_caches.read(source_file).to_s
-          source_buffer = Parser::Source::Buffer.new('(string)')
-          source_buffer.source = source
-          source_buffer
-        end
-
-        def parse_source(source_file)
-          parser = Parser::CurrentRuby.new
-          parser.parse(buffer_of(source_file))
-        end
-
-        def process(source_file)
-          processor = I18nChecker::Locale::TextProcessor.new(file: source_file)
-          processor.process(parse_source(source_file))
-          processor.locale_texts
-        end
+          def buffer_of(source_file)
+            source = file_caches.read(source_file).to_s
+            source_buffer = Parser::Source::Buffer.new('(string)')
+            source_buffer.source = source
+            source_buffer
+          end
+
+          def parse_source(source_file)
+            parser = Parser::CurrentRuby.new
+            parser.parse(buffer_of(source_file))
+          end
+
+          def process(source_file)
+            processor = I18nChecker::Locale::TextProcessor.new(file: source_file)
+            processor.process(parse_source(source_file))
+            processor.locale_texts
+          end
       end
     end
   end

data/lib/i18n_checker/locale/file.rb

@@ -9,6 +9,7 @@ module I18nChecker
         def load_yaml(s)
           new(YAML.load(s))
         end
+
         def load_yaml_file(yaml_file)
           load_yaml(::File.open(yaml_file, &:read))
         end
@@ -26,19 +27,19 @@ module I18nChecker
 
       private
 
-      def compact_of(values={}, path=KeyPath.new)
-        result = {}
-        values.each_with_index do |(i, v)|
-          path.move_to(i)
-          if v.is_a?(Hash)
-            result.merge!(compact_of(v, path))
-          else
-            result[path.to_s] = v
+        def compact_of(values = {}, path = KeyPath.new)
+          result = {}
+          values.each_with_index do |(i, v)|
+            path.move_to(i)
+            if v.is_a?(Hash)
+              result.merge!(compact_of(v, path))
+            else
+              result[path.to_s] = v
+            end
+            path.leave
           end
-          path.leave
+          result
         end
-        result
-      end
     end
   end
 end

data/lib/i18n_checker/locale/files.rb

@@ -20,7 +20,7 @@ module I18nChecker
 
       private
 
-      attr_reader :locale_files
+        attr_reader :locale_files
     end
   end
 end

data/lib/i18n_checker/locale/texts.rb

@@ -34,8 +34,7 @@ module I18nChecker
 
       private
 
-      attr_reader :texts
+        attr_reader :texts
     end
   end
 end
-

data/lib/i18n_checker/locale.rb

@@ -1,7 +1,7 @@
-require "i18n_checker/locale/key_path"
-require "i18n_checker/locale/file"
-require "i18n_checker/locale/files"
-require "i18n_checker/locale/collector"
+require 'i18n_checker/locale/key_path'
+require 'i18n_checker/locale/file'
+require 'i18n_checker/locale/files'
+require 'i18n_checker/locale/collector'
 
 module I18nChecker
   module Locale

data/lib/i18n_checker/locale_text_not_found_checker.rb

@@ -1,6 +1,6 @@
-require "i18n_checker/detector/locale_text_not_found"
-require "i18n_checker/detector/text_result"
-require "i18n_checker/detector/detected_result"
+require 'i18n_checker/detector/locale_text_not_found'
+require 'i18n_checker/detector/text_result'
+require 'i18n_checker/detector/detected_result'
 
 module I18nChecker
   class LocaleTextNotFoundChecker
@@ -12,7 +12,7 @@ module I18nChecker
 
     def check
       not_found_detector = I18nChecker::Detector::LocaleTextNotFound.new(@locale_files)
-      not_found_result = @locale_texts.detect(not_found_detector) 
+      not_found_result = @locale_texts.detect(not_found_detector)
       @reporter.report not_found_result
       yield not_found_result if block_given?
     end

data/lib/i18n_checker/rake_task.rb

@@ -3,7 +3,7 @@ require 'rake/tasklib'
 require 'i18n_checker/cache'
 require 'i18n_checker/locale'
 require 'i18n_checker/reporter'
-require "i18n_checker/locale_text_not_found_checker"
+require 'i18n_checker/locale_text_not_found_checker'
 
 module I18nChecker
   class RakeTask < ::Rake::TaskLib
@@ -18,7 +18,7 @@ module I18nChecker
       @source_paths = FileList['app/views/*', 'app/controllers/*', 'app/jobs/*', 'app/models/*', 'app/helpers/*']
       @locale_file_paths = FileList['config/locales/*']
       @logger = Logger.new(STDOUT)
-      @logger.formatter = proc {|severity, datetime, progname, message|
+      @logger.formatter = proc { |_severity, _datetime, _progname, message|
         "#{message}\n"
       }
       @reporter = I18nChecker::Reporter::DefaultReporter.new(logger: logger)
@@ -28,20 +28,20 @@ module I18nChecker
 
     private
 
-    def define
-      desc 'Check language files and templates.'
-      task(name) { run_task }
-    end
+      def define
+        desc 'Check language files and templates.'
+        task(name) { run_task }
+      end
 
-    def run_task
-      checker = I18nChecker::LocaleTextNotFoundChecker.new(
-        reporter: reporter,
-        source_paths: source_paths,
-        locale_file_paths: locale_file_paths
-      )
-      checker.check do |result|
-        exit 1 unless result.empty?
+      def run_task
+        checker = I18nChecker::LocaleTextNotFoundChecker.new(
+          reporter: reporter,
+          source_paths: source_paths,
+          locale_file_paths: locale_file_paths
+        )
+        checker.check do |result|
+          exit 1 unless result.empty?
+        end
       end
-    end
   end
 end

data/lib/i18n_checker/reporter/default_reporter.rb

@@ -3,7 +3,7 @@ require 'colorator'
 module I18nChecker
   module Reporter
     class DefaultReporter < DetectResultReporter
-      CHECK_COMPLETED = 'Translation text checking is complete.'
+      CHECK_COMPLETED = 'Translation text checking is complete.'.freeze
 
       def report(result)
         return passed if result.empty?
@@ -19,7 +19,7 @@ module I18nChecker
         logger.info CHECK_COMPLETED.red
         logger.info "There are settings where translated text can not be found\n".red
         result.locale_texts.each do |locale_text|
-          logger.info "#{locale_text.file.cyan}"
+          logger.info locale_text.file.cyan.to_s
           logger.info "  line:#{locale_text.line}, column:#{locale_text.column} - #{locale_text.lang}.#{locale_text.text}"
         end
       end

data/lib/i18n_checker/reporter/detect_result_reporter.rb

@@ -9,7 +9,7 @@ module I18nChecker
 
       private
 
-      attr_reader :logger
+        attr_reader :logger
     end
   end
 end

data/lib/i18n_checker/reporter.rb

@@ -1,5 +1,5 @@
-require "i18n_checker/reporter/detect_result_reporter"
-require "i18n_checker/reporter/default_reporter"
+require 'i18n_checker/reporter/detect_result_reporter'
+require 'i18n_checker/reporter/default_reporter'
 
 module I18nChecker
   module Reporter

data/lib/i18n_checker/version.rb

@@ -1,3 +1,3 @@
 module I18nChecker
-  VERSION = "0.4.1"
+  VERSION = '0.4.2'.freeze
 end

data/lib/i18n_checker.rb

@@ -1,22 +1,22 @@
-require "i18n_checker/version"
-require "i18n_checker/rake_task"
-require "i18n_checker/collectible"
-require "i18n_checker/cache"
-require "i18n_checker/locale"
-require "i18n_checker/locale/text_processor"
-require "i18n_checker/locale/collector/haml"
-require "i18n_checker/locale/collector/ruby"
-require "i18n_checker/locale/text"
-require "i18n_checker/locale/texts"
-require "i18n_checker/locale/key_path"
-require "i18n_checker/locale/file"
-require "i18n_checker/locale/files"
-require "i18n_checker/detector/locale_text_not_found"
-require "i18n_checker/detector/text_result"
-require "i18n_checker/detector/detected_result"
-require "i18n_checker/reporter/detect_result_reporter"
-require "i18n_checker/reporter/default_reporter"
-require "i18n_checker/locale_text_not_found_checker"
+require 'i18n_checker/version'
+require 'i18n_checker/rake_task'
+require 'i18n_checker/collectible'
+require 'i18n_checker/cache'
+require 'i18n_checker/locale'
+require 'i18n_checker/locale/text_processor'
+require 'i18n_checker/locale/collector/haml'
+require 'i18n_checker/locale/collector/ruby'
+require 'i18n_checker/locale/text'
+require 'i18n_checker/locale/texts'
+require 'i18n_checker/locale/key_path'
+require 'i18n_checker/locale/file'
+require 'i18n_checker/locale/files'
+require 'i18n_checker/detector/locale_text_not_found'
+require 'i18n_checker/detector/text_result'
+require 'i18n_checker/detector/detected_result'
+require 'i18n_checker/reporter/detect_result_reporter'
+require 'i18n_checker/reporter/default_reporter'
+require 'i18n_checker/locale_text_not_found_checker'
 
 module I18nChecker
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: i18n_checker
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - holyshared
@@ -136,6 +136,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: onkcop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Verification of translation of Ruby source and Haml template
 email:
 - holy.shared.design@gmail.com
@@ -147,6 +161,7 @@ files:
 - ".editorconfig"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - Gemfile.lock
@@ -178,7 +193,8 @@ files:
 - lib/i18n_checker/version.rb
 - screenshot.png
 homepage: https://github.com/holyshared/i18n-checker
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []