hyrax 3.4.1 → 3.4.2

data/app/controllers/hyrax/dashboard/collections_controller.rb

@@ -84,26 +84,13 @@ module Hyrax
       end
 
       def after_create
-        if @collection.is_a?(ActiveFedora::Base)
-          form
-          set_default_permissions
-          # if we are creating the new collection as a subcollection (via the nested collections controller),
-          # we pass the parent_id through a hidden field in the form and link the two after the create.
-          link_parent_collection(params[:parent_id]) unless params[:parent_id].nil?
-        end
-        respond_to do |format|
-          Hyrax::SolrService.commit
-          format.html { redirect_to edit_dashboard_collection_path(@collection), notice: t('hyrax.dashboard.my.action.collection_create_success') }
-          format.json { render json: @collection, status: :created, location: dashboard_collection_path(@collection) }
-        end
+        Deprecation.warn("Method `#after_create` will be removed in Hyrax 4.0.")
+        after_create_response # call private method for processing
       end
 
       def after_create_error
-        form
-        respond_to do |format|
-          format.html { render action: 'new' }
-          format.json { render json: @collection.errors, status: :unprocessable_entity }
-        end
+        Deprecation.warn("Method `#after_create_error` will be removed in Hyrax 4.0.")
+        after_create_errors("") # call private method for processing
       end
 
       def create
@@ -112,57 +99,39 @@ module Hyrax
         # collection is saved without a value for `has_model.`
         @collection = Hyrax.config.collection_class.new
         authorize! :create, @collection
-        return valkyrie_create if @collection.is_a?(Valkyrie::Resource)
 
-        # Coming from the UI, a collection type gid should always be present.  Coming from the API, if a collection type gid is not specified,
-        # use the default collection type (provides backward compatibility with versions < Hyrax 2.1.0)
-        @collection.collection_type_gid = params[:collection_type_gid].presence || default_collection_type.to_global_id
-        @collection.attributes = collection_params.except(:members, :parent_id, :collection_type_gid)
-        @collection.apply_depositor_metadata(current_user.user_key)
-        @collection.visibility = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE unless @collection.discoverable?
-        if @collection.save
-          after_create
-          add_members_to_collection unless batch.empty?
+        case @collection
+        when ActiveFedora::Base
+          create_active_fedora_collection
         else
-          after_create_error
+          create_valkyrie_collection
         end
       end
 
       def after_update
-        respond_to do |format|
-          format.html { redirect_to update_referer, notice: t('hyrax.dashboard.my.action.collection_update_success') }
-          format.json { render json: @collection, status: :updated, location: dashboard_collection_path(@collection) }
-        end
+        Deprecation.warn("Method `#after_update` will be removed in Hyrax 4.0.")
+        after_update_response # call private method for processing
       end
 
       def after_update_error
-        form
-        respond_to do |format|
-          format.html { render action: 'edit' }
-          format.json { render json: @collection.errors, status: :unprocessable_entity }
-        end
+        Deprecation.warn("Method `#after_update_error` will be removed in Hyrax 4.0.")
+        after_update_errors(@collection.errors) # call private method for processing
       end
 
       def update
-        unless params[:update_collection].nil?
-          process_banner_input
-          process_logo_input
-        end
-
-        process_member_changes
-
-        return valkyrie_update if @collection.is_a?(Valkyrie::Resource)
-
-        @collection.visibility = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE unless @collection.discoverable?
-        # we don't have to reindex the full graph when updating collection
-        @collection.reindex_extent = Hyrax::Adapters::NestingIndexAdapter::LIMITED_REINDEX
-        if @collection.update(collection_params.except(:members))
-          after_update
+        case @collection
+        when ActiveFedora::Base
+          update_active_fedora_collection
         else
-          after_update_error
+          update_valkyrie_collection
         end
       end
 
+      def process_branding
+        process_banner_input
+        process_logo_input
+      end
+
       def after_destroy(_id)
         # leaving id to avoid changing the method's parameters prior to release
         respond_to do |format|
@@ -215,28 +184,66 @@ module Hyrax
 
       private
 
-      def valkyrie_create
-        form.validate(collection_params) &&
-          @collection = transactions['change_set.create_collection']
-                        .with_step_args(
-                          'change_set.set_user_as_depositor' => { user: current_user },
-                          'change_set.add_to_collections' => { collection_ids: Array(params[:parent_id]) },
-                          'collection_resource.apply_collection_type_permissions' => { user: current_user }
-                        )
-                        .call(form)
-                        .value_or { return after_create_error }
+      def create_active_fedora_collection
+        # Coming from the UI, a collection type gid should always be present.  Coming from the API, if a collection type gid is not specified,
+        # use the default collection type (provides backward compatibility with versions < Hyrax 2.1.0)
+        @collection.collection_type_gid = params[:collection_type_gid].presence || default_collection_type.to_global_id
+        @collection.attributes = collection_params.except(:members, :parent_id, :collection_type_gid)
+        @collection.apply_depositor_metadata(current_user.user_key)
+        @collection.visibility = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE unless @collection.discoverable?
+        if @collection.save
+          after_create_response
+        else
+          after_create_errors(@collection.errors)
+        end
+      end
 
-        after_create
-        add_members_to_collection unless batch.empty?
-        @collection
+      def create_valkyrie_collection
+        return after_create_errors(form_err_msg(form)) unless form.validate(collection_params)
+
+        result =
+          transactions['change_set.create_collection']
+          .with_step_args(
+            'change_set.set_user_as_depositor' => { user: current_user },
+            'change_set.add_to_collections' => { collection_ids: Array(params[:parent_id]) },
+            'collection_resource.apply_collection_type_permissions' => { user: current_user }
+          )
+          .call(form)
+
+        @collection = result.value_or { return after_create_errors(result.failure.first) }
+        after_create_response
       end
 
-      def valkyrie_update
-        form.validate(collection_params) &&
-          @collection = transactions['change_set.update_collection']
-                        .call(form)
-                        .value_or { return after_update_error }
-        after_update
+      def update_active_fedora_collection
+        process_member_changes
+        process_branding
+
+        @collection.visibility = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE unless @collection.discoverable?
+        # we don't have to reindex the full graph when updating collection
+        @collection.reindex_extent = Hyrax::Adapters::NestingIndexAdapter::LIMITED_REINDEX
+        if @collection.update(collection_params.except(:members))
+          after_update_response
+        else
+          after_update_errors(@collection.errors)
+        end
+      end
+
+      def update_valkyrie_collection
+        return after_update_errors(form_err_msg(form)) unless form.validate(collection_params)
+
+        result = transactions['change_set.update_collection']
+                 .with_step_args(
+                          'collection_resource.save_collection_banner' => { update_banner_file_ids: params["banner_files"],
+                                                                            banner_unchanged_indicator: params["banner_unchanged"] },
+                          'collection_resource.save_collection_logo' => { update_logo_file_ids: params["logo_files"],
+                                                                          alttext_values: params["alttext"],
+                                                                          linkurl_values: params["linkurl"] }
+                        )
+                 .call(form)
+        @collection = result.value_or { return after_update_errors(result.failure.first) }
+
+        process_member_changes
+        after_update_response
       end
 
       def valkyrie_destroy
@@ -247,6 +254,14 @@ module Hyrax
         end
       end
 
+      def form_err_msg(form)
+        errmsg = []
+        form.errors.messages.each do |fld, err|
+          errmsg << "#{fld} #{err.to_sentence}"
+        end
+        errmsg.to_sentence
+      end
+
       def default_collection_type
         Hyrax::CollectionType.find_or_create_default_collection_type
       end
@@ -376,9 +391,7 @@ module Hyrax
       end
 
       def presenter
-        @presenter ||= begin
-          presenter_class.new(curation_concern, current_ability)
-        end
+        @presenter ||= presenter_class.new(curation_concern, current_ability)
       end
 
       def curation_concern
@@ -499,7 +512,9 @@ module Hyrax
         @form ||=
           case @collection
           when Valkyrie::Resource
-            Hyrax::Forms::ResourceForm.for(@collection)
+            form = Hyrax::Forms::ResourceForm.for(@collection)
+            form.prepopulate!
+            form
           else
             form_class.new(@collection, current_ability, repository)
           end
@@ -562,6 +577,75 @@ module Hyrax
       def valid_url?(url)
         (url =~ URI.regexp(['http', 'https']))
       end
+
+      def after_create_response
+        if @collection.is_a?(ActiveFedora::Base)
+          form
+          set_default_permissions
+          # if we are creating the new collection as a subcollection (via the nested collections controller),
+          # we pass the parent_id through a hidden field in the form and link the two after the create.
+          link_parent_collection(params[:parent_id]) unless params[:parent_id].nil?
+        end
+        respond_to do |format|
+          Hyrax::SolrService.commit
+          format.html { redirect_to edit_dashboard_collection_path(@collection), notice: t('hyrax.dashboard.my.action.collection_create_success') }
+          format.json { render json: @collection, status: :created, location: dashboard_collection_path(@collection) }
+        end
+        add_members_to_collection unless batch.empty?
+      end
+
+      def after_create_errors_for_active_fedora(errors)
+        form
+        respond_to do |format|
+          format.html do
+            flash[:error] = errors.to_s
+            render action: 'new'
+          end
+          format.json { render json: @collection.errors, status: :unprocessable_entity }
+        end
+      end
+
+      def after_create_errors(errors) # for valkyrie
+        return after_create_errors_for_active_fedora(errors) if @collection.is_a? ActiveFedora::Base
+        respond_to do |wants|
+          wants.html do
+            flash[:error] = errors.to_s
+            render 'new', status: :unprocessable_entity
+          end
+          wants.json do
+            render_json_response(response_type: :unprocessable_entity, options: { errors: errors })
+          end
+        end
+      end
+
+      def after_update_response
+        respond_to do |format|
+          format.html { redirect_to update_referer, notice: t('hyrax.dashboard.my.action.collection_update_success') }
+          format.json { render json: @collection, status: :updated, location: dashboard_collection_path(@collection) }
+        end
+      end
+
+      def after_update_errors_for_active_fedora(errors)
+        form
+        respond_to do |format|
+          format.html do
+            flash[:error] = errors.to_s
+            render action: 'edit'
+          end
+          format.json { render json: @collection.errors, status: :unprocessable_entity }
+        end
+      end
+
+      def after_update_errors(errors) # for valkyrie
+        return after_update_errors_for_active_fedora(errors) if @collection.is_a? ActiveFedora::Base
+        respond_to do |wants|
+          wants.html do
+            flash[:error] = errors.to_s
+            render 'edit', status: :unprocessable_entity
+          end
+          wants.json { render_json_response(response_type: :unprocessable_entity, options: { errors: errors }) }
+        end
+      end
     end
   end
 end

data/app/controllers/hyrax/single_use_links_viewer_controller.rb

@@ -75,7 +75,7 @@ module Hyrax
 
     def render_single_use_error(exception)
       logger.error("Rendering PAGE due to exception: #{exception.inspect} - #{exception.backtrace if exception.respond_to? :backtrace}")
-      render 'single_use_error', layout: "error", status: 404
+      render 'single_use_error', layout: "error", status: :not_found
     end
 
     def _prefixes

data/app/forms/hyrax/forms/collection_form.rb

@@ -9,7 +9,7 @@ module Hyrax
       attr_reader :scope
 
       delegate :id, :depositor, :permissions, :human_readable_type, :member_ids, :nestable?,
-               :alternative_title, to: :model
+               :alternative_title, :visibility, to: :model
 
       class_attribute :membership_service_class
 

data/app/forms/hyrax/forms/pcdm_collection_form.rb

@@ -6,7 +6,32 @@ module Hyrax
     # @api public
     # @see https://github.com/samvera/valkyrie/wiki/ChangeSets-and-Dirty-Tracking
     class PcdmCollectionForm < Valkyrie::ChangeSet # rubocop:disable Metrics/ClassLength
-      property :title, required: true, primary: true
+      include Hyrax::FormFields(:core_metadata)
+
+      BannerInfoPrepopulator = lambda do |_options|
+        self.banner_info ||= begin
+          banner_info = CollectionBrandingInfo.where(collection_id: id.to_s, role: "banner")
+          banner_file = File.split(banner_info.first.local_path).last unless banner_info.empty?
+          alttext = banner_info.first.alt_text unless banner_info.empty?
+          file_location = banner_info.first.local_path unless banner_info.empty?
+          relative_path = "/" + banner_info.first.local_path.split("/")[-4..-1].join("/") unless banner_info.empty?
+          { file: banner_file, full_path: file_location, relative_path: relative_path, alttext: alttext }
+        end
+      end
+
+      LogoInfoPrepopulator = lambda do |_options|
+        self.logo_info ||= begin
+          logos_info = CollectionBrandingInfo.where(collection_id: id.to_s, role: "logo")
+
+          logos_info.map do |logo_info|
+            logo_file = File.split(logo_info.local_path).last
+            relative_path = "/" + logo_info.local_path.split("/")[-4..-1].join("/")
+            alttext = logo_info.alt_text
+            linkurl = logo_info.target_url
+            { file: logo_file, full_path: logo_info.local_path, relative_path: relative_path, alttext: alttext, linkurl: linkurl }
+          end
+        end
+      end
 
       property :human_readable_type, writable: false
       property :date_modified, readable: false
@@ -18,9 +43,11 @@ module Hyrax
 
       property :member_of_collection_ids, default: [], type: Valkyrie::Types::Array
 
-      validates :title, presence: true
       validates :collection_type_gid, presence: true
 
+      property :banner_info, virtual: true, prepopulator: BannerInfoPrepopulator
+      property :logo_info, virtual: true, prepopulator: LogoInfoPrepopulator
+
       class << self
         def model_class
           Hyrax::PcdmCollection

data/app/forms/hyrax/forms/resource_form.rb

@@ -99,7 +99,7 @@ module Hyrax
       property :in_works_ids, virtual: true, prepopulator: InWorksPrepopulator
       property :member_ids, default: [], type: Valkyrie::Types::Array
       property :member_of_collection_ids, default: [], type: Valkyrie::Types::Array
-      property :member_of_collections_attributes, virtual: true
+      property :member_of_collections_attributes, virtual: true, populator: :in_collections_populator
       validates_with CollectionMembershipValidator
 
       property :representative_id, type: Valkyrie::Types::String
@@ -208,6 +208,20 @@ module Hyrax
 
       private
 
+      def in_collections_populator(fragment:, **_options)
+        adds = []
+        deletes = []
+        fragment.each do |_, h|
+          if h["_destroy"] == "true"
+            deletes << Valkyrie::ID.new(h["id"])
+          else
+            adds << Valkyrie::ID.new(h["id"])
+          end
+        end
+
+        self.member_of_collection_ids = ((member_of_collection_ids + adds) - deletes).uniq
+      end
+
       # https://trailblazer.to/2.1/docs/reform.html#reform-populators-populator-collections
       def permission_populator(collection:, index:, **)
         Hyrax::Forms::Permission.new(collection[index])

data/app/forms/hyrax/forms/widgets/admin_set_visibility.rb

@@ -6,7 +6,7 @@ module Hyrax
         # Visibility options for permission templates
         def options
           i18n_prefix = "hyrax.admin.admin_sets.form_visibility.visibility"
-          # Note: Visibility 'varies' = '' implies no constraints
+          # NOTE: Visibility 'varies' = '' implies no constraints
           [[Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC, I18n.t('.everyone', scope: i18n_prefix)],
            ['', I18n.t('.varies', scope: i18n_prefix)],
            [Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED, I18n.t('.institution', scope: i18n_prefix)],

data/app/indexers/hyrax/pcdm_collection_indexer.rb

@@ -9,7 +9,6 @@ module Hyrax
     include Hyrax::VisibilityIndexer
     include Hyrax::ThumbnailIndexer
     include Hyrax::Indexer(:core_metadata)
-    include Hyrax::Indexer(:basic_metadata)
 
     self.thumbnail_path_service = CollectionThumbnailPathService
 

data/app/jobs/characterize_job.rb

@@ -31,7 +31,11 @@ class CharacterizeJob < Hyrax::ApplicationJob
     raise "#{file_set.class.characterization_proxy} was not found for FileSet #{file_set.id}" unless file_set.characterization_proxy?
     filepath = Hyrax::WorkingDirectory.find_or_retrieve(file_id, file_set.id) unless filepath && File.exist?(filepath)
     characterize(file_set, file_id, filepath)
-    CreateDerivativesJob.perform_later(file_set, file_id, filepath)
+
+    Hyrax.publisher.publish('file.characterized',
+                            file_set: file_set,
+                            file_id: file_id,
+                            path_hint: filepath)
   end
 
   private

data/app/jobs/import_url_job.rb

@@ -80,12 +80,10 @@ class ImportUrlJob < Hyrax::ApplicationJob
     Rails.logger.debug("ImportUrlJob: Copying <#{uri}> to #{dir}")
 
     File.open(File.join(dir, filename), 'wb') do |f|
-      begin
-        write_file(f)
-        yield f
-      rescue StandardError => e
-        send_error(e.message)
-      end
+      write_file(f)
+      yield f
+    rescue StandardError => e
+      send_error(e.message)
     end
     Rails.logger.debug("ImportUrlJob: Closing #{File.join(dir, filename)}")
   end

data/app/jobs/valkyrie_ingest_job.rb

@@ -21,104 +21,42 @@ class ValkyrieIngestJob < Hyrax::ApplicationJob
   #
   # @param [Hyrax::UploadedFile] file
   # @param [RDF::URI] pcdm_use
-
   # @return [void]
   def ingest(file:, pcdm_use:)
     file_set_uri = Valkyrie::ID.new(file.file_set_uri)
     file_set = Hyrax.query_service.find_by(id: file_set_uri)
 
-    updated_metadata = upload_file(file: file, file_set: file_set, pcdm_use: pcdm_use)
-
-    add_file_to_file_set(file_set: file_set,
-                         file_metadata: updated_metadata,
-                         user: file.user)
+    updated_metadata = upload_file(
+      file: file,
+      file_set: file_set,
+      pcdm_use: pcdm_use,
+      user: file.user
+    )
 
     ValkyrieCreateDerivativesJob.perform_later(file_set.id.to_s, updated_metadata.id.to_s)
   end
 
-  ##
-  # @api private
-  #
-  # @param [Hyrax::FileSet] file_set the file set to add to
-  # @param [Hyrax::FileMetadata] file_metadata the metadata object representing
-  #   the file to add
-  # @param [::User] user  the user performing the add
-  #
-  # @return [Hyrax::FileSet] updated file set
-  def add_file_to_file_set(file_set:, file_metadata:, user:)
-    file_set.file_ids << file_metadata.id
-    set_file_use_ids(file_set, file_metadata)
-
-    Hyrax.persister.save(resource: file_set)
-    Hyrax.publisher.publish('object.membership.updated', object: file_set, user: user)
-  end
-
   ##
   # @api private
   #
   # @param [Hyrax::UploadedFile] file
   # @param [Hyrax::FileSet] file_set
   # @param [RDF::URI] pcdm_use  the use/type to apply to the created FileMetadata
+  # @param [User] user
   #
   # @return [Hyrax::FileMetadata] the metadata representing the uploaded file
-  def upload_file(file:, file_set:, pcdm_use:) # rubocop:disable Metrics/MethodLength
+  def upload_file(file:, file_set:, pcdm_use:, user: nil)
     carrier_wave_sanitized_file = file.uploader.file
     # Pull file, since carrierwave files don't respond to a proper IO #read. See
     # https://github.com/carrierwaveuploader/carrierwave/issues/1959
     file_io = carrier_wave_sanitized_file.to_file
-    uploaded = Hyrax.storage_adapter
-                    .upload(resource: file_set,
-                            file: file_io,
-                            original_filename: carrier_wave_sanitized_file.original_filename)
-
-    file_metadata = find_or_create_metadata(id: uploaded.id, file: carrier_wave_sanitized_file)
-
-    file_metadata.type << pcdm_use
-    file_metadata.file_set_id = file.file_set_uri
-    file_metadata.file_identifier = uploaded.id
-    file_metadata.size = uploaded.size
 
-    saved_metadata = Hyrax.persister.save(resource: file_metadata)
-    Hyrax.publisher.publish("object.file.uploaded", metadata: saved_metadata)
-    file_io.close
-
-    if pcdm_use == Hyrax::FileMetadata::Use::ORIGINAL_FILE
-      # Set file set label.
-      reset_title = file_set.title.first == file_set.label
-      # set title to label if that's how it was before this characterization
-      file_set.title = file_metadata.original_filename if reset_title
-      # always set the label to the original_name
-      file_set.label = file_metadata.original_filename
-    end
-
-    saved_metadata
-  end
-
-  ##
-  # @api private
-  def find_or_create_metadata(id:, file:)
-    Hyrax.custom_queries.find_file_metadata_by(id: id)
-  rescue Valkyrie::Persistence::ObjectNotFoundError => e
-    Hyrax.logger.warn "Failed to find existing metadata for #{id}:"
-    Hyrax.logger.warn e.message
-    Hyrax.logger.warn "Creating Hyrax::FileMetadata now"
-    Hyrax::FileMetadata.for(file: file)
-  end
-
-  ##
-  # @api private
-  def set_file_use_ids(file_set, file_metadata)
-    file_metadata.type.each do |type|
-      case type
-      when Hyrax::FileMetadata::Use::ORIGINAL_FILE
-        file_set.original_file_id = file_metadata.id
-      when Hyrax::FileMetadata::Use::THUMBNAIL
-        file_set.thumbnail_id = file_metadata.id
-      when Hyrax::FileMetadata::Use::EXTRACTED_TEXT
-        file_set.extracted_text_id = file_metadata.id
-      else
-        Rails.logger.warn "Unknown file use #{file_metadata.type} specified for #{file_metadata.file_identifier}"
-      end
-    end
+    ::Hyrax::ValkyrieUpload.file(
+      io: file_io,
+      filename: carrier_wave_sanitized_file.original_filename,
+      file_set: file_set,
+      use: pcdm_use,
+      user: user
+    )
   end
 end

data/app/models/admin_set.rb

@@ -97,6 +97,14 @@ class AdminSet < ActiveFedora::Base
     permission_template.reset_access_controls_for(collection: self)
   end
 
+  # @api public
+  #
+  # return an id for the AdminSet.
+  # defaults to calling Hyrax::Noid, but needs a fall back if noid is off
+  def assign_id
+    super || SecureRandom.uuid
+  end
+
   private
 
   def destroy_permission_template

data/app/models/concerns/hyrax/collection_behavior.rb

@@ -87,7 +87,7 @@ module Hyrax
 
     module ClassMethods
       # This governs which partial to draw when you render this type of object
-      def _to_partial_path #:nodoc:
+      def _to_partial_path # :nodoc:
         @_to_partial_path ||= begin
           element = ActiveSupport::Inflector.underscore(ActiveSupport::Inflector.demodulize(name))
           collection = ActiveSupport::Inflector.tableize(name)

data/app/models/concerns/hyrax/user.rb

@@ -53,6 +53,13 @@ module Hyrax::User
     public_send(self.class.user_key_field)
   end
 
+  ##
+  # @return [String] a local identifier for this user; for use (e.g.) in ACL
+  #   data
+  def agent_key
+    user_key
+  end
+
   # Look for, in order:
   #   A cached version of the agent
   #   A non-cached version (direct read of the database)
@@ -177,6 +184,10 @@ module Hyrax::User
       User.find_by_user_key(user_key) || User.create!(user_key_field => user_key, password: Devise.friendly_token[0, 20])
     end
 
+    def from_agent_key(key)
+      User.find_by_user_key(key)
+    end
+
     def from_url_component(component)
       User.find_by_user_key(component.gsub(/-dot-/, '.'))
     end

data/app/models/concerns/hyrax/work_behavior.rb

@@ -34,7 +34,7 @@ module Hyrax
 
     module ClassMethods
       # This governs which partial to draw when you render this type of object
-      def _to_partial_path #:nodoc:
+      def _to_partial_path # :nodoc:
         @_to_partial_path ||= begin
           element = ActiveSupport::Inflector.underscore(ActiveSupport::Inflector.demodulize(name))
           collection = ActiveSupport::Inflector.tableize(name)

data/app/models/featured_work_list.rb

@@ -18,7 +18,6 @@ class FeaturedWorkList
     @works = FeaturedWork.all
     add_solr_document_to_works
     @works = @works.reject do |work|
-      work.destroy if work.presenter.blank?
       work.presenter.blank?
     end
   end