hyrax 3.3.0 → 3.4.0

data/app/services/hyrax/collections/nested_collection_query_service.rb

@@ -12,11 +12,11 @@ module Hyrax
         attr_accessor :parents, :pathnames, :ancestors, :depth, :id
 
         def initialize(id:, scope:)
-          query_builder = Hyrax::CollectionSearchBuilder.new(scope).where(id: id)
+          query_builder = Hyrax::CollectionSearchBuilder.new(scope).where(id: id.to_s)
           query = Hyrax::Collections::NestedCollectionQueryService.clean_lucene_error(builder: query_builder)
           response = scope.repository.search(query)
           collection_doc = response.documents.first
-          @id = id
+          @id = id.to_s
           @parents = collection_doc[Samvera::NestingIndexer.configuration.solr_field_name_for_storing_parent_ids]
           @pathnames = collection_doc[Samvera::NestingIndexer.configuration.solr_field_name_for_storing_pathnames]
           @ancestors = collection_doc[Samvera::NestingIndexer.configuration.solr_field_name_for_storing_ancestors]
@@ -34,7 +34,7 @@ module Hyrax
       # @param limit_to_id [nil, String] Limit the query to just check if the given id is in the response. Useful for validation.
       # @return [Array<SolrDocument>]
       def self.available_child_collections(parent:, scope:, limit_to_id: nil)
-        return [] unless parent.try(:nestable?)
+        return [] unless nestable?(collection: parent)
         return [] unless scope.can?(:deposit, parent)
         query_solr(collection: parent, access: :read, scope: scope, limit_to_id: limit_to_id, nest_direction: :as_child).documents
       end
@@ -52,7 +52,7 @@ module Hyrax
       #
       # @return [Array<SolrDocument>]
       def self.available_parent_collections(child:, scope:, limit_to_id: nil)
-        return [] unless child.try(:nestable?)
+        return [] unless nestable?(collection: child)
         return [] unless scope.can?(:read, child)
         query_solr(collection: child, access: :deposit, scope: scope, limit_to_id: limit_to_id, nest_direction: :as_parent).documents
       end
@@ -69,7 +69,7 @@ module Hyrax
       #
       # @return [Blacklight::Solr::Response]
       def self.parent_collections(child:, scope:, page: 1)
-        return [] unless child.try(:nestable?)
+        return [] unless nestable?(collection: child)
         query_builder = Hyrax::NestedCollectionsParentSearchBuilder.new(scope: scope, child: child, page: page)
         query = clean_lucene_error(builder: query_builder)
         scope.repository.search(query)
@@ -86,7 +86,7 @@ module Hyrax
       #   id is in the response. Useful for validation.
       # @param nest_direction [Symbol] :as_child or :as_parent
       def self.query_solr(collection:, access:, scope:, limit_to_id:, nest_direction:)
-        nesting_attributes = NestingAttributes.new(id: collection.id, scope: scope)
+        nesting_attributes = NestingAttributes.new(id: collection.id.to_s, scope: scope)
         query_builder = Hyrax::Dashboard::NestedCollectionsSearchBuilder.new(
           access: access,
           collection: collection,
@@ -95,7 +95,7 @@ module Hyrax
           nest_direction: nest_direction
         )
 
-        query_builder.where(id: limit_to_id) if limit_to_id
+        query_builder.where(id: limit_to_id.to_s) if limit_to_id
         query = clean_lucene_error(builder: query_builder)
         scope.repository.search(query)
       end
@@ -139,8 +139,8 @@ module Hyrax
       def self.parent_and_child_can_nest?(parent:, child:, scope:)
         return false if parent == child # Short-circuit
         return false unless parent.collection_type_gid == child.collection_type_gid
-        return false if available_parent_collections(child: child, scope: scope, limit_to_id: parent.id).none?
-        return false if available_child_collections(parent: parent, scope: scope, limit_to_id: child.id).none?
+        return false if available_parent_collections(child: child, scope: scope, limit_to_id: parent.id.to_s).none?
+        return false if available_child_collections(parent: parent, scope: scope, limit_to_id: child.id.to_s).none?
         true
       end
 
@@ -190,7 +190,7 @@ module Hyrax
         descendant_depth = response[Samvera::NestingIndexer.configuration.solr_field_name_for_deepest_nested_depth]
 
         # => 2) Then we get the stored depth of the child collection itself to eliminate the collections above this one from our count, and add 1 to add back in this collection itself
-        child_depth = NestingAttributes.new(id: child.id, scope: scope).depth
+        child_depth = NestingAttributes.new(id: child.id.to_s, scope: scope).depth
         nesting_depth = descendant_depth - child_depth + 1
 
         # this should always be positive, but just being safe
@@ -207,9 +207,21 @@ module Hyrax
       #   this collection (includes this collection)
       def self.parent_nesting_depth(parent:, scope:)
         return 1 if parent.nil?
-        NestingAttributes.new(id: parent.id, scope: scope).depth
+        NestingAttributes.new(id: parent.id.to_s, scope: scope).depth
       end
       private_class_method :parent_nesting_depth
+
+      # @api private
+      #
+      # @param collection [Hyrax::PcdmCollection,::Collection]
+      # @return [Boolean] true if the collection is nestable; otherwise, false
+      def self.nestable?(collection:)
+        return false if collection.blank?
+        return collection.nestable? if collection.respond_to? :nestable?
+        collection_type = Hyrax::CollectionType.find_by_gid!(collection.collection_type_gid)
+        collection_type.nestable?
+      end
+      private_class_method :nestable?
     end
   end
 end

data/app/services/hyrax/custom_queries/navigators/child_file_sets_navigator.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+module Hyrax
+  module CustomQueries
+    module Navigators
+      ##
+      # Navigate from a resource to the child filesets in the resource.
+      #
+      # @see https://github.com/samvera/valkyrie/wiki/Queries#custom-queries
+      # @since 3.4.0
+      class ChildFileSetsNavigator
+        # Define the queries that can be fulfilled by this navigator.
+        def self.queries
+          [:find_child_file_sets, :find_child_file_set_ids]
+        end
+
+        attr_reader :query_service
+
+        def initialize(query_service:)
+          @query_service = query_service
+        end
+
+        ##
+        # Find child filesets of a given resource, and map to Valkyrie Resources
+        #
+        # @param [Valkyrie::Resource] resource
+        #
+        # @return [Array<Valkyrie::Resource>]
+        def find_child_file_sets(resource:)
+          query_service.find_members(resource: resource).select(&:file_set?)
+        end
+
+        ##
+        # Find the ids of child filesets of a given resource, and map to Valkyrie Resources IDs
+        #
+        # @param [Valkyrie::Resource] resource
+        #
+        # @return [Array<Valkyrie::ID>]
+        def find_child_file_set_ids(resource:)
+          find_child_file_sets(resource: resource).map(&:id)
+        end
+      end
+    end
+  end
+end

data/app/services/hyrax/custom_queries/navigators/child_filesets_navigator.rb

@@ -6,6 +6,7 @@ module Hyrax
       ##
       # Navigate from a resource to the child filesets in the resource.
       #
+      # @deprecated use Hyrax::CustomQueries::Navigators::ChildFileSetsNavigator instead
       # @see https://github.com/samvera/valkyrie/wiki/Queries#custom-queries
       # @since 3.0.0
       class ChildFilesetsNavigator
@@ -26,8 +27,10 @@ module Hyrax
         # @param [Valkyrie::Resource] resource
         #
         # @return [Array<Valkyrie::Resource>]
+        # @deprecated
         def find_child_filesets(resource:)
-          query_service.find_members(resource: resource).select(&:file_set?)
+          Deprecation.warn("Custom query find_child_filesets is deprecated; use find_child_file_sets instead.")
+          Hyrax.custom_queries.find_child_file_sets(resource: resource)
         end
 
         ##
@@ -36,8 +39,10 @@ module Hyrax
         # @param [Valkyrie::Resource] resource
         #
         # @return [Array<Valkyrie::ID>]
+        # @deprecated
         def find_child_fileset_ids(resource:)
-          find_child_filesets(resource: resource).map(&:id)
+          Deprecation.warn("Custom query find_child_fileset_ids is deprecated; use find_child_file_set_ids instead.")
+          Hyrax.custom_queries.find_child_file_set_ids(resource: resource)
         end
       end
     end

data/app/services/hyrax/custom_queries/navigators/parent_work_navigator.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+module Hyrax
+  module CustomQueries
+    module Navigators
+      ##
+      # Navigate from a resource to it's parent work.
+      #
+      # @see https://github.com/samvera/valkyrie/wiki/Queries#custom-queries
+      # @since 3.4.0
+      class ParentWorkNavigator
+        # Define the queries that can be fulfilled by this navigator.
+        def self.queries
+          [:find_parent_work, :find_parent_work_id]
+        end
+
+        attr_reader :query_service
+
+        def initialize(query_service:)
+          @query_service = query_service
+        end
+
+        ##
+        # Find parent work of a given resource, and map to Valkyrie Resources
+        # @note There should be only one parent resource.  A warning is logged if
+        #   more than one resource is found and the first of the resources is returned.
+        # @param [Valkyrie::Resource] resource
+        #
+        # @return [Array<Valkyrie::Resource>]
+        def find_parent_work(resource:)
+          results = Hyrax.query_service.find_inverse_references_by(resource: resource,
+                                                                   property: :member_ids).select(&:work?)
+          if results.count > 1
+            Hyrax.logger.warn("#{resource.work? ? 'Work' : 'File set'} " \
+                              "#{resource.id} is in #{results.count} works when it " \
+                              "should be in no more than one.")
+          end
+          results.first
+        end
+
+        ##
+        # Find the id of the parent work of a given resource, and map to Valkyrie Resources IDs
+        # @note There should be only one parent resource.  A warning is logged if
+        #   more than one resource is found and the first of the resources is returned.
+        # @param [Valkyrie::Resource] resource
+        #
+        # @return [Array<Valkyrie::ID>]
+        def find_parent_work_id(resource:)
+          find_parent_work(resource: resource)&.id
+        end
+      end
+    end
+  end
+end

data/app/services/hyrax/default_middleware_stack.rb

@@ -42,6 +42,9 @@ module Hyrax
         # Decode the private/public/institution on the form into permisisons on
         # the model
         middleware.use Hyrax::Actors::InterpretVisibilityActor
+        #
+        # Handles transfering ownership of works from one user to another
+        middleware.use Hyrax::Actors::TransferRequestActor
 
         # Copies default permissions from the PermissionTemplate to the work
         middleware.use Hyrax::Actors::ApplyPermissionTemplateActor

data/app/services/hyrax/file_set_derivatives_service.rb

@@ -3,13 +3,22 @@ module Hyrax
   # Responsible for creating and cleaning up the derivatives of a file_set
   class FileSetDerivativesService
     attr_reader :file_set
-    delegate :uri, :mime_type, to: :file_set
+    delegate :mime_type, to: :file_set
 
     # @param file_set [Hyrax::FileSet] At least for this class, it must have #uri and #mime_type
     def initialize(file_set)
       @file_set = file_set
     end
 
+    def uri
+      # If given a FileMetadata object, use its parent ID.
+      if file_set.respond_to?(:file_set_id)
+        file_set.file_set_id.to_s
+      else
+        file_set.uri
+      end
+    end
+
     def cleanup_derivatives
       derivative_path_factory.derivatives_for_reference(file_set).each do |path|
         FileUtils.rm_f(path)
@@ -33,12 +42,22 @@ module Hyrax
     # The destination_name parameter has to match up with the file parameter
     # passed to the DownloadsController
     def derivative_url(destination_name)
-      path = derivative_path_factory.derivative_path_for_reference(file_set, destination_name)
+      path = derivative_path_factory.derivative_path_for_reference(derivative_url_target, destination_name)
       URI("file://#{path}").to_s
     end
 
     private
 
+    # If given a FileMetadata object pass the file_set_id for derivative URL
+    # creation.
+    def derivative_url_target
+      if file_set.try(:file_set_id)
+        file_set.file_set_id.to_s
+      else
+        file_set
+      end
+    end
+
     def supported_mime_types
       file_set.class.pdf_mime_types +
         file_set.class.office_document_mime_types +

data/app/services/hyrax/file_set_type_service.rb

@@ -17,13 +17,10 @@ module Hyrax
     attr_reader :file_set
 
     ##
-    # @todo make `file_set_characterization_proxy` (or something better?)
-    #   application-level configuration.
-    #
     # @param [Hyrax::FileSet] file_set
     # @param [Symbol] characterization_proxy defaults to the setting provided by
     #   the application's ActiveFedora `FileSet` class.
-    def initialize(file_set:, characterization_proxy: ::FileSet.characterization_proxy, query_service: Hyrax.custom_queries)
+    def initialize(file_set:, characterization_proxy: Hyrax.config.characterization_proxy, query_service: Hyrax.custom_queries)
       @file_set = file_set
       @proxy_use = Hyrax::FileMetadata::Use.uri_for(use: characterization_proxy)
       @queries = query_service
@@ -48,7 +45,7 @@ module Hyrax
     private
 
     def audio_types
-      return ::FileSet.audio_mime_types if defined?(::FileSet)
+      return ::FileSet.audio_mime_types if defined?(::FileSet) && ::FileSet.respond_to?(:audio_mime_types)
       DEFAULT_AUDIO_TYPES
     end
   end

data/app/services/hyrax/listeners/file_metadata_listener.rb

@@ -3,13 +3,32 @@
 module Hyrax
   module Listeners
     ##
-    # Listens for events related to Hyrax::FileMetadata
+    # Listens for events related to {Hyrax::FileMetadata}
     class FileMetadataListener
+      ##
+      # Called when 'file.metadata.updated' event is published; reindexes a
+      # {Hyrax::FileSet} when a file claiming to be its `pcdm_use:OriginalFile`
+      #
+      # @param [Dry::Events::Event] event
+      # @return [void]
+      def on_file_metadata_updated(event)
+        return unless event[:metadata].original_file?
+
+        file_set = Hyrax.query_service.find_by(id: event[:metadata].file_set_id)
+        Hyrax.index_adapter.save(resource: file_set)
+      rescue Valkyrie::Persistence::ObjectNotFoundError => err
+        Hyrax.logger.warn "tried to index file with id #{event[:metadata].id} " \
+                          "in response to an event of type #{event.id} but " \
+                          "encountered an error #{err.message}. should this " \
+                          "object be in a FileSet #{event[:metadata]}"
+      end
+
       ##
       # Called when 'object.file.uploaded' event is published
       # @param [Dry::Events::Event] event
       # @return [void]
       def on_object_file_uploaded(event)
+        # Run characterization
         Hyrax.config
              .characterization_service
              .run(metadata: event[:metadata], file: event[:metadata].file)

data/app/services/hyrax/listeners/member_cleanup_listener.rb

@@ -3,7 +3,7 @@
 module Hyrax
   module Listeners
     ##
-    # Listens for object deleted events and cleans up associated members
+    # Listens for resource deleted events and cleans up associated members
     class MemberCleanupListener
       # Called when 'object.deleted' event is published
       # @param [Dry::Events::Event] event
@@ -12,11 +12,11 @@ module Hyrax
         return unless event.payload.key?(:object) # legacy callback
         return if event[:object].is_a?(ActiveFedora::Base) # handled by legacy code
 
-        Hyrax.custom_queries.find_child_filesets(resource: event[:object]).each do |file_set|
+        Hyrax.custom_queries.find_child_file_sets(resource: event[:object]).each do |file_set|
           begin
             Hyrax.persister.delete(resource: file_set)
             Hyrax.publisher
-                 .publish('object.deleted', object: file_set, id: file_set.id, user: user)
+                 .publish('object.deleted', object: file_set, id: file_set.id, user: event[:user])
           rescue StandardError # we don't uncaught errors looping filesets
             Hyrax.logger.warn "Failed to delete #{file_set.class}:#{file_set.id} " \
                               "during cleanup for resource: #{event[:object]}. " \
@@ -24,6 +24,26 @@ module Hyrax
           end
         end
       end
+
+      # Called when 'collection.deleted' event is published
+      # @param [Dry::Events::Event] event
+      # @return [void]
+      def on_collection_deleted(event)
+        return unless event.payload.key?(:collection) # legacy callback
+        return if event[:collection].is_a?(ActiveFedora::Base) # handled by legacy code
+
+        Hyrax.custom_queries.find_members_of(collection: event[:collection]).each do |resource|
+          begin
+            resource.member_of_collection_ids -= [event[:collection].id]
+            Hyrax.persister.save(resource: resource)
+            Hyrax.publisher
+                 .publish('collection.membership.updated', collection: event[:collection], user: event[:user])
+          rescue StandardError
+            Hyrax.logger.warn "Failed to remove collection reference from #{work.class}:#{work.id} " \
+                              "during cleanup for collection: #{event[:collection]}. "
+          end
+        end
+      end
     end
   end
 end

data/app/services/hyrax/listeners/metadata_index_listener.rb

@@ -22,6 +22,34 @@ module Hyrax
         Hyrax.index_adapter.save(resource: event[:collection])
       end
 
+      ##
+      # Re-index the resource.
+      #
+      # Called when 'file.metadata.updated' event is published
+      # @param [Dry::Events::Event] event
+      # @return [void]
+      def on_file_metadata_updated(event)
+        return unless resource? event[:metadata]
+        Hyrax.index_adapter.save(resource: event[:metadata])
+      end
+
+      ##
+      # Re-index the resource.
+      #
+      # Called when 'object.membership.updated' event is published
+      # @param [Dry::Events::Event] event
+      # @return [void]
+      def on_object_membership_updated(event)
+        resource = event.to_h.fetch(:object) { Hyrax.query_service.find_by(id: event[:object_id]) }
+        return unless resource?(resource)
+
+        Hyrax.index_adapter.save(resource: resource)
+      rescue Valkyrie::Persistence::ObjectNotFoundError => err
+        Hyrax.logger.error("Tried to index for an #{event.id} event with " \
+                           "payload #{event.payload}, but failed due to error:\n"\
+                           "\t#{err.message}")
+      end
+
       ##
       # Re-index the resource.
       #
@@ -44,6 +72,17 @@ module Hyrax
         Hyrax.index_adapter.delete(resource: event[:object])
       end
 
+      ##
+      # Remove the resource from the index.
+      #
+      # Called when 'collection.deleted' event is published
+      # @param [Dry::Events::Event] event
+      # @return [void]
+      def on_collection_deleted(event)
+        return unless resource?(event.payload[:collection])
+        Hyrax.index_adapter.delete(resource: event[:collection])
+      end
+
       private
 
       def resource?(resource)

data/app/services/hyrax/listeners/proxy_deposit_listener.rb

@@ -3,19 +3,25 @@
 module Hyrax
   module Listeners
     ##
-    # Listens for deposit events, and checks for proxy situations. When a user
+    # @deprecated transfer requests are now carried out synchronously during
+    # object save
+    #
+    ## Listens for deposit events, and checks for proxy situations. When a user
     # deposits an item `on_behalf_of` another, ensures transfer is handled.
     class ProxyDepositListener
       ##
       # Called when 'object.deposited' event is published
-      # @param [Dry::Events::Event] event
+      # @param [Dry::Events::Event] _event
       # @return [void]
-      def on_object_deposited(event)
-        return if event[:object].try(:on_behalf_of).blank? ||
-                  (event[:object].on_behalf_of == event[:object].depositor)
-
-        ContentDepositorChangeEventJob
-          .perform_later(event[:object], ::User.find_by_user_key(event[:object].on_behalf_of))
+      def on_object_deposited(_event)
+        Deprecation.warn(
+          "The ProxyDepositListener was deprecated, effective immediately, in \
+          response to a difficult-to-diagnose race condition bug. This listener \
+          is now a no-op. To retain functionality ensure that \
+          DefaultMiddlewareStack is configured to use \
+          Hyrax::Actors::TransferRequestActor. To quiet this deprecation remove any \
+          local initializer configuration that subscribes this listener."
+        )
       end
     end
   end

data/app/services/hyrax/location_service.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+module Hyrax
+  class LocationService < ::Qa::Authorities::Geonames
+    CACHE_KEY_PREFIX = 'hyrax_geonames_label-v1-'
+    CACHE_EXPIRATION = 1.week
+
+    def full_label(uri)
+      return if uri.blank?
+      id = extract_id uri
+      Rails.cache.fetch(cache_key(id), expires_in: CACHE_EXPIRATION) do
+        label.call(find(id))
+      end
+    end
+
+    private
+
+    def extract_id(obj)
+      uri = case obj
+            when String
+              URI(obj)
+            when URI
+              obj
+            else
+              raise ArgumentError, "#{obj} is not a valid type"
+            end
+      uri.path.split('/').last
+    end
+
+    def cache_key(id)
+      "#{CACHE_KEY_PREFIX}#{id}"
+    end
+  end
+end

data/app/services/hyrax/multiple_membership_checker.rb

@@ -11,6 +11,26 @@ module Hyrax
       @item = item
     end
 
+    # @api public
+    #
+    # Validate member_of_collection_ids does not have any membership conflicts
+    # based on the collection types of the members.
+    #
+    # Collections that have a collection type declaring
+    # `allow_multiple_membership` as `false` require that its members do not
+    # also belong to other collections of the same type.
+    #
+    # @return [True, String] true if no conflicts; otherwise, an error message string
+    def validate
+      return true if item.member_of_collection_ids.empty? || item.member_of_collection_ids.count <= 1
+      return true unless single_membership_collection_types_exist?
+
+      collections_to_check = filter_to_single_membership_collections(item.member_of_collection_ids)
+      problematic_collections = check_collections(collections_to_check)
+      errs = build_error_message(problematic_collections)
+      errs.presence || true
+    end
+
     # @api public
     #
     # Scan a list of collection_ids for multiple single-membership collections.
@@ -42,15 +62,18 @@ module Hyrax
 
     private
 
+    # @return [Boolean] true if there a any collection types that restrict membership
     def single_membership_collection_types_exist?
       single_membership_collection_types_gids.present?
     end
 
+    # @return [Array<String] global ids of collection types that restrict membership
     def single_membership_collection_types_gids
       @single_membership_collection_types_gids ||=
         Hyrax::CollectionType.gids_that_do_not_allow_multiple_membership&.map(&:to_s)
     end
 
+    # @return [Array<Hyrax::PcdmCollection>] list of collection instances for single membership collections
     def filter_to_single_membership_collections(collection_ids)
       return [] if collection_ids.blank?
       field_pairs = {
@@ -58,11 +81,14 @@ module Hyrax
       }
       Hyrax::SolrQueryService.new
                              .with_generic_type(generic_type: "Collection")
-                             .with_ids(ids: Array[collection_ids])
+                             .with_ids(ids: Array(collection_ids).map(&:to_s))
                              .with_field_pairs(field_pairs: field_pairs, join_with: ' OR ')
                              .get_objects(use_valkyrie: true).to_a
     end
 
+    # @param proposed [Array<Hyrax::PcdmCollection>] collections with restricted membership that are being added
+    # @param include_current_members [Boolean] true if current collections for item should also be checked
+    # @return [Array<Hyrax::PcdmCollection>] collections with restricted membership
     def collections_to_check(proposed, include_current_members)
       # ActorStack does a wholesale collection membership replacement, such that
       # proposed collections include existing and new collections.  Parameter
@@ -72,6 +98,19 @@ module Hyrax
       proposed | filter_to_single_membership_collections(item.member_of_collection_ids)
     end
 
+    # @param collections_to_check [Array<Hyrax::PcdmCollection>] collections with restricted membership
+    # @return [Array<Array>] collections groups by collection type
+    # @example example return result
+    #   [
+    #     [
+    #       <Collection(id: 1, collection_type_gid: 1, ...)>,
+    #       <Collection(id: 4, collection_type_gid: 1, ...)>
+    #     ],
+    #     [
+    #       <Collection(id: 13, collection_type_gid: 8, ...)>,
+    #       <Collection(id: 26, collection_type_gid: 8, ...)>
+    #     ]
+    #   ]
     def check_collections(collections_to_check)
       # uniq insures we include a collection only once when it is in the list multiple
       # group_by groups collections of the same collection type together
@@ -82,6 +121,7 @@ module Hyrax
                           .select { |_gid, list| list.count > 1 }
     end
 
+    # @return [nil, String] nil if no errors; otherwise, errors appended into a single human readable message
     def build_error_message(problematic_collections)
       return if problematic_collections.blank?
       error_message_clauses = problematic_collections.map do |gid, list|
@@ -93,10 +133,13 @@ module Hyrax
         "#{error_message_clauses.join('; ')}"
     end
 
+    # @return [String] title of the collection type
     def collection_type_title_from_gid(gid)
       Hyrax::CollectionType.find_by_gid(gid).title
     end
 
+    # @return [String] comma separated (with and before final) list of titles
+    # @example "Title 1, Title 2, and Title 3"
     def collection_titles_from_list(collection_list)
       collection_list.map do |collection|
         collection.title.first

data/app/services/hyrax/resource_visibility_propagator.rb

@@ -39,7 +39,7 @@ module Hyrax
     #
     # @raise [RuntimeError] if visibility propagation fails
     def propagate
-      queries.find_child_filesets(resource: source).each do |file_set|
+      queries.find_child_file_sets(resource: source).each do |file_set|
         file_set.visibility = source.visibility
         embargo_manager.copy_embargo_to(target: file_set)
         lease_manager.copy_lease_to(target: file_set)

data/app/services/hyrax/simple_schema_loader.rb

@@ -76,7 +76,11 @@ module Hyrax
       ##
       # @return [Dry::Types::Type]
       def type
-        collection_type = config['multiple'] ? Valkyrie::Types::Array : Identity
+        collection_type = if config['multiple']
+                            Valkyrie::Types::Array.constructor { |v| Array(v).select(&:present?) }
+                          else
+                            Identity
+                          end
         collection_type.of(type_for(config['type']))
       end