hyrax 3.0.0.pre.beta1 → 3.0.0.pre.beta2

data/spec/services/hyrax/workflow/changes_required_notification_spec.rb

@@ -13,7 +13,7 @@ RSpec.describe Hyrax::Workflow::ChangesRequiredNotification do
       expect(approver).to receive(:send_message)
         .with(anything,
               "Test title (<a href=\"/concern/generic_works/#{work.id}\">#{work.id}</a>) " \
-              "requires additional changes before approval.\n\n 'A pleasant read'",
+              "requires additional changes before approval.\n 'A pleasant read'",
               anything).exactly(3).times.and_call_original
 
       expect { described_class.send_notification(entity: entity, user: approver, comment: comment, recipients: recipients) }

data/spec/spec_helper.rb

@@ -40,6 +40,7 @@ require 'rspec/active_model/mocks'
 require 'capybara/rspec'
 require 'capybara/rails'
 require 'selenium-webdriver'
+require 'chromedriver-helper'
 require 'equivalent-xml'
 require 'equivalent-xml/rspec_matchers'
 require 'database_cleaner'
@@ -169,13 +170,6 @@ RSpec.configure do |config|
       DatabaseCleaner.start
     end
 
-    if example.metadata[:type] == :view
-      # View tests should not hit any services. This ensures the tests are unit
-      # testing only the views and run fast.
-      WebMock.disable_net_connect!(allow_localhost: false)
-    else
-      WebMock.disable_net_connect!(allow_localhost: true)
-    end
     # using :workflow is preferable to :clean_repo, use the former if possible
     # It's important that this comes after DatabaseCleaner.start
     ensure_deposit_available_for(user) if example.metadata[:workflow]
@@ -195,7 +189,15 @@ RSpec.configure do |config|
   end
 
   config.include(ControllerLevelHelpers, type: :view)
-  config.before(:each, type: :view) { initialize_controller_helpers(view) }
+
+  config.before(:each, type: :view) do
+    initialize_controller_helpers(view)
+    WebMock.disable_net_connect!(allow_localhost: false)
+  end
+
+  config.after(:each, type: :view) do
+    WebMock.disable_net_connect!(allow_localhost: true)
+  end
 
   config.before(:all, type: :feature) do
     # Assets take a long time to compile. This causes two problems:

data/spec/support/selectors.rb

@@ -43,7 +43,16 @@ module Selectors
     def select_member_of_collection(collection)
       find('#s2id_member_of_collection_ids').click
       find('.select2-input').set(collection.title.first)
-      sleep 10
+      # Crude way of waiting for the AJAX response
+      select2_results = []
+      time_elapsed = 0
+      while select2_results.empty? && time_elapsed < 30
+        begin_time = Time.now.to_f
+        doc = Nokogiri::XML.parse(page.body)
+        select2_results = doc.xpath('//html:li[contains(@class,"select2-result")]', html: 'http://www.w3.org/1999/xhtml')
+        end_time = Time.now.to_f
+        time_elapsed += end_time - begin_time
+      end
       expect(page).to have_css('.select2-result')
       within ".select2-result" do
         find("span", text: collection.title.first).click

data/spec/test_app_templates/Gemfile.extra

@@ -4,3 +4,5 @@ group :development do
   gem 'better_errors'
   gem 'binding_of_caller'
 end
+
+gem 'bootsnap', require: false

data/spec/test_app_templates/lib/generators/test_app_generator.rb

@@ -5,6 +5,12 @@ class TestAppGenerator < Rails::Generators::Base
   # so the following path gets us to /path/to/hyrax/spec/test_app_templates/
   source_root File.expand_path('../../../../spec/test_app_templates/', __FILE__)
 
+  def require_bootsnap
+    inject_into_file 'config/boot.rb', after: "require 'bundler/setup' # Set up gems listed in the Gemfile.\n" do
+      "require 'bootsnap/setup'\n"
+    end
+  end
+
   def install_engine
     generate 'hyrax:install', '-f'
   end

data/spec/views/catalog/_index_list_default.html.erb_spec.rb

@@ -8,14 +8,15 @@ RSpec.describe 'catalog/_index_list_default', type: :view do
       'date_modified_dtsi'   => 'a date',
       'rights_statement_tesim' => [''],
       'embargo_release_date_dtsi' => 'a date',
-      'lease_expiration_date_dtsi' => 'a date' }
+      'lease_expiration_date_dtsi' => 'a date',
+      'has_model_ssim' => 'GenericWork' }
   end
   let(:document) { SolrDocument.new(attributes) }
   let(:presenter) { double }
 
   before do
     allow(view).to receive(:index_presenter).and_return(presenter)
-    allow(presenter).to receive(:field_value) { |field| "Test #{field}" }
+    allow(presenter).to receive(:field_value) { |field| "Test #{field.field}" }
     render 'catalog/index_list_default', document: document
   end
 

data/spec/views/catalog/_thumbnail_list_collection.html.erb_spec.rb

@@ -1,10 +1,43 @@
 RSpec.describe 'catalog/_thumbnail_list_collection.html.erb', type: :view do
-  before do
-    stub_template 'catalog/_thumbnail_list_collection.html.erb' => '<div class="col-sm-3"><span class="fa fa-cubes collection-icon-search"></span></div>'
-    render
+  context "When the collection thumbnail is attached" do
+    let(:attributes) do
+      { id: "xxx",
+        "has_model_ssim": ["Collection"],
+        "title_tesim": ["Collection Title"],
+        "description_tesim": ["Collection Description"],
+        "system_modified_dtsi": 'date',
+        "thumbnail_path_ss": '/xxx/yyy?file=thumbnail' }
+    end
+    let(:doc) { SolrDocument.new(attributes) }
+    let(:current_ability) { Ability.new(build(:user)) }
+
+    before do
+      render 'catalog/thumbnail_list_collection', document: doc
+    end
+
+    it 'displays the collection thumbnail in the search results' do
+      expect(rendered).to include '/xxx/yyy?file=thumbnail'
+    end
   end
 
-  it 'displays the collection icon in the search results' do
-    expect(rendered).to match '<div class="col-sm-3"><span class="fa fa-cubes collection-icon-search"></span></div>'
+  context "When the collection thumbnail is not attached" do
+    let(:attributes) do
+      { id: "xxx",
+        "has_model_ssim": ["Collection"],
+        "title_tesim": ["Collection Title"],
+        "description_tesim": ["Collection Description"],
+        "system_modified_dtsi": 'date',
+        "thumbnail_path_ss" => Hyrax::CollectionIndexer.thumbnail_path_service.default_image }
+    end
+    let(:doc) { SolrDocument.new(attributes) }
+    let(:current_ability) { Ability.new(build(:user)) }
+
+    before do
+      render 'catalog/thumbnail_list_collection', document: doc
+    end
+
+    it 'displays the collection icon in the search results' do
+      expect(rendered).to include '/assets/collection-'
+    end
   end
 end

data/spec/views/hyrax/base/_attributes.html.erb_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe 'hyrax/base/_attributes.html.erb' do
   let(:solr_document) { SolrDocument.new(attributes) }
   let(:attributes) do
     {
-      Solrizer.solr_name('has_model', :symbol) => ["GenericWork"],
+      ActiveFedora.index_field_mapper.solr_name('has_model', :symbol) => ["GenericWork"],
       subject_tesim: subject,
       contributor_tesim: contributor,
       creator_tesim: creator,

data/spec/views/hyrax/base/_show_actions.html.erb_spec.rb

@@ -15,7 +15,7 @@ RSpec.describe 'hyrax/base/_show_actions.html.erb', type: :view do
     before do
       allow(presenter).to receive(:show_deposit_for?).with(anything).and_return(false)
       allow(presenter).to receive(:editor?).and_return(false)
-      render 'hyrax/base/show_actions.html.erb', presenter: presenter
+      render 'hyrax/base/show_actions', presenter: presenter
     end
     it "doesn't show edit / delete / Add to collection links" do
       expect(rendered).not_to have_link 'Edit'
@@ -32,7 +32,7 @@ RSpec.describe 'hyrax/base/_show_actions.html.erb', type: :view do
     context "when the work does not contain children" do
       before do
         allow(presenter).to receive(:member_presenters).and_return([])
-        render 'hyrax/base/show_actions.html.erb', presenter: presenter
+        render 'hyrax/base/show_actions', presenter: presenter
       end
       it "does not show file manager link" do
         expect(rendered).not_to have_link 'File Manager'
@@ -46,7 +46,7 @@ RSpec.describe 'hyrax/base/_show_actions.html.erb', type: :view do
     context "when the work contains 1 child" do
       before do
         allow(presenter).to receive(:member_presenters).and_return([member])
-        render 'hyrax/base/show_actions.html.erb', presenter: presenter
+        render 'hyrax/base/show_actions', presenter: presenter
       end
       it "does not show file manager link" do
         expect(rendered).not_to have_link 'File Manager'
@@ -60,7 +60,7 @@ RSpec.describe 'hyrax/base/_show_actions.html.erb', type: :view do
 
       before do
         allow(presenter).to receive(:member_presenters).and_return([member, file_member])
-        render 'hyrax/base/show_actions.html.erb', presenter: presenter
+        render 'hyrax/base/show_actions', presenter: presenter
       end
       it "shows file manager link" do
         expect(rendered).to have_link 'File Manager'
@@ -70,7 +70,7 @@ RSpec.describe 'hyrax/base/_show_actions.html.erb', type: :view do
     context "when there are valid_child_concerns" do
       before do
         allow(presenter).to receive(:member_presenters).and_return([])
-        render 'hyrax/base/show_actions.html.erb', presenter: presenter
+        render 'hyrax/base/show_actions', presenter: presenter
       end
       it "creates a link to add child work" do
         expect(rendered).to have_link 'Attach Generic Work', href: "/concern/parent/#{presenter.id}/generic_works/new"
@@ -87,7 +87,7 @@ RSpec.describe 'hyrax/base/_show_actions.html.erb', type: :view do
     context "and user is editor" do
       before do
         allow(presenter).to receive(:editor?).and_return(true)
-        render 'hyrax/base/show_actions.html.erb', presenter: presenter
+        render 'hyrax/base/show_actions', presenter: presenter
       end
 
       it "shows editor related buttons" do
@@ -101,7 +101,7 @@ RSpec.describe 'hyrax/base/_show_actions.html.erb', type: :view do
     context "and user is viewer" do
       before do
         allow(presenter).to receive(:editor?).and_return(false)
-        render 'hyrax/base/show_actions.html.erb', presenter: presenter
+        render 'hyrax/base/show_actions', presenter: presenter
       end
       it "shows only Add to collection link" do
         expect(rendered).not_to have_link 'File Manager'
@@ -121,7 +121,7 @@ RSpec.describe 'hyrax/base/_show_actions.html.erb', type: :view do
     context "and user is editor" do
       before do
         allow(presenter).to receive(:editor?).and_return(true)
-        render 'hyrax/base/show_actions.html.erb', presenter: presenter
+        render 'hyrax/base/show_actions', presenter: presenter
       end
 
       it "shows editor related buttons" do
@@ -135,7 +135,7 @@ RSpec.describe 'hyrax/base/_show_actions.html.erb', type: :view do
     context "and user is viewer" do
       before do
         allow(presenter).to receive(:editor?).and_return(false)
-        render 'hyrax/base/show_actions.html.erb', presenter: presenter
+        render 'hyrax/base/show_actions', presenter: presenter
       end
 
       it "shows only Add to collection link" do

data/spec/views/hyrax/base/show.html.erb_spec.rb

@@ -9,6 +9,7 @@ RSpec.describe 'hyrax/base/show.html.erb', type: :view do
                      description_tesim: ['Lorem ipsum lorem ipsum.'],
                      keyword_tesim: ['bacon', 'sausage', 'eggs'],
                      rights_statement_tesim: ['http://example.org/rs/1'],
+                     rights_notes_tesim: ['Notes on the rights'],
                      date_created_tesim: ['1984-01-02'])
   end
 
@@ -62,7 +63,7 @@ RSpec.describe 'hyrax/base/show.html.erb', type: :view do
     stub_template 'hyrax/base/_workflow_actions_widget.html.erb' => ''
     stub_template '_masthead.html.erb' => ''
     assign(:presenter, presenter)
-    render template: 'hyrax/base/show.html.erb', layout: 'layouts/hyrax/1_column'
+    render template: 'hyrax/base/show', layout: 'layouts/hyrax/1_column'
   end
 
   it 'shows workflow badge' do
@@ -72,7 +73,7 @@ RSpec.describe 'hyrax/base/show.html.erb', type: :view do
   describe 'IIIF viewer integration' do
     before do
       allow(presenter).to receive(:iiif_viewer?).and_return(viewer_enabled)
-      render template: 'hyrax/base/show.html.erb'
+      render template: 'hyrax/base/show'
     end
 
     context 'when presenter says it is enabled' do

data/spec/views/hyrax/collections/_show_document_list_row.html.erb_spec.rb

@@ -15,15 +15,16 @@ RSpec.describe 'hyrax/collections/_show_document_list_row.html.erb', type: :view
   context 'when not logged in' do
     before do
       view.blacklight_config = Blacklight::Configuration.new
+      assign(:presenter, collection)
       allow(view).to receive(:current_user).and_return(nil)
       allow(work).to receive(:title_or_label).and_return("One Hundred Years of Solitude")
       allow(work).to receive(:edit_people).and_return([])
-      allow(view).to receive(:render_collection_links).and_return("collections: #{collection.title}")
+      allow(view).to receive(:render_other_collection_links).and_return([])
     end
 
     it "renders collections links" do
       render('hyrax/collections/show_document_list_row.html.erb', document: work)
-      expect(rendered).to have_content 'My awesome collection'
+      expect(rendered).not_to have_content 'My awesome collection'
     end
 
     it "renders works" do

data/spec/views/hyrax/dashboard/collections/_show_document_list_row.html.erb_spec.rb

@@ -15,15 +15,16 @@ RSpec.describe 'hyrax/dashboard/collections/_show_document_list_row.html.erb', t
   context 'when not logged in' do
     before do
       view.blacklight_config = Blacklight::Configuration.new
+      assign(:presenter, collection)
       allow(view).to receive(:current_user).and_return(nil)
       allow(work).to receive(:title_or_label).and_return("One Hundred Years of Solitude")
       allow(work).to receive(:edit_people).and_return([])
-      allow(view).to receive(:render_collection_links).and_return("collections: #{collection.title}")
+      allow(view).to receive(:render_other_collection_links).and_return([])
     end
 
     it "renders collections links" do
       render('show_document_list_row', document: work)
-      expect(rendered).to have_content 'My awesome collection'
+      expect(rendered).not_to have_content 'My awesome collection'
     end
 
     it "renders works" do

data/spec/wings/active_fedora_converter_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+require 'spec_helper'
+require 'wings'
+require 'wings/active_fedora_converter'
+
+RSpec.describe Wings::ActiveFedoraConverter do
+  subject(:converter) { described_class.new(resource: resource) }
+  let(:adapter)       { Valkyrie::Persistence::Memory::MetadataAdapter.new }
+  let(:attributes)    { { id: id } }
+  let(:id)            { 'moomin_id' }
+  let(:resource)      { work.valkyrie_resource }
+  let(:work)          { GenericWork.new(attributes) }
+
+  describe '#convert' do
+    it 'returns the ActiveFedora model' do
+      expect(converter.convert).to eq work
+    end
+
+    context 'with attributes' do
+      let(:attributes) do
+        FactoryBot.attributes_for(:generic_work)
+      end
+
+      it 'repopulates the attributes' do
+        expect(converter.convert).to have_attributes(attributes)
+      end
+
+      it 'populates reflections'
+    end
+  end
+end

data/spec/wings/model_transformer_spec.rb

@@ -0,0 +1,288 @@
+# frozen_string_literal: true
+require 'spec_helper'
+require 'wings/model_transformer'
+
+RSpec.describe Wings::ModelTransformer do
+  subject(:factory) { described_class.new(pcdm_object: pcdm_object) }
+  let(:pcdm_object) { work }
+  let(:adapter)     { Valkyrie::MetadataAdapter.find(:memory) }
+  let(:id)          { 'moomin123' }
+  let(:persister)   { adapter.persister }
+  let(:work)        { GenericWork.new(id: id, **attributes) }
+
+  let(:uris) do
+    [RDF::URI('http://example.com/fake1'),
+     RDF::URI('http://example.com/fake2')]
+  end
+
+  let(:attributes) do
+    {
+      title: ['fake title'],
+      date_created: [Time.now.utc],
+      depositor: 'user1',
+      description: ['a description'],
+      import_url: uris.first,
+      publisher: [false],
+      related_url: uris,
+      source: [1.125, :moomin]
+    }
+  end
+
+  before(:context) do
+    Valkyrie::MetadataAdapter.register(
+      Valkyrie::Persistence::Memory::MetadataAdapter.new,
+      :memory
+    )
+
+    Valkyrie::StorageAdapter.register(
+      Valkyrie::Storage::Memory.new,
+      :memory
+    )
+  end
+
+  # TODO: extract to Valkyrie?
+  define :have_a_valkyrie_alternate_id_of do |expected_id_str|
+    match do |valkyrie_resource|
+      valkyrie_resource.alternate_ids.map(&:id).include?(expected_id_str)
+    end
+  end
+
+  describe '.convert_class_name_to_valkyrie_resource_class' do
+    context 'when given a ActiveFedora class name (eg. a constant that responds to #properties)' do
+      it 'creates a Valkyrie::Resource class' do
+        subject = described_class.convert_class_name_to_valkyrie_resource_class('GenericWork')
+        expect(subject.new).to be_a Valkyrie::Resource
+      end
+    end
+  end
+
+  describe '.to_valkyrie_resource_class' do
+    context 'when given a ActiveFedora class (eg. a constant that responds to #properties)' do
+      context 'for the returned object (e.g. a class)' do
+        subject { described_class.to_valkyrie_resource_class(klass: GenericWork) }
+        it 'will be Valkyrie::Resource build' do
+          expect(subject.new).to be_a Valkyrie::Resource
+        end
+        it 'has a to_s instance that delegates to the given klass' do
+          expect(subject.to_s).to eq(GenericWork.to_s)
+        end
+        it 'has a internal_resource instance that is the given klass' do
+          expect(subject.internal_resource).to eq(GenericWork)
+        end
+      end
+    end
+    context 'when given a non-ActiveFedora class' do
+      it 'raises an exception' do
+        expect { described_class.to_valkyrie_resource_class(klass: String) }.to raise_error
+      end
+    end
+  end
+
+  describe '.for' do
+    it 'returns a Valkyrie::Resource' do
+      expect(described_class.for(work)).to be_a Valkyrie::Resource
+    end
+  end
+
+  describe '#build' do
+    it 'returns a Valkyrie::Resource' do
+      expect(factory.build).to be_a Valkyrie::Resource
+    end
+
+    it 'has the id of the pcdm_object' do
+      expect(factory.build).to have_a_valkyrie_alternate_id_of work.id
+    end
+
+    it 'has attributes matching the pcdm_object' do
+      expect(factory.build)
+        .to have_attributes title: work.title,
+                            date_created: work.date_created,
+                            depositor: work.depositor,
+                            description: work.description
+    end
+
+    it 'round trips attributes' do # rubocop:disable RSpec/ExampleLength
+      persister.save(resource: factory.build)
+
+      expect(adapter.query_service.find_by_alternate_identifier(alternate_identifier: work.id))
+        .to have_attributes title: work.title,
+                            date_created: work.date_created,
+                            depositor: work.depositor,
+                            description: work.description,
+                            import_url: work.import_url,
+                            publisher: work.publisher,
+                            related_url: work.related_url,
+                            source: work.source
+    end
+  end
+
+  context 'with relationship properties' do
+    let(:pcdm_object) { book }
+    let(:id)          { 'moomin123' }
+    let(:book)        { book_class.new(id: id, **attributes) }
+    let(:page1)       { page_class.new(id: 'pg1') }
+    let(:page2)       { page_class.new(id: 'pg2') }
+
+    let(:book_class) do
+      Book = Class.new(ActiveFedora::Base) do
+        has_many :pages
+        property :title, predicate: ::RDF::Vocab::DC.title
+        property :contributor, predicate: ::RDF::Vocab::DC.contributor
+        property :description, predicate: ::RDF::Vocab::DC.description
+      end
+    end
+
+    let(:page_class) do
+      Page = Class.new(ActiveFedora::Base) do
+        belongs_to :book_with_pages, predicate: ActiveFedora::RDF::Fcrepo::RelsExt.isPartOf
+      end
+    end
+
+    after do
+      Object.send(:remove_const, :Page)
+      Object.send(:remove_const, :Book)
+    end
+
+    let(:attributes) do
+      {
+        title: ['fake title', 'fake title 2'],
+        contributor: ['user1'],
+        description: ['a description'],
+        pages: [page1, page2]
+      }
+    end
+
+    describe '.for' do
+      it 'returns a Valkyrie::Resource' do
+        expect(described_class.for(book)).to be_a Valkyrie::Resource
+      end
+    end
+
+    describe '#build' do
+      it 'returns a Valkyrie::Resource' do
+        expect(subject.build).to be_a Valkyrie::Resource
+      end
+
+      it 'has the id of the active_fedora_object' do
+        expect(subject.build).to have_a_valkyrie_alternate_id_of book.id
+      end
+
+      it 'has attributes matching the active_fedora_object' do
+        expect(subject.build)
+          .to have_attributes title: book.title,
+                              contributor: book.contributor,
+                              description: book.description
+        expect_ids_to_match(subject.build.page_ids, ['pg1', 'pg2'])
+      end
+    end
+  end
+
+  context 'for PCDM & Hydra-Works models', :clean_repo do
+    let(:collection1) { build(:public_collection_lw, id: 'col1', title: ['Collection 1']) }
+    let(:collection2) { build(:public_collection_lw, id: 'col2', title: ['Collection 2']) }
+    let(:collection3) { build(:public_collection_lw, id: 'col3', title: ['Collection 3']) }
+    let(:work1)       { build(:work, id: 'wk1', title: ['Work 1']) }
+    let(:work2)       { build(:work, id: 'wk2', title: ['Work 2']) }
+    let(:work3)       { build(:work, id: 'wk3', title: ['Work 3']) }
+    let(:fileset1)    { build(:file_set, id: 'fs1', title: ['Fileset 1']) }
+    let(:fileset2)    { build(:file_set, id: 'fs2', title: ['Fileset 2']) }
+
+    describe '#build' do
+      context 'for parent collection' do
+        before do
+          collection1.members = [work1, work2, collection2, collection3]
+          collection1.save!
+        end
+
+        let(:pcdm_object) { collection1 }
+
+        it 'returns a Valkyrie::Resource' do
+          expect(subject.build).to be_a Valkyrie::Resource
+        end
+
+        it 'has the id of the active_fedora_object' do
+          expect(subject.build).to have_a_valkyrie_alternate_id_of collection1.id
+        end
+
+        it 'has attributes for the PCDM model' do
+          expect(subject.build)
+            .to have_attributes title: collection1.title
+          expect_ids_to_match(subject.build.member_ids, [work1.id, work2.id, collection2.id, collection3.id])
+        end
+      end
+
+      context 'for child collection' do
+        let(:pcdm_object) { collection3 }
+
+        before do
+          collection3.member_of_collections = [collection1, collection2]
+          collection3.save!
+        end
+
+        it 'returns a Valkyrie::Resource' do
+          expect(subject.build).to be_a Valkyrie::Resource
+        end
+
+        it 'has the id of the active_fedora_object' do ###
+          expect(subject.build).to have_a_valkyrie_alternate_id_of collection3.id
+        end
+
+        it 'has attributes matching the active_fedora_object' do
+          expect(subject.build)
+            .to have_attributes title: collection3.title
+          expect_ids_to_match(subject.build.member_of_collection_ids, ['col1', 'col2'])
+        end
+      end
+
+      context 'for work in collection' do
+        let(:pcdm_object) { work1 }
+
+        before do
+          work1.member_of_collections = [collection1, collection2]
+          work1.save!
+        end
+
+        it 'returns a Valkyrie::Resource' do
+          expect(subject.build).to be_a Valkyrie::Resource
+        end
+
+        it 'has the id of the active_fedora_object' do ###
+          expect(subject.build).to have_a_valkyrie_alternate_id_of work1.id
+        end
+
+        it 'has attributes matching the active_fedora_object' do
+          expect(subject.build)
+            .to have_attributes title: work1.title
+          expect_ids_to_match(subject.build.member_of_collection_ids, ['col1', 'col2'])
+        end
+      end
+
+      context 'work with works and filesets' do
+        let(:pcdm_object) { work1 }
+
+        before do
+          work1.members = [work2, work3, fileset1, fileset2]
+          work1.save!
+        end
+
+        it 'returns a Valkyrie::Resource' do
+          expect(subject.build).to be_a Valkyrie::Resource
+        end
+
+        it 'has the id of the active_fedora_object' do ###
+          expect(subject.build).to have_a_valkyrie_alternate_id_of work1.id
+        end
+
+        it 'has attributes matching the active_fedora_object' do
+          expect(subject.build)
+            .to have_attributes title: work1.title
+          expect_ids_to_match(subject.build.member_ids, [work2.id, work3.id, fileset1.id, fileset2.id])
+        end
+      end
+    end
+  end
+
+  def expect_ids_to_match(valkyrie_ids, expected_ids)
+    expect(valkyrie_ids.map(&:id)).to match_array expected_ids
+  end
+end