hyperclient 0.8.5 → 1.0.1

data/test/hyperclient/link_collection_test.rb

@@ -14,33 +14,33 @@ module Hyperclient
     end
 
     it 'is a collection' do
-      LinkCollection.ancestors.must_include Collection
+      _(LinkCollection.ancestors).must_include Collection
     end
 
     it 'initializes the collection with links' do
-      links.must_respond_to :filter
-      links.must_respond_to :gizmos
+      _(links).must_respond_to :search
+      _(links).must_respond_to :gizmos
     end
 
     it 'returns link objects for each link' do
-      links.filter.must_be_kind_of Link
-      links['self'].must_be_kind_of Link
+      _(links.search).must_be_kind_of Link
+      _(links['self']).must_be_kind_of Link
 
-      links.gizmos.must_be_kind_of Array
-      links['gizmos'].must_be_kind_of Array
+      _(links.gizmos).must_be_kind_of Array
+      _(links['gizmos']).must_be_kind_of Array
     end
 
     describe 'plain link' do
       let(:plain_link) { links.self }
       it 'must be correct' do
-        plain_link._url.must_equal '/productions/1'
+        _(plain_link._url).must_equal '/productions/1'
       end
     end
 
     describe 'templated link' do
-      let(:templated_link) { links.filter }
+      let(:templated_link) { links.search }
       it 'must expand' do
-        templated_link._expand(filter: 'gizmos')._url.must_equal '/productions/1?categories=gizmos'
+        _(templated_link._expand(search: 'gizmos')._url).must_equal '/productions/1?categories=gizmos'
       end
     end
 
@@ -48,10 +48,10 @@ module Hyperclient
       let(:curied_link) { links['image:thumbnail'] }
       let(:curie) { links._curies['image'] }
       it 'must expand' do
-        curied_link._expand(version: 'small')._url.must_equal '/images/thumbnails/small.jpg'
+        _(curied_link._expand(version: 'small')._url).must_equal '/images/thumbnails/small.jpg'
       end
       it 'exposes curie' do
-        curie.expand('thumbnail').must_equal '/docs/images/thumbnail'
+        _(curie.expand('thumbnail')).must_equal '/docs/images/thumbnail'
       end
     end
 
@@ -59,12 +59,12 @@ module Hyperclient
       let(:gizmos) { links.gizmos }
 
       it 'should have 2 items' do
-        gizmos.length.must_equal 2
+        _(gizmos.length).must_equal 2
       end
 
       it 'must be an array of Links' do
         gizmos.each do |link|
-          link.must_be_kind_of Link
+          _(link).must_be_kind_of Link
         end
       end
     end
@@ -72,7 +72,7 @@ module Hyperclient
     describe 'null link value' do
       let(:null_link) { links.null_link }
       it 'must be nil' do
-        null_link.must_be_nil
+        _(null_link).must_be_nil
       end
     end
   end

data/test/hyperclient/link_test.rb

@@ -7,16 +7,16 @@ module Hyperclient
       EntryPoint.new('http://api.example.org/')
     end
 
-    %w(type deprecation name profile title hreflang).each do |prop|
+    %w[type deprecation name profile title hreflang].each do |prop|
       describe prop do
         it 'returns the property value' do
           link = Link.new('key', { prop => 'value' }, entry_point)
-          link.send("_#{prop}").must_equal 'value'
+          _(link.send("_#{prop}")).must_equal 'value'
         end
 
         it 'returns nil if the property is not present' do
           link = Link.new('key', {}, entry_point)
-          link.send("_#{prop}").must_equal nil
+          _(link.send("_#{prop}")).must_be_nil
         end
       end
     end
@@ -25,13 +25,13 @@ module Hyperclient
       it 'returns true if the link is templated' do
         link = Link.new('key', { 'templated' => true }, entry_point)
 
-        link._templated?.must_equal true
+        _(link._templated?).must_equal true
       end
 
       it 'returns false if the link is not templated' do
         link = Link.new('key', {}, entry_point)
 
-        link._templated?.must_equal false
+        _(link._templated?).must_equal false
       end
     end
 
@@ -39,13 +39,13 @@ module Hyperclient
       it 'returns a list of required variables' do
         link = Link.new('key', { 'href' => '/orders{?id,owner}', 'templated' => true }, entry_point)
 
-        link._variables.must_equal %w(id owner)
+        _(link._variables).must_equal %w[id owner]
       end
 
       it 'returns an empty array for untemplated links' do
         link = Link.new('key', { 'href' => '/orders' }, entry_point)
 
-        link._variables.must_equal []
+        _(link._variables).must_equal []
       end
     end
 
@@ -53,41 +53,41 @@ module Hyperclient
       describe 'required argument' do
         it 'builds a Link with the templated URI representation' do
           link = Link.new('key', { 'href' => '/orders/{id}', 'templated' => true }, entry_point)
-          link._expand(id: '1')._url.must_equal '/orders/1'
+          _(link._expand(id: '1')._url).must_equal '/orders/1'
         end
 
         it 'expands an uri template without variables' do
           link = Link.new('key', { 'href' => '/orders/{id}', 'templated' => true }, entry_point)
-          link._expand._url.must_equal '/orders/'
-          link._url.must_equal '/orders/'
+          _(link._expand._url).must_equal '/orders/'
+          _(link._url).must_equal '/orders/'
         end
       end
 
       describe 'query string argument' do
         it 'builds a Link with the templated URI representation' do
           link = Link.new('key', { 'href' => '/orders{?id}', 'templated' => true }, entry_point)
-          link._expand(id: '1')._url.must_equal '/orders?id=1'
+          _(link._expand(id: '1')._url).must_equal '/orders?id=1'
         end
 
         it 'expands an uri template without variables' do
           link = Link.new('key', { 'href' => '/orders{?id}', 'templated' => true }, entry_point)
-          link._expand._url.must_equal '/orders'
-          link._url.must_equal '/orders'
+          _(link._expand._url).must_equal '/orders'
+          _(link._url).must_equal '/orders'
         end
 
         it 'does not expand unknown variables' do
           link = Link.new('key', { 'href' => '/orders{?id}', 'templated' => true }, entry_point)
-          link._expand(unknown: '1')._url.must_equal '/orders'
+          _(link._expand(unknown: '1')._url).must_equal '/orders'
         end
 
         it 'only expands known variables' do
           link = Link.new('key', { 'href' => '/orders{?id}', 'templated' => true }, entry_point)
-          link._expand(unknown: '1', id: '2')._url.must_equal '/orders?id=2'
+          _(link._expand(unknown: '1', id: '2')._url).must_equal '/orders?id=2'
         end
 
         it 'only expands templated links' do
           link = Link.new('key', { 'href' => '/orders{?id}', 'templated' => false }, entry_point)
-          link._expand(id: '1')._url.must_equal '/orders{?id}'
+          _(link._expand(id: '1')._url).must_equal '/orders{?id}'
         end
       end
     end
@@ -96,36 +96,36 @@ module Hyperclient
       it 'expands an uri template without variables' do
         link = Link.new('key', { 'href' => '/orders{?id}', 'templated' => true }, entry_point)
 
-        link._url.must_equal '/orders'
+        _(link._url).must_equal '/orders'
       end
 
       it 'expands an uri template with variables' do
         link = Link.new('key', { 'href' => '/orders{?id}', 'templated' => true }, entry_point, id: 1)
 
-        link._url.must_equal '/orders?id=1'
+        _(link._url).must_equal '/orders?id=1'
       end
 
       it 'does not expand an uri template with unknown variables' do
         link = Link.new('key', { 'href' => '/orders{?id}', 'templated' => true }, entry_point, unknown: 1)
 
-        link._url.must_equal '/orders'
+        _(link._url).must_equal '/orders'
       end
 
       it 'only expands known variables in a uri template' do
         link = Link.new('key', { 'href' => '/orders{?id}', 'templated' => true }, entry_point, unknown: 1, id: 2)
 
-        link._url.must_equal '/orders?id=2'
+        _(link._url).must_equal '/orders?id=2'
       end
 
       it 'returns the link when no uri template' do
         link = Link.new('key', { 'href' => '/orders' }, entry_point)
-        link._url.must_equal '/orders'
+        _(link._url).must_equal '/orders'
       end
 
       it 'aliases to_s to _url' do
         link = Link.new('key', { 'href' => '/orders{?id}', 'templated' => true }, entry_point, id: 1)
 
-        link.to_s.must_equal '/orders?id=1'
+        _(link.to_s).must_equal '/orders?id=1'
       end
     end
 
@@ -151,7 +151,7 @@ module Hyperclient
           stub.get('http://api.example.org/productions/1') { [200, {}, nil] }
         end
 
-        link._get.must_be_kind_of Resource
+        _(link._get).must_be_kind_of Resource
       end
 
       it 'raises exceptions by default' do
@@ -161,35 +161,7 @@ module Hyperclient
           stub.get('http://api.example.org/productions/1') { [400, {}, nil] }
         end
 
-        lambda { link._get }.must_raise Faraday::ClientError
-      end
-
-      it 'executes requests asynchronously using futuroscope' do
-        link = Link.new('key', { 'href' => '/productions/1' }, entry_point)
-
-        stub_request(entry_point.connection) do |stub|
-          stub.get('http://api.example.org/productions/1') { [200, {}, nil] }
-        end
-
-        Futuroscope::Future.expects(:new).returns(stub(body: nil))
-
-        link._get
-      end
-
-      describe 'when entry_point.options is set to { async: false }' do
-        it 'executes requests synchronously without futuroscope' do
-          entry_point.options = { async: false }
-
-          link = Link.new('key', { 'href' => '/productions/1' }, entry_point)
-
-          stub_request(entry_point.connection) do |stub|
-            stub.get('http://api.example.org/productions/1') { [200, {}, nil] }
-          end
-
-          Futuroscope::Future.expects(:new).never
-
-          link._get
-        end
+        _(-> { link._get }).must_raise Faraday::ClientError
       end
     end
 
@@ -201,35 +173,7 @@ module Hyperclient
           stub.options('http://api.example.org/productions/1') { [200, {}, nil] }
         end
 
-        link._options.must_be_kind_of Resource
-      end
-
-      it 'executes requests asynchronously using futuroscope' do
-        link = Link.new('key', { 'href' => '/productions/1' }, entry_point)
-
-        stub_request(entry_point.connection) do |stub|
-          stub.options('http://api.example.org/productions/1') { [200, {}, nil] }
-        end
-
-        Futuroscope::Future.expects(:new).returns(stub(body: nil))
-
-        link._options
-      end
-
-      describe 'when entry_point.options is set to { async: false }' do
-        it 'executes requests synchronously without futuroscope' do
-          entry_point.options = { async: false }
-
-          link = Link.new('key', { 'href' => '/productions/1' }, entry_point)
-
-          stub_request(entry_point.connection) do |stub|
-            stub.options('http://api.example.org/productions/1') { [200, {}, nil] }
-          end
-
-          Futuroscope::Future.expects(:new).never
-
-          link._options
-        end
+        _(link._options).must_be_kind_of Resource
       end
     end
 
@@ -241,35 +185,7 @@ module Hyperclient
           stub.head('http://api.example.org/productions/1') { [200, {}, nil] }
         end
 
-        link._head.must_be_kind_of Resource
-      end
-
-      it 'executes requests asynchronously using futuroscope' do
-        link = Link.new('key', { 'href' => '/productions/1' }, entry_point)
-
-        stub_request(entry_point.connection) do |stub|
-          stub.head('http://api.example.org/productions/1') { [200, {}, nil] }
-        end
-
-        Futuroscope::Future.expects(:new).returns(stub(body: nil))
-
-        link._head
-      end
-
-      describe 'when entry_point.options is set to { async: false }' do
-        it 'executes requests synchronously without futuroscope' do
-          entry_point.options = { async: false }
-
-          link = Link.new('key', { 'href' => '/productions/1' }, entry_point)
-
-          stub_request(entry_point.connection) do |stub|
-            stub.head('http://api.example.org/productions/1') { [200, {}, nil] }
-          end
-
-          Futuroscope::Future.expects(:new).never
-
-          link._head
-        end
+        _(link._head).must_be_kind_of Resource
       end
     end
 
@@ -281,35 +197,7 @@ module Hyperclient
           stub.delete('http://api.example.org/productions/1') { [200, {}, nil] }
         end
 
-        link._delete.must_be_kind_of Resource
-      end
-
-      it 'executes requests asynchronously using futuroscope' do
-        link = Link.new('key', { 'href' => '/productions/1' }, entry_point)
-
-        stub_request(entry_point.connection) do |stub|
-          stub.delete('http://api.example.org/productions/1') { [200, {}, nil] }
-        end
-
-        Futuroscope::Future.expects(:new).returns(stub(body: nil))
-
-        link._delete
-      end
-
-      describe 'when entry_point.options is set to { async: false }' do
-        it 'executes requests synchronously without futuroscope' do
-          entry_point.options = { async: false }
-
-          link = Link.new('key', { 'href' => '/productions/1' }, entry_point)
-
-          stub_request(entry_point.connection) do |stub|
-            stub.delete('http://api.example.org/productions/1') { [200, {}, nil] }
-          end
-
-          Futuroscope::Future.expects(:new).never
-
-          link._delete
-        end
+        _(link._delete).must_be_kind_of Resource
       end
     end
 
@@ -321,7 +209,7 @@ module Hyperclient
           stub.post('http://api.example.org/productions/1') { [200, {}, nil] }
         end
 
-        link._post('foo' => 'bar').must_be_kind_of Resource
+        _(link._post('foo' => 'bar')).must_be_kind_of Resource
       end
 
       it 'defaults params to an empty hash' do
@@ -329,35 +217,7 @@ module Hyperclient
           stub.post('http://api.example.org/productions/1') { [200, {}, nil] }
         end
 
-        link._post.must_be_kind_of Resource
-      end
-
-      it 'executes requests asynchronously using futuroscope' do
-        link = Link.new('key', { 'href' => '/productions/1' }, entry_point)
-
-        stub_request(entry_point.connection) do |stub|
-          stub.post('http://api.example.org/productions/1') { [200, {}, nil] }
-        end
-
-        Futuroscope::Future.expects(:new).returns(stub(body: nil))
-
-        link._post
-      end
-
-      describe 'when entry_point.options is set to { async: false }' do
-        it 'executes requests synchronously without futuroscope' do
-          entry_point.options = { async: false }
-
-          link = Link.new('key', { 'href' => '/productions/1' }, entry_point)
-
-          stub_request(entry_point.connection) do |stub|
-            stub.post('http://api.example.org/productions/1') { [200, {}, nil] }
-          end
-
-          Futuroscope::Future.expects(:new).never
-
-          link._post
-        end
+        _(link._post).must_be_kind_of Resource
       end
     end
 
@@ -369,7 +229,7 @@ module Hyperclient
           stub.put('http://api.example.org/productions/1', '{"foo":"bar"}') { [200, {}, nil] }
         end
 
-        link._put('foo' => 'bar').must_be_kind_of Resource
+        _(link._put('foo' => 'bar')).must_be_kind_of Resource
       end
 
       it 'defaults params to an empty hash' do
@@ -377,35 +237,7 @@ module Hyperclient
           stub.put('http://api.example.org/productions/1') { [200, {}, nil] }
         end
 
-        link._put.must_be_kind_of Resource
-      end
-
-      it 'executes requests asynchronously using futuroscope' do
-        link = Link.new('key', { 'href' => '/productions/1' }, entry_point)
-
-        stub_request(entry_point.connection) do |stub|
-          stub.put('http://api.example.org/productions/1') { [200, {}, nil] }
-        end
-
-        Futuroscope::Future.expects(:new).returns(stub(body: nil))
-
-        link._put
-      end
-
-      describe 'when entry_point.options is set to { async: false }' do
-        it 'executes requests synchronously without futuroscope' do
-          entry_point.options = { async: false }
-
-          link = Link.new('key', { 'href' => '/productions/1' }, entry_point)
-
-          stub_request(entry_point.connection) do |stub|
-            stub.put('http://api.example.org/productions/1') { [200, {}, nil] }
-          end
-
-          Futuroscope::Future.expects(:new).never
-
-          link._put
-        end
+        _(link._put).must_be_kind_of Resource
       end
     end
 
@@ -417,7 +249,7 @@ module Hyperclient
           stub.patch('http://api.example.org/productions/1', '{"foo":"bar"}') { [200, {}, nil] }
         end
 
-        link._patch('foo' => 'bar').must_be_kind_of Resource
+        _(link._patch('foo' => 'bar')).must_be_kind_of Resource
       end
 
       it 'defaults params to an empty hash' do
@@ -425,35 +257,7 @@ module Hyperclient
           stub.patch('http://api.example.org/productions/1') { [200, {}, nil] }
         end
 
-        link._patch.must_be_kind_of Resource
-      end
-
-      it 'executes requests asynchronously using futuroscope' do
-        link = Link.new('key', { 'href' => '/productions/1' }, entry_point)
-
-        stub_request(entry_point.connection) do |stub|
-          stub.patch('http://api.example.org/productions/1') { [200, {}, nil] }
-        end
-
-        Futuroscope::Future.expects(:new).returns(stub(body: nil))
-
-        link._patch
-      end
-
-      describe 'when entry_point.options is set to { async: false }' do
-        it 'executes requests synchronously without futuroscope' do
-          entry_point.options = { async: false }
-
-          link = Link.new('key', { 'href' => '/productions/1' }, entry_point)
-
-          stub_request(entry_point.connection) do |stub|
-            stub.patch('http://api.example.org/productions/1') { [200, {}, nil] }
-          end
-
-          Futuroscope::Future.expects(:new).never
-
-          link._patch
-        end
+        _(link._patch).must_be_kind_of Resource
       end
     end
 
@@ -461,8 +265,8 @@ module Hyperclient
       it 'outputs a custom-friendly output' do
         link = Link.new('key', { 'href' => '/productions/1' }, 'foo')
 
-        link.inspect.must_include 'Link'
-        link.inspect.must_include '"href"=>"/productions/1"'
+        _(link.inspect).must_include 'Link'
+        _(link.inspect).must_include '"href"=>"/productions/1"'
       end
     end
 
@@ -475,8 +279,18 @@ module Hyperclient
             stub.get('http://api.example.org/orders') { [200, {}, { '_embedded' => { 'orders' => [{ 'id' => 1 }] } }] }
           end
 
-          resource.orders._embedded.orders.first.id.must_equal 1
-          resource.orders.first.id.must_equal 1
+          _(resource.orders._embedded.orders.first.id).must_equal 1
+          _(resource.orders.first.id).must_equal 1
+        end
+
+        it 'can handle false values in the response' do
+          resource = Resource.new({ '_links' => { 'orders' => { 'href' => '/orders' } } }, entry_point)
+
+          stub_request(entry_point.connection) do |stub|
+            stub.get('http://api.example.org/orders') { [200, {}, { 'any' => false }] }
+          end
+
+          _(resource.orders.any).must_equal false
         end
 
         it "doesn't delegate when link key doesn't match" do
@@ -486,8 +300,8 @@ module Hyperclient
             stub.get('http://api.example.org/orders') { [200, {}, { '_embedded' => { 'orders' => [{ 'id' => 1 }] } }] }
           end
 
-          resource.foos._embedded.orders.first.id.must_equal 1
-          resource.foos.first.must_equal nil
+          _(resource.foos._embedded.orders.first.id).must_equal 1
+          _(resource.foos.first).must_be_nil
         end
 
         it 'backtracks when navigating links' do
@@ -497,7 +311,7 @@ module Hyperclient
             stub.get('http://api.example.org/page2') { [200, {}, { '_links' => { 'next' => { 'href' => 'http://api.example.org/page3' } } }] }
           end
 
-          resource.next._links.next._url.must_equal 'http://api.example.org/page3'
+          _(resource.next._links.next._url).must_equal 'http://api.example.org/page3'
         end
       end
 
@@ -521,18 +335,18 @@ module Hyperclient
         end
 
         it 'raises an error when the method does not exist in the resource' do
-          lambda { link.this_method_does_not_exist }.must_raise NoMethodError
+          _(-> { link.this_method_does_not_exist }).must_raise NoMethodError
         end
 
         it 'responds to missing methods' do
           resource.expects(:respond_to?).with('orders').returns(false)
           resource.expects(:respond_to?).with('embedded').returns(true)
-          link.respond_to?(:embedded).must_equal true
+          _(link.respond_to?(:embedded)).must_equal true
         end
 
         it 'does not delegate to_ary to resource' do
           resource.expects(:to_ary).never
-          [[link, link]].flatten.must_equal [link, link]
+          _([[link, link]].flatten).must_equal [link, link]
         end
       end
     end