hyper-react 1.0.0.lap23 → 1.0.0.lap24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 86768c3348a431a1b97b43fddcced051f69aa697270ddc39baa5ebf249f4d0d6
-  data.tar.gz: 32a0527f8adef0613cf12b8eacbc805e832207fd2bc05cbc92d918aa41c3b97b
+  metadata.gz: f835a40b1580dca8202104593f6d2c8f68cbe342236850bab449d24e56691859
+  data.tar.gz: 85432b5f788b3860b518df213ff6f19744a431cbc7943d46713882ac0440c3aa
 SHA512:
-  metadata.gz: bcb9c31c77e0efae816a0a67a91c0fbc02f63ab06ea2e014e31f943aff6c15ccc8500d1eb5f1ccff30158d232a90f87ab089492395f76c93858fdb4127eb2f57
-  data.tar.gz: f53942a3396b92b43ddd7194e171ba759b5005d3fc31266714fa10d72af34fed92276ec1bcf4f69b870fae69c0b3101f080e2b3aab06c02b0190bdacd22e4fdf
+  metadata.gz: fb068dad9c84503247339c1205012f81385bc5460feb060bca396fa2886b2df5ab449a918c3dc70ee784b5d3b470c1c5bbe989e7f0fdffdf41481a1e91272529
+  data.tar.gz: 04f88e4453a78556bbdc8c2c66f0a3ffd490d08932c5279c6dd6373071847a122522eb2e445d2e37800b88613affb83fbdce3d7c1b1b1af425e8e9e3a1a04df9

data/lib/react/api.rb

@@ -71,7 +71,7 @@ module React
               this.__opalInstanceSyncSetState = true;
               this.__opalInstance.$component_will_mount();
               this.__opalInstanceSyncSetState = false;
-            }  
+            }
           }
           componentDidMount() {
             this.__opalInstance.is_mounted = true
@@ -171,6 +171,10 @@ module React
           props["className"] = value
         elsif ["style", "dangerously_set_inner_HTML"].include? key
           props[lower_camelize(key)] = value.to_n
+
+        elsif key == "key"
+          props["key"] = value.to_key
+          
         elsif key == 'ref' && value.is_a?(Proc)
           props[key] = %x{
                           function(dom_node){

data/lib/react/callbacks.rb

@@ -1,5 +1,5 @@
 require 'hyperloop-config'
-Hyperloop::Context
+
 module React
   module Callbacks
     def self.included(base)

data/lib/react/object.rb

@@ -12,4 +12,19 @@ class Object
       React::Component::Tags.html_tag_class_for(const_name) || raise(e)
     end
   end
+
+  def to_key
+    object_id
+  end
+end
+class Number
+  def to_key
+    self
+  end
+end
+
+class Boolean
+  def to_key
+    self
+  end
 end

data/lib/reactive-ruby/version.rb

@@ -1,3 +1,3 @@
 module React
-  VERSION = '1.0.0.lap23'
+  VERSION = '1.0.0.lap24'
 end

data/spec/react/opal_jquery_extensions_spec.rb

@@ -2,26 +2,29 @@ require 'spec_helper'
 
 describe 'opal-jquery extensions', js: true do
   describe 'Element' do
-    xit 'will reuse the wrapper componet class for the same Element' do
-      # TODO how come a def component_will_unmount will not be received
-      stub_const 'Foo', Class.new(React::Component::Base)
-      Foo.class_eval do
-        param :name
-        def render
-          "hello #{params.name}"
-        end
-
-        def component_will_unmount
+    xit 'will reuse the wrapper component class for the same Element' do
+      evaluate_ruby do
+        class Foo < React::Component::Base
+          param :name
+          def render
+            "hello #{params.name}"
+          end
 
+          def self.rec_cnt
+            @@rec_cnt ||= 0
+          end
+          before_unmount do
+            @@rec_cnt ||= 0
+            @@rec_cnt += 1
+          end
         end
       end
-
-      expect_any_instance_of(Foo).to_not receive(:component_will_unmount)
-
-      test_div = Element.new(:div)
-      test_div.render { Foo(name: 'fred') }
-      test_div.render { Foo(name: 'freddy') }
-      expect(Element[test_div].find('span').html).to eq('hello freddy')
+      expect_evaluate_ruby do
+        test_div = Element.new(:div)
+        test_div.render { Foo(name: 'fred') }
+        test_div.render { Foo(name: 'freddy') }
+        [ Element[test_div].find('span').html, Foo.rec_cnt]
+      end.to eq(['hello freddy', 0])
     end
 
     it 'renders a top level component using render with a block' do

data/spec/react/to_key_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe 'to_key helper', js: true do
+  it "has added 'to_key' method to Object and each key is different" do
+    expect_evaluate_ruby do
+      Object.new.to_key != Object.new.to_key
+    end.to be_truthy
+  end
+
+  it "to_key return 'self' for String objects" do
+    expect_evaluate_ruby do
+      debugger
+      "hello".to_key == "hello"
+    end.to be_truthy
+  end
+
+  it "to_key return 'self' for Number objects" do
+    expect_evaluate_ruby do
+      12.to_key == 12
+    end.to be_truthy
+  end
+
+  it "to_key return 'self' for Boolean objects" do
+    expect_evaluate_ruby do
+      true.to_key == true && false.to_key == false
+    end.to be_truthy
+  end
+  
+  it "will use the use the to_key method to get the react key" do
+    mount "TestComponent" do
+      class MyTestClass
+        attr_reader :to_key_called
+        def to_key
+          @to_key_called = true
+          super
+        end
+      end
+      class TestComponent < Hyperloop::Component
+        before_mount { @test_object = MyTestClass.new }
+        render do
+          DIV(key: @test_object) { TestComponent2(test_object: @test_object) }
+        end
+      end
+      class TestComponent2 < Hyperloop::Component
+        param :test_object
+        render do
+          "to key was called!" if params.test_object.to_key_called
+        end
+      end
+    end
+    expect(page).to have_content('to key was called!')
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hyper-react
 version: !ruby/object:Gem::Version
-  version: 1.0.0.lap23
+  version: 1.0.0.lap24
 platform: ruby
 authors:
 - David Chang
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-18 00:00:00.000000000 Z
+date: 2018-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hyper-store
@@ -19,14 +19,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0.lap23
+        version: 1.0.0.lap24
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0.lap23
+        version: 1.0.0.lap24
 - !ruby/object:Gem::Dependency
   name: opal
   requirement: !ruby/object:Gem::Requirement
@@ -81,14 +81,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0.lap23
+        version: 1.0.0.lap24
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0.lap23
+        version: 1.0.0.lap24
 - !ruby/object:Gem::Dependency
   name: jquery-rails
   requirement: !ruby/object:Gem::Requirement
@@ -430,6 +430,7 @@ files:
 - spec/react/test/rspec_spec.rb
 - spec/react/test/session_spec.rb
 - spec/react/test/utils_spec.rb
+- spec/react/to_key_spec.rb
 - spec/react/top_level_component_spec.rb
 - spec/react/tutorial/tutorial_spec.rb
 - spec/react/validator_spec.rb
@@ -555,6 +556,7 @@ test_files:
 - spec/react/test/rspec_spec.rb
 - spec/react/test/session_spec.rb
 - spec/react/test/utils_spec.rb
+- spec/react/to_key_spec.rb
 - spec/react/top_level_component_spec.rb
 - spec/react/tutorial/tutorial_spec.rb
 - spec/react/validator_spec.rb