hydra-remote_identifier 0.6.6 → 0.6.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2fcf10674f5f9e20c6ea4147a6b9aec719cc98c3
-  data.tar.gz: 327fc545d8bd8578916d3af5d6626a3275c644c3
+  metadata.gz: 4125473c39c8033862e28720835d14d0c8baebae
+  data.tar.gz: 27620bdaca103694e3b6439b359ad2794668704f
 SHA512:
-  metadata.gz: 0593100d48e273621c9a25f121f752538ca86aec27c58549225958b665db77e395f4d09c29373505029f5e162569a31bba9d993becdad1c0da425e318abe0eb1
-  data.tar.gz: 768422a4cced4fc06c85a204fd32a910bb0a85fd862e60f3c8f1ac46050db44a6376bb29e3ca25e7a7421e6e0108f6a0968e79014bd832dab82e484a1192f24e
+  metadata.gz: b1efd34aabe1c1cc5eb4863aa1130e57c292aa813cc067bf551396cf41370265b737a131094e3c579f4190d6220d07638b494964a7cc51d6534c423735181264
+  data.tar.gz: e077fcde38e2d162b04857357805cc9821676b2d8abc82184902b8f80bc8198e5aa45aea0829c2ca1de0d4cbca27cfb65e4f2e1f4a9b8a06b6cd59e3ee1e75d6

data/hydra-remote_identifier.gemspec

@@ -23,5 +23,5 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency 'rspec', "~>2.99"
+  spec.add_development_dependency 'rspec', "~>2.14"
 end

data/lib/hydra/remote_identifier/remote_services/doi.rb

@@ -1,6 +1,7 @@
 require 'uri'
 require 'rest_client'
 require 'hydra/remote_identifier/remote_service'
+require 'hydra/remote_identifier/exceptions'
 require 'active_support/core_ext/hash/indifferent_access'
 
 module Hydra::RemoteIdentifier
@@ -25,8 +26,15 @@ module Hydra::RemoteIdentifier
         @resolver_url = configuration.fetch(:resolver_url) { default_resolver_url }
       end
 
+      def normalize_identifier(value)
+        value.to_s.strip.
+          sub(/\A#{resolver_url}/, '').
+          sub(/\A\s*doi:\s+/, 'doi:').
+          sub(/\A(\d)/, 'doi:\1')
+      end
+
       def remote_uri_for(identifier)
-        URI.parse(File.join(resolver_url, identifier))
+        URI.parse(File.join(resolver_url, normalize_identifier(identifier)))
       end
 
       REQUIRED_ATTRIBUTES = ['target', 'creator', 'title', 'publisher', 'publicationyear' ].freeze

data/lib/hydra/remote_identifier/version.rb

@@ -1,5 +1,5 @@
 module Hydra
   module RemoteIdentifier
-    VERSION = "0.6.6"
+    VERSION = "0.6.7"
   end
 end

data/spec/lib/hydra/remote_identifier/remote_services/doi_spec.rb

@@ -21,6 +21,18 @@ module Hydra::RemoteIdentifier
       }
       subject { RemoteServices::Doi.new(configuration) }
 
+      context '#normalize_identifier' do
+        [
+          ['doi: 10.6017/ital.v28i2.3177', 'doi:10.6017/ital.v28i2.3177'],
+          ['10.6017/ital.v28i2.3177', 'doi:10.6017/ital.v28i2.3177'],
+          [ RemoteServices::Doi::TEST_CONFIGURATION.fetch(:resolver_url) + '10.6017/ital.v28i2.3177', 'doi:10.6017/ital.v28i2.3177']
+        ].each_with_index do |(input, expected), index|
+          it "scenario ##{index}" do
+            expect(subject.normalize_identifier(input)).to eq(expected)
+          end
+        end
+      end
+
       context '.call' do
         it 'should post to remote service', VCR::SpecSupport(cassette_name: 'doi-create') do
           expect(subject.call(payload)).to eq(expected_doi)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hydra-remote_identifier
 version: !ruby/object:Gem::Version
-  version: 0.6.6
+  version: 0.6.7
 platform: ruby
 authors:
 - Jeremy Friesen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-23 00:00:00.000000000 Z
+date: 2014-08-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -78,14 +78,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.99'
+        version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.99'
+        version: '2.14'
 description: Handles the registration and minting of remote identifiers (i.e. DOI,
   ARK, ORCID)
 email: