hydra-remote_identifier 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 99922dd154a6430c8dd64418d60db843a3f1082a
-  data.tar.gz: 0e6d029a6ae54490e3d5b6270469eb6a4ee57932
+  metadata.gz: 6ac8dc0f0b85926cf288ac03f12db9d73214dd6c
+  data.tar.gz: 3c4ae6364a1f553290673f61bbb2eb22eaafd514
 SHA512:
-  metadata.gz: f22cacf89302908db05f330156f84f9a4145881b113ae1571e3e92338d3e8456e91b550af7860a53a74e39e9ab13f45ce7c05ad6ca3d02d11f968e405fcfd47f
-  data.tar.gz: 234cbd5325b35472d2d003f22bf5bc6ed3527b397548777cc643a5baaf7f29465962eab419dc808f1189fa09015cb88964829245af6c9ea875da4ad49e8c5e29
+  metadata.gz: 252283bc9042efb903196966abb512d0dca158bb879f31f7774fd0849687af7a9e0e1157d57b9d7809ad3f799c01891cecba1aa6ad1c5bf3ecb3e2abd594b51e
+  data.tar.gz: c283ff802068b8eb57cc5a52d5a13d4dcc32997f8682c3b56eb5d1452c727dd161191dbacb169cb904e85d87438847d97e6687121ca9f562684fec3550190eda

data/lib/hydra/remote_identifier/exceptions.rb

@@ -4,4 +4,43 @@ module Hydra::RemoteIdentifier
       super(errors.join(". ") << '.')
     end
   end
+
+  class RemoteServiceError < RuntimeError
+    def initialize(exception, uri, payload)
+      @exception = exception
+      @uri = uri
+      @payload = payload
+    end
+
+    def to_s
+      text = ""
+      text << "response.code: #{response_code.inspect}\n"
+      text << "response.body: #{response_body.inspect}\n"
+      text << "\n"
+      text << "request.uri: #{request_sanitized_uri.inspect}\n"
+      text << "request.payload: #{request_sanitized_paylod.inspect}\n"
+    end
+
+    private
+    def request_sanitized_paylod
+      @payload
+    end
+
+    def request_sanitized_uri
+      uri = URI.parse(@uri.to_s)
+      x = "#{uri.scheme}://"
+      x << "xxx:xxx@" if uri.user || uri.password
+      x << File.join(uri.host, uri.path)
+      x << '?' << uri.query if uri.query
+      x
+    end
+
+    def response_code
+      @exception.http_code rescue NoMethodError @exception.to_s
+    end
+
+    def response_body
+      @exception.http_body rescue NoMethodError 'unknown'
+    end
+  end
 end

data/lib/hydra/remote_identifier/remote_services/doi.rb

@@ -49,6 +49,8 @@ module Hydra::RemoteIdentifier
         response = RestClient.post(uri_for_create.to_s, data, content_type: 'text/plain')
         matched_data = /\Asuccess:(.*)(?<doi>doi:[^\|]*)(.*)\Z/.match(response.body)
         matched_data[:doi].strip
+      rescue RestClient::Exception => e
+        raise(RemoteServiceError.new(e, uri_for_create, payload))
       end
 
       def data_for_create(payload)

data/lib/hydra/remote_identifier/version.rb

@@ -1,5 +1,5 @@
 module Hydra
   module RemoteIdentifier
-    VERSION = "0.6.0"
+    VERSION = "0.6.1"
   end
 end

data/spec/lib/hydra/remote_identifier/exceptions_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+require File.expand_path('../../../../../lib/hydra/remote_identifier/exceptions', __FILE__)
+module Hydra::RemoteIdentifier
+  describe RemoteServiceError do
+    let(:payload) { "This is my payload!" }
+    let(:uri) { URI.parse('http://username:password@hello-world.com/path/to/resource?show=1') }
+    let(:exception) { double(http_code: '400 Bad Request', http_body: 'This is the raw response') }
+    subject { RemoteServiceError.new(exception, uri, payload) }
+
+    let(:expected_message) {
+      x = []
+      x << 'response.code: "400 Bad Request"'
+      x << 'response.body: "This is the raw response"'
+      x << ''
+      x << 'request.uri: "http://xxx:xxx@hello-world.com/path/to/resource?show=1"'
+      x << 'request.payload: "This is my payload!"'
+      x << ''
+      x.join("\n")
+    }
+
+    its(:to_s) { should eq(expected_message) }
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hydra-remote_identifier
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Jeremy Friesen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-15 00:00:00.000000000 Z
+date: 2013-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -121,6 +121,7 @@ files:
 - spec/fixtures/cassettes/doi-create.yml
 - spec/fixtures/cassettes/doi-integration.yml
 - spec/lib/hydra/remote_identifier/configuration_spec.rb
+- spec/lib/hydra/remote_identifier/exceptions_spec.rb
 - spec/lib/hydra/remote_identifier/mapper_spec.rb
 - spec/lib/hydra/remote_identifier/minter_spec.rb
 - spec/lib/hydra/remote_identifier/minting_coordinator_spec.rb
@@ -158,6 +159,7 @@ test_files:
 - spec/fixtures/cassettes/doi-create.yml
 - spec/fixtures/cassettes/doi-integration.yml
 - spec/lib/hydra/remote_identifier/configuration_spec.rb
+- spec/lib/hydra/remote_identifier/exceptions_spec.rb
 - spec/lib/hydra/remote_identifier/mapper_spec.rb
 - spec/lib/hydra/remote_identifier/minter_spec.rb
 - spec/lib/hydra/remote_identifier/minting_coordinator_spec.rb