hydra-remote_identifier 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 10836a31b160f5f0061cb2d18a6ccce899434f52
-  data.tar.gz: feb33ac8e38e21c1bc001207d17ce834ef4c620e
+  metadata.gz: 00609ca00a1aa3d266e11024d3e68b755716d609
+  data.tar.gz: d9fcb87871a336c9850fd913585296cc75951200
 SHA512:
-  metadata.gz: b7cc709cba8c837303e438c6b71d369a49eb995ba17023dbef89f9814be236f59de0aa7decbf930541590cc6283da0781b9952267bcab1e8d5b21f4ff24d03ae
-  data.tar.gz: e7181ea4930d62f5c83c6886d49903c2566ead86ac600b615d8040749347bb809de0edf95673d053f38fb2125e9071c5a15d3e58f43c3b9989a7a27b1ed94153
+  metadata.gz: cbfdc77f38b4d7031246bd72e525701cb2888882f304bc376800d76bb52e1fec61890f9941e60ec61567bb4e92749cca9928e458d85170b49e9c30faf0fff203
+  data.tar.gz: 56fd2f04082c9b23390e900e07ef27273053c955a4ded0c0b9bf5c938173fab3fbc99d5fef7085ff656d6a23a5103708c3ce2ad4fe6cf44227fcf277e8a23d3f

data/lib/hydra/remote_identifier.rb

@@ -31,6 +31,20 @@ module Hydra::RemoteIdentifier
       yield(configuration)
     end
 
+    # @example
+    #     Hydra::RemoteIdentifier.with_registered_remote_service(:doi, book) do |remote_service|
+    #       Hydra::RemoteIdentifier.mint(:doi, book)
+    #     end
+    def with_registered_remote_service(service_name, target)
+      # @TODO - the registered remote identifier is more than a bit off;
+      # but it continues to work
+      target.registered_remote_identifier_minters.each {|minter|
+        if minter.remote_service.name.to_s == service_name.to_s
+          yield(minter.remote_service)
+        end
+      }
+    end
+
     # Using the RemoteService mint the corresponding remote identifier for
     # the target. You must first configure the RemoteService and target's class
     # to define the attribute map. See Hydra::RemoteIdentifier.configure

data/lib/hydra/remote_identifier/registration.rb

@@ -24,8 +24,11 @@ module Hydra::RemoteIdentifier
     private
 
     def register_target(target_class, &map)
-      unless target_class.respond_to?(:registered_remote_identifier_minters)
-        target_class.class_attribute :registered_remote_identifier_minters
+      target_class.module_exec(remote_service) do |service|
+        unless target_class.respond_to?(:registered_remote_identifier_minters)
+          class_attribute :registered_remote_identifier_minters
+        end
+        attr_accessor service.accessor_name
       end
       target_class.registered_remote_identifier_minters ||= []
       target_class.registered_remote_identifier_minters += [minting_coordinator.new(remote_service, &map)]

data/lib/hydra/remote_identifier/remote_service.rb

@@ -1,3 +1,4 @@
+require 'active_support/core_ext/string/inflections'
 module Hydra::RemoteIdentifier
 
   # The RemoteService is responsible for delivering a payload to a remote
@@ -7,6 +8,14 @@ module Hydra::RemoteIdentifier
   # payload.
   class RemoteService
 
+    def name
+      self.class.to_s.demodulize.underscore.to_sym
+    end
+
+    def accessor_name
+      "mint_#{name}".to_sym
+    end
+
     def valid_attribute?(attribute_name)
       raise NotImplementedError,
         "You must implement #{self.class}#valid_attribute?"

data/lib/hydra/remote_identifier/version.rb

@@ -1,5 +1,5 @@
 module Hydra
   module RemoteIdentifier
-    VERSION = "0.2.1"
+    VERSION = "0.2.2"
   end
 end

data/spec/lib/hydra/remote_identifier/registration_spec.rb

@@ -4,16 +4,27 @@ module Hydra::RemoteIdentifier
   describe Registration do
     let(:minting_coordinator) { double(new: :minting_coordinator) }
     let(:target_class) { Class.new }
+    let(:remote_service) { double(accessor_name: :mint_my_remote_service) }
     let(:map) { lambda {|m| m.title :title } }
-    subject { Registration.new(:my_remote_service, minting_coordinator) }
+    subject { Registration.new(remote_service, minting_coordinator) }
+
     it 'requires a map' do
       expect { subject.register(target_class) }.to raise_error(RuntimeError)
     end
+
     it 'adds a .registered_remote_identifier_minters method' do
       expect {
         subject.register(target_class, &map)
       }.to change{ target_class.respond_to?(:registered_remote_identifier_minters) }.from(false).to(true)
     end
+
+    it 'adds a #mint_remote_service attribute' do
+      subject.register(target_class, &map)
+      target = target_class.new
+      expect(target).to respond_to(:mint_my_remote_service)
+      expect(target).to respond_to(:mint_my_remote_service=)
+    end
+
     it 'registers the minting coordinator on the target class' do
       subject.register(target_class, &map)
       expect(target_class.registered_remote_identifier_minters).to eq [:minting_coordinator]

data/spec/lib/hydra/remote_identifier/remote_service_spec.rb

@@ -7,6 +7,9 @@ module Hydra::RemoteIdentifier
     let(:payload) { 'abc' }
     subject { RemoteService.new }
 
+    its(:name) { should eq :remote_service }
+    its(:accessor_name) { should eq :mint_remote_service }
+
     context '#call' do
       it { expect { subject.call(payload) }.to raise_error NotImplementedError }
     end

data/spec/lib/hydra/remote_identifier_spec.rb

@@ -2,7 +2,21 @@ require 'spec_helper'
 require File.expand_path('../../../../lib/hydra/remote_identifier', __FILE__)
 module Hydra::RemoteIdentifier
 
-  describe '.configure' do
+  describe 'public API' do
+    before(:each) do
+      Hydra::RemoteIdentifier.configure do |config|
+        config.remote_service(:doi, doi_options) do |doi|
+          doi.register(target_class) do |map|
+            map.target :url
+            map.creator :creator
+            map.title :title
+            map.publisher :publisher
+            map.publicationyear :publicationyear
+            map.set_identifier(:set_identifier=)
+          end
+        end
+      end
+    end
 
     let(:target_class) {
       Class.new {
@@ -31,23 +45,18 @@ module Hydra::RemoteIdentifier
       }
     }
 
-    describe '.register API' do
-
-      before(:each) do
-        Hydra::RemoteIdentifier.configure do |config|
-          config.remote_service(:doi, doi_options) do |doi|
-            doi.register(target_class) do |map|
-              map.target :url
-              map.creator :creator
-              map.title :title
-              map.publisher :publisher
-              map.publicationyear :publicationyear
-              map.set_identifier(:set_identifier=)
-            end
-          end
-        end
+    describe '.with_remote_service' do
+
+      it 'should yield the service if one is registered' do
+        expect {|block|
+          Hydra::RemoteIdentifier.with_registered_remote_service(:doi, target, &block)
+        }.to yield_with_args(RemoteServices::Doi)
       end
 
+    end
+
+    describe '.register' do
+
       it 'works!', VCR::SpecSupport.merge(record: :new_episodes, cassette_name: 'doi-integration') do
         expect {
           Hydra::RemoteIdentifier.mint(:doi, target)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hydra-remote_identifier
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Jeremy Friesen