hydra-remote_identifier 0.0.3 → 0.2.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: c555e2e358d784219f8aeae86457d9a456410470
+  data.tar.gz: 1e6e8f346332a2692a6c04001837cb18ca3ef6db
+SHA512:
+  metadata.gz: 8ce31c0525b6c307bcebc30f9a227a87d047ad76da1a872c3a5454b900d2081f5aeedd67a0126bed876cba6337d0ec1efee78086f487c5a9377198b7fd68bd54
+  data.tar.gz: 8379665c7d8f1a022a3e09bf3f7ef4ed4fa126caebda959325f2585c437e3e4eb68ddb4c149e004f8c7b813997f404ee670ee56fa120d4e1b9b41e4f8bfc0c79

data/Gemfile

@@ -6,4 +6,11 @@ gemspec
 group :test do
   gem 'guard-rspec'
   gem 'ruby_gntp'
+  gem 'vcr'
+  gem 'webmock'
+end
+
+group :doc do
+  gem 'yard'
+  gem 'redcarpet'
 end

data/README.md

@@ -19,11 +19,18 @@ Or install it yourself as:
 
 ## Usage
 
-In your `./config/initializers` add a file that registers remote identification
-services for a list of models.
-
-    Hydra::RemoteIdentifier.register(:doi, Book) do |map|
-      map.what  {|book| book.title + ": " book.subtitle }
-      map.who   :author_name
-      map.set_identifier {|book, value| book.set_doi!(value)}
+Configure your remote identifiers with credentials and what have you:
+
+    doi_credentials = Psych.load('/path/to/doi_credentials.yml')
+    Hydra::RemoteIdentifier.configure do |config|
+      config.configure_remote_service(:doi, doi_credentials) do |doi|
+        doi.register(target_class) do |map|
+          map.target :url
+          map.creator :creator
+          map.title :title
+          map.publisher :publisher
+          map.publicationyear :publicationyear
+          map.set_identifier(:set_identifier=)
+        end
+      end
     end

data/hydra-remote_identifier.gemspec

@@ -19,10 +19,9 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency 'activesupport', '>= 3.2.13', '< 5.0'
+  spec.add_dependency 'rest-client', '~> 1.6.7'
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'yard'
-  spec.add_development_dependency 'redcarpet'
 end

data/lib/hydra/remote_identifier.rb

@@ -1,50 +1,34 @@
 require "hydra/remote_identifier/version"
+require 'hydra/remote_identifier/configuration'
 require 'hydra/remote_identifier/registration'
 require 'hydra/remote_identifier/remote_service'
-require 'hydra/remote_identifier/remote_services'
 
 module Hydra::RemoteIdentifier
 
   class << self
 
-    # For the given :remote_service_name and :target_classes register the Map
-    # to use for minting a remote identifier for instances of the
-    # :target_classes
+    # Used for configuring available RemoteService and any additional
+    # initialization requirements for those RemoteServices (i.e. credentials)
     #
     # @example
-    #     Hydra::RemoteIdentifier.register(:doi, Book) do |map|
-    #       map.what  {|book| book.title + ": " book.subtitle }
-    #       map.who   :author_name
-    #       map.set_identifier {|book, value| book.set_doi!(value)}
+    #     Hydra::RemoteIdentifier.configure do |config|
+    #       config.configure_remote_service(:doi, doi_credentials) do |doi|
+    #         doi.register(target_class) do |map|
+    #           map.target :url
+    #           map.creator :creator
+    #           map.title :title
+    #           map.publisher :publisher
+    #           map.publicationyear :publicationyear
+    #           map.set_identifier(:set_identifier=)
+    #         end
+    #       end
     #     end
     #
-    # @param remote_service_name [#to_s] the name of a remote service we will
-    #   use to mint the corresponding remote identifier
-    # @param target_classes [Array<Class>] a collection of classes who's
-    #   instances to which we will assign a remote identifier
-    # @yieldparam map [Map] defines what attributes are required by the
-    #   :remote_service as well as what the callback for what the
-    #   :remote_resource should do (see Mapper::Wrapper)
-    def register(remote_service_name, *target_classes, &map)
-      Array(target_classes).flatten.compact.each do |target_class|
-        Registration.new(remote_service(remote_service_name), target_class, &map)
-      end
-    end
-
-
-    # Given a string retrieve an instance of the corresponding RemoteService.
-    # @param string [#to_s]
-    # @return [RemoteService]
-    def remote_service(string)
-      namespace_for_lookup = RemoteServices
-      remote_service_class_name = string.to_s.gsub(/(?:^|_)([a-z])/) { $1.upcase }
-      if namespace_for_lookup.const_defined?(remote_service_class_name)
-        namespace_for_lookup.const_get(remote_service_class_name).new
-      else
-        raise NotImplementedError.new(
-          "Unable to find #{self} remote_service '#{string}'. Consider creating #{namespace_for_lookup}::#{remote_service_class_name}"
-        )
-      end
+    # @yieldparam config [Configuration]
+    attr_accessor :configuration
+    def configure
+      self.configuration ||= Configuration.new
+      yield(configuration)
     end
 
   end

data/lib/hydra/remote_identifier/configuration.rb

@@ -0,0 +1,46 @@
+require File.expand_path('../remote_services', __FILE__)
+
+module Hydra::RemoteIdentifier
+
+  # Configuration is responsible for exposing the available RemoteServices
+  # and configuring those RemoteServices.
+  class Configuration
+
+    def initialize(options = {})
+      @remote_service_namespace_container = options.fetch(:remote_service_namespace_container, Hydra::RemoteIdentifier::RemoteServices)
+      @remote_services = {}
+    end
+    attr_reader :remote_service_namespace_container
+    private :remote_service_namespace_container
+    attr_reader :remote_services
+
+    def find_remote_service(service_name)
+      remote_services.fetch(service_name, remote_service_class_lookup(service_name).new)
+    end
+
+    def remote_service(service_name, *args, &block)
+      remote_service_class_lookup(service_name).configure(*args, &block)
+    end
+
+    def configure_remote_service(service_name, *args, &block)
+      remote_service = remote_service_class_lookup(service_name).new(*args)
+      remote_services[service_name]
+      yield(Registration.new(remote_service))
+      remote_service
+    end
+
+    private
+
+    def remote_service_class_lookup(string)
+      remote_service_class_name = string.to_s.gsub(/(?:^|_)([a-z])/) { $1.upcase }
+      if remote_service_namespace_container.const_defined?(remote_service_class_name)
+        remote_service_namespace_container.const_get(remote_service_class_name)
+      else
+        raise NotImplementedError.new(
+          "Unable to find #{self} remote_service '#{string}'. Consider creating #{remote_service_namespace_container}::#{remote_service_class_name}"
+        )
+      end
+    end
+  end
+
+end

data/lib/hydra/remote_identifier/mapper.rb

@@ -2,10 +2,19 @@ require File.expand_path('../exceptions', __FILE__)
 
 module Hydra::RemoteIdentifier
 
-  # Registry is responsible for associating a model with a set of remote services and defining the attribute map
-  # The Mapper is responsible for transforming a target, via a Map, into an acceptable format for a Minter
+  # The Mapper is responsible for transforming a target, via a Map, into an
+  # acceptable format for a Minter
   class Mapper
 
+    attr_reader :map
+    def initialize(service_class, map_builder = Map, &mapping_block)
+      @map = map_builder.new(service_class, &mapping_block)
+    end
+
+    def call(target, wrapper_builder = Wrapper)
+      wrapper_builder.new(map, target)
+    end
+
     # The Wrapper provides the getting and setting behavior for a target based on a Map
     class Wrapper
       attr_reader :map, :target
@@ -33,7 +42,7 @@ module Hydra::RemoteIdentifier
           target.send(setter, value)
         elsif setter.is_a?(Hash)
           datastream = setter.fetch(:at)
-          field = setter.fetch(:in, scheme)
+          field = setter.fetch(:in)
           target.datastreams["#{datastream}"].send("#{field}=", value)
         end
       end
@@ -83,15 +92,6 @@ module Hydra::RemoteIdentifier
       end
     end
 
-    attr_reader :map
-    def initialize(service_class, map_builder = Map, &mapping_block)
-      @map = map_builder.new(service_class, &mapping_block)
-    end
-
-    def call(target, wrapper_builder = Wrapper)
-      wrapper_builder.new(map, target)
-    end
-
   end
 
 end

data/lib/hydra/remote_identifier/registration.rb

@@ -3,16 +3,32 @@ require File.expand_path('../minting_coordinator', __FILE__)
 
 module Hydra::RemoteIdentifier
 
-  # The Registration is responsible for connecting a RemoteService, a Target
+  # The Registration is responsible for connecting a RemoteService and a Target
   # to a particular Map
   class Registration
-    def initialize(service_class, target_class, minting_coordinator = MintingCoordinator, &map)
+    attr_reader :remote_service, :minting_coordinator
+    def initialize(remote_service, minting_coordinator = MintingCoordinator, &map)
+      @remote_service = remote_service
+      @minting_coordinator = minting_coordinator
+    end
+
+    def register(*target_classes, &map)
       if map.nil?
-        raise RuntimeError, "You attempted to register the remote service #{service_class} for #{target_class} without a map"
+        raise RuntimeError, "You attempted to register the remote service #{remote_service} for #{target_classes} without a map"
+      end
+      Array(target_classes).flatten.compact.each {|target_class|
+        register_target(target_class, &map)
+      }
+    end
+
+    private
+
+    def register_target(target_class, &map)
+      unless target_class.respond_to?(:registered_remote_identifier_minters)
+        target_class.class_attribute :registered_remote_identifier_minters
       end
-      target_class.class_attribute :registered_remote_identifier_minters unless target_class.respond_to?(:registered_remote_identifier_minters)
       target_class.registered_remote_identifier_minters ||= []
-      target_class.registered_remote_identifier_minters += [minting_coordinator.new(service_class, &map)]
+      target_class.registered_remote_identifier_minters += [minting_coordinator.new(remote_service, &map)]
     end
   end
 

data/lib/hydra/remote_identifier/remote_services.rb

@@ -1,5 +1 @@
-module Hydra::RemoteIdentifier
-  module RemoteServices
-    # For namespace
-  end
-end
+require 'hydra/remote_identifier/remote_services/doi'

data/lib/hydra/remote_identifier/remote_services/doi.rb

@@ -0,0 +1,51 @@
+require 'uri'
+require 'rest_client'
+require 'hydra/remote_identifier/remote_service'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module Hydra::RemoteIdentifier
+  module RemoteServices
+    class Doi < Hydra::RemoteIdentifier::RemoteService
+
+      attr_reader :uri
+      def initialize(configuration = {})
+        username = configuration.fetch(:username)
+        password = configuration.fetch(:password)
+        shoulder = configuration.fetch(:shoulder)
+        url = configuration.fetch(:url)
+
+        # This is specific for the creation of DOIs
+        @uri = URI.parse(File.join(url, 'shoulder', shoulder))
+        @uri.user = username
+        @uri.password = password
+      end
+
+      REQUIRED_ATTRIBUTES = ['target', 'creator', 'title', 'publisher', 'publicationyear' ].freeze
+      def valid_attribute?(attribute_name)
+        REQUIRED_ATTRIBUTES.include?(attribute_name.to_s)
+      end
+
+      def call(payload)
+        request(data_for_create(payload.with_indifferent_access))
+      end
+
+      private
+
+      def request(data)
+        response = RestClient.post(uri.to_s, data, content_type: 'text/plain')
+        matched_data = /\Asuccess:(.*)(?<doi>doi:[^\|]*)(.*)\Z/.match(response.body)
+        matched_data[:doi].strip
+      end
+
+      def data_for_create(payload)
+        [
+          "_target: #{payload.fetch(:target)}",
+          "datacite.creator: #{payload.fetch(:creator)}",
+          "datacite.title: #{payload.fetch(:title)}",
+          "datacite.publisher: #{payload.fetch(:publisher)}",
+          "datacite.publicationyear: #{payload.fetch(:publicationyear)}"
+        ].join("\n")
+      end
+    end
+  end
+end

data/lib/hydra/remote_identifier/version.rb

@@ -1,5 +1,5 @@
 module Hydra
   module RemoteIdentifier
-    VERSION = "0.0.3"
+    VERSION = "0.2.0"
   end
 end

data/spec/fixtures/cassettes/doi-create.yml

@@ -0,0 +1,47 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://apitest:apitest@n2t.net/ezid/shoulder/doi:10.5072/FK2
+    body:
+      encoding: UTF-8
+      string: |-
+        _target: http://google.com
+        datacite.creator: Jeremy Friesen
+        datacite.title: My Article
+        datacite.publisher: Me Myself and I
+        datacite.publicationyear: 2013
+    headers:
+      Accept:
+      - '*/*; q=0.5, application/xml'
+      Accept-Encoding:
+      - gzip, deflate
+      Content-Type:
+      - text/plain
+      Content-Length:
+      - '153'
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 201
+      message: CREATED
+    headers:
+      Date:
+      - Thu, 03 Oct 2013 17:50:51 GMT
+      Server:
+      - Apache/2.2.17 (Unix) DAV/2 mod_wsgi/3.3 Python/2.7 mod_ssl/2.2.17 OpenSSL/0.9.8o
+      Vary:
+      - Cookie
+      Set-Cookie:
+      - sessionid=649cfcff023c40d4c8f1420673837ae6; Path=/ezid/
+      Content-Length:
+      - '53'
+      Content-Type:
+      - text/plain; charset=UTF-8
+    body:
+      encoding: UTF-8
+      string: 'success: doi:10.5072/FK23J3QV8 | ark:/b5072/fk23j3qv8'
+    http_version: 
+  recorded_at: Thu, 03 Oct 2013 17:50:54 GMT
+recorded_with: VCR 2.6.0

data/spec/fixtures/cassettes/doi-integration.yml

@@ -0,0 +1,47 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://apitest:apitest@n2t.net/ezid/shoulder/doi:10.5072/FK2
+    body:
+      encoding: UTF-8
+      string: |-
+        _target: http://google.com
+        datacite.creator: my creator
+        datacite.title: my title
+        datacite.publisher: my publisher
+        datacite.publicationyear: 2013
+    headers:
+      Accept:
+      - '*/*; q=0.5, application/xml'
+      Accept-Encoding:
+      - gzip, deflate
+      Content-Type:
+      - text/plain
+      Content-Length:
+      - '144'
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 201
+      message: CREATED
+    headers:
+      Date:
+      - Thu, 03 Oct 2013 19:10:22 GMT
+      Server:
+      - Apache/2.2.17 (Unix) DAV/2 mod_wsgi/3.3 Python/2.7 mod_ssl/2.2.17 OpenSSL/0.9.8o
+      Vary:
+      - Cookie
+      Set-Cookie:
+      - sessionid=995dadb966d7013e9251daf61b6122ba; Path=/ezid/
+      Content-Length:
+      - '53'
+      Content-Type:
+      - text/plain; charset=UTF-8
+    body:
+      encoding: UTF-8
+      string: 'success: doi:10.5072/FK2FT8XZZ | ark:/b5072/fk2ft8xzz'
+    http_version: 
+  recorded_at: Thu, 03 Oct 2013 19:10:25 GMT
+recorded_with: VCR 2.6.0

data/spec/lib/hydra/remote_identifier/configuration_spec.rb

@@ -0,0 +1,48 @@
+require File.expand_path('../../../../../lib/hydra/remote_identifier/configuration', __FILE__)
+
+module Hydra::RemoteIdentifier
+
+  describe Configuration do
+    around do |example|
+      module RemoteServices
+        class MyRemoteService
+          class << self
+            attr_reader :options
+            def configure(*args, &block)
+              @options = [args, block]
+            end
+          end
+        end
+      end
+      example.run
+      RemoteServices.send(:remove_const, :MyRemoteService)
+    end
+
+    subject { Configuration.new }
+
+    context 'with a missing service' do
+      specify do
+        expect { subject.remote_service(:obviously_missing_service) }.to raise_error(NotImplementedError)
+      end
+      specify do
+        expect {
+          subject.find_remote_service(:obviously_missing_service)
+        }.to raise_error(NotImplementedError)
+      end
+    end
+
+    context 'with an existing service' do
+      let(:block) { lambda {} }
+      specify do
+        expect {
+          subject.remote_service(:my_remote_service, :arg, &block)
+        }.to change(RemoteServices::MyRemoteService, :options).from(nil).to([[:arg], block])
+      end
+      specify do
+        expect(subject.find_remote_service(:my_remote_service)).to be_an_instance_of(RemoteServices::MyRemoteService)
+      end
+    end
+
+  end
+
+end

data/spec/lib/hydra/remote_identifier/mapper_spec.rb

@@ -47,5 +47,111 @@ module Hydra::RemoteIdentifier
         }.to raise_error(InvalidServiceMapping)
       end
     end
+
+    describe Mapper::Wrapper do
+      subject { Mapper::Wrapper.new(map, target) }
+
+      context 'extract_payload' do
+        let(:target) { double(foo: :foo_value) }
+        describe 'with implicit getter' do
+          let(:map) { double(_getters: { bar: :foo } ) }
+          its(:extract_payload) { should == {bar: :foo_value} }
+        end
+
+        describe 'with lambda getter' do
+          let(:map) { double(_getters: { bar: lambda {|o| o.foo } } ) }
+          its(:extract_payload) { should == {bar: :foo_value} }
+        end
+
+        describe 'with implicit datastream getter' do
+          let(:target) {
+            double(datastreams: {'datastream' => double(foo: :foo_value)})
+          }
+          let(:map) {
+            double(_getters: { foo: { at: 'datastream' } } )
+          }
+          its(:extract_payload) { should == {foo: :foo_value} }
+        end
+
+        describe 'with explicit datastream getter' do
+          let(:target) {
+            double(datastreams: {'datastream' => double(blorg: :foo_value)})
+          }
+          let(:map) {
+            double(_getters: { foo: { at: 'datastream', in: :blorg } } )
+          }
+          its(:extract_payload) { should == {foo: :foo_value} }
+        end
+
+      end
+
+      context '#extract_payload' do
+
+        let(:target) { double(foo: :foo_value) }
+        describe 'with implicit getter' do
+          let(:map) { double(_getters: { bar: :foo } ) }
+          its(:extract_payload) { should == {bar: :foo_value} }
+        end
+
+        describe 'with lambda getter' do
+          let(:map) { double(_getters: { bar: lambda {|o| o.foo } } ) }
+          its(:extract_payload) { should == {bar: :foo_value} }
+        end
+
+        describe 'with implicit datastream getter' do
+          let(:target) {
+            double(datastreams: {'datastream' => double(foo: :foo_value)})
+          }
+          let(:map) {
+            double(_getters: { foo: { at: 'datastream' } } )
+          }
+          its(:extract_payload) { should == {foo: :foo_value} }
+        end
+
+        describe 'with explicit datastream getter' do
+          let(:target) {
+            double(datastreams: {'datastream' => double(blorg: :foo_value)})
+          }
+          let(:map) {
+            double(_getters: { foo: { at: 'datastream', in: :blorg } } )
+          }
+          its(:extract_payload) { should == {foo: :foo_value} }
+        end
+
+      end
+
+      context '#set_identifier' do
+        let(:target) { double }
+        describe 'with implicit setter' do
+          let(:map) { double(_setter: :bar) }
+          specify {
+            target.should_receive(:bar).with(:expected_identifier)
+            subject.set_identifier(:expected_identifier)
+          }
+        end
+
+        describe 'with lambda setter' do
+          let(:map) { double(_setter: lambda {|o, v| o.foo = v  } ) }
+          specify {
+            target.should_receive(:foo=).with(:expected_identifier)
+            subject.set_identifier(:expected_identifier)
+          }
+        end
+
+        describe 'with explicit datastream getter' do
+          let(:target) { double(datastreams: datastreams ) }
+          let(:datastreams) { {'properties' => double } }
+          let(:map) {
+            double(_setter: { at: 'properties', in: :identifier } )
+          }
+          specify {
+            datastreams['properties'].should_receive(:identifier=).with(:expected_identifier)
+            subject.set_identifier(:expected_identifier)
+          }
+        end
+
+      end
+
+    end
   end
 end

data/spec/lib/hydra/remote_identifier/registration_spec.rb

@@ -5,21 +5,18 @@ module Hydra::RemoteIdentifier
     let(:minting_coordinator) { double(new: :minting_coordinator) }
     let(:target_class) { Class.new }
     let(:map) { lambda {|m| m.title :title } }
+    subject { Registration.new(:my_remote_service, minting_coordinator) }
     it 'requires a map' do
-      expect { Registration.new(:my_remote_service, target_class, minting_coordinator) }.to raise_error(RuntimeError)
+      expect { subject.register(target_class) }.to raise_error(RuntimeError)
     end
     it 'adds a .registered_remote_identifier_minters method' do
       expect {
-        Registration.new(:my_remote_service, target_class, minting_coordinator, &map)
+        subject.register(target_class, &map)
       }.to change{ target_class.respond_to?(:registered_remote_identifier_minters) }.from(false).to(true)
     end
     it 'adds a .registered_remote_identifier_minters method' do
-      Registration.new(:my_remote_service, target_class, minting_coordinator, &map)
+      subject.register(target_class, &map)
       expect(target_class.registered_remote_identifier_minters).to eq [:minting_coordinator]
     end
-
-    it 'should yield a map' do
-      Registration.new(:my_remote_service, target_class, minting_coordinator, &map)
-    end
   end
 end

data/spec/lib/hydra/remote_identifier/remote_service_spec.rb

@@ -3,12 +3,13 @@ require File.expand_path('../../../../../lib/hydra/remote_identifier/remote_serv
 module Hydra::RemoteIdentifier
 
   describe RemoteService do
-    let(:payload) { 'abc' }
-    subject { RemoteService.new }
-
-    it { expect { subject.call(payload) }.to raise_error NotImplementedError }
-    it { expect { subject.valid_attribute?(:attribute_name) }.to raise_error NotImplementedError }
 
+    describe 'instance methods' do
+      let(:payload) { 'abc' }
+      subject { RemoteService.new }
+      it { expect { subject.call(payload) }.to raise_error NotImplementedError }
+      it { expect { subject.valid_attribute?(:attribute_name) }.to raise_error NotImplementedError }
+    end
   end
 
 end

data/spec/lib/hydra/remote_identifier/remote_services/doi_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+require 'hydra/remote_identifier/remote_services/doi'
+
+module Hydra::RemoteIdentifier
+  module RemoteServices
+
+    describe Doi do
+      let(:configuration) {
+        {
+          username: 'apitest',
+          password: 'apitest',
+          shoulder: 'doi:10.5072/FK2',
+          url: "https://n2t.net/ezid/"
+        }
+      }
+      let(:payload) {
+        {
+          target: 'http://google.com',
+          creator: 'Jeremy Friesen',
+          title: 'My Article',
+          publisher: 'Me Myself and I',
+          publicationyear: "2013"
+        }
+      }
+      let(:expected_doi) {
+        # From the doi-create cassette
+        'doi:10.5072/FK23J3QV8'
+      }
+      subject { RemoteServices::Doi.new(configuration) }
+
+      context '.call' do
+        it 'should post to remote service', VCR::SpecSupport.merge(cassette_name: 'doi-create') do
+          expect(subject.call(payload)).to eq(expected_doi)
+        end
+      end
+    end
+  end
+end

data/spec/lib/hydra/remote_identifier_spec.rb

@@ -1,61 +1,60 @@
 require File.expand_path('../../../../lib/hydra/remote_identifier', __FILE__)
 module Hydra::RemoteIdentifier
 
-  describe 'with custom remote service' do
-    around do |example|
-      module RemoteServices
-        class MyRemoteService < ::Hydra::RemoteIdentifier::RemoteService
-          def valid_attribute?(*)
-            true
-          end
-          def call(payload)
-            :remote_service_response
-          end
-        end
-      end
-      example.run
-      RemoteServices.send(:remove_const, :MyRemoteService)
-    end
+  describe '.configure' do
+
+    let(:target_class) {
+      Class.new {
+        def url; 'http://google.com'; end
+        def creator; 'my creator'; end
+        def title; 'my title'; end
+        def publisher; 'my publisher'; end
+        def publicationyear; '2013'; end
+        attr_accessor :set_identifier
+      }
+    }
 
-    describe '.register' do
+    let(:target) { target_class.new }
 
-      let(:target_class) {
-        Class.new {
-          attr_reader :identifier
-          def title; 'a special title'; end
-          def update_identifier(value); @identifier = value; end
-        }
-      }
-      let(:target) { target_class.new }
+    let(:expected_doi) {
+      # From the doi-create cassette
+      'doi:10.5072/FK2FT8XZZ'
+    }
 
-      it 'should update the registered identifier based on the registered attributes' do
-        Hydra::RemoteIdentifier.register(:my_remote_service, target_class) do |config|
-          config.title :title
-          config.set_identifier :update_identifier
+    let(:doi_options) {
+      {
+        username: 'apitest',
+        password: 'apitest',
+        shoulder: 'doi:10.5072/FK2',
+        url: "https://n2t.net/ezid/"
+      }
+    }
+
+    describe '.register API' do
+
+      before(:each) do
+        Hydra::RemoteIdentifier.configure do |config|
+          config.configure_remote_service(:doi, doi_options) do |doi|
+            doi.register(target_class) do |map|
+              map.target :url
+              map.creator :creator
+              map.title :title
+              map.publisher :publisher
+              map.publicationyear :publicationyear
+              map.set_identifier(:set_identifier=)
+            end
+          end
         end
+      end
 
+      it 'works!', VCR::SpecSupport.merge(record: :new_episodes, cassette_name: 'doi-integration') do
         expect {
           target_class.registered_remote_identifier_minters.each do |minter|
             minter.call(target)
           end
-        }.to change(target, :identifier).from(nil).to(:remote_service_response)
-
+        }.to change(target, :set_identifier).from(nil).to(expected_doi)
       end
-    end
 
-    describe '.remote_service' do
-      context 'with valid remote service' do
-        subject { Hydra::RemoteIdentifier.remote_service(:my_remote_service) }
-        it 'should return an instance of that service' do
-          expect(subject).to be_instance_of RemoteServices::MyRemoteService
-        end
-      end
-      context 'with invalid remote service' do
-        subject { Hydra::RemoteIdentifier.remote_service(:undefined_service) }
-        it 'should raise a NotImplementedError' do
-          expect { subject }.to raise_error NotImplementedError
-        end
-      end
     end
 
   end

data/spec/spec_helper.rb

@@ -1,6 +1,21 @@
 GEM_ROOT = File.expand_path("../../", __FILE__)
 $:.unshift File.join(GEM_ROOT, "lib")
 
+require 'vcr'
+
+module VCR::SpecSupport
+  module_function
+  def merge(options = {})
+    {vcr: {record: :new_episodes}.merge(options)}
+  end
+end
+
+VCR.configure do |config|
+  config.cassette_library_dir = 'spec/fixtures/cassettes'
+  config.hook_into :webmock
+  config.configure_rspec_metadata!
+end
+
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
 # Require this file using `require "spec_helper"` to ensure that it is only

metadata

@@ -1,22 +1,20 @@
 --- !ruby/object:Gem::Specification
 name: hydra-remote_identifier
 version: !ruby/object:Gem::Version
-  version: 0.0.3
-  prerelease: 
+  version: 0.2.0
 platform: ruby
 authors:
 - Jeremy Friesen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-02 00:00:00.000000000 Z
+date: 2013-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.2.13
     - - <
@@ -25,92 +23,67 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.2.13
     - - <
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rest-client
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
+        version: 1.6.7
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 1.6.7
 - !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: yard
+  name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: redcarpet
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Handles the registration and minting of remote identifiers (i.e. DOI,
@@ -131,6 +104,7 @@ files:
 - Rakefile
 - hydra-remote_identifier.gemspec
 - lib/hydra/remote_identifier.rb
+- lib/hydra/remote_identifier/configuration.rb
 - lib/hydra/remote_identifier/exceptions.rb
 - lib/hydra/remote_identifier/mapper.rb
 - lib/hydra/remote_identifier/minter.rb
@@ -138,52 +112,54 @@ files:
 - lib/hydra/remote_identifier/registration.rb
 - lib/hydra/remote_identifier/remote_service.rb
 - lib/hydra/remote_identifier/remote_services.rb
+- lib/hydra/remote_identifier/remote_services/doi.rb
 - lib/hydra/remote_identifier/version.rb
+- spec/fixtures/cassettes/doi-create.yml
+- spec/fixtures/cassettes/doi-integration.yml
+- spec/lib/hydra/remote_identifier/configuration_spec.rb
 - spec/lib/hydra/remote_identifier/mapper_spec.rb
 - spec/lib/hydra/remote_identifier/minter_spec.rb
 - spec/lib/hydra/remote_identifier/minting_coordinator_spec.rb
 - spec/lib/hydra/remote_identifier/registration_spec.rb
 - spec/lib/hydra/remote_identifier/remote_service_spec.rb
+- spec/lib/hydra/remote_identifier/remote_services/doi_spec.rb
 - spec/lib/hydra/remote_identifier_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/jeremyf/hydra-remote_identifier
 licenses:
 - APACHE2
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1218886598798334275
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1218886598798334275
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Handles the registration and minting of remote identifiers (i.e. DOI, ARK,
   ORCID)
 test_files:
+- spec/fixtures/cassettes/doi-create.yml
+- spec/fixtures/cassettes/doi-integration.yml
+- spec/lib/hydra/remote_identifier/configuration_spec.rb
 - spec/lib/hydra/remote_identifier/mapper_spec.rb
 - spec/lib/hydra/remote_identifier/minter_spec.rb
 - spec/lib/hydra/remote_identifier/minting_coordinator_spec.rb
 - spec/lib/hydra/remote_identifier/registration_spec.rb
 - spec/lib/hydra/remote_identifier/remote_service_spec.rb
+- spec/lib/hydra/remote_identifier/remote_services/doi_spec.rb
 - spec/lib/hydra/remote_identifier_spec.rb
 - spec/spec_helper.rb
 has_rdoc: