hydra-editor 3.3.1 → 3.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 483516ed526d6a67b385e0e68bdcc09d67654943
-  data.tar.gz: c54e1eb9a3c3ab157e03bced6e0a19bddcb8d463
+  metadata.gz: bf1742bb171c18f225eafe23a40a84f28ce88588
+  data.tar.gz: f7eba9637334928973ea1a2c9615e9e51dbfe697
 SHA512:
-  metadata.gz: b69df85c3c3f58083db84b61e606fdbea630ba91c8febe8f8408eee7129732074923036c9041570084917543e8b8fd303d0dc54308cb3ffbf231145e34b40fbd
-  data.tar.gz: bb2a3636961a894beb9ce36d47fd36461264ce042a3bb02a7450ed144e44df14b1b0d73c13e12f3cfaccf4e205e4820055350c34a5732f3e9785974539abe5cf
+  metadata.gz: e3f11286ab8251e7ac992ec0eb97c6a2d5ee9c0b60dda759f1aae9059400e16cc581bcdffecc6170d2eacd4bec2fd3224508d60551d2c5b58ce43e93a4f99c2f
+  data.tar.gz: 47695067e2ced57b919bfe9e889bd92f4fa2caecc6626b863b337b46a6ecec931403b0411922a6af218e2ca113b64dfd6e5a08288198bf4a220c0f6d0b7752e8

data/app/assets/javascripts/hydra-editor/field_manager.es6

@@ -1,12 +1,16 @@
 export class FieldManager {
     constructor(element, options) {
         this.element = $(element);
+
         this.options = options;
 
         this.options.label = this.getFieldLabel(this.element, options)
 
-        this.adder    = this.createAddHtml(this.options);
-        this.remover  = this.createRemoveHtml(this.options);
+        this.addSelector = '.add'
+        this.removeSelector = '.remove'
+
+        this.adder    = this.createAddHtml(this.options)
+        this.remover  = this.createRemoveHtml(this.options)
 
         this.controls = $(options.controlsHtml);
 
@@ -35,18 +39,43 @@ export class FieldManager {
         $(this.element).find('.listing').attr('aria-live', 'polite')
     }
 
+    // Add the "Add another" and "Remove" controls to the DOM
     _appendControls() {
-        $(this.fieldWrapperClass, this.element).append(this.controls);
-        $(this.fieldWrapperClass + ' .field-controls', this.element).append(this.remover);
+        // We want to make these DOM additions idempotently, so exit if it's
+        // already set up.
+        if (!this._hasRemoveControl()) {
+          this._createRemoveWrapper()
+          this._createRemoveControl()
+        }
 
-        if ($(this.element).find('.add').length == 0) {
-            $(this.element).find(this.listClass).after(this.adder);
+        if (!this._hasAddControl()) {
+          this._createAddControl()
         }
     }
 
+    _createRemoveWrapper() {
+      $(this.fieldWrapperClass, this.element).append(this.controls);
+    }
+
+    _createRemoveControl() {
+      $(this.fieldWrapperClass + ' .field-controls', this.element).append(this.remover)
+    }
+
+    _createAddControl() {
+      this.element.find(this.listClass).after(this.adder)
+    }
+
+    _hasRemoveControl() {
+      return this.element.find(this.removeSelector).length > 0
+    }
+
+    _hasAddControl() {
+      return this.element.find(this.addSelector).length > 0
+    }
+
     _attachEvents() {
-        this.element.on('click', '.remove', (e) => this.removeFromList(e));
-        this.element.on('click', '.add', (e) =>this.addToList(e));
+        this.element.on('click', this.removeSelector, (e) => this.removeFromList(e))
+        this.element.on('click', this.addSelector, (e) => this.addToList(e))
     }
 
     _addCallbacks() {

data/lib/hydra_editor/version.rb

@@ -1,3 +1,3 @@
 module HydraEditor
-  VERSION = '3.3.1'.freeze
+  VERSION = '3.3.2'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hydra-editor
 version: !ruby/object:Gem::Version
-  version: 3.3.1
+  version: 3.3.2
 platform: ruby
 authors:
 - Justin Coyne
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-04 00:00:00.000000000 Z
+date: 2017-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -129,6 +129,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.1'
+- !ruby/object:Gem::Dependency
+  name: rails-controller-testing
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: factory_girl_rails
   requirement: !ruby/object:Gem::Requirement