hydra-batch-edit 2.0.2 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 69ea091b00ff503bd8818b9a8aee327d4e830b63
-  data.tar.gz: dd061b36c841a8143150dac1ea9da388e491b0e5
+  metadata.gz: 49eb4f38e25d7b886f7069572baa623ea0602172
+  data.tar.gz: ed6a555e20a829174d1fd90ef11080601afe9a3a
 SHA512:
-  metadata.gz: bd47ffb0ad55b19d8b8bfc66dd5593f88e679c2283082a8967d01f84c5776e3fb29f569610c76d8096f4a1eec265a175f7c2ec2ca0c710c12c81aa27b75a8c74
-  data.tar.gz: 4e0251902312a7ed1808b4c638861762612ea1f8662f524920b0b045e58d1090a599c10192dd03f80d986ef266644d19ec20434a0f9f1c25c50b31c0a652cbcc
+  metadata.gz: aba85956838b2f175908c1e8c80b84906d010bf8cccb2fb7861b601c8653098987b7d100880561193a38fdc05fa5f1fdf513422979423672219690b9f008be94
+  data.tar.gz: 28ae45abf6af7337460cdc7e9a4525ef2a6d0068de06ade7335d0aaca3a397fb28aea80156489a5abbc1336e01c1615c0ba2a2996f703ee346c4b04619a467d9

data/.rubocop.yml

@@ -1,4 +1,3 @@
-require: rubocop-rspec
 inherit_from: .rubocop_todo.yml
 
 AllCops:

data/.rubocop_todo.yml

@@ -1,3 +1,4 @@
+require: rubocop-rspec
 # This configuration was generated by
 # `rubocop --auto-gen-config`
 # on 2016-04-20 07:34:46 -0700 using RuboCop version 0.39.0.
@@ -53,6 +54,10 @@ Lint/Void:
 Metrics/MethodLength:
   Max: 17
 
+RSpec/VerifiedDoubles:
+  Exclude:
+    - 'spec/controllers/batch_edits_controller_spec.rb'
+
 # Offense count: 1
 RSpec/AnyInstance:
   Exclude:

data/.travis.yml

@@ -1,5 +1,11 @@
 rvm:
   - 2.2.4
 
+env:
+  global:
+    - NOKOGIRI_USE_SYSTEM_LIBRARIES=true
+  matrix:
+    - "RAILS_VERSION=4.2.7.1"
+
 notifications:
   irc: "irc.freenode.org#projecthydra"

data/app/controllers/concerns/hydra/batch_edit_behavior.rb

@@ -5,8 +5,8 @@ module Hydra
     included do
       include CurationConcerns::Collections::AcceptsBatches
 
-      before_filter :filter_docs_with_access!, :only=>[:edit, :update, :destroy_collection]
-      before_filter :check_for_empty!, :only=>[:edit, :update, :destroy_collection]
+      before_action :filter_docs_with_access!, :only=>[:edit, :update, :destroy_collection]
+      before_action :check_for_empty!, :only=>[:edit, :update, :destroy_collection]
     end
 
     # fetch the documents that match the ids in the folder

data/lib/hydra/batch_edit/version.rb

@@ -1,5 +1,5 @@
 module Hydra
   module BatchEdit
-    VERSION = "2.0.2".freeze
+    VERSION = "2.1.0".freeze
   end
 end

data/spec/controllers/batch_edits_controller_spec.rb

@@ -43,18 +43,25 @@ describe BatchEditsController do
       
     end
     it "should complain when none are in the batch " do
-      put :update, :multiresimage=>{:titleSet_display=>'My title' } 
+      put :update, :multiresimage=>{:titleSet_display=>'My title' }
       expect(response).to redirect_to 'where_i_came_from'
       expect(flash[:notice]).to eq("Select something first")
     end
-    it "should not update when the user doesn't have permissions" do
-      controller.batch = [@one.pid, @two.pid]
-      expect(controller).to receive(:can?).with(:edit, @one.pid).and_return(false)
-      expect(controller).to receive(:can?).with(:edit, @two.pid).and_return(false)
-      put :update, :multiresimage=>{:titleSet_display=>'My title' } 
-      expect(response).to redirect_to 'where_i_came_from'
-      expect(flash[:notice]).to eq("You do not have permission to edit the documents: #{@one.pid}, #{@two.pid}")
+
+    context "when the user doesn't have permissions" do
+      before do
+        controller.batch = [@one.pid, @two.pid]
+      end
+
+      it "should not update when the user doesn't have permissions" do
+        expect(controller).to receive(:can?).with(:edit, @one.pid).and_return(false)
+        expect(controller).to receive(:can?).with(:edit, @two.pid).and_return(false)
+        put :update, :multiresimage=>{:titleSet_display=>'My title' } 
+        expect(response).to redirect_to 'where_i_came_from'
+        expect(flash[:notice]).to eq("You do not have permission to edit the documents: #{@one.pid}, #{@two.pid}")
+      end
     end
+
     describe "when current user has access to the documents" do
       before do
         @one.save
@@ -95,14 +102,21 @@ describe BatchEditsController do
       expect(response).to redirect_to 'where_i_came_from'
       expect(flash[:notice]).to eq("Select something first")
     end
-    it "should not update when the user doesn't have permissions" do
-      controller.batch = [@one.pid, @two.pid]
-      expect(controller).to receive(:can?).with(:edit, @one.pid).and_return(false)
-      expect(controller).to receive(:can?).with(:edit, @two.pid).and_return(false)
-      delete :destroy_collection 
-      expect(response).to redirect_to 'where_i_came_from'
-      expect(flash[:notice]).to eq("You do not have permission to edit the documents: #{@one.pid}, #{@two.pid}")
+
+    context "when the user doesn't have permissions" do
+      before do
+        controller.batch = [@one.pid, @two.pid]
+      end
+
+      it "does not update" do
+        expect(controller).to receive(:can?).with(:edit, @one.pid).and_return(false)
+        expect(controller).to receive(:can?).with(:edit, @two.pid).and_return(false)
+        delete :destroy_collection 
+        expect(response).to redirect_to 'where_i_came_from'
+        expect(flash[:notice]).to eq("You do not have permission to edit the documents: #{@one.pid}, #{@two.pid}")
+      end
     end
+
     describe "when current user has access to the documents" do
       before do
         @one.save

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hydra-batch-edit
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.1.0
 platform: ruby
 authors:
 - Justin Coyne
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-20 00:00:00.000000000 Z
+date: 2016-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -192,7 +192,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Rails engine to do batch editing with curation_concerns