hydra-batch-edit 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a068e7ba2ffe23aa8d8516d5b5adccd30e853af0
-  data.tar.gz: ebe41d7cd935281d49186340d33afdcba1b3d4ee
+  metadata.gz: 17f70ff6bd5f560f5902817c5598135db737d835
+  data.tar.gz: 8c30144e646cc1a88fe30683e7c424ccf2ca734d
 SHA512:
-  metadata.gz: dcefca2cc633cb24ff0396ccf87ab321d610b58678199daece1c558031b8318f09aca8c6858154e56a8a29734a2f44df34e0b8e9b25d9abc1c7111fc19cb0817
-  data.tar.gz: 3a3ca327a18c49273a8b70a842b88600cdde2ca2be100e39a332fdba474d5fd07af2b76630d19844ca10fcc0eb404274ac653caf197e37de408ef49c38415a0e
+  metadata.gz: d8589151d6549d05a8c5f7316a39152d352c1d8455913a4567bd7de0e9fd43c363c698d9767c66949efc6881f641ba5d9efb4dffc3c4a07693c305ee6b1d6e8d
+  data.tar.gz: cf7a5c941a39f8daf06e362d272d4f990b0fa7abb407d52994dd341d94e5f25d33262757ee565f51517098e5b7d5514deb726a832e56727117a20f09d1052023

data/.travis.yml

@@ -0,0 +1,9 @@
+rvm:
+  - 2.0.0
+
+gemfile:
+  - gemfiles/rails3.gemfile
+  - gemfiles/rails4.gemfile
+
+notifications:
+  irc: "irc.freenode.org#projecthydra"

data/CONTRIBUTING.md

@@ -0,0 +1,111 @@
+# How to Contribute
+
+We want your help to make Project Hydra great.
+There are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
+
+## Hydra Project Intellectual Property Licensing and Ownership
+
+All code contributors must have an Individual Contributor License Agreement (iCLA) on file with the Hydra Project Steering Group.
+If the contributor works for an institution, the institution must have a Corporate Contributor License Agreement (cCLA) on file.
+
+https://wiki.duraspace.org/display/hydra/Hydra+Project+Intellectual+Property+Licensing+and+Ownership
+
+You should also add yourself to the `CONTRIBUTORS.md` file in the root of the project.
+
+## Contribution Tasks
+
+* Reporting Issues
+* Making Changes
+* Submitting Changes
+* Merging Changes
+
+### Reporting Issues
+
+* Make sure you have a [GitHub account](https://github.com/signup/free)
+* Submit a [Github issue](./issues) by:
+  * Clearly describing the issue
+    * Provide a descriptive summary
+    * Explain the expected behavior
+    * Explain the actual behavior
+    * Provide steps to reproduce the actual behavior
+
+### Making Changes
+
+* Fork the repository on GitHub
+* Create a topic branch from where you want to base your work.
+  * This is usually the master branch.
+  * To quickly create a topic branch based on master; `git branch fix/master/my_contribution master`
+  * Then checkout the new branch with `git checkout fix/master/my_contribution`.
+  * Please avoid working directly on the `master` branch.
+  * You may find the [hub suite of commands](https://github.com/defunkt/hub) helpful
+* Make commits of logical units.
+  * Your commit should include a high level description of your work in HISTORY.textile 
+* Check for unnecessary whitespace with `git diff --check` before committing.
+* Make sure your commit messages are [well formed](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
+* If you created an issue, you can close it by including "Closes #issue" in your commit message. See [Github's blog post for more details](https://github.com/blog/1386-closing-issues-via-commit-messages)
+
+```
+    Present tense short summary (50 characters or less)
+
+    More detailed description, if necessary. It should be wrapped to 72
+    characters. Try to be as descriptive as you can, even if you think that
+    the commit content is obvious, it may not be obvious to others. You
+    should add such description also if it's already present in bug tracker,
+    it should not be necessary to visit a webpage to check the history.
+
+    Include Closes #<issue-number> when relavent.
+
+    Description can have multiple paragraphs and you can use code examples
+    inside, just indent it with 4 spaces:
+
+        class PostsController
+          def index
+            respond_with Post.limit(10)
+          end
+        end
+
+    You can also add bullet points:
+
+    - you can use dashes or asterisks
+
+    - also, try to indent next line of a point for readability, if it's too
+      long to fit in 72 characters
+```
+
+* Make sure you have added the necessary tests for your changes.
+* Run _all_ the tests to assure nothing else was accidentally broken.
+* When you are ready to submit a pull request
+
+### Submitting Changes
+
+* Read the article ["Using Pull Requests"](https://help.github.com/articles/using-pull-requests) on GitHub.
+* Make sure your branch is up to date with its parent branch (i.e. master)
+  * `git checkout master`
+  * `git pull --rebase`
+  * `git checkout <your-branch>`
+  * `git rebase master`
+  * It is likely a good idea to run your tests again.
+* Squash the commits for your branch into one commit
+  * `git rebase --interactive HEAD~<number-of-commits>` ([See Github help](https://help.github.com/articles/interactive-rebase))
+  * To determine the number of commits on your branch: `git log master..<your-branch> --oneline | wc -l`
+  * Squashing your branch's changes into one commit is "good form" and helps the person merging your request to see everything that is going on.
+* Push your changes to a topic branch in your fork of the repository.
+* Submit a pull request from your fork to the project.
+
+### Merging Changes
+
+* It is considered "poor from" to merge your own request.
+* Please take the time to review the changes and get a sense of what is being changed. Things to consider:
+  * Does the commit message explain what is going on?
+  * Does the code changes have tests? _Not all changes need new tests, some changes are refactorings_
+  * Does the commit contain more than it should? Are two separate concerns being addressed in one commit?
+  * Did the Travis tests complete successfully?
+* If you are uncertain, bring other contributors into the conversation by creating a comment that includes their @username.
+* If you like the pull request, but want others to chime in, create a +1 comment and tag a user.
+
+# Additional Resources
+
+* [General GitHub documentation](http://help.github.com/)
+* [GitHub pull request documentation](http://help.github.com/send-pull-requests/)
+* [Pro Git](http://git-scm.com/book) is both a free and excellent book about Git.
+* [A Git Config for Contributing](http://ndlib.github.io/practices/my-typical-per-project-git-config/)

data/History.md

@@ -0,0 +1,3 @@
+# 1.0.2 (2013-07-22)
+
+* Routes should work the same in rails 3.2 and rails 4.0

data/README.textile

@@ -1,5 +1,7 @@
 h1. hydra-batch-edit
 
+!https://travis-ci.org/projecthydra/hydra-batch-edit.png!:https://travis-ci.org/projecthydra/hydra-batch-edit !https://badge.fury.io/rb/hydra-batch-edit.png!:http://badge.fury.io/rb/hydra-batch-edit
+
 Batch Editing Functionality for Hydra Heads
 
 *This is Alpha Software!*  While working on a specific Hydra Head with specific content & use cases, we added batch editing functionality.  We wrote the code as a separate gem so that others can use this as a starting point, but _you will have to modify the code_ to get this to work.  If other Hydra partners start using the gem, it will become more immediately useful & configurable out of the box.  At that point, someone will delete this message.
@@ -65,7 +67,7 @@ h2. Customizing
 
 h3. What you will need to do
 
-You will *definitely* need to override the edit form.
+You will *definitely* need to override the edit form. `app/views/batch_edits/edit.html.erb`
 You will probably need to override BatchEditController#update 
 You might need to override BatchEditController#edit
 
@@ -93,7 +95,7 @@ Example app/controllers/batch_updates_controller.rb
 
 h3. Override Edit View
 
-Example app/views/batch_edit/edit.html.erb
+Example app/views/batch_edits/edit.html.erb
 
 <pre>
   <%= form_for MyModel.new, :url=>batch_edit_path, :method=>:put do |f| %>

data/Rakefile

@@ -23,8 +23,10 @@ task :generate do
   unless File.exists?('spec/internal/Rakefile')
     puts "Generating rails app"
     `rails new spec/internal`
-    puts "Copying gemfile"
-    `cp spec/support/Gemfile spec/internal`
+    puts "Updating gemfile"
+    `echo "gem 'hydra-batch-edit', :path=>'../../../hydra-batch-edit'
+gem 'rspec-rails'
+    " >> spec/internal/Gemfile`
     puts "Copying generator"
     `cp -r spec/support/lib/generators spec/internal/lib`
 

data/gemfiles/rails3.gemfile

@@ -0,0 +1,6 @@
+source 'https://rubygems.org'
+
+# Please see hydra-batch-edit.gemspec for dependency information.
+gemspec :path=>"../"
+
+gem 'rails', "~> 3.2"

data/gemfiles/rails4.gemfile

@@ -0,0 +1,6 @@
+source 'https://rubygems.org'
+
+# Please see hydra-batch-edit.gemspec for dependency information.
+gemspec :path=>"../"
+
+gem 'rails', '~> 4.0.0'

data/lib/hydra/batch_edit/routes.rb

@@ -15,7 +15,7 @@ module Hydra
               delete :destroy
             end
             collection do
-              match 'destroy' => 'batch_edits#destroy_collection', :via=>:delete
+              get :index
               get :edit
               put :update
               delete :clear
@@ -24,6 +24,7 @@ module Hydra
             end
           end
           match 'batch_edits/:id' => 'batch_edits#add', :via=>:put
+          match 'batch_edits' => 'batch_edits#destroy_collection', :via=>:delete
         end
       end
 

data/lib/hydra/batch_edit/version.rb

@@ -1,5 +1,5 @@
 module Hydra
   module BatchEdit
-    VERSION = "1.0.1"
+    VERSION = "1.0.2"
   end
 end

data/spec/routing/batch_edit_routes_spec.rb

@@ -3,6 +3,7 @@ require 'spec_helper'
 describe "Routes for batch_update" do
   it "should route index" do 
     { :get => '/batch_edits' }.should route_to( :controller => "batch_edits", :action => "index")
+    batch_edits_path.should == '/batch_edits'
   end
   it "should route edit" do 
     { :get => edit_batch_edits_path }.should route_to( :controller => "batch_edits", :action => "edit")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hydra-batch-edit
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Justin Coyne
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-10 00:00:00.000000000 Z
+date: 2013-07-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: blacklight
@@ -89,7 +89,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
+- CONTRIBUTING.md
 - Gemfile
+- History.md
 - LICENSE
 - README.textile
 - Rakefile
@@ -103,7 +106,8 @@ files:
 - app/views/batch_edits/_tools.html.erb
 - app/views/batch_edits/edit.html.erb
 - app/views/batch_edits/index.html.erb
-- config/routes.rb
+- gemfiles/rails3.gemfile
+- gemfiles/rails4.gemfile
 - hydra-batch-edit.gemspec
 - lib/hydra-batch-edit.rb
 - lib/hydra/batch_edit.rb
@@ -161,3 +165,4 @@ test_files:
 - spec/support/db/migrate/20111101221803_create_searches.rb
 - spec/support/lib/generators/test_app_generator.rb
 - spec/support/lib/tasks/rspec.rake
+has_rdoc: 

data/config/routes.rb

@@ -1,15 +0,0 @@
-Hydra::BatchEdit::Engine.routes.draw do
-###NOTE this isn't used
-  
-  match 'batch_edits/:id' => 'batch_edits#add', :via=>:put
-  resources :batch_edits, :only=>[:index] do
-    member do
-      delete :destroy
-    end
-    collection do
-      get :edit
-      put :update
-      delete :clear
-    end
-  end
-end