hydra-access-controls 10.0.0.beta1 → 10.0.0.beta2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e70730aa7b919d1cbf3e4815db314bdf6c7ab61b
-  data.tar.gz: be22eb4d9e206a741b8e7543d355bcec3a9342dd
+  metadata.gz: 9665cf60571d6ee1e75abbdbc49e6901685a6ad1
+  data.tar.gz: 14e7ee3c6bc5459a4e511ae4db987f91cd24dc2b
 SHA512:
-  metadata.gz: ebeb634bda7b08ac09e6a4210c87ba55863a6d63ad7d6abe9b6d31f8fd8d313bcd916494f2c5f9f3b50fea52012141b2caf5201593043747dbe451dc0d3b94b3
-  data.tar.gz: f13e52899116432172f7bcf87d53b55abf1173c294a70c4c66b28037339807297305ca54b8b1b948bb6ef6cccb57e347b48188e2c85c987bc5ec8b231cbe067b
+  metadata.gz: 9476ae7eceb9e244213a74226214e5af0e3a86060b58d90fef84c4e739b7bd9b36edaa4d94065787e5639e1c6e4fa55397636182e56e6ac4a6f5cebea51d7235
+  data.tar.gz: da20d7a1b237040d0efc5ebe266e1f839bd810c4f75ed107595aa88d7de0ac33af0613751b74ab26e1bd3655bd21a72daad4c494d8e669cadbe4558cedfc0fa6

data/app/models/hydra/access_control.rb

@@ -34,10 +34,6 @@ module Hydra
       end
     end
 
-    # def has_destroy_flag?(hash)
-    #   ActiveFedora::Type::Boolean.new.cast(hash['_destroy'])
-    # end
-
     def relationship
       @relationship ||= CollectionRelationship.new(self, :contains)
     end
@@ -49,7 +45,7 @@ module Hydra
       end
 
       delegate :to_a, :to_ary, :map, :delete, :last, :size, :count, :[],
-               :==, :detect, to: :@relationship
+               :==, :detect, :empty?, to: :@relationship
 
       # TODO: if directly_contained relationships supported find, we could just
       # delegate find.

data/spec/unit/collection_relationship_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe Hydra::AccessControl::CollectionRelationship do
+  let(:access_control) { Hydra::AccessControl.new }
+  let(:relationship) { access_control.relationship }
+
+  describe "#==" do
+    subject { relationship }
+    it "compares to array" do
+      expect(subject).to eq []
+    end
+  end
+
+  describe "#empty?" do
+    subject { relationship.empty? }
+    it { is_expected.to be true }
+  end
+end

data/spec/unit/permissions_spec.rb

@@ -7,14 +7,14 @@ describe Hydra::AccessControls::Permissions do
     end
   end
 
-  subject { Foo.new }
+  let(:model) { Foo.new }
+  subject { model }
 
-  it "has many permissions" do
-    expect(subject.permissions).to eq []
+  describe "#permisisons" do
+    subject { model.permissions }
+    it { is_expected.to be_kind_of Hydra::AccessControl::CollectionRelationship }
   end
 
-  #TODO is permission same as an acl?
-
   it "has a set of permissions" do
     subject.read_groups=['group1', 'group2']
     subject.edit_users=['user1']

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hydra-access-controls
 version: !ruby/object:Gem::Version
-  version: 10.0.0.beta1
+  version: 10.0.0.beta2
 platform: ruby
 authors:
 - Chris Beer
@@ -196,6 +196,7 @@ files:
 - spec/unit/access_right_spec.rb
 - spec/unit/accessible_by_spec.rb
 - spec/unit/admin_policy_spec.rb
+- spec/unit/collection_relationship_spec.rb
 - spec/unit/config_spec.rb
 - spec/unit/embargoable_spec.rb
 - spec/unit/ip_base_ability_spec.rb
@@ -249,6 +250,7 @@ test_files:
 - spec/unit/access_right_spec.rb
 - spec/unit/accessible_by_spec.rb
 - spec/unit/admin_policy_spec.rb
+- spec/unit/collection_relationship_spec.rb
 - spec/unit/config_spec.rb
 - spec/unit/embargoable_spec.rb
 - spec/unit/ip_base_ability_spec.rb