hybrid_platforms_conductor 33.9.4 → 34.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 433e01481e26d03667cde79b93697f0f14e949a6201931c6e570ebb84670e79a
-  data.tar.gz: 61c1eb5c9b9ec3df221528e8ae1c08a7a6bdf3628c2a6a83b1756e11a84a2e88
+  metadata.gz: 4105038cdad3d70849816004ec2d909053e0e792900fc03e514d7b1ddc95d9c4
+  data.tar.gz: 5bda67856370632895782f6271c4044c50c22b0f340d8fc36ec6e11d8ca8fd8f
 SHA512:
-  metadata.gz: 31ff562ab7108537b8ba57b8c657ef516ef5665fb40fc81d4afe4f14a54400f62324597136845af8c39bd8788318d3d12c54362562cb73dff9d769c60cf8bce1
-  data.tar.gz: cb7dfea944204a89f9522703fb588ec8085dcd9a92816abe0cc012f0e7440432ee4a3831825517ae9b74f59e1ac1ff7d4995b6fa75220c28096de1a8e95f31b6
+  metadata.gz: e5a2dee126aecde247f6143f0d047e23280778755cb01cfb8c94d3f74bb128259bdba6044b25213a3e06f91e25fce53d71a31d6afa9dd95b01b797a4906e6745
+  data.tar.gz: f170805ef694bed86c8c673a3947b6c68755a27fba4ba79abebdf210dbf0ee39acb598466960f0eb3b387bb352dcc2b07094cca2e1f0d63b182eaa212d081926

data/CHANGELOG.md

@@ -1,3 +1,19 @@
+# [v34.0.0](https://github.com/sweet-delights/hybrid-platforms-conductor/compare/v33.9.5...v34.0.0) (2025-04-25 22:44:39)
+
+### Patches
+
+* [Fix NPM packages installation in Github workflows](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/5d18119b49ad7d0975d2c003139a394b9dd1116b)
+
+### Breaking changes
+
+* [Migrate to Ruby 3](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/6e1b93a37b68b01b3144fe03ccc280e1275dd493)
+
+# [v33.9.5](https://github.com/sweet-delights/hybrid-platforms-conductor/compare/v33.9.4...v33.9.5) (2022-03-20 17:46:29)
+
+### Patches
+
+* [[#118] Fix linear strategy checks when merge commits are found](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/01464ae5bb5c39e95be6216fceed0e9ac00ae83e)
+
 # [v33.9.4](https://github.com/sweet-delights/hybrid-platforms-conductor/compare/v33.9.3...v33.9.4) (2022-03-20 16:20:04)
 
 ### Patches

data/README.md

@@ -96,7 +96,7 @@ Here are the various plugin categories:
 # Installation
 
 Installing Hybrid Platforms Conductor requires 2 steps:
-1. Have **Ruby >= 2.5 and < 3.0** installed.
+1. Have **Ruby >= 3.0** installed.
 2. Install the `hybrid_platforms_conductor` Rubygem.
 
 See [installation details](docs/install.md) for more details on how to install those.
@@ -429,6 +429,8 @@ A subset of tests (or even a single test) can be run by using a part of their na
 
 To enable debugging logs during tests run, set the environment variable `TEST_DEBUG` to `1`: `TEST_DEBUG=1 bundle exec rspec -e "HybridPlatformsConductor::Deployer checking the docker images provisioning"`
 
+Some tests depend on Docker and sshpass which should be installed separately if those tests are required to pass.
+
 ## License
 
 BSD license (details in the [LICENSE.md file](LICENSE.md)).

data/bin/free_veids

@@ -11,7 +11,7 @@ executable.parse_options!
 nodes_handler.prefetch_metadata_of nodes_handler.known_nodes, :veid
 veids = nodes_handler.
   known_nodes.
-  map { |node| nodes_handler.get_veid_of(node) ? nodes_handler.get_veid_of(node).to_i : nil }.
+  map { |node| nodes_handler.get_veid_of(node)&.to_i }.
   compact
 
 executable.out "Free VEIDs: #{([10_000] + veids).missing.rangify}"

data/bin/last_deploys

@@ -53,7 +53,7 @@ info_displayed = {
   error: 'Error'
 }
 executable.out(Terminal::Table.new(headings: info_displayed.values) do |table|
-  sorted_deploy_info.each do |_node, deploy_info|
+  sorted_deploy_info.each do |(_node, deploy_info)|
     table << info_displayed.keys.map { |key| deploy_info[key] }
   end
 end)

data/bin/nodes_to_deploy

@@ -68,9 +68,9 @@ unless ignore_deploy_info
       node_impacted = false
       # Loop over all possible repositories concerned by this deployment
       repo_idx = 0
-      while node_deploy_info[:deployment_info].key?("repo_name_#{repo_idx}".to_sym)
-        repo_name = node_deploy_info[:deployment_info]["repo_name_#{repo_idx}".to_sym]
-        commit_id = node_deploy_info[:deployment_info]["commit_id_#{repo_idx}".to_sym]
+      while node_deploy_info[:deployment_info].key?(:"repo_name_#{repo_idx}")
+        repo_name = node_deploy_info[:deployment_info][:"repo_name_#{repo_idx}"]
+        commit_id = node_deploy_info[:deployment_info][:"commit_id_#{repo_idx}"]
         impacted_nodes = cache_impacted_nodes.dig(repo_name, commit_id)
         if impacted_nodes.nil?
           if platforms_handler.platform(repo_name)

data/lib/hybrid_platforms_conductor/core_extensions/bundler/without_bundled_env.rb

@@ -10,7 +10,7 @@ module Bundler
 
     # @return [Hash] Environment with all bundler-related variables removed
     def current_unbundled_env
-      env = ENV.clone.to_hash
+      env = ENV.to_h
       %w[
         PATH
         RUBYLIB

data/lib/hybrid_platforms_conductor/core_extensions/cleanroom/fix_kwargs.rb

@@ -46,6 +46,7 @@ module Cleanroom
     #   []
     #   {:string=>"With to_hash"}
     KWARGS_TYPES = %i[key keyreq]
+    private_constant :KWARGS_TYPES
 
     #
     # The list of exposed methods with kwargs.

data/lib/hybrid_platforms_conductor/credentials.rb

@@ -82,7 +82,7 @@ module HybridPlatformsConductor
 
       provider ||= proc do |requested_resource, requester|
         # Check environment variables
-        user = ENV["hpc_user_for_#{id}"]
+        user = ENV.fetch("hpc_user_for_#{id}", nil)
         # Clone the password as we are going to treat it as a secret string that will be wiped out
         password = ENV["hpc_password_for_#{id}"].dup
         if user.nil? || user.empty? || password.nil? || password.empty?

data/lib/hybrid_platforms_conductor/current_dir_monitor.rb

@@ -21,13 +21,13 @@ module HybridPlatformsConductor
     # * *module_to_decorate* (Module): The module including the method to decorate
     # * *method_name* (Symbol): The method name to be decorated
     def self.decorate_method(module_to_decorate, method_name)
-      original_method_name = "__hpc__#{method_name}__undecorated__".to_sym
+      original_method_name = :"__hpc__#{method_name}__undecorated__"
       module_to_decorate.alias_method original_method_name, method_name
-      module_to_decorate.define_method(method_name) do |*args, &block|
+      module_to_decorate.define_method(method_name) do |*args, **kwargs, &block|
         result = nil
         CurrentDirMonitor.monitor.synchronize do
           # puts "TID #{Thread.current.object_id} from #{caller[2]} - Current dir monitor taken from #{Dir.pwd}"
-          result = send(original_method_name, *args, &block)
+          result = send(original_method_name, *args, **kwargs, &block)
           # puts "TID #{Thread.current.object_id} from #{caller[2]} - Current dir monitor released back to #{Dir.pwd}"
         end
         result

data/lib/hybrid_platforms_conductor/deployer.rb

@@ -288,7 +288,7 @@ module HybridPlatformsConductor
 
       # Check that we are allowed to deploy
       unless @use_why_run
-        reason_for_interdiction = @services_handler.deploy_allowed?(
+        reason_for_interdiction = @services_handler.barrier_to_deploy(
           services: services_to_deploy,
           local_environment: @local_environment
         )

data/lib/hybrid_platforms_conductor/executable.rb

@@ -86,7 +86,7 @@ module HybridPlatformsConductor
       #
       # Result::
       # * Boolean: Has a singleton been instantiated for this component?
-      define_method("#{component}_instantiated?".to_sym) do
+      define_method(:"#{component}_instantiated?") do
         @instantiated_components.key?(component)
       end
 

data/lib/hybrid_platforms_conductor/hpc_plugins/cmdb/host_ip.rb

@@ -64,6 +64,8 @@ module HybridPlatformsConductor
         # Number of threads max to use for getent calls
         MAX_THREADS_GETENT = 32
 
+        private_constant :TIMEOUT_GETENT, :MAX_THREADS_GETENT
+
         # Discover the real IPs associated to a list of hosts.
         #
         # Parameters::

data/lib/hybrid_platforms_conductor/hpc_plugins/cmdb/host_keys.rb

@@ -69,6 +69,8 @@ module HybridPlatformsConductor
         # Number of threads max to use for ssh-keyscan calls
         MAX_THREADS_SSH_KEY_SCAN = 32
 
+        private_constant :TIMEOUT_SSH_KEYSCAN, :MAX_THREADS_SSH_KEY_SCAN
+
         # Discover the host keys associated to a list of hosts.
         #
         # Parameters::

data/lib/hybrid_platforms_conductor/hpc_plugins/connector/ssh.rb

@@ -85,7 +85,7 @@ module HybridPlatformsConductor
               binding
             end
             variables.each do |var_name, var_value|
-              erb_context.instance_variable_set("@#{var_name}".to_sym, var_value)
+              erb_context.instance_variable_set(:"@#{var_name}", var_value)
             end
             ERB.new(@gateways[gateway_conf]).result(erb_context.private_binding)
           end
@@ -131,8 +131,8 @@ module HybridPlatformsConductor
         # [API] - @nodes_handler can be used
         def init
           # Default values
-          @ssh_user = ENV['hpc_ssh_user']
-          @ssh_user = ENV['USER'] if @ssh_user.nil? || @ssh_user.empty?
+          @ssh_user = ENV.fetch('hpc_ssh_user', nil)
+          @ssh_user = ENV.fetch('USER', nil) if @ssh_user.nil? || @ssh_user.empty?
           if @ssh_user.nil? || @ssh_user.empty?
             _exit_status, stdout = @cmd_runner.run_cmd 'whoami', log_to_stdout: log_debug?
             @ssh_user = stdout.strip
@@ -141,7 +141,7 @@ module HybridPlatformsConductor
           @ssh_strict_host_key_checking = true
           @passwords = {}
           @auth_password = false
-          @ssh_gateways_conf = ENV['hpc_ssh_gateways_conf'].nil? ? nil : ENV['hpc_ssh_gateways_conf'].to_sym
+          @ssh_gateways_conf = ENV['hpc_ssh_gateways_conf']&.to_sym
           @ssh_gateway_user = ENV['hpc_ssh_gateway_user'].nil? ? 'ubradm' : ENV['hpc_ssh_gateway_user']
           # The map of existing ssh directories that have been created, per node that can access them
           # Array< String, Array<String> >
@@ -333,13 +333,13 @@ module HybridPlatformsConductor
                 #{File.basename(from)} | \
               #{ssh_exec} \
                 #{ssh_url} \
-                \"#{need_sudo ? @actions_executor.sudo_prefix(@node) : ''}tar \
+                "#{need_sudo ? @actions_executor.sudo_prefix(@node) : ''}tar \
                   --extract \
                   --gunzip \
                   --file - \
                   --directory #{to} \
                   --owner root \
-                \"
+                "
             EO_BASH
           end
         end
@@ -415,7 +415,7 @@ module HybridPlatformsConductor
               User #{@ssh_user}
               # Default control socket path to be used when multiplexing SSH connections
               ControlPath #{control_master_file('%h', '%p', '%r')}
-              #{open_ssh_major_version >= 7 ? 'PubkeyAcceptedKeyTypes +ssh-dss' : ''}
+              #{open_ssh_major_version >= 7 && open_ssh_major_version < 9 ? 'PubkeyAcceptedKeyTypes +ssh-dss' : ''}
               #{known_hosts_file.nil? ? '' : "UserKnownHostsFile #{known_hosts_file}"}
               #{@ssh_strict_host_key_checking ? '' : 'StrictHostKeyChecking no'}
 
@@ -492,6 +492,8 @@ module HybridPlatformsConductor
         # Time in seconds to wait between different retries because system is booting up
         WAIT_TIME_FOR_BOOT = 10
 
+        private_constant :MAX_THREADS_CONTROL_MASTER, :MAX_RETRIES_FOR_BOOT, :WAIT_TIME_FOR_BOOT
+
         # Open an SSH control master to multiplex connections to a given list of nodes.
         # This method is re-entrant and reuses the same control masters.
         # It is multi-processes:

data/lib/hybrid_platforms_conductor/hpc_plugins/platform_handler/serverless_chef/recipes_tree_builder.rb

@@ -160,7 +160,7 @@ module HybridPlatformsConductor
               flatten(1)
             # Check for some helpers we know include some recipes
             @config.known_helpers_including_recipes.each do |helper_name, used_recipes_by_helper|
-              if recipe_content =~ Regexp.new(/(\W|^)#{Regexp.escape(helper_name)}(\W|$)/)
+              if recipe_content =~ /(\W|^)#{Regexp.escape(helper_name)}(\W|$)/
                 used_recipes.concat(used_recipes_by_helper.map { |recipe_def| @platform.decode_recipe(recipe_def) })
                 used_recipes.uniq!
               end
@@ -214,6 +214,7 @@ module HybridPlatformsConductor
           INVALID_LIBRARY_METHODS = [
             'initialize'
           ]
+          private_constant :INVALID_LIBRARY_METHODS
 
           # Get the user defined library methods, per cookbook.
           # Keep a memory cache of it.

data/lib/hybrid_platforms_conductor/hpc_plugins/platform_handler/yaml_inventory.rb

@@ -16,7 +16,7 @@ module HybridPlatformsConductor
         def init
           # This method is called when initializing a new instance of this platform handler, for a given repository.
           inv_file = "#{@repository_path}/inventory.yaml"
-          @inventory = File.exist?(inv_file) ? YAML.safe_load(File.read(inv_file)) : {}
+          @inventory = File.exist?(inv_file) ? YAML.safe_load_file(inv_file) : {}
         end
 
         # Get the list of known nodes.

data/lib/hybrid_platforms_conductor/hpc_plugins/provisioner/proxmox/proxmox_waiter.rb

@@ -696,6 +696,7 @@ class ProxmoxWaiter
 
   # Timeout in seconds before giving up on a lock
   LOCK_TIMEOUT = 30
+  private_constant :LOCK_TIMEOUT
 
   # Get the IP address of a given LXC container
   #

data/lib/hybrid_platforms_conductor/hpc_plugins/provisioner/proxmox/reserve_proxmox_container

@@ -85,8 +85,8 @@ begin
 
   proxmox_waiter = ProxmoxWaiter.new(
     config_file,
-    ENV['hpc_user_for_proxmox'],
-    ENV['hpc_password_for_proxmox'],
+    ENV.fetch('hpc_user_for_proxmox', nil),
+    ENV.fetch('hpc_password_for_proxmox', nil),
     ENV['hpc_realm_for_proxmox'] || 'pam'
   )
 

data/lib/hybrid_platforms_conductor/hpc_plugins/provisioner/proxmox.rb

@@ -518,6 +518,7 @@ module HybridPlatformsConductor
         # Consider that it is to be used on the following patterns: (config|create|destroy)_<ID>.json
         # So remaining length is 255 - 13 = 242 characters.
         MAX_FILE_ID_SIZE = 242
+        private_constant :MAX_FILE_ID_SIZE
 
         # Get an ID unique for this node/environment and that can be used in file names.
         #

data/lib/hybrid_platforms_conductor/hpc_plugins/report/confluence.rb

@@ -51,6 +51,7 @@ module HybridPlatformsConductor
         private
 
         TEMPLATES_PATH = File.expand_path("#{File.dirname(__FILE__)}/templates")
+        private_constant :TEMPLATES_PATH
 
         # Render a given ERB template into a String
         #

data/lib/hybrid_platforms_conductor/hpc_plugins/secrets_reader/keepass.rb

@@ -87,8 +87,8 @@ module HybridPlatformsConductor
 
               with_credentials_for(:keepass, resource: keepass_secrets_info[:database]) do |_user, password|
                 Tempfile.create('hpc_keepass') do |xml_file|
-                  key_file = ENV['hpc_key_file_for_keepass']
-                  password_enc = ENV['hpc_password_enc_for_keepass']
+                  key_file = ENV.fetch('hpc_key_file_for_keepass', nil)
+                  password_enc = ENV.fetch('hpc_password_enc_for_keepass', nil)
                   keepass_credentials = {}
                   keepass_credentials[:password] = password.to_unprotected if password
                   keepass_credentials[:password_enc] = password_enc if password_enc
@@ -116,6 +116,7 @@ module HybridPlatformsConductor
           url: 'URL',
           user_name: 'UserName'
         }
+        private_constant :FIELDS
 
         # Parse XML secrets from a Nokogiri XML group node
         #

data/lib/hybrid_platforms_conductor/hpc_plugins/test/executables.rb

@@ -26,12 +26,12 @@ module HybridPlatformsConductor
             cmd_runner: @cmd_runner
           ).known_platforms.first
           unless example_platform.nil?
-            tests.concat [
+            tests.push(
               "#{CmdRunner.executables_prefix}get_impacted_nodes --platform #{example_platform.name} --show-commands"
-            ]
+            )
             example_node = example_platform.known_nodes.first
             unless example_node.nil?
-              tests.concat [
+              tests.push(
                 "#{CmdRunner.executables_prefix}check-node --node #{example_node} --show-commands",
                 "#{CmdRunner.executables_prefix}deploy --node #{example_node} --show-commands --why-run",
                 "#{CmdRunner.executables_prefix}last_deploys --node #{example_node} --show-commands",
@@ -39,7 +39,7 @@ module HybridPlatformsConductor
                 "#{CmdRunner.executables_prefix}report --node #{example_node} --format stdout",
                 "#{CmdRunner.executables_prefix}run --node #{example_node} --show-commands --interactive",
                 "#{CmdRunner.executables_prefix}topograph --from \"--node #{example_node}\" --to \"--node #{example_node}\" --skip-run --output graphviz:graph.gv"
-              ]
+              )
             end
           end
           tests.sort.each do |cmd|
@@ -48,7 +48,7 @@ module HybridPlatformsConductor
             assert_equal(exit_status, 0, "Command #{cmd} returned code #{exit_status}:\n#{stdout}")
           end
           # Remove the file created by Topograph if it exists
-          File.unlink('graph.gv') if File.exist?('graph.gv')
+          FileUtils.rm_f('graph.gv')
         end
 
       end

data/lib/hybrid_platforms_conductor/hpc_plugins/test/linear_strategy.rb

@@ -20,18 +20,18 @@ module HybridPlatformsConductor
             _exit_status, stdout, _stderr = @cmd_runner.run_cmd(<<~EO_BASH, log_to_stdout: log_debug?, no_exception: true, expected_code: [0, 1])
               cd #{@platform.repository_path} && \
               git --no-pager log \
+                --pretty=format:"%H" \
+                --graph \
                 $(git merge-base \
                   --octopus \
-                  $(git --no-pager log #{merge_commit_id} --max-count 1 --pretty=format:\"%P\") \
-                )..#{merge_commit_id} \
-                --pretty=format:\"%H\" \
-                --graph \
+                  $(git --no-pager log #{merge_commit_id} --max-count 1 --pretty=format:"%P") \
+                )..#{merge_commit_id}
               | grep '|'
             EO_BASH
             next if stdout.empty?
 
             _exit_status, stdout, _stderr = @cmd_runner.run_cmd(
-              "cd #{@platform.repository_path} && git --no-pager log #{merge_commit_id} --max-count 1 --pretty=format:%aI",
+              "cd #{@platform.repository_path} && git show --no-patch --format=%ci #{merge_commit_id}",
               log_to_stdout: log_debug?
             )
             error "Git history is not linear because of Merge commit #{merge_commit_id}" if Time.now - Time.parse(stdout.strip) < LOOKING_PERIOD

data/lib/hybrid_platforms_conductor/hpc_plugins/test/veids.rb

@@ -13,7 +13,7 @@ module HybridPlatformsConductor
           @nodes_handler.prefetch_metadata_of @nodes_handler.known_nodes, :veid
           veids = @nodes_handler.
             known_nodes.
-            to_h { |node| [node, @nodes_handler.get_veid_of(node) ? @nodes_handler.get_veid_of(node).to_i : nil] }
+            to_h { |node| [node, @nodes_handler.get_veid_of(node)&.to_i] }
 
           # Check there are no duplicates
           veids.group_by { |_node, veid| veid }.each do |veid, nodes|

data/lib/hybrid_platforms_conductor/hpc_plugins/test_report/confluence.rb

@@ -56,6 +56,7 @@ module HybridPlatformsConductor
         private
 
         TEMPLATES_PATH = File.expand_path("#{__dir__}/templates")
+        private_constant :TEMPLATES_PATH
 
         # Render a given ERB template into a String
         #

data/lib/hybrid_platforms_conductor/json_dumper.rb

@@ -55,7 +55,7 @@ module HybridPlatformsConductor
     def dump_json_for(nodes_selectors)
       nodes = @nodes_handler.select_nodes(nodes_selectors)
       unless @skip_run
-        nodes.map { |node| @nodes_handler.platform_for(node) }.uniq.each.each do |platform_handler|
+        nodes.map { |node| @nodes_handler.platform_for(node) }.uniq.each do |platform_handler|
           platform_handler.prepare_why_run_deploy_for_json_dump if platform_handler.respond_to?(:prepare_why_run_deploy_for_json_dump)
         end
         @deployer.concurrent_execution = true

data/lib/hybrid_platforms_conductor/logger_helpers.rb

@@ -221,7 +221,7 @@ module HybridPlatformsConductor
     # * Object: The stdout log device
     def stdout_device
       # TODO: Find a more elegant way to access the internal log device
-      @logger.instance_variable_get(:@logdev).dev
+      @logger.instance_variable_get(:@logdev)&.dev
     end
 
     # Set the stdout device
@@ -230,7 +230,7 @@ module HybridPlatformsConductor
     # * *log_device* (Object): The stdout log device to set
     def stdout_device=(log_device)
       # TODO: Find a more elegant way to access the internal log device
-      @logger.instance_variable_get(:@logdev).send(:set_dev, log_device)
+      @logger.instance_variable_get(:@logdev)&.send(:set_dev, log_device)
     end
 
     # Get the stderr device
@@ -239,7 +239,7 @@ module HybridPlatformsConductor
     # * IO or String: The stdout IO or file name
     def stderr_device
       # TODO: Find a more elegant way to access the internal log device
-      @logger_stderr.instance_variable_get(:@logdev).dev
+      @logger_stderr.instance_variable_get(:@logdev)&.dev
     end
 
     # Set the stderr device
@@ -248,7 +248,7 @@ module HybridPlatformsConductor
     # * *log_device* (Object): The stdout log device to set
     def stderr_device=(log_device)
       # TODO: Find a more elegant way to access the internal log device
-      @logger_stderr.instance_variable_get(:@logdev).send(:set_dev, log_device)
+      @logger_stderr.instance_variable_get(:@logdev)&.send(:set_dev, log_device)
     end
 
     # Is stdout really getting to the terminal display?
@@ -307,8 +307,8 @@ module HybridPlatformsConductor
         yield progress_bar
       ensure
         LoggerHelpers.progress_bar_semaphore.synchronize do
-          stdout_device.flush
-          stderr_device.flush
+          stdout_device&.flush
+          stderr_device&.flush
           self.stdout_device = previous_stdout_device unless previous_stdout_device.nil?
           self.stderr_device = previous_stderr_device unless previous_stderr_device.nil?
         end

data/lib/hybrid_platforms_conductor/nodes_handler.rb

@@ -323,7 +323,7 @@ module HybridPlatformsConductor
     # Parameters::
     # * *property* (Symbol): The property name
     def define_property_method_for(property)
-      define_singleton_method("get_#{property}_of".to_sym) { |node| metadata_of(node, property) }
+      define_singleton_method(:"get_#{property}_of") { |node| metadata_of(node, property) }
     end
 
     # Accept any method of name get_<property>_of to get the metadata property of a given node.
@@ -331,15 +331,13 @@ module HybridPlatformsConductor
     #
     # Parameters::
     # * *method* (Symbol): The missing method name
-    # * *args* (Array<Object>): Arguments given to the call
-    # * *block* (Proc): Code block given to the call
-    def method_missing(method, *args, &block)
+    def method_missing(method, ...)
       if method.to_s =~ /^get_(.*)_of$/
         property = Regexp.last_match(1).to_sym
         # Define the method so that we don't go trough method_missing next time (more efficient).
         define_property_method_for(property)
         # Then call it
-        send("get_#{property}_of".to_sym, *args, &block)
+        send(:"get_#{property}_of", ...)
       else
         # We really don't know this method.
         # Call original implementation of method_missing that will raise an exception.
@@ -391,7 +389,7 @@ module HybridPlatformsConductor
           end
           # Property values, per node name
           # Hash< String, Object >
-          metadata_from_cmdb = cmdb.send("get_#{cmdb_property}".to_sym, nodes_to_query, @metadata.slice(*nodes_to_query)).transform_values do |cmdb_result|
+          metadata_from_cmdb = cmdb.send(:"get_#{cmdb_property}", nodes_to_query, @metadata.slice(*nodes_to_query)).transform_values do |cmdb_result|
             cmdb_property == :others ? cmdb_result[property] : cmdb_result
           end.compact
           cmdb_log_header = "[CMDB #{cmdb.class.name.split('::').last}.#{cmdb_property}] -"

data/lib/hybrid_platforms_conductor/parallel_threads.rb

@@ -72,7 +72,7 @@ module HybridPlatformsConductor
                 nbr_processing = pools[:processing].size
                 nbr_processed = pools[:processed].size
               end
-              progress_bar.title = "Queue: #{nbr_to_process} - Processing: #{nbr_processing} - Done: #{nbr_processed} - Total: #{nbr_total}"
+              progress_bar.title = "Queue: #{nbr_to_process} - Processing: #{nbr_processing} - Done: #{nbr_processed} - Total: #{nbr_total}" if stdout_displayed?
               progress_bar.progress = nbr_processed
               break if nbr_processed == nbr_total
 

data/lib/hybrid_platforms_conductor/platform_handler.rb

@@ -17,7 +17,7 @@ module HybridPlatformsConductor
       # Make sure we define automatically a helper for such a platform
       mixin = Module.new
       platform_type = subclass.name.split('::').last.gsub(/([a-z\d])([A-Z\d])/, '\1_\2').downcase.to_sym
-      mixin.define_method("#{platform_type}_platform".to_sym) do |path: nil, git: nil, branch: 'master', name: nil, &platform_config_code|
+      mixin.define_method(:"#{platform_type}_platform") do |path: nil, git: nil, branch: 'master', name: nil, &platform_config_code|
         repository_path =
           if !path.nil?
             path

data/lib/hybrid_platforms_conductor/platforms_handler.rb

@@ -82,7 +82,7 @@ module HybridPlatformsConductor
     # Result::
     # * Array<PlatformHandler>: List of platform handlers
     def known_platforms(platform_type: nil)
-      (platform_type.nil? ? @platform_handlers.keys : [platform_type]).map { |search_platform_type| (@platform_handlers[search_platform_type] || []) }.flatten
+      (platform_type.nil? ? @platform_handlers.keys : [platform_type]).map { |search_platform_type| @platform_handlers[search_platform_type] || [] }.flatten
     end
 
     # Return the platform handler for a given platform name

data/lib/hybrid_platforms_conductor/services_handler.rb

@@ -52,7 +52,7 @@ module HybridPlatformsConductor
       @platforms_handler.inject_dependencies(nodes_handler: @nodes_handler, actions_executor: @actions_executor)
     end
 
-    # Are we allowed to deploy?
+    # Get a potential reason that would prevent deployment.
     # This checks eventual restrictions on deployments, considering environments, options, secrets...
     #
     # Parameters::
@@ -60,7 +60,7 @@ module HybridPlatformsConductor
     # * *local_environment* (Boolean): Are we deploying to a local environment?
     # Result::
     # * String or nil: Reason for which we are not allowed to deploy, or nil if deployment is authorized
-    def deploy_allowed?(
+    def barrier_to_deploy(
       services:,
       local_environment:
     )
@@ -198,13 +198,13 @@ module HybridPlatformsConductor
       # Get all platforms involved in the deployment of those services on this node
       platforms_for(node => services).keys.each.with_index do |platform, platform_idx|
         log_info.merge!(
-          "repo_name_#{platform_idx}".to_sym => platform.name
+          "repo_name_#{platform_idx}": platform.name
         )
         if platform.info.key?(:commit)
           log_info.merge!(
-            "commit_id_#{platform_idx}".to_sym => platform.info[:commit][:id],
-            "commit_message_#{platform_idx}".to_sym => platform.info[:commit][:message].split("\n").first,
-            "diff_files_#{platform_idx}".to_sym => (platform.info[:status][:changed_files] + platform.info[:status][:added_files] + platform.info[:status][:deleted_files] + platform.info[:status][:untracked_files]).join(', ')
+            "commit_id_#{platform_idx}": platform.info[:commit][:id],
+            "commit_message_#{platform_idx}": platform.info[:commit][:message].split("\n").first,
+            "diff_files_#{platform_idx}": (platform.info[:status][:changed_files] + platform.info[:status][:added_files] + platform.info[:status][:deleted_files] + platform.info[:status][:untracked_files]).join(', ')
           )
         end
       end

data/lib/hybrid_platforms_conductor/test_report.rb

@@ -155,11 +155,11 @@ module HybridPlatformsConductor
           first_criteria =
             case first_criteria
             when :test_name
-              proc { |test| test.name }
+              proc(&:name)
             when :platform
-              proc { |test| test.platform }
+              proc(&:platform)
             when :node
-              proc { |test| test.node }
+              proc(&:node)
             else
               raise "Unknown group criteria name: #{first_criteria}"
             end
@@ -232,7 +232,7 @@ module HybridPlatformsConductor
     def flatten_hash(hash)
       hash.each_with_object({}) do |(k, v), h|
         if v.is_a? Hash
-          flatten_hash(v).map { |h_k, h_v| h["#{k}.#{h_k}".to_sym] = h_v }
+          flatten_hash(v).map { |h_k, h_v| h[:"#{k}.#{h_k}"] = h_v }
         else
           h[k] = v
         end