hybrid_platforms_conductor 33.8.1 → 33.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 825b299003fe2fa6b3ec566bab9e42dcc45a7e320756977398a40ed571affd4a
-  data.tar.gz: c7fd81b8e969e7f422ef471c1463f92d5a3ffd4f1203f6d9bcbf06dfe7d8b115
+  metadata.gz: d88a5c946d63351586ef1b77ec9840e13e84af48c210bc8dfd1004abc27f547d
+  data.tar.gz: 8d04e563077d81cc72d5c3dc883f0010205a3880a255c1fb229ff3ba11771b49
 SHA512:
-  metadata.gz: f1fd8c7beb855136184ae08b06e1cef38a155cec4c4d006a96c593ac05d21064eaa2277089f1cf4cf37aec015d93d7726cb8fcc1d6f549f1f36fdd2814096f95
-  data.tar.gz: f877c9d45503be56bb36ee8cac5745722a9badf69aa614d1e7650cc41a40e943c12b228603c720831ef20cb4df5d56082e068566b5f2bd210ce0d226589722e2
+  metadata.gz: 211847acef3bff5d8e2e554a6262c783230989c3877b830cdbf4a3c5ff8a0fdb414669c891b9bf102f8adf26aed4000189df7565a1e33e93094ee384a577cbd1
+  data.tar.gz: 1faa911b27e3fdda61c605711de26598c6bac9a533519a4b2d583da479f1be9ea32265433d34cf9d8c6aaeee06d45e83b80e648c013ed2342df728a83f9bb6cf

data/CHANGELOG.md

@@ -1,3 +1,51 @@
+# [v33.9.0](https://github.com/sweet-delights/hybrid-platforms-conductor/compare/v33.8.4...v33.9.0) (2021-08-24 13:15:44)
+
+## Global changes
+### Patches
+
+* [[Feature(platform_handler)] [#102] Add the name option when declaring platforms to set the platform name](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/13ada7687f08b3f970521320e2b26ea42d9a6d7f)
+
+## Changes for platform_handler
+### Features
+
+* [[Feature(platform_handler)] [#102] Add the name option when declaring platforms to set the platform name](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/13ada7687f08b3f970521320e2b26ea42d9a6d7f)
+
+# [v33.8.4](https://github.com/sweet-delights/hybrid-platforms-conductor/compare/v33.8.3...v33.8.4) (2021-08-20 15:45:41)
+
+## Global changes
+### Patches
+
+* [[Fix(platform_handler_serverless_chef)] [#99] Make sure dynamic or unparsable cookbook/recipe names are considered using metadata for recipes dependencies](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/1d7feb24881f04cd3f31bc1e41712dfc4cfe715f)
+
+## Changes for platform_handler_serverless_chef
+### Patches
+
+* [[Fix(platform_handler_serverless_chef)] [#99] Make sure dynamic or unparsable cookbook/recipe names are considered using metadata for recipes dependencies](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/1d7feb24881f04cd3f31bc1e41712dfc4cfe715f)
+
+# [v33.8.3](https://github.com/sweet-delights/hybrid-platforms-conductor/compare/v33.8.2...v33.8.3) (2021-08-16 14:18:52)
+
+## Global changes
+### Patches
+
+* [[Fix(platform_handler_serverless_chef)] [#97] Fix git_diff_impacts when a library file is removed](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/da60609dbd395b9a78c5df8089b39255db1fed9f)
+
+## Changes for platform_handler_serverless_chef
+### Patches
+
+* [[Fix(platform_handler_serverless_chef)] [#97] Fix git_diff_impacts when a library file is removed](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/da60609dbd395b9a78c5df8089b39255db1fed9f)
+
+# [v33.8.2](https://github.com/sweet-delights/hybrid-platforms-conductor/compare/v33.8.1...v33.8.2) (2021-08-14 21:12:19)
+
+## Global changes
+### Patches
+
+* [[Fix(test_github_ci)] [#95] Make sure the github_ci test does not fail when a repository has no workflow run](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/e805c5b2d7e391c3c5205996fd56dadc14ddec7f)
+
+## Changes for test_github_ci
+### Patches
+
+* [[Fix(test_github_ci)] [#95] Make sure the github_ci test does not fail when a repository has no workflow run](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/e805c5b2d7e391c3c5205996fd56dadc14ddec7f)
+
 # [v33.8.1](https://github.com/sweet-delights/hybrid-platforms-conductor/compare/v33.8.0...v33.8.1) (2021-08-05 17:11:39)
 
 ### Patches

data/docs/config_dsl.md

@@ -28,19 +28,25 @@ This DSL can also be completed by plugins. Check [the plugins documentations](pl
 Declare a new platform of type `<platform_type>`, providing either a local path to it (using `path: '/path/to/files'`) or a git repository to it (using `git: 'git_url'`). The possible platform types are the names of the [`platform_handler` plugins](plugins.md#platform_handler).
 
 Git branches can also be specified using `branch: 'branch_name'`.
+
+The name of the platform (as used for example by the [`for_nodes`](#for_nodes) DSL) defaults to the base name of the directory in case of a local path, or the base name of the first remote in case of a git repository. It can be enforced to a given name using `name: 'platform_name'` (useful to avoid name conflicts and keep consistency with the rest of your configuration among the team).
+
 An optional code block taking the local repository path as parameter can also be specified to add configuration that is specific to this platform.
 
 Examples:
 ```ruby
-# Declare a platform of type Chef, located in a distant git repository
+# Declare a platform of type Chef, located in a distant git repository (its name will be my-chef-repo)
 chef_platform git: 'https://my-git.domain.com/project/my-chef-repo.git'
 
-# Declare a platform located in a local path
-chef_platform path: '/path/to/my-chef-repo'
+# Declare a platform located in a local path (its name will be my-other-chef-repo)
+chef_platform path: '/path/to/my-other-chef-repo'
+
+# Declare a platform located in a local path and forces its name (its name will be my-platform)
+chef_platform path: '/path/to/my-repo', name: 'my-platform'
 
 # Declare a platform from a git branch, and apply some configuration to it
 chef_platform(
-  git: 'https://my-git.domain.com/project/my-chef-repo.git',
+  git: 'https://my-git.domain.com/project/devops-chef-repo.git',
   branch: 'my-branch'
 ) do |path|
   # Here path will be a local path containing a checkout of the branch my-branch of the git repo.

data/lib/hybrid_platforms_conductor/hpc_plugins/log/remote_fs.rb

@@ -138,22 +138,23 @@ module HybridPlatformsConductor
                   value = Regexp.last_match(2)
                   key = key_str.to_sym
                   # Type-cast some values
-                  case key_str
-                  when 'date'
-                    # Date and time values
-                    # Thu Nov 23 18:43:01 UTC 2017
-                    deploy_info[key] = Time.parse("#{value} UTC")
-                  when 'debug'
-                    # Boolean values
-                    # Yes
-                    deploy_info[key] = (value == 'Yes')
-                  when /^diff_files_.+$/, 'services'
-                    # Array of strings
-                    # my_file.txt, other_file.txt
-                    deploy_info[key] = value.split(', ')
-                  else
-                    deploy_info[key] = value
-                  end
+                  deploy_info[key] =
+                    case key_str
+                    when 'date'
+                      # Date and time values
+                      # Thu Nov 23 18:43:01 UTC 2017
+                      Time.parse("#{value} UTC")
+                    when 'debug'
+                      # Boolean values
+                      # Yes
+                      value == 'Yes'
+                    when /^diff_files_.+$/, 'services'
+                      # Array of strings
+                      # my_file.txt, other_file.txt
+                      value.split(', ')
+                    else
+                      value
+                    end
                 else
                   deploy_info[:unknown_lines] = [] unless deploy_info.key?(:unknown_lines)
                   deploy_info[:unknown_lines] << line

data/lib/hybrid_platforms_conductor/hpc_plugins/platform_handler/serverless_chef/dsl_parser.rb

@@ -26,7 +26,7 @@ module HybridPlatformsConductor
           # Parameters::
           # * *source* (String): File to parse
           def parse(source)
-            instance_eval(File.read(source))
+            instance_eval(File.read(source), source)
           end
 
           # Intercept all missing methods

data/lib/hybrid_platforms_conductor/hpc_plugins/platform_handler/serverless_chef/recipes_tree_builder.rb

@@ -105,8 +105,59 @@ module HybridPlatformsConductor
             recipe_content = File.read("#{@platform.repository_path}/#{cookbook_dir}/#{cookbook}/recipes/#{recipe}.rb")
             # Check for include_recipe
             used_recipes = recipe_content.
-              scan(/include_recipe\s+["'](\w+(::\w+)?)["']/).
-              map { |(recipe_def, _sub_grp)| @platform.decode_recipe(recipe_def) }
+              scan(/include_recipe(\((.+)\)|\s+(.+)|\((.*))$/).
+              map do |(_match, match_1, match_2, match_3)|
+                case match_1 || match_2 || match_3
+                when /^["']([^:'"]+(::[^'"]+)?)["']$/
+                  # The recipe definition is given in a String
+                  used_cookbook, used_recipe = Regexp.last_match(1).split('::')
+                  used_recipe = 'default' if used_recipe.nil?
+                  if used_cookbook =~ /^\w+$/
+                    # Find the cookbook it belongs to
+                    used_cookbook_dir = @platform.known_cookbook_paths.find { |cookbook_path| File.exist?("#{@platform.repository_path}/#{cookbook_path}/#{used_cookbook}") }
+                    if used_recipe =~ /^\w+$/
+                      # Check that the recipe exists if we know the cookbook dir
+                      raise "Unknown recipe #{used_cookbook}::#{used_recipe} from cookbook #{@platform.repository_path}/#{used_cookbook_dir}/#{used_cookbook}." if !used_cookbook_dir.nil? && !File.exist?("#{@platform.repository_path}/#{used_cookbook_dir}/#{used_cookbook}/recipes/#{used_recipe}.rb")
+
+                      [
+                        [used_cookbook_dir, used_cookbook.to_sym, used_recipe.to_sym]
+                      ]
+                    elsif used_cookbook_dir
+                      # We are dealing with a dynamically named recipe.
+                      # Return all recipes of the cookbook if we know the cookbook dir
+                      Dir.glob("#{@platform.repository_path}/#{used_cookbook_dir}/#{used_cookbook}/recipes/*.rb").map do |used_recipe_file_path|
+                        [
+                          used_cookbook_dir,
+                          used_cookbook.to_sym,
+                          File.basename(used_recipe_file_path, '.rb').to_sym
+                        ]
+                      end
+                    else
+                      # We are dealing with a dynamically named recipe.
+                      # We have no cookbook dir - certainly comes from the supermarket.
+                      []
+                    end
+                  elsif used_recipe =~ /^\w+$/
+                    # We are dealing with a dynamically named cookbook, but the recipe name is known.
+                    # Look for this recipe in all cookbooks that are part of the metadata.
+                    dependent_cookbooks(cookbook_dir, cookbook).map do |dependent_cookbook|
+                      dependent_cookbook_dir = @platform.known_cookbook_paths.find { |cookbook_path| File.exist?("#{@platform.repository_path}/#{cookbook_path}/#{dependent_cookbook}") }
+                      if !dependent_cookbook_dir.nil? && File.exist?("#{@platform.repository_path}/#{dependent_cookbook_dir}/#{dependent_cookbook}/recipes/#{used_recipe}.rb")
+                        # Found a matching recipe name
+                        [dependent_cookbook_dir, dependent_cookbook, used_recipe.to_sym]
+                      end
+                    end.compact
+                  else
+                    # We are dealing with cynamically named cookbooks and recipes.
+                    # Consider we depend on all recipes of our dependent cookbooks.
+                    all_dependent_recipes(cookbook_dir, cookbook)
+                  end
+                else
+                  # The recipe definition is much more complex, so treat it as unparsable and consider we depnd on all recipes of our dependent cookbooks from metadata.
+                  all_dependent_recipes(cookbook_dir, cookbook)
+                end
+              end.
+              flatten(1)
             # Check for some helpers we know include some recipes
             @config.known_helpers_including_recipes.each do |helper_name, used_recipes_by_helper|
               if recipe_content =~ Regexp.new(/(\W|^)#{Regexp.escape(helper_name)}(\W|$)/)
@@ -222,6 +273,47 @@ module HybridPlatformsConductor
             end
           end
 
+          # Get the list of dependent cookbooks from a cookbook's metadata
+          #
+          # Parameters::
+          # * *cookbook_dir* (String): The cookbook directory
+          # * *cookbook* (Symbol): The cookbook name
+          # Result::
+          # * Array<Symbol>: List of dependent cookbooks
+          def dependent_cookbooks(cookbook_dir, cookbook)
+            # Read the metadata file
+            dsl_parser = DslParser.new
+            dsl_parser.parse("#{@platform.repository_path}/#{cookbook_dir}/#{cookbook}/metadata.rb")
+            dsl_parser.
+              calls.
+              map { |call_info| call_info[:method] == :depends ? call_info[:args].first.to_sym : nil }.
+              compact
+          end
+
+          # Get all recipes from all cookbooks that are a metadata dependency from a given cookbook.
+          #
+          # Parameters::
+          # * *cookbook_dir* (String): The cookbook directory
+          # * *cookbook* (Symbol): The cookbook name
+          # Result::
+          # * Array< [String, Symbol, Symbol] >: List of tuples [cookbook_dir, cookbook, recipe] used by this recipe
+          def all_dependent_recipes(cookbook_dir, cookbook)
+            dependent_cookbooks(cookbook_dir, cookbook).map do |dependent_cookbook|
+              dependent_cookbook_dir = @platform.known_cookbook_paths.find { |cookbook_path| File.exist?("#{@platform.repository_path}/#{cookbook_path}/#{dependent_cookbook}") }
+              if dependent_cookbook_dir.nil?
+                nil
+              else
+                Dir.glob("#{@platform.repository_path}/#{dependent_cookbook_dir}/#{dependent_cookbook}/recipes/*.rb").map do |used_recipe_file_path|
+                  [
+                    dependent_cookbook_dir,
+                    dependent_cookbook,
+                    File.basename(used_recipe_file_path, '.rb').to_sym
+                  ]
+                end
+              end
+            end.compact.flatten(1)
+          end
+
         end
 
       end

data/lib/hybrid_platforms_conductor/hpc_plugins/platform_handler/serverless_chef.rb

@@ -47,24 +47,10 @@ module HybridPlatformsConductor
         end
         extend_config_dsl_with MyDSLExtension, :init_serverless_chef
 
-        # Constructor
-        #
-        # Parameters::
-        # * *platform_type* (Symbol): Platform type
-        # * *repository_path* (String): Repository path
-        # * *logger* (Logger): Logger to be used [default: Logger.new(STDOUT)]
-        # * *logger_stderr* (Logger): Logger to be used for stderr [default: Logger.new(STDERR)]
-        # * *config* (Config): Config to be used. [default: Config.new]
-        # * *cmd_runner* (CmdRunner): Command executor to be used. [default: CmdRunner.new]
-        def initialize(
-          platform_type,
-          repository_path,
-          logger: Logger.new($stdout),
-          logger_stderr: Logger.new($stderr),
-          config: Config.new,
-          cmd_runner: CmdRunner.new
-        )
-          super
+        # Initialize a new instance of this platform handler.
+        # [API] - This method is optional.
+        # [API] - @cmd_runner is accessible.
+        def init
           # Mutex for getting the full recipes tree
           @recipes_tree_mutex = Mutex.new
         end
@@ -428,14 +414,16 @@ module HybridPlatformsConductor
                   end
                 when %r{libraries/(.+)}
                   # Find any recipe using methods from this library
-                  lib_methods_regexps = File.read("#{@repository_path}/#{impacted_file}").scan(/(\W|^)def\s+(\w+)(\W|$)/).map { |_grp_1, method_name, _grp_2| /(\W|^)#{Regexp.escape(method_name)}(\W|$)/ }
-                  known_cookbook_paths.each do |cookbooks_path|
-                    Dir.glob("#{@repository_path}/#{cookbooks_path}/**/recipes/*.rb") do |recipe_path|
-                      file_content = File.read(recipe_path)
-                      found_lib_regexp = lib_methods_regexps.find { |regexp| file_content =~ regexp }
-                      unless found_lib_regexp.nil?
-                        cookbook_name, recipe_name = recipe_path.match(%r{#{cookbooks_path}/(\w+)/recipes/(\w+)\.rb})[1..2]
-                        register.call("included library helper #{found_lib_regexp.source[6..-7]}", recipe_name, cookbook_name: cookbook_name)
+                  if File.exist?("#{@repository_path}/#{impacted_file}")
+                    lib_methods_regexps = File.read("#{@repository_path}/#{impacted_file}").scan(/(\W|^)def\s+(\w+)(\W|$)/).map { |_grp_1, method_name, _grp_2| /(\W|^)#{Regexp.escape(method_name)}(\W|$)/ }
+                    known_cookbook_paths.each do |cookbooks_path|
+                      Dir.glob("#{@repository_path}/#{cookbooks_path}/**/recipes/*.rb") do |recipe_path|
+                        file_content = File.read(recipe_path)
+                        found_lib_regexp = lib_methods_regexps.find { |regexp| file_content =~ regexp }
+                        unless found_lib_regexp.nil?
+                          cookbook_name, recipe_name = recipe_path.match(%r{#{cookbooks_path}/(\w+)/recipes/(\w+)\.rb})[1..2]
+                          register.call("included library helper #{found_lib_regexp.source[6..-7]}", recipe_name, cookbook_name: cookbook_name)
+                        end
                       end
                     end
                   end

data/lib/hybrid_platforms_conductor/hpc_plugins/test/github_ci.rb

@@ -18,10 +18,15 @@ module HybridPlatformsConductor
         def test
           for_each_github_repo do |client, repo_info|
             log_debug "Checking CI for Github repository #{repo_info[:slug]}"
-            last_status = client.repository_workflow_runs(repo_info[:slug])[:workflow_runs].
+            last_run = client.repository_workflow_runs(repo_info[:slug])[:workflow_runs].
               select { |run| run[:head_branch] == 'master' }.
-              max_by { |run| run[:created_at] }[:conclusion]
-            error "Last workflow status for repository #{repo_info[:slug]} is #{last_status}" unless last_status == 'success'
+              max_by { |run| run[:created_at] }
+            if last_run.nil?
+              error "No workflow run found for repository #{repo_info[:slug]}"
+            else
+              last_status = last_run[:conclusion]
+              error "Last workflow status for repository #{repo_info[:slug]} is #{last_status}" unless last_status == 'success'
+            end
           end
         end
 

data/lib/hybrid_platforms_conductor/platform_handler.rb

@@ -17,13 +17,13 @@ module HybridPlatformsConductor
       # Make sure we define automatically a helper for such a platform
       mixin = Module.new
       platform_type = subclass.name.split('::').last.gsub(/([a-z\d])([A-Z\d])/, '\1_\2').downcase.to_sym
-      mixin.define_method("#{platform_type}_platform".to_sym) do |path: nil, git: nil, branch: 'master', &platform_config_code|
+      mixin.define_method("#{platform_type}_platform".to_sym) do |path: nil, git: nil, branch: 'master', name: nil, &platform_config_code|
         repository_path =
           if !path.nil?
             path
           elsif !git.nil?
             # Clone in a local repository
-            local_repository_path = "#{@git_platforms_dir}/#{File.basename(git)[0..-File.extname(git).size - 1]}"
+            local_repository_path = "#{@git_platforms_dir}/#{name.nil? ? File.basename(git)[0..-File.extname(git).size - 1] : name}"
             unless File.exist?(local_repository_path)
               branch = "refs/heads/#{branch}" unless branch.include?('/')
               local_ref = "refs/remotes/origin/#{branch.split('/').last}"
@@ -37,8 +37,10 @@ module HybridPlatformsConductor
           else
             raise 'The platform has to be defined with either a path or a git URL'
           end
-        @platform_dirs[platform_type] = [] unless @platform_dirs.key?(platform_type)
-        @platform_dirs[platform_type] << repository_path
+        @platforms_info[platform_type] = {} unless @platforms_info.key?(platform_type)
+        raise "Platform repository path #{repository_path} is declared several times." if @platforms_info.values.any? { |known_platforms_info| known_platforms_info.key?(repository_path) }
+
+        @platforms_info[platform_type][repository_path] = name.nil? ? {} : { name: name }
         platform_config_code&.call(repository_path)
       end
       # Register this new mixin in the Config DSL
@@ -66,18 +68,21 @@ module HybridPlatformsConductor
     # * *logger_stderr* (Logger): Logger to be used for stderr [default: Logger.new(STDERR)]
     # * *config* (Config): Config to be used. [default: Config.new]
     # * *cmd_runner* (CmdRunner): Command executor to be used. [default: CmdRunner.new]
+    # * *name* (String or nil): Platform name, or nil for defaults (based on path or git remote) [default: nil]
     def initialize(
       platform_type,
       repository_path,
       logger: Logger.new($stdout),
       logger_stderr: Logger.new($stderr),
       config: Config.new,
-      cmd_runner: CmdRunner.new
+      cmd_runner: CmdRunner.new,
+      name: nil
     )
       super(logger: logger, logger_stderr: logger_stderr, config: config)
       @platform_type = platform_type
       @repository_path = repository_path
       @cmd_runner = cmd_runner
+      @name = name
       init if respond_to?(:init)
     end
 
@@ -142,7 +147,12 @@ module HybridPlatformsConductor
             git_status = git.status
             git_commit = git.log.first
             {
-              repo_name: git.remotes.empty? ? File.basename(@repository_path) : File.basename(git.remotes.first.url).gsub(/\.git$/, ''),
+              repo_name:
+                if @name.nil?
+                  git.remotes.empty? ? File.basename(@repository_path) : File.basename(git.remotes.first.url).gsub(/\.git$/, '')
+                else
+                  @name
+                end,
               commit: {
                 id: git_commit.sha,
                 ref: git_commit.name,
@@ -162,7 +172,7 @@ module HybridPlatformsConductor
             }
           else
             {
-              repo_name: File.basename(@repository_path)
+              repo_name: @name.nil? ? File.basename(@repository_path) : @name
             }
           end
       end

data/lib/hybrid_platforms_conductor/platforms_handler.rb

@@ -9,13 +9,14 @@ module HybridPlatformsConductor
     # Add some config DSL
     module ConfigDSLExtension
 
-      # List of platforms repository directories, per platform type
-      #   Hash<Symbol, Array<String> >
-      attr_reader :platform_dirs
+      # List of platforms repository directories and their associated info, per platform type
+      #   Hash<Symbol,        Hash<String,          Hash<Symbol,Object> > >
+      #   Hash<platform_type, Hash<repository_path, Hash<Symbol,Object> > >
+      attr_reader :platforms_info
 
       # Mixin initializer
       def init_platforms_handler
-        @platform_dirs = {}
+        @platforms_info = {}
         # Directory in which platforms are cloned
         @git_platforms_dir = "#{@hybrid_platforms_dir}/cloned_platforms"
       end
@@ -46,15 +47,16 @@ module HybridPlatformsConductor
       # Hash<Symbol, Array<PlatformHandler> >
       @platform_handlers = {}
       # Read all platforms from the config
-      @config.platform_dirs.each do |platform_type, repositories|
-        repositories.each do |repository_path|
+      @config.platforms_info.each do |platform_type, repositories_info|
+        repositories_info.each do |repository_path, repository_info|
           platform_handler = @platform_types[platform_type].new(
             platform_type,
             repository_path,
             logger: @logger,
             logger_stderr: @logger_stderr,
             config: @config,
-            cmd_runner: @cmd_runner
+            cmd_runner: @cmd_runner,
+            name: repository_info[:name]
           )
           # Check that this platform has unique name
           raise "Platform name #{platform_handler.name} is declared several times." if @platform_handlers.values.flatten.any? { |known_platform| known_platform.name == platform_handler.name }

data/lib/hybrid_platforms_conductor/version.rb

@@ -1,5 +1,5 @@
 module HybridPlatformsConductor
 
-  VERSION = '33.8.1'
+  VERSION = '33.9.0'
 
 end

data/spec/hybrid_platforms_conductor_test/api/nodes_handler/nodes_selectors_spec.rb

@@ -15,6 +15,10 @@ describe HybridPlatformsConductor::NodesHandler do
           },
           'platform2' => {
             nodes: { 'node4' => {}, 'node5' => { services: %w[service3 service1] }, 'node6' => {} }
+          },
+          'platform3' => {
+            nodes: { 'node7' => {} },
+            name: 'other_platform'
           }
         },
         &block
@@ -24,12 +28,13 @@ describe HybridPlatformsConductor::NodesHandler do
     # List all tests of nodes selectors, and the corresponding nodes list they should be resolved into
     {
       [] => [],
-      [{ all: true }] => %w[node1 node2 node3 node4 node5 node6],
+      [{ all: true }] => %w[node1 node2 node3 node4 node5 node6 node7],
       'node1' => %w[node1],
       '/node[12]/' => %w[node1 node2],
       [{ list: 'nodeslist1' }] => %w[node1 node3],
       [{ list: 'nodeslist2' }] => %w[node1 node2],
       [{ platform: 'platform2' }] => %w[node4 node5 node6],
+      [{ platform: 'other_platform' }] => %w[node7],
       [{ service: 'service1' }] => %w[node2 node5],
       ['/node[12]/', { service: 'service1' }] => %w[node1 node2 node5],
       [{ git_diff: { platform: 'platform2' } }] => %w[node4 node5 node6]
@@ -45,13 +50,13 @@ describe HybridPlatformsConductor::NodesHandler do
 
     it 'fails when selecting unknown nodes' do
       with_test_platform_for_nodes do
-        expect { test_nodes_handler.select_nodes('node1', 'node7') }.to raise_error(RuntimeError, 'Unknown nodes: node7')
+        expect { test_nodes_handler.select_nodes('node1', 'unknown_node') }.to raise_error(RuntimeError, 'Unknown nodes: unknown_node')
       end
     end
 
     it 'ignore unknown nodes when asked' do
       with_test_platform_for_nodes do
-        expect(test_nodes_handler.select_nodes(%w[node1 node7], ignore_unknowns: true).sort).to eq %w[node1 node7].sort
+        expect(test_nodes_handler.select_nodes(%w[node1 unknown_node], ignore_unknowns: true).sort).to eq %w[node1 unknown_node].sort
       end
     end
 
@@ -105,7 +110,7 @@ describe HybridPlatformsConductor::NodesHandler do
 
     it 'considers all nodes for en empty nodes selector stack' do
       with_test_platform_for_nodes do
-        expect(test_nodes_handler.select_from_nodes_selector_stack([]).sort).to eq %w[node1 node2 node3 node4 node5 node6].sort
+        expect(test_nodes_handler.select_from_nodes_selector_stack([]).sort).to eq %w[node1 node2 node3 node4 node5 node6 node7].sort
       end
     end
 

data/spec/hybrid_platforms_conductor_test/api/platform_handlers/serverless_chef/diff_impacts_spec.rb

@@ -158,6 +158,16 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
       end
     end
 
+    it 'returns no impacted service due to a library helper being removed' do
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('cookbooks/test_cookbook_2/libraries/removed.rb' => {})).to eq [
+          [],
+          [],
+          false
+        ]
+      end
+    end
+
     it 'ignored impacted service from an unknown helper' do
       with_serverless_chef_platforms('recipes') do |platform, repository|
         File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EO_RECIPE)
@@ -225,6 +235,59 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
       end
     end
 
+    it 'returns impacted service due to a usage of another cookbook\'s recipe using parenthesis' do
+      with_serverless_chef_platforms('recipes') do |platform, repository|
+        File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EO_RECIPE)
+          include_recipe('test_cookbook_2::other_recipe')
+        EO_RECIPE
+        expect(platform.impacts_from('cookbooks/test_cookbook_2/recipes/other_recipe.rb' => {})).to eq [
+          [],
+          %w[test_policy_1],
+          false
+        ]
+      end
+    end
+
+    it 'returns impacted service due to a usage of another cookbook\'s recipe using dynamic recipe name' do
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('cookbooks/test_cookbook_4/recipes/recipe_1.rb' => {})).to eq [
+          [],
+          %w[test_policy_31 test_policy_33 test_policy_35],
+          false
+        ]
+      end
+    end
+
+    it 'returns impacted service due to a usage of another cookbook\'s recipe using dynamic cookbook name' do
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('cookbooks/test_cookbook_4/recipes/recipe_2.rb' => {})).to eq [
+          [],
+          %w[test_policy_31 test_policy_32 test_policy_33 test_policy_35],
+          false
+        ]
+      end
+    end
+
+    it 'returns impacted service due to a usage of another cookbook\'s recipe using dynamic cookbook and recipe names' do
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('cookbooks/test_cookbook_4/recipes/recipe_3.rb' => {})).to eq [
+          [],
+          %w[test_policy_31 test_policy_33 test_policy_35],
+          false
+        ]
+      end
+    end
+
+    it 'returns impacted service due to a usage of another cookbook\'s recipe using dynamic or unparsable cookbook and recipe names, using metadata' do
+      with_serverless_chef_platforms('recipes') do |platform|
+        expect(platform.impacts_from('cookbooks/test_cookbook_5/recipes/recipe_1.rb' => {})).to eq [
+          [],
+          %w[test_policy_33 test_policy_35],
+          false
+        ]
+      end
+    end
+
     it 'ignores cookbooks from cookbook paths that are not configured' do
       with_serverless_chef_platforms('several_cookbooks') do |platform, repository|
         File.write("#{repository}/cookbooks/test_cookbook_1/recipes/default.rb", <<~EO_RECIPE)

data/spec/hybrid_platforms_conductor_test/api/platforms_handler_spec.rb

@@ -2,22 +2,22 @@ describe HybridPlatformsConductor::PlatformsHandler do
 
   context 'when checking config specific DSL' do
 
-    it 'returns platform directories along with platform types' do
+    it 'returns platforms info' do
       with_test_platforms(
         {
           'platform1' => { platform_type: :test },
           'platform2' => { platform_type: :test_2 },
-          'platform3' => { platform_type: :test }
+          'platform3' => { platform_type: :test, name: 'other_platform' }
         }
       ) do |repositories|
-        expect(test_config.platform_dirs.keys.sort).to eq %i[test test_2].sort
-        expect(test_config.platform_dirs[:test].sort).to eq [
-          repositories['platform1'],
-          repositories['platform3']
-        ].sort
-        expect(test_config.platform_dirs[:test_2].sort).to eq [
-          repositories['platform2']
-        ].sort
+        expect(test_config.platforms_info.keys.sort).to eq %i[test test_2].sort
+        expect(test_config.platforms_info[:test]).to eq(
+          repositories['platform1'] => {},
+          repositories['platform3'] => { name: 'other_platform' }
+        )
+        expect(test_config.platforms_info[:test_2]).to eq(
+          repositories['platform2'] => {}
+        )
       end
     end
 
@@ -55,27 +55,57 @@ describe HybridPlatformsConductor::PlatformsHandler do
       {
         'platform1' => { platform_type: :test },
         'platform2' => { platform_type: :test_2 },
-        'platform3' => { platform_type: :test }
+        'platform3' => { platform_type: :test, name: 'other_platform' }
       }
     ) do
-      expect(test_platforms_handler.known_platforms.map(&:name).sort).to eq %w[platform1 platform2 platform3].sort
+      expect(test_platforms_handler.known_platforms.map(&:name).sort).to eq %w[platform1 platform2 other_platform].sort
     end
   end
 
   it 'fails if several platforms share the same name' do
     with_repository('platform1') do |repository|
+      FileUtils.mkdir_p "#{repository}/platform1"
       with_test_platforms(
         {
           'platform1' => { platform_type: :test },
           'platform2' => { platform_type: :test_2 }
         },
-        additional_config: "test_2_platform path: \'#{repository}\'"
+        additional_config: "test_2_platform path: \'#{repository}/platform1\'"
       ) do
         expect { test_platforms_handler.known_platforms }.to raise_error 'Platform name platform1 is declared several times.'
       end
     end
   end
 
+  it 'fails if several platforms share the same path' do
+    with_repository('platform1') do |repository|
+      with_test_platforms(
+        {
+          'platform1' => { platform_type: :test },
+          'platform2' => { platform_type: :test_2 }
+        },
+        additional_config: "test_2_platform path: \'#{repository}\', name: 'other_platform'"
+      ) do
+        expect { test_platforms_handler.known_platforms }.to raise_error "Platform repository path #{repository} is declared several times."
+      end
+    end
+  end
+
+  it 'can differentiate several platforms sharing the same path ending but with different explicit names' do
+    with_repository('platform1') do |repository|
+      FileUtils.mkdir_p "#{repository}/platform1"
+      with_test_platforms(
+        {
+          'platform1' => { platform_type: :test },
+          'platform2' => { platform_type: :test_2 }
+        },
+        additional_config: "test_platform path: \'#{repository}/platform1\', name: 'other_platform'"
+      ) do
+        expect(test_platforms_handler.known_platforms.map(&:name).sort).to eq %w[platform1 platform2 other_platform].sort
+      end
+    end
+  end
+
   it 'returns defined platforms filtered by platform type' do
     with_test_platforms(
       {

data/spec/hybrid_platforms_conductor_test/helpers/platforms_handler_helpers.rb

@@ -73,7 +73,9 @@ module HybridPlatformsConductorTest
       # Clean-up at the end.
       #
       # Parameters::
-      # * *platforms_info* (Hash<String,Object>): Platforms info for the test platform
+      # * *platforms_info* (Hash<String,Object>): Platforms info for the test platform:
+      #   * *platform_type* (Symbol): Name of the platform handler plugin for this platform
+      #   * *name* (String): Optional name to give the platform [optional]
       # * *as_git* (Boolean): Do we initialize those repositories as Git repositories? [default: false]
       # * *additional_config* (String): Additional config to be added [default: '']
       # * Proc: Code called with the environment ready
@@ -86,7 +88,7 @@ module HybridPlatformsConductorTest
             repositories.map do |platform, dir|
               platform_type = platforms_info[platform].key?(:platform_type) ? platforms_info[platform][:platform_type] : :test
               platform_types << platform_type unless platform_types.include?(platform_type)
-              "#{platform_type}_platform path: '#{dir}'"
+              "#{platform_type}_platform path: '#{dir}'#{platforms_info[platform].key?(:name) ? ", name: '#{platforms_info[platform][:name]}'" : ''}"
             end.join("\n") + "\n#{additional_config}"
           ) do
             register_platform_handlers(platform_types.map do |platform_type|

data/spec/hybrid_platforms_conductor_test/platform_handler_plugins/test.rb

@@ -200,10 +200,11 @@ module HybridPlatformsConductorTest
       # Result::
       # * Hash<Symbol, Object>: Platform info (check TestPlatformHandler#platforms_info to know about properties)
       def platform_info
+        _repo_base_name, found_platform_info = HybridPlatformsConductorTest::PlatformHandlerPlugins::Test.platforms_info.find { |search_repo_base_name, search_platform_info| (search_platform_info[:name] || search_repo_base_name) == name }
         {
           nodes: {},
           nodes_lists: {}
-        }.merge(HybridPlatformsConductorTest::PlatformHandlerPlugins::Test.platforms_info[name])
+        }.merge(found_platform_info)
       end
 
       # Return the node info of a given node

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_3/metadata.rb

@@ -0,0 +1,13 @@
+name             'test_cookbook_3'
+maintainer       'Muriel Salvan'
+maintainer_email 'muriel@x-aeon.com'
+supports         'debian'
+chef_version     '>= 14.8'
+source_url       'https://x-aeon.com'
+issues_url       'https://x-aeon.com'
+license          'BSD'
+description      'Installs/Configures test_cookbook_3'
+long_description ''
+version          '0.1.0'
+depends          'test_cookbook_4'
+depends          'test_cookbook_5'

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_3/recipes/31_unknown_recipe_include.rb

@@ -0,0 +1,2 @@
+recipe_name = 'recipe_1'
+include_recipe "test_cookbook_4::#{recipe_name}"

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_3/recipes/32_unknown_cookbook_include.rb

@@ -0,0 +1,2 @@
+cookbook_name = 'test_cookbook_4'
+include_recipe "#{cookbook_name}::recipe_2"

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_3/recipes/33_unknown_include.rb

@@ -0,0 +1,3 @@
+cookbook_name = 'test_cookbook_4'
+recipe_name = 'recipe_3'
+include_recipe "#{cookbook_name}::#{recipe_name}"

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_3/recipes/34_known_include.rb

@@ -0,0 +1 @@
+include_recipe 'test_cookbook_4::recipe_4'

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_3/recipes/35_unparsable_include.rb

@@ -0,0 +1,7 @@
+cookbook_name = ENV['cookbook_name']
+recipe_name = ENV['recipe_name']
+# rubocop:disable Style/StringConcatenation
+include_recipe(
+  cookbook_name + '::' + recipe_name
+)
+# rubocop:enable Style/StringConcatenation

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_4/recipes/recipe_1.rb

@@ -0,0 +1 @@
+# Recipe code

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_4/recipes/recipe_2.rb

@@ -0,0 +1 @@
+# Recipe code

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_4/recipes/recipe_3.rb

@@ -0,0 +1 @@
+# Recipe code

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_4/recipes/recipe_4.rb

@@ -0,0 +1 @@
+# Recipe code

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_5/recipes/recipe_1.rb

@@ -0,0 +1 @@
+# Recipe code

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_5/recipes/recipe_2.rb

@@ -0,0 +1 @@
+# Recipe code

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/nodes/node31.json

@@ -0,0 +1,10 @@
+{
+  "name": "node31",
+  "normal": {
+    "description": "Node 31",
+    "image": "debian_9",
+    "private_ips": ["172.16.0.31"]
+  },
+  "policy_name": "test_policy_31",
+  "policy_group": "test_group"
+}

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/nodes/node32.json

@@ -0,0 +1,10 @@
+{
+  "name": "node32",
+  "normal": {
+    "description": "Node 32",
+    "image": "debian_9",
+    "private_ips": ["172.16.0.32"]
+  },
+  "policy_name": "test_policy_32",
+  "policy_group": "test_group"
+}

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/nodes/node33.json

@@ -0,0 +1,10 @@
+{
+  "name": "node33",
+  "normal": {
+    "description": "Node 33",
+    "image": "debian_9",
+    "private_ips": ["172.16.0.33"]
+  },
+  "policy_name": "test_policy_33",
+  "policy_group": "test_group"
+}

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/nodes/node34.json

@@ -0,0 +1,10 @@
+{
+  "name": "node34",
+  "normal": {
+    "description": "Node 34",
+    "image": "debian_9",
+    "private_ips": ["172.16.0.34"]
+  },
+  "policy_name": "test_policy_34",
+  "policy_group": "test_group"
+}

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/nodes/node35.json

@@ -0,0 +1,10 @@
+{
+  "name": "node35",
+  "normal": {
+    "description": "Node 35",
+    "image": "debian_9",
+    "private_ips": ["172.16.0.35"]
+  },
+  "policy_name": "test_policy_35",
+  "policy_group": "test_group"
+}

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/policyfiles/test_policy_31.rb

@@ -0,0 +1,4 @@
+name File.basename(__FILE__, '.rb')
+default_source :supermarket
+default_source :chef_repo, '..'
+run_list 'recipe[test_cookbook_3::31_unknown_recipe_include]'

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/policyfiles/test_policy_32.rb

@@ -0,0 +1,4 @@
+name File.basename(__FILE__, '.rb')
+default_source :supermarket
+default_source :chef_repo, '..'
+run_list 'recipe[test_cookbook_3::32_unknown_cookbook_include]'

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/policyfiles/test_policy_33.rb

@@ -0,0 +1,4 @@
+name File.basename(__FILE__, '.rb')
+default_source :supermarket
+default_source :chef_repo, '..'
+run_list 'recipe[test_cookbook_3::33_unknown_include]'

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/policyfiles/test_policy_34.rb

@@ -0,0 +1,4 @@
+name File.basename(__FILE__, '.rb')
+default_source :supermarket
+default_source :chef_repo, '..'
+run_list 'recipe[test_cookbook_3::34_known_include]'

data/spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/policyfiles/test_policy_35.rb

@@ -0,0 +1,4 @@
+name File.basename(__FILE__, '.rb')
+default_source :supermarket
+default_source :chef_repo, '..'
+run_list 'recipe[test_cookbook_3::35_unparsable_include]'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hybrid_platforms_conductor
 version: !ruby/object:Gem::Version
-  version: 33.8.1
+  version: 33.9.0
 platform: ruby
 authors:
 - Muriel Salvan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-08-05 00:00:00.000000000 Z
+date: 2021-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: range_operators
@@ -1003,10 +1003,32 @@ files:
 - spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_2/recipes/default.rb
 - spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_2/recipes/other_recipe.rb
 - spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_2/resources/my_resource.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_3/metadata.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_3/recipes/31_unknown_recipe_include.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_3/recipes/32_unknown_cookbook_include.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_3/recipes/33_unknown_include.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_3/recipes/34_known_include.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_3/recipes/35_unparsable_include.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_4/recipes/recipe_1.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_4/recipes/recipe_2.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_4/recipes/recipe_3.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_4/recipes/recipe_4.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_5/recipes/recipe_1.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/cookbooks/test_cookbook_5/recipes/recipe_2.rb
 - spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/nodes/node1.json
 - spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/nodes/node2.json
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/nodes/node31.json
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/nodes/node32.json
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/nodes/node33.json
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/nodes/node34.json
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/nodes/node35.json
 - spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/policyfiles/test_policy_1.rb
 - spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/policyfiles/test_policy_2.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/policyfiles/test_policy_31.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/policyfiles/test_policy_32.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/policyfiles/test_policy_33.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/policyfiles/test_policy_34.rb
+- spec/hybrid_platforms_conductor_test/serverless_chef_repositories/recipes/policyfiles/test_policy_35.rb
 - spec/hybrid_platforms_conductor_test/serverless_chef_repositories/several_cookbooks/config.rb
 - spec/hybrid_platforms_conductor_test/serverless_chef_repositories/several_cookbooks/cookbooks/test_cookbook_1/recipes/default.rb
 - spec/hybrid_platforms_conductor_test/serverless_chef_repositories/several_cookbooks/nodes/node1.json