hybrid_platforms_conductor 32.18.0 → 33.0.4

data/lib/hybrid_platforms_conductor/hpc_plugins/test/jenkins_ci_masters_ok.rb

@@ -11,7 +11,7 @@ module HybridPlatformsConductor
       # Check that all repositories have a successful master branch on a Jenkins CI
       class JenkinsCiMastersOk < HybridPlatformsConductor::Test
 
-        self.extend_config_dsl_with CommonConfigDsl::Bitbucket, :init_bitbucket
+        extend_config_dsl_with CommonConfigDsl::Bitbucket, :init_bitbucket
 
         SUCCESS_STATUSES = [
           # Add nil as the status of a currently running job (which is always the case for hybrid-platforms) is null
@@ -29,17 +29,15 @@ module HybridPlatformsConductor
             else
               master_info_url = "#{repo_info[:jenkins_ci_url]}/job/master/api/json"
               Credentials.with_credentials_for(:jenkins_ci, @logger, @logger_stderr, url: master_info_url) do |jenkins_user, jenkins_password|
-                begin
-                  # Get the master branch info from the API
-                  master_info = JSON.parse(open(master_info_url, http_basic_authentication: [jenkins_user, jenkins_password]).read)
-                  # Get the last build's URL
-                  last_build_info_url = "#{master_info['lastBuild']['url']}/api/json"
-                  last_build_info = JSON.parse(open(last_build_info_url, http_basic_authentication: [jenkins_user, jenkins_password]).read)
-                  log_debug "Build info for #{master_info_url}:\n#{JSON.pretty_generate(last_build_info)}"
-                  error "Last build for job #{repo_info[:project]}/#{repo_info[:name]} is in status #{last_build_info['result']}: #{master_info['lastBuild']['url']}" unless SUCCESS_STATUSES.include?(last_build_info['result'])
-                rescue
-                  error "Error while checking Jenkins CI job for #{repo_info[:project]}/#{repo_info[:name]} from URL #{master_info_url}: #{$!}"
-                end
+                # Get the master branch info from the API
+                master_info = JSON.parse(URI.parse(master_info_url).open(http_basic_authentication: [jenkins_user, jenkins_password]).read)
+                # Get the last build's URL
+                last_build_info_url = "#{master_info['lastBuild']['url']}/api/json"
+                last_build_info = JSON.parse(URI.parse(last_build_info_url).open(http_basic_authentication: [jenkins_user, jenkins_password]).read)
+                log_debug "Build info for #{master_info_url}:\n#{JSON.pretty_generate(last_build_info)}"
+                error "Last build for job #{repo_info[:project]}/#{repo_info[:name]} is in status #{last_build_info['result']}: #{master_info['lastBuild']['url']}" unless SUCCESS_STATUSES.include?(last_build_info['result'])
+              rescue
+                error "Error while checking Jenkins CI job for #{repo_info[:project]}/#{repo_info[:name]} from URL #{master_info_url}: #{$ERROR_INFO}"
               end
             end
           end

data/lib/hybrid_platforms_conductor/hpc_plugins/test/linear_strategy.rb

@@ -17,7 +17,7 @@ module HybridPlatformsConductor
             log_to_stdout: log_debug?
           )
           stdout.split("\n").each do |merge_commit_id|
-            _exit_status, stdout, _stderr = @cmd_runner.run_cmd(<<~EOS, log_to_stdout: log_debug?, no_exception: true, expected_code: [0, 1])
+            _exit_status, stdout, _stderr = @cmd_runner.run_cmd(<<~EO_BASH, log_to_stdout: log_debug?, no_exception: true, expected_code: [0, 1])
               cd #{@platform.repository_path} && \
               git --no-pager log \
                 $(git merge-base \
@@ -27,14 +27,14 @@ module HybridPlatformsConductor
                 --pretty=format:\"%H\" \
                 --graph \
               | grep '|'
-            EOS
-            if !stdout.empty?
-              _exit_status, stdout, _stderr = @cmd_runner.run_cmd(
-                "cd #{@platform.repository_path} && git --no-pager log #{merge_commit_id} --pretty=format:%aI",
-                log_to_stdout: log_debug?
-              )
-              error "Git history is not linear because of Merge commit #{merge_commit_id}" if Time.now - Time.parse(stdout.strip) < LOOKING_PERIOD
-            end
+            EO_BASH
+            next if stdout.empty?
+
+            _exit_status, stdout, _stderr = @cmd_runner.run_cmd(
+              "cd #{@platform.repository_path} && git --no-pager log #{merge_commit_id} --pretty=format:%aI",
+              log_to_stdout: log_debug?
+            )
+            error "Git history is not linear because of Merge commit #{merge_commit_id}" if Time.now - Time.parse(stdout.strip) < LOOKING_PERIOD
           end
         end
 

data/lib/hybrid_platforms_conductor/hpc_plugins/test/local_users.rb

@@ -24,7 +24,7 @@ module HybridPlatformsConductor
           # Array< Hash<Symbol, Object> >
           attr_reader :users_that_should_be_present
 
-          # Initialize the DSL 
+          # Initialize the DSL
           def init_local_users_test
             @users_that_should_be_absent = []
             @users_that_should_be_present = []
@@ -54,7 +54,7 @@ module HybridPlatformsConductor
 
         end
 
-        self.extend_config_dsl_with ConfigDslExtension, :init_local_users_test
+        extend_config_dsl_with ConfigDslExtension, :init_local_users_test
 
         # Check my_test_plugin.rb.sample documentation for signature details.
         def test_on_node

data/lib/hybrid_platforms_conductor/hpc_plugins/test/mounts.rb

@@ -24,7 +24,7 @@ module HybridPlatformsConductor
           # Array< Hash<Symbol, Object> >
           attr_reader :mount_rules_that_should_be_present
 
-          # Initialize the DSL 
+          # Initialize the DSL
           def init_mounts_test
             @mount_rules_that_should_be_absent = []
             @mount_rules_that_should_be_present = []
@@ -58,7 +58,7 @@ module HybridPlatformsConductor
 
         end
 
-        self.extend_config_dsl_with ConfigDslExtension, :init_mounts_test
+        extend_config_dsl_with ConfigDslExtension, :init_mounts_test
 
         # Check my_test_plugin.rb.sample documentation for signature details.
         def test_on_node

data/lib/hybrid_platforms_conductor/hpc_plugins/test/orphan_files.rb

@@ -18,7 +18,7 @@ module HybridPlatformsConductor
           # Array< Hash<Symbol, Object> >
           attr_reader :ignored_orphan_files_paths
 
-          # Initialize the DSL 
+          # Initialize the DSL
           def init_orphan_files_test
             # List of paths to ignore info. Each info has the following properties:
             # * *nodes_selectors_stack* (Array<Object>): Stack of nodes selectors impacted by this rule
@@ -34,13 +34,13 @@ module HybridPlatformsConductor
           def ignore_orphan_files_from(paths_to_ignore)
             @ignored_orphan_files_paths << {
               ignored_paths: paths_to_ignore.is_a?(Array) ? paths_to_ignore : [paths_to_ignore],
-              nodes_selectors_stack: current_nodes_selectors_stack,
+              nodes_selectors_stack: current_nodes_selectors_stack
             }
           end
 
         end
 
-        self.extend_config_dsl_with ConfigDslExtension, :init_orphan_files_test
+        extend_config_dsl_with ConfigDslExtension, :init_orphan_files_test
 
         # List of directories to always ignore
         DIRECTORIES_TO_ALWAYS_IGNORE = [
@@ -53,12 +53,13 @@ module HybridPlatformsConductor
         def test_on_node
           {
             # TODO: Access the user correctly when the user notion will be moved out of the ssh connector
-            "#{@deployer.instance_variable_get(:@actions_executor).connector(:ssh).ssh_user == 'root' ? '' : "#{@nodes_handler.sudo_on(@node)} "}/usr/bin/find / \\( #{@nodes_handler.
-              select_confs_for_node(@node, @config.ignored_orphan_files_paths).
-              inject(DIRECTORIES_TO_ALWAYS_IGNORE) { |merged_paths, paths_to_ignore_info| merged_paths + paths_to_ignore_info[:ignored_paths] }.
-              uniq.
-              map { |dir| "-path #{dir}" }.
-              join(' -o ')
+            "#{@deployer.instance_variable_get(:@actions_executor).connector(:ssh).ssh_user == 'root' ? '' : "#{@nodes_handler.sudo_on(@node)} "}/usr/bin/find / \\( #{
+              @nodes_handler.
+                select_confs_for_node(@node, @config.ignored_orphan_files_paths).
+                inject(DIRECTORIES_TO_ALWAYS_IGNORE) { |merged_paths, paths_to_ignore_info| merged_paths + paths_to_ignore_info[:ignored_paths] }.
+                uniq.
+                map { |dir| "-path #{dir}" }.
+                join(' -o ')
             } \\) -prune -o -nogroup -nouser -print" => {
               validator: proc do |stdout|
                 assert_equal stdout, [], "#{stdout.size} orphan files found.", stdout.join("\n")

data/lib/hybrid_platforms_conductor/hpc_plugins/test/ports.rb

@@ -21,7 +21,7 @@ module HybridPlatformsConductor
           # Array< Hash<Symbol, Object> >
           attr_reader :ports_rules
 
-          # Initialize the DSL 
+          # Initialize the DSL
           def init_ports_test
             @ports_rules = []
           end
@@ -52,7 +52,7 @@ module HybridPlatformsConductor
 
         end
 
-        self.extend_config_dsl_with ConfigDslExtension, :init_ports_test
+        extend_config_dsl_with ConfigDslExtension, :init_ports_test
 
         # Check my_test_plugin.rb.sample documentation for signature details.
         def test_for_node

data/lib/hybrid_platforms_conductor/hpc_plugins/test/private_ips.rb

@@ -11,15 +11,15 @@ module HybridPlatformsConductor
         def test
           # Get a map of private IPs per node
           @nodes_handler.prefetch_metadata_of @nodes_handler.known_nodes, :private_ips
-          private_ips = Hash[@nodes_handler.
+          private_ips = @nodes_handler.
             known_nodes.
-            map { |node| [node, @nodes_handler.get_private_ips_of(node) || []] }
-          ]
+            map { |node| [node, @nodes_handler.get_private_ips_of(node) || []] }.
+            to_h
 
           # Check there are no duplicates
           nodes_per_private_ip = {}
-          private_ips.each do |node, private_ips|
-            private_ips.each do |private_ip|
+          private_ips.each do |node, node_private_ips|
+            node_private_ips.each do |private_ip|
               nodes_per_private_ip[private_ip] = [] unless nodes_per_private_ip.key?(private_ip)
               nodes_per_private_ip[private_ip] << node
             end

data/lib/hybrid_platforms_conductor/hpc_plugins/test/public_ips.rb

@@ -11,15 +11,15 @@ module HybridPlatformsConductor
         def test
           # Get a map of public IPs per node
           @nodes_handler.prefetch_metadata_of @nodes_handler.known_nodes, :public_ips
-          public_ips = Hash[@nodes_handler.
+          public_ips = @nodes_handler.
             known_nodes.
-            map { |node| [node, @nodes_handler.get_public_ips_of(node) || []] }
-          ]
+            map { |node| [node, @nodes_handler.get_public_ips_of(node) || []] }.
+            to_h
 
           # Check there are no duplicates
           nodes_per_public_ip = {}
-          public_ips.each do |node, public_ips|
-            public_ips.each do |public_ip|
+          public_ips.each do |node, node_public_ips|
+            node_public_ips.each do |public_ip|
               nodes_per_public_ip[public_ip] = [] unless nodes_per_public_ip.key?(public_ip)
               nodes_per_public_ip[public_ip] << node
             end

data/lib/hybrid_platforms_conductor/hpc_plugins/test/spectre.rb

@@ -17,11 +17,11 @@ module HybridPlatformsConductor
 
         # Check my_test_plugin.rb.sample documentation for signature details.
         def test_on_node
-          spectre_cmd = <<~EOS
+          spectre_cmd = <<~EO_BASH
             #{@deployer.instance_variable_get(:@actions_executor).connector(:ssh).ssh_user == 'root' ? '' : "#{@nodes_handler.sudo_on(@node)} "}/bin/bash <<'EOAction'
             #{File.read("#{__dir__}/spectre-meltdown-checker.sh")}
             EOAction
-          EOS
+          EO_BASH
           {
             spectre_cmd => {
               validator: proc do |stdout|
@@ -31,13 +31,11 @@ module HybridPlatformsConductor
                   if status_idx.nil?
                     error "Unable to find vulnerability section #{id}"
                   else
-                    while !stdout[status_idx].nil? && !(stdout[status_idx] =~ /STATUS:[^A-Z]+([A-Z ]+)/)
-                      status_idx += 1
-                    end
+                    status_idx += 1 while !stdout[status_idx].nil? && stdout[status_idx] !~ /STATUS:[^A-Z]+([A-Z ]+)/
                     if stdout[status_idx].nil?
                       error "Unable to find vulnerability status for #{id}"
                     else
-                      status = $1.strip
+                      status = Regexp.last_match(1).strip
                       error "Status for #{name}: #{status}" if status != 'NOT VULNERABLE'
                     end
                   end

data/lib/hybrid_platforms_conductor/hpc_plugins/test/veids.rb

@@ -11,10 +11,10 @@ module HybridPlatformsConductor
         def test
           # Get a map of VEIDs per node
           @nodes_handler.prefetch_metadata_of @nodes_handler.known_nodes, :veid
-          veids = Hash[@nodes_handler.
+          veids = @nodes_handler.
             known_nodes.
-            map { |node| [node, @nodes_handler.get_veid_of(node) ? @nodes_handler.get_veid_of(node).to_i : nil] }
-          ]
+            map { |node| [node, @nodes_handler.get_veid_of(node) ? @nodes_handler.get_veid_of(node).to_i : nil] }.
+            to_h
 
           # Check there are no duplicates
           veids.group_by { |_node, veid| veid }.each do |veid, nodes|

data/lib/hybrid_platforms_conductor/hpc_plugins/test/vulnerabilities.rb

@@ -48,8 +48,9 @@ module HybridPlatformsConductor
                   # Follow the last link recursively until we find a .xml or compressed file
                   current_url = artifactory_url
                   loop do
-                    current_url = "#{current_url}#{current_url.end_with?('/') ? '' : '/'}#{Nokogiri::HTML.parse(URI.open(current_url)).css('a').last['href']}"
+                    current_url = "#{current_url}#{current_url.end_with?('/') ? '' : '/'}#{Nokogiri::HTML.parse(URI.parse(current_url).open).css('a').last['href']}"
                     break if current_url.end_with?('.xml') || KNOWN_COMPRESSIONS.keys.any? { |file_ext| current_url.end_with?(".#{file_ext}") }
+
                     log_debug "Follow last link to #{current_url}"
                   end
                   current_url
@@ -57,7 +58,7 @@ module HybridPlatformsConductor
               )
               # TODO: Access the user correctly when the user notion will be moved out of the ssh connector
               sudo = @deployer.instance_variable_get(:@actions_executor).connector(:ssh).ssh_user == 'root' ? '' : "#{@nodes_handler.sudo_on(@node)} "
-              Hash[urls.map do |url|
+              urls.map do |url|
                 # 1. Get the OVAL file on the node to be tested (uncompress it if needed)
                 # 2. Make sure oscap is installed
                 # 3. Generate the report for this OVAL file using oscap
@@ -67,13 +68,13 @@ module HybridPlatformsConductor
                 packages_to_install = []
                 KNOWN_COMPRESSIONS.each do |file_ext, compress_info|
                   file_ending = ".#{file_ext}"
-                  if local_oval_file.end_with?(file_ending)
-                    uncompress_cmds << compress_info[:cmd].call(local_oval_file)
-                    packages_to_install.concat(compress_info[:packages])
-                    local_oval_file = File.basename(local_oval_file, file_ending)
-                  end
+                  next unless local_oval_file.end_with?(file_ending)
+
+                  uncompress_cmds << compress_info[:cmd].call(local_oval_file)
+                  packages_to_install.concat(compress_info[:packages])
+                  local_oval_file = File.basename(local_oval_file, file_ending)
                 end
-                cmds = <<~EOS
+                cmds = <<~EO_BASH
                   set -e
                   #{
                     case image
@@ -85,7 +86,7 @@ module HybridPlatformsConductor
                       # On Debian 10 we have to compile it from sources, as the packaged official version has core dumps.
                       # cf https://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1688223.html
                       # TODO: Remove this Debian 10 specificity when the official libopenscap8 will be corrected
-                      <<~EOS2
+                      <<~EO_BASH2
                         if [ ! -x "$(command -v oscap)" ] || [ "$(oscap --version | head -n 1 | awk '{print $6}')" != "1.3.4" ]; then
                           rm -rf openscap
                           git clone --recurse-submodules https://github.com/OpenSCAP/openscap.git
@@ -97,7 +98,7 @@ module HybridPlatformsConductor
                           #{sudo}make install
                         fi
                         #{sudo}apt install -y wget #{packages_to_install.join(' ')}
-                      EOS2
+                      EO_BASH2
                     else
                       raise "Non supported image: #{image}. Please adapt this test's code."
                     end
@@ -111,7 +112,7 @@ module HybridPlatformsConductor
                   echo "===== RESULTS ====="
                   cat "#{local_oval_file}.results.xml"
                   cd ..
-                EOS
+                EO_BASH
                 [
                   cmds,
                   {
@@ -120,21 +121,21 @@ module HybridPlatformsConductor
                       if idx_results.nil?
                         error 'No results given by the oscap run', stdout.join("\n")
                       else
-                        results = Nokogiri::XML(stdout[idx_results + 1..-1].join("\n"))
+                        results = Nokogiri::XML(stdout[idx_results + 1..].join("\n"))
                         results.remove_namespaces!
                         oval_definitions = results.css('oval_results oval_definitions definitions definition')
                         results.css('results system definitions definition').each do |definition_xml|
-                          if definition_xml['result'] == 'true'
-                            # Just found an OVAL item to be patched.
-                            definition_id = definition_xml['definition_id']
-                            oval_definition = oval_definitions.find { |el| el['id'] == definition_id }
-                            # We don't forcefully want to report all missing patches. Only the most important ones.
-                            severity = oval_definition.css('metadata advisory severity').text
-                            severity = 'Unknown' if severity.empty?
-                            if !oval_info.key?('reported_severities') || oval_info['reported_severities'].include?(severity)
-                              # Only consider the first line of the description, as sometimes it's very long
-                              error "Non-patched #{severity} vulnerability found: #{oval_definition.css('metadata title').text} - #{oval_definition.css('metadata description').text.split("\n").first}"
-                            end
+                          next unless definition_xml['result'] == 'true'
+
+                          # Just found an OVAL item to be patched.
+                          definition_id = definition_xml['definition_id']
+                          oval_definition = oval_definitions.find { |el| el['id'] == definition_id }
+                          # We don't forcefully want to report all missing patches. Only the most important ones.
+                          severity = oval_definition.css('metadata advisory severity').text
+                          severity = 'Unknown' if severity.empty?
+                          if !oval_info.key?('reported_severities') || oval_info['reported_severities'].include?(severity)
+                            # Only consider the first line of the description, as sometimes it's very long
+                            error "Non-patched #{severity} vulnerability found: #{oval_definition.css('metadata title').text} - #{oval_definition.css('metadata description').text.split("\n").first}"
                           end
                         end
                       end
@@ -143,7 +144,7 @@ module HybridPlatformsConductor
                     timeout: 240
                   }
                 ]
-              end]
+              end.to_h
             else
               error "No OVAL file defined for image #{image} at #{oval_file}"
               {}

data/lib/hybrid_platforms_conductor/hpc_plugins/test_report/confluence.rb

@@ -12,7 +12,7 @@ module HybridPlatformsConductor
       # Report tests results on a generated Confluence page
       class Confluence < HybridPlatformsConductor::TestReport
 
-        self.extend_config_dsl_with CommonConfigDsl::Confluence, :init_confluence
+        extend_config_dsl_with CommonConfigDsl::Confluence, :init_confluence
 
         # Maximum errors to be reported by item
         MAX_ERROR_ITEMS_DISPLAYED = 10
@@ -34,7 +34,7 @@ module HybridPlatformsConductor
                   at('h1:contains("Evolution")').
                   search('~ structured-macro:first-of-type').
                   css('table td').
-                  map { |td_element| td_element.text }.
+                  map(&:text).
                   each_slice(2).
                   to_a.
                   map { |(time_str, value_str)| [Time.parse("#{time_str} UTC"), value_str.to_f] }

data/lib/hybrid_platforms_conductor/hpc_plugins/test_report/stdout.rb

@@ -97,18 +97,20 @@ module HybridPlatformsConductor
               table << [
                 nodes_list,
                 nodes_info[:nodes].size,
-                nodes_info[:nodes].empty? ? '' : "#{(nodes_info[:tested_nodes].size*100.0/nodes_info[:nodes].size).to_i} %",
+                nodes_info[:nodes].empty? ? '' : "#{(nodes_info[:tested_nodes].size * 100.0 / nodes_info[:nodes].size).to_i} %",
                 nodes_info[:tested_nodes].empty? ? '' : "#{((nodes_info[:tested_nodes].size - nodes_info[:tested_nodes_in_error_as_expected].size) * 100.0 / nodes_info[:tested_nodes].size).to_i} %",
                 nodes_info[:tested_nodes].empty? ? '' : "#{((nodes_info[:tested_nodes].size - nodes_info[:tested_nodes_in_error].size) * 100.0 / nodes_info[:tested_nodes].size).to_i} %",
-                nodes_info[:nodes].empty? ? '' :
+                if nodes_info[:nodes].empty?
+                  ''
+                else
                   ('=' * ((nodes_info[:tested_nodes_in_error_as_expected].size * PROGRESS_BAR_SIZE.to_f) / nodes_info[:nodes].size).round).yellow.bold +
-                  ('=' * (((nodes_info[:tested_nodes_in_error].size - nodes_info[:tested_nodes_in_error_as_expected].size).abs * PROGRESS_BAR_SIZE.to_f) / nodes_info[:nodes].size).round).red.bold +
-                  ('=' * (((nodes_info[:tested_nodes].size - nodes_info[:tested_nodes_in_error].size) * PROGRESS_BAR_SIZE.to_f) / nodes_info[:nodes].size).round).green.bold +
-                  ('=' * (((nodes_info[:nodes].size - nodes_info[:tested_nodes].size) * PROGRESS_BAR_SIZE.to_f) / nodes_info[:nodes].size).round).white.bold
+                    ('=' * (((nodes_info[:tested_nodes_in_error].size - nodes_info[:tested_nodes_in_error_as_expected].size).abs * PROGRESS_BAR_SIZE.to_f) / nodes_info[:nodes].size).round).red.bold +
+                    ('=' * (((nodes_info[:tested_nodes].size - nodes_info[:tested_nodes_in_error].size) * PROGRESS_BAR_SIZE.to_f) / nodes_info[:nodes].size).round).green.bold +
+                    ('=' * (((nodes_info[:nodes].size - nodes_info[:tested_nodes].size) * PROGRESS_BAR_SIZE.to_f) / nodes_info[:nodes].size).round).white.bold
+                end
               ]
             end
           end)
-
         end
 
       end

data/lib/hybrid_platforms_conductor/io_router.rb

@@ -30,6 +30,7 @@ module HybridPlatformsConductor
     # Start routing messages asynchronously
     def start
       raise 'IO router is already started. Can\'t start it again.' unless @reading_thread.nil?
+
       @end_read = false
       # Create a thread to handle routes asynchronously
       @reading_thread = Thread.new do
@@ -37,22 +38,21 @@ module HybridPlatformsConductor
           need_to_stop = @end_read.clone
           data_found = false
           @routes.each do |src_io, dst_ios|
-            if src_io.is_a?(Queue)
-              queue_size = src_io.size
-              if queue_size > 0
-                # There is data to be read from src_io
-                data_found = true
-                data_chunk_str = queue_size.times.map { src_io.pop }.join
-                dst_ios.each do |dst_io|
-                  dst_io << data_chunk_str
-                  dst_io.flush if dst_io.respond_to?(:flush)
-                end
-              end
-            else
-              raise "Unknown type of source IO: #{src_io}"
+            raise "Unknown type of source IO: #{src_io}" unless src_io.is_a?(Queue)
+
+            queue_size = src_io.size
+            next unless queue_size.positive?
+
+            # There is data to be read from src_io
+            data_found = true
+            data_chunk_str = queue_size.times.map { src_io.pop }.join
+            dst_ios.each do |dst_io|
+              dst_io << data_chunk_str
+              dst_io.flush if dst_io.respond_to?(:flush)
             end
           end
           break if need_to_stop && !data_found
+
           sleep 0.1
         end
       end
@@ -61,6 +61,7 @@ module HybridPlatformsConductor
     # Stop routing messages asynchronously
     def stop
       raise 'IO router is not started. Can\'t stop it.' if @reading_thread.nil?
+
       @end_read = true
       @reading_thread.join
     end