hybrid_platforms_conductor 32.17.1 → 33.0.3

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/local/connectable_nodes_spec.rb

@@ -1,8 +1,8 @@
 describe HybridPlatformsConductor::ActionsExecutor do
 
-  context 'checking connector plugin local' do
+  context 'when checking connector plugin local' do
 
-    context 'checking connectable nodes selection' do
+    context 'when checking connectable nodes selection' do
 
       # Return the connector to be tested
       #
@@ -13,12 +13,16 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'selects connectable nodes correctly' do
-        with_test_platform(nodes: {
-          'node1' => { meta: { host_ip: '192.168.42.42' } },
-          'node2' => {},
-          'node3' => { meta: { host_ip: '127.0.0.1', local_node: true } },
-          'node4' => { meta: { local_node: true } }
-        }) do
+        with_test_platform(
+          {
+            nodes: {
+              'node1' => { meta: { host_ip: '192.168.42.42' } },
+              'node2' => {},
+              'node3' => { meta: { host_ip: '127.0.0.1', local_node: true } },
+              'node4' => { meta: { local_node: true } }
+            }
+          }
+        ) do
           expect(test_connector.connectable_nodes_from(%w[node1 node2 node3 node4]).sort).to eq %w[node3 node4].sort
         end
       end

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/local/remote_actions_spec.rb

@@ -1,8 +1,8 @@
 describe HybridPlatformsConductor::ActionsExecutor do
 
-  context 'checking connector plugin local' do
+  context 'when checking connector plugin local' do
 
-    context 'checking remote actions' do
+    context 'when checking remote actions' do
 
       # Return the connector to be tested
       #
@@ -19,7 +19,6 @@ describe HybridPlatformsConductor::ActionsExecutor do
       # * *expected_stdout* (String): Expected stdout after client code execution [default: '']
       # * *expected_stderr* (String): Expected stderr after client code execution [default: '']
       # * *timeout* (Integer or nil): Timeout to prepare the connector for [default: nil]
-      # * *password* (String or nil): Password to set for the node, or nil for none [default: nil]
       # * *additional_config* (String): Additional config [default: '']
       # * Proc: Client code to execute testing
       def with_test_platform_for_remote_testing(
@@ -27,13 +26,11 @@ describe HybridPlatformsConductor::ActionsExecutor do
         expected_stdout: '',
         expected_stderr: '',
         timeout: nil,
-        password: nil,
         additional_config: ''
       )
         with_test_platform(
           { nodes: { 'node' => { meta: { local_node: true } } } },
-          false,
-          additional_config
+          additional_config: additional_config
         ) do
           with_cmd_runner_mocked(expected_cmds) do
             test_connector.with_connection_to(['node']) do
@@ -62,7 +59,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
           expected_cmds: [
             [
               'cd /tmp/hpc_local_workspaces/node ; bash_cmd.bash',
-              proc do |cmd, log_to_file: nil, log_to_stdout: true, log_stdout_to_io: nil, log_stderr_to_io: nil, expected_code: 0, timeout: nil, no_exception: false|
+              proc do |_cmd, log_to_file: nil, log_to_stdout: true, log_stdout_to_io: nil, log_stderr_to_io: nil, expected_code: 0, timeout: nil, no_exception: false|
                 expect(timeout).to eq 5
                 [0, '', '']
               end

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/ssh/cli_options_spec.rb

@@ -1,8 +1,8 @@
 describe HybridPlatformsConductor::ActionsExecutor do
 
-  context 'checking connector plugin ssh' do
+  context 'when checking connector plugin ssh' do
 
-    context 'checking command-line interface options' do
+    context 'when checking command-line interface options' do
 
       # Setup a platform for tests
       #
@@ -13,11 +13,10 @@ describe HybridPlatformsConductor::ActionsExecutor do
       def with_test_platform_for_cli
         with_test_platform(
           { nodes: { 'node' => {} } },
-          false,
-          "
+          additional_config: <<~EO_CONFIG
             gateway :test_gateway, 'Host test_gateway'
-            gateway :test_gateway2, 'Host test_gateway2'
-          "
+            gateway :test_gateway_2, 'Host test_gateway_2'
+          EO_CONFIG
         ) do |repository|
           ENV['hpc_ssh_gateways_conf'] = 'test_gateway'
           yield repository
@@ -34,10 +33,10 @@ describe HybridPlatformsConductor::ActionsExecutor do
 
       it 'selects the correct gateway user' do
         with_test_platform_for_cli do
-          expect_actions_executor_runs([proc do |actions, timeout: nil, concurrent: false, log_to_dir: 'run_logs', log_to_stdout: true|
+          expect_actions_executor_runs [proc do
             expect(test_connector.ssh_gateway_user).to eq 'another_user'
             {}
-          end])
+          end]
           exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--ssh-gateway-user', 'another_user'
           expect(exit_code).to eq 0
           expect(stdout).to eq ''
@@ -47,11 +46,11 @@ describe HybridPlatformsConductor::ActionsExecutor do
 
       it 'selects the correct gateway conf' do
         with_test_platform_for_cli do
-          expect_actions_executor_runs([proc do |actions, timeout: nil, concurrent: false, log_to_dir: 'run_logs', log_to_stdout: true|
-            expect(test_connector.ssh_gateways_conf).to eq :test_gateway2
+          expect_actions_executor_runs [proc do
+            expect(test_connector.ssh_gateways_conf).to eq :test_gateway_2
             {}
-          end])
-          exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--ssh-gateways-conf', 'test_gateway2'
+          end]
+          exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--ssh-gateways-conf', 'test_gateway_2'
           expect(exit_code).to eq 0
           expect(stdout).to eq ''
           expect(stderr).to eq ''
@@ -60,10 +59,10 @@ describe HybridPlatformsConductor::ActionsExecutor do
 
       it 'does not use the SSH control master' do
         with_test_platform_for_cli do
-          expect_actions_executor_runs([proc do |actions, timeout: nil, concurrent: false, log_to_dir: 'run_logs', log_to_stdout: true|
+          expect_actions_executor_runs [proc do
             expect(test_connector.ssh_use_control_master).to eq false
             {}
-          end])
+          end]
           exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--ssh-no-control-master'
           expect(exit_code).to eq 0
           expect(stdout).to eq ''
@@ -73,10 +72,10 @@ describe HybridPlatformsConductor::ActionsExecutor do
 
       it 'does not use strict host key checking' do
         with_test_platform_for_cli do
-          expect_actions_executor_runs([proc do |actions, timeout: nil, concurrent: false, log_to_dir: 'run_logs', log_to_stdout: true|
+          expect_actions_executor_runs [proc do
             expect(test_connector.ssh_strict_host_key_checking).to eq false
             {}
-          end])
+          end]
           exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--ssh-no-host-key-checking'
           expect(exit_code).to eq 0
           expect(stdout).to eq ''
@@ -86,10 +85,10 @@ describe HybridPlatformsConductor::ActionsExecutor do
 
       it 'uses a different SSH user name' do
         with_test_platform_for_cli do
-          expect_actions_executor_runs([proc do |actions, timeout: nil, concurrent: false, log_to_dir: 'run_logs', log_to_stdout: true|
+          expect_actions_executor_runs [proc do
             expect(test_connector.ssh_user).to eq 'ssh_new_user'
             {}
-          end])
+          end]
           exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--ssh-user', 'ssh_new_user'
           expect(exit_code).to eq 0
           expect(stdout).to eq ''
@@ -101,9 +100,9 @@ describe HybridPlatformsConductor::ActionsExecutor do
         ENV.delete 'hpc_ssh_user'
         ENV.delete 'USER'
         with_test_platform_for_cli do
-          with_cmd_runner_mocked([
+          with_cmd_runner_mocked [
             ['whoami', proc { [0, '', ''] }]
-          ]) do
+          ] do
             expect { run 'run', '--node', 'node', '--command', 'echo Hello' }.to raise_error(RuntimeError, 'No SSH user name specified. Please use --ssh-user option or hpc_ssh_user environment variable to set it.')
           end
         end
@@ -111,10 +110,10 @@ describe HybridPlatformsConductor::ActionsExecutor do
 
       it 'expects passwords to be input' do
         with_test_platform_for_cli do
-          expect_actions_executor_runs([proc do |actions, timeout: nil, concurrent: false, log_to_dir: 'run_logs', log_to_stdout: true|
+          expect_actions_executor_runs [proc do
             expect(test_connector.auth_password).to eq true
             {}
-          end])
+          end]
           exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--password'
           expect(exit_code).to eq 0
           expect(stdout).to eq ''

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/ssh/config_dsl_spec.rb

@@ -1,13 +1,13 @@
 describe HybridPlatformsConductor::ActionsExecutor do
 
-  context 'checking connector plugin ssh' do
+  context 'when checking connector plugin ssh' do
 
-    context 'checking Config DSL extensions' do
+    context 'when checking Config DSL extensions' do
 
       it 'returns 1 defined gateway' do
-        with_repository do |repository|
-          with_platforms 'gateway :gateway1, \'\'' do
-            expect(test_config.known_gateways).to eq [:gateway1]
+        with_repository do
+          with_platforms 'gateway :gateway_1, \'\'' do
+            expect(test_config.known_gateways).to eq [:gateway_1]
           end
         end
       end
@@ -17,28 +17,28 @@ describe HybridPlatformsConductor::ActionsExecutor do
           Host gateway
             Hostname mygateway.com
         '
-        with_repository do |repository|
-          with_platforms "gateway :gateway1, '#{ssh_gateway}'" do
-            expect(test_config.ssh_for_gateway(:gateway1)).to eq ssh_gateway
+        with_repository do
+          with_platforms "gateway :gateway_1, '#{ssh_gateway}'" do
+            expect(test_config.ssh_for_gateway(:gateway_1)).to eq ssh_gateway
           end
         end
       end
 
       it 'returns 1 defined gateway with its content and replacing ERB template correctly' do
-        with_repository do |repository|
-          with_platforms 'gateway :gateway1, \'Host gateway_<%= @user %>\'' do
-            expect(test_config.ssh_for_gateway(:gateway1, user: 'test_user')).to eq 'Host gateway_test_user'
+        with_repository do
+          with_platforms 'gateway :gateway_1, \'Host gateway_<%= @user %>\'' do
+            expect(test_config.ssh_for_gateway(:gateway_1, user: 'test_user')).to eq 'Host gateway_test_user'
           end
         end
       end
 
       it 'returns several defined gateways' do
-        with_repository do |repository|
+        with_repository do
           with_platforms '
-            gateway :gateway1, \'\'
-            gateway :gateway2, \'\'
+            gateway :gateway_1, \'\'
+            gateway :gateway_2, \'\'
           ' do
-            expect(test_config.known_gateways.sort).to eq %i[gateway1 gateway2].sort
+            expect(test_config.known_gateways.sort).to eq %i[gateway_1 gateway_2].sort
           end
         end
       end
@@ -50,30 +50,29 @@ describe HybridPlatformsConductor::ActionsExecutor do
               'node1' => {},
               'node2' => {},
               'node3' => {}
-            },
+            }
           },
-          false,
-          '
+          additional_config: <<~'EO_CONFIG'
             for_nodes(%w[node1 node3]) do
               transform_ssh_connection do |node, connection, connection_user, gateway, gateway_user|
                 ["#{connection}_#{node}_13", "#{connection_user}_#{node}_13", "#{gateway}_#{node}_13", "#{gateway_user}_#{node}_13"]
               end
             end
-            for_nodes(\'node1\') do
+            for_nodes('node1') do
               transform_ssh_connection do |node, connection, connection_user, gateway, gateway_user|
                 ["#{connection}_#{node}_1", "#{connection_user}_#{node}_1", "#{gateway}_#{node}_1", "#{gateway_user}_#{node}_1"]
               end
             end
-          '
+          EO_CONFIG
         ) do
           expect(test_config.ssh_connection_transforms.size).to eq 2
           expect(test_config.ssh_connection_transforms[0][:nodes_selectors_stack]).to eq [%w[node1 node3]]
-          expect(test_config.ssh_connection_transforms[0][:transform].call('node1', 'test_host', 'test_user', 'test_gateway', 'test_gateway_user')).to eq [
-            'test_host_node1_13', 'test_user_node1_13', 'test_gateway_node1_13', 'test_gateway_user_node1_13'
+          expect(test_config.ssh_connection_transforms[0][:transform].call('node1', 'test_host', 'test_user', 'test_gateway', 'test_gateway_user')).to eq %w[
+            test_host_node1_13 test_user_node1_13 test_gateway_node1_13 test_gateway_user_node1_13
           ]
           expect(test_config.ssh_connection_transforms[1][:nodes_selectors_stack]).to eq ['node1']
-          expect(test_config.ssh_connection_transforms[1][:transform].call('node1', 'test_host', 'test_user', 'test_gateway', 'test_gateway_user')).to eq [
-            'test_host_node1_1', 'test_user_node1_1', 'test_gateway_node1_1', 'test_gateway_user_node1_1'
+          expect(test_config.ssh_connection_transforms[1][:transform].call('node1', 'test_host', 'test_user', 'test_gateway', 'test_gateway_user')).to eq %w[
+            test_host_node1_1 test_user_node1_1 test_gateway_node1_1 test_gateway_user_node1_1
           ]
         end
       end

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/ssh/connectable_nodes_spec.rb

@@ -1,8 +1,8 @@
 describe HybridPlatformsConductor::ActionsExecutor do
 
-  context 'checking connector plugin ssh' do
+  context 'when checking connector plugin ssh' do
 
-    context 'checking connectable nodes selection' do
+    context 'when checking connectable nodes selection' do
 
       # Return the connector to be tested
       #
@@ -13,10 +13,14 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'selects connectable nodes correctly' do
-        with_test_platform(nodes: {
-          'node1' => { meta: { host_ip: '192.168.42.42' } },
-          'node2' => {}
-        }) do
+        with_test_platform(
+          {
+            nodes: {
+              'node1' => { meta: { host_ip: '192.168.42.42' } },
+              'node2' => {}
+            }
+          }
+        ) do
           expect(test_connector.connectable_nodes_from(%w[node1 node2])).to eq ['node1']
         end
       end

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/ssh/connections_spec.rb

@@ -1,8 +1,8 @@
 describe HybridPlatformsConductor::ActionsExecutor do
 
-  context 'checking connector plugin ssh' do
+  context 'when checking connector plugin ssh' do
 
-    context 'checking connections preparations' do
+    context 'when checking connections preparations' do
 
       # Return the connector to be tested
       #
@@ -13,12 +13,12 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'creates an SSH master to 1 node' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } }) do
+        with_test_platform({ nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } } }) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
               ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
-            ] + ssh_expected_commands_for('node' => { connection: '192.168.42.42', user: 'test_user' })
+            ] + ssh_expected_commands_for({ 'node' => { connection: '192.168.42.42', user: 'test_user' } })
           ) do
             test_connector.ssh_user = 'test_user'
             test_connector.with_connection_to(['node']) do |connected_nodes|
@@ -29,7 +29,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'creates an SSH master to 1 node not having Session Exec capabilities' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42', ssh_session_exec: false } } }) do
+        with_test_platform({ nodes: { 'node' => { meta: { host_ip: '192.168.42.42', ssh_session_exec: false } } } }) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
@@ -45,7 +45,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'can\'t create an SSH master to 1 node not having Session Exec capabilities when hpc_interactive is false' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42', ssh_session_exec: false } } }) do
+        with_test_platform({ nodes: { 'node' => { meta: { host_ip: '192.168.42.42', ssh_session_exec: false } } } }) do
           ENV['hpc_interactive'] = 'false'
           with_cmd_runner_mocked(
             [
@@ -67,19 +67,25 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'fails without creating exception when creating an SSH master to 1 node not having Session Exec capabilities when hpc_interactive is false and we use no_exception' do
-        with_test_platform(nodes: {
-          'node1' => { meta: { host_ip: '192.168.42.1' } },
-          'node2' => { meta: { host_ip: '192.168.42.2', ssh_session_exec: false } },
-          'node3' => { meta: { host_ip: '192.168.42.3' } }
-        }) do
+        with_test_platform(
+          {
+            nodes: {
+              'node1' => { meta: { host_ip: '192.168.42.1' } },
+              'node2' => { meta: { host_ip: '192.168.42.2', ssh_session_exec: false } },
+              'node3' => { meta: { host_ip: '192.168.42.3' } }
+            }
+          }
+        ) do
           ENV['hpc_interactive'] = 'false'
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
               ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
             ] + ssh_expected_commands_for(
-              'node1' => { connection: '192.168.42.1', user: 'test_user' },
-              'node3' => { connection: '192.168.42.3', user: 'test_user' }
+              {
+                'node1' => { connection: '192.168.42.1', user: 'test_user' },
+                'node3' => { connection: '192.168.42.3', user: 'test_user' }
+              }
             ) + ssh_expected_commands_for(
               {
                 'node2' => { connection: '192.168.42.2', user: 'test_user' }
@@ -97,19 +103,25 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'creates SSH master to several nodes' do
-        with_test_platform(nodes: {
-          'node1' => { meta: { host_ip: '192.168.42.1' } },
-          'node2' => { meta: { host_ip: '192.168.42.2' } },
-          'node3' => { meta: { host_ip: '192.168.42.3' } }
-        }) do
+        with_test_platform(
+          {
+            nodes: {
+              'node1' => { meta: { host_ip: '192.168.42.1' } },
+              'node2' => { meta: { host_ip: '192.168.42.2' } },
+              'node3' => { meta: { host_ip: '192.168.42.3' } }
+            }
+          }
+        ) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
               ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
             ] + ssh_expected_commands_for(
-              'node1' => { connection: '192.168.42.1', user: 'test_user' },
-              'node2' => { connection: '192.168.42.2', user: 'test_user' },
-              'node3' => { connection: '192.168.42.3', user: 'test_user' }
+              {
+                'node1' => { connection: '192.168.42.1', user: 'test_user' },
+                'node2' => { connection: '192.168.42.2', user: 'test_user' },
+                'node3' => { connection: '192.168.42.3', user: 'test_user' }
+              }
             )
           ) do
             test_connector.ssh_user = 'test_user'
@@ -123,32 +135,33 @@ describe HybridPlatformsConductor::ActionsExecutor do
       it 'creates SSH master to several nodes with ssh connections transformed' do
         with_test_platform(
           { nodes: {
-          'node1' => { meta: { host_ip: '192.168.42.1' } },
-          'node2' => { meta: { host_ip: '192.168.42.2' } },
-          'node3' => { meta: { host_ip: '192.168.42.3' } }
+            'node1' => { meta: { host_ip: '192.168.42.1' } },
+            'node2' => { meta: { host_ip: '192.168.42.2' } },
+            'node3' => { meta: { host_ip: '192.168.42.3' } }
           } },
-          false,
-          '
+          additional_config: <<~'EO_CONFIG'
             for_nodes(%w[node1 node3]) do
               transform_ssh_connection do |node, connection, connection_user, gateway, gateway_user|
                 ["#{connection}_#{node}_13", "#{connection_user}_#{node}_13", "#{gateway}_#{node}_13", "#{gateway_user}_#{node}_13"]
               end
             end
-            for_nodes(\'node1\') do
+            for_nodes('node1') do
               transform_ssh_connection do |node, connection, connection_user, gateway, gateway_user|
                 ["#{connection}_#{node}_1", "#{connection_user}_#{node}_1", "#{gateway}_#{node}_1", "#{gateway_user}_#{node}_1"]
               end
             end
-          '
+          EO_CONFIG
         ) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
               ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
             ] + ssh_expected_commands_for(
-              'node1' => { ip: '192.168.42.1', connection: '192.168.42.1_node1_13_node1_1', user: 'test_user_node1_13_node1_1' },
-              'node2' => { ip: '192.168.42.2', connection: '192.168.42.2', user: 'test_user' },
-              'node3' => { ip: '192.168.42.3', connection: '192.168.42.3_node3_13', user: 'test_user_node3_13' }
+              {
+                'node1' => { ip: '192.168.42.1', connection: '192.168.42.1_node1_13_node1_1', user: 'test_user_node1_13_node1_1' },
+                'node2' => { ip: '192.168.42.2', connection: '192.168.42.2', user: 'test_user' },
+                'node3' => { ip: '192.168.42.3', connection: '192.168.42.3_node3_13', user: 'test_user_node3_13' }
+              }
             )
           ) do
             test_connector.ssh_user = 'test_user'
@@ -160,11 +173,15 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'fails when an SSH master can\'t be created' do
-        with_test_platform(nodes: {
-          'node1' => { meta: { host_ip: '192.168.42.1' } },
-          'node2' => { meta: { host_ip: '192.168.42.2' } },
-          'node3' => { meta: { host_ip: '192.168.42.3' } }
-        }) do
+        with_test_platform(
+          {
+            nodes: {
+              'node1' => { meta: { host_ip: '192.168.42.1' } },
+              'node2' => { meta: { host_ip: '192.168.42.2' } },
+              'node3' => { meta: { host_ip: '192.168.42.3' } }
+            }
+          }
+        ) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
@@ -186,24 +203,30 @@ describe HybridPlatformsConductor::ActionsExecutor do
             )
           ) do
             test_connector.ssh_user = 'test_user'
-            expect { test_connector.with_connection_to(%w[node1 node2 node3]) }.to raise_error(/^Error while starting SSH Control Master with .+\/ssh -o BatchMode=yes -o ControlMaster=yes -o ControlPersist=yes hpc.node2 true: Can't connect to 192.168.42.2$/)
+            expect { test_connector.with_connection_to(%w[node1 node2 node3]) }.to raise_error(%r{^Error while starting SSH Control Master with .+/ssh -o BatchMode=yes -o ControlMaster=yes -o ControlPersist=yes hpc.node2 true: Can't connect to 192.168.42.2$})
           end
         end
       end
 
       it 'fails without throwing exception when an SSH master can\'t be created and we use no_exception' do
-        with_test_platform(nodes: {
-          'node1' => { meta: { host_ip: '192.168.42.1' } },
-          'node2' => { meta: { host_ip: '192.168.42.2' } },
-          'node3' => { meta: { host_ip: '192.168.42.3' } }
-        }) do
+        with_test_platform(
+          {
+            nodes: {
+              'node1' => { meta: { host_ip: '192.168.42.1' } },
+              'node2' => { meta: { host_ip: '192.168.42.2' } },
+              'node3' => { meta: { host_ip: '192.168.42.3' } }
+            }
+          }
+        ) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
               ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
             ] + ssh_expected_commands_for(
-              'node1' => { connection: '192.168.42.1', user: 'test_user' },
-              'node3' => { connection: '192.168.42.3', user: 'test_user' }
+              {
+                'node1' => { connection: '192.168.42.1', user: 'test_user' },
+                'node3' => { connection: '192.168.42.3', user: 'test_user' }
+              }
             ) + ssh_expected_commands_for(
               {
                 'node2' => { connection: '192.168.42.2', user: 'test_user', control_master_create_error: 'Can\'t connect to 192.168.42.2' }
@@ -220,13 +243,13 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'reuses SSH master already created to 1 node' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } }) do
+        with_test_platform({ nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } } }) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
               ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
             ] +
-              ssh_expected_commands_for('node' => { connection: '192.168.42.42', user: 'test_user' }) +
+              ssh_expected_commands_for({ 'node' => { connection: '192.168.42.42', user: 'test_user' } }) +
               ssh_expected_commands_for(
                 { 'node' => { connection: '192.168.42.42', user: 'test_user' } },
                 with_strict_host_key_checking: false,
@@ -245,24 +268,32 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'reuses SSH masters already created to some nodes and create new ones if needed' do
-        with_test_platform(nodes: {
-          'node1' => { meta: { host_ip: '192.168.42.1' } },
-          'node2' => { meta: { host_ip: '192.168.42.2' } },
-          'node3' => { meta: { host_ip: '192.168.42.3' } },
-          'node4' => { meta: { host_ip: '192.168.42.4' } }
-        }) do
+        with_test_platform(
+          {
+            nodes: {
+              'node1' => { meta: { host_ip: '192.168.42.1' } },
+              'node2' => { meta: { host_ip: '192.168.42.2' } },
+              'node3' => { meta: { host_ip: '192.168.42.3' } },
+              'node4' => { meta: { host_ip: '192.168.42.4' } }
+            }
+          }
+        ) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
               ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
             ] +
               ssh_expected_commands_for(
-                'node1' => { connection: '192.168.42.1', user: 'test_user' },
-                'node3' => { connection: '192.168.42.3', user: 'test_user' }
+                {
+                  'node1' => { connection: '192.168.42.1', user: 'test_user' },
+                  'node3' => { connection: '192.168.42.3', user: 'test_user' }
+                }
               ) +
               ssh_expected_commands_for(
-                'node2' => { connection: '192.168.42.2', user: 'test_user' },
-                'node4' => { connection: '192.168.42.4', user: 'test_user' }
+                {
+                  'node2' => { connection: '192.168.42.2', user: 'test_user' },
+                  'node4' => { connection: '192.168.42.4', user: 'test_user' }
+                }
               ) +
               ssh_expected_commands_for(
                 {
@@ -285,14 +316,14 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'makes sure the last client using ControlMaster destroys it, even using a different environment' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } }) do
+        with_test_platform({ nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } } }) do
           # 1. Current thread creates the ControlMaster.
           # 2. Second thread connects to it.
           # 3. Current thread releases it.
           # 4. Second thread releases it, hence destroying it.
           init_commands = [
             ['which env', proc { [0, "/usr/bin/env\n", ''] }],
-            ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }],
+            ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
           ]
           nodes_connections_to_mock = { 'node' => { connection: '192.168.42.42', user: 'test_user' } }
           step = 0
@@ -311,7 +342,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
               second_config = HybridPlatformsConductor::Config.new logger: logger, logger_stderr: logger
               second_platforms_handler = HybridPlatformsConductor::PlatformsHandler.new logger: logger, logger_stderr: logger, config: second_config, cmd_runner: second_cmd_runner
               second_nodes_handler = HybridPlatformsConductor::NodesHandler.new logger: logger, logger_stderr: logger, config: second_config, cmd_runner: second_cmd_runner, platforms_handler: second_platforms_handler
-              second_actions_executor = HybridPlatformsConductor::ActionsExecutor.new logger: logger, logger_stderr: logger, config: second_config, cmd_runner: second_cmd_runner, nodes_handler: second_nodes_handler
+              second_actions_executor = described_class.new logger: logger, logger_stderr: logger, config: second_config, cmd_runner: second_cmd_runner, nodes_handler: second_nodes_handler
               second_actions_executor.connector(:ssh).ssh_user = 'test_user'
               # Wait for the first thread to create ControlMaster
               sleep 0.1 while step == 0
@@ -339,7 +370,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'does not create SSH master if asked' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } }) do
+        with_test_platform({ nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } } }) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
@@ -360,7 +391,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'does not check host keys if asked' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } }) do
+        with_test_platform({ nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } } }) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
@@ -379,7 +410,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'does not use batch mode when passwords are to be expected' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } }) do
+        with_test_platform({ nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } } }) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
@@ -398,7 +429,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'uses sshpass to prepare connections needing passwords' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } }) do
+        with_test_platform({ nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } } }) do
           with_cmd_runner_mocked(
             [
               ['sshpass -V', proc { [0, "sshpass 1.06\n", ''] }],
@@ -418,13 +449,13 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'does not reuse provided SSH executables and configs' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } }) do
+        with_test_platform({ nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } } }) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
               ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
             ] +
-              ssh_expected_commands_for('node' => { connection: '192.168.42.42', user: 'test_user' }) +
+              ssh_expected_commands_for({ 'node' => { connection: '192.168.42.42', user: 'test_user' } }) +
               ssh_expected_commands_for(
                 { 'node' => { connection: '192.168.42.42', user: 'test_user' } },
                 with_strict_host_key_checking: false,
@@ -449,13 +480,13 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'cleans provided SSH executables and configs after use' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } }) do
+        with_test_platform({ nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } } }) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
               ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
             ] +
-              ssh_expected_commands_for('node' => { connection: '192.168.42.42', user: 'test_user' }) +
+              ssh_expected_commands_for({ 'node' => { connection: '192.168.42.42', user: 'test_user' } }) +
               ssh_expected_commands_for(
                 { 'node' => { connection: '192.168.42.42', user: 'test_user' } },
                 with_strict_host_key_checking: false,
@@ -488,12 +519,12 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'creates an SSH master to 1 node even when there is a stalled ControlMaster file' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } }) do
+        with_test_platform({ nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } } }) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
               ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
-            ] + ssh_expected_commands_for('node' => { connection: '192.168.42.42', user: 'test_user' })
+            ] + ssh_expected_commands_for({ 'node' => { connection: '192.168.42.42', user: 'test_user' } })
           ) do
             test_connector.ssh_user = 'test_user'
             # Fake a ControlMaster file that is stalled
@@ -505,12 +536,12 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'creates an SSH master to 1 node even when there is a left-over user for the ControlMaster file that has not been unregistered' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } }) do
+        with_test_platform({ nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } } }) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
               ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
-            ] + ssh_expected_commands_for('node' => { connection: '192.168.42.42', user: 'test_user' })
+            ] + ssh_expected_commands_for({ 'node' => { connection: '192.168.42.42', user: 'test_user' } })
           ) do
             test_connector.ssh_user = 'test_user'
             # Fake a user that was not cleaned correctly
@@ -522,21 +553,21 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'retries when the remote node is booting up' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } }) do
+        with_test_platform({ nodes: { 'node' => { meta: { host_ip: '192.168.42.42' } } } }) do
           nbr_boot_messages = 0
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
-              ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }],
+              ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
             ] +
               [[
-                /^.+\/ssh -o BatchMode=yes -o ControlMaster=yes -o ControlPersist=yes hpc\.node true$/,
+                %r{^.+/ssh -o BatchMode=yes -o ControlMaster=yes -o ControlPersist=yes hpc\.node true$},
                 proc do
                   nbr_boot_messages += 1
                   [255, '', "System is booting up. See pam_nologin(8)\nAuthentication failed.\n"]
                 end
               ]] * 3 +
-              ssh_expected_commands_for('node' => { connection: '192.168.42.42', user: 'test_user' })
+              ssh_expected_commands_for({ 'node' => { connection: '192.168.42.42', user: 'test_user' } })
           ) do
             test_connector.ssh_user = 'test_user'
             # To speed up the test, alter the wait time between retries.