hybrid_platforms_conductor 32.17.1 → 32.18.0

data/lib/hybrid_platforms_conductor/hpc_plugins/log/my_log_plugin.rb.sample

@@ -0,0 +1,100 @@
+require 'hybrid_platforms_conductor/log'
+
+module HybridPlatformsConductor
+
+  module HpcPlugins
+
+    module Log
+
+      # Save logs on the remote node's file system
+      class RemoteFs < HybridPlatformsConductor::Log
+
+        # Get actions to save logs
+        # [API] - This method is mandatory.
+        # [API] - The following API components are accessible:
+        # * *@config* (Config): Main configuration API.
+        # * *@nodes_handler* (NodesHandler): Nodes handler API.
+        # * *@actions_executor* (ActionsExecutor): Actions executor API.
+        #
+        # Parameters::
+        # * *node* (String): Node for which logs are being saved
+        # * *services* (Array<String>): The list of services that have been deployed on this node
+        # * *deployment_info* (Hash<Symbol,Object>): Additional information to attach to the logs
+        # * *exit_status* (Integer or Symbol): Exit status of the deployment
+        # * *stdout* (String): Deployment's stdout
+        # * *stderr* (String): Deployment's stderr
+        # Result::
+        # * Array< Hash<Symbol,Object> >: List of actions to be done
+        def actions_to_save_logs(node, services, deployment_info, exit_status, stdout, stderr)
+          # Return here all actions that are to be run to save those logs.
+          [
+            {
+              bash: <<~EOS
+                cat <<'EOLOGFILE' >>all_logs.txt
+                Deployment log on #{node}:
+                #{stdout}
+                EOLOGFILE
+              EOS
+            }
+          ]
+        end
+
+        # Get actions to read logs.
+        # If provided, this method can return some actions to be executed that will fetch logs from servers or remote nodes.
+        # By using this method to run actions instead of the synchronous method logs_from, such actions will be run in parallel which can greatly improve time-consuming operations when querying a lot of nodes.
+        # [API] - This method is optional.
+        # [API] - The following API components are accessible:
+        # * *@config* (Config): Main configuration API.
+        # * *@nodes_handler* (NodesHandler): Nodes handler API.
+        # * *@actions_executor* (ActionsExecutor): Actions executor API.
+        #
+        # Parameters::
+        # * *node* (String): Node for which deployment logs are being read
+        # Result::
+        # * Array< Hash<Symbol,Object> >: List of actions to be done
+        def actions_to_read_logs(node)
+          [
+            { bash: 'cat all_logs.txt' }
+          ]
+        end
+
+        # Get deployment logs from a node.
+        # This method can use the result of actions previously run to read logs, as returned by the actions_to_read_logs method.
+        # [API] - This method is mandatory.
+        # [API] - The following API components are accessible:
+        # * *@config* (Config): Main configuration API.
+        # * *@nodes_handler* (NodesHandler): Nodes handler API.
+        # * *@actions_executor* (ActionsExecutor): Actions executor API.
+        #
+        # Parameters::
+        # * *node* (String): The node we want deployment logs from
+        # * *exit_status* (Integer, Symbol or nil): Exit status of actions to read logs, or nil if no action was returned by actions_to_read_logs
+        # * *stdout* (String or nil): stdout of actions to read logs, or nil if no action was returned by actions_to_read_logs
+        # * *stderr* (String or nil): stderr of actions to read logs, or nil if no action was returned by actions_to_read_logs
+        # Result::
+        # * Hash<Symbol,Object>: Deployment log information:
+        #   * *error* (String): Error string in case deployment logs could not be retrieved. If set then further properties will be ignored. [optional]
+        #   * *services* (Array<String>): List of services deployed on the node
+        #   * *deployment_info* (Hash<Symbol,Object>): Deployment metadata
+        #   * *exit_status* (Integer or Symbol): Deployment exit status
+        #   * *stdout* (String): Deployment stdout
+        #   * *stderr* (String): Deployment stderr
+        def logs_for(node, exit_status, stdout, stderr)
+          # Here we should retrieve this info from somewhere.
+          # Based on this example, stdout is the value of the execution of the action 'cat all_logs.txt' as returned by actions_to_read_logs.
+          {
+            services: %w[unknown],
+            deployment_info: {},
+            exit_status: 0,
+            stdout: stdout,
+            stderr: ''
+          }
+        end
+
+      end
+
+    end
+
+  end
+
+end

data/lib/hybrid_platforms_conductor/hpc_plugins/log/remote_fs.rb

@@ -0,0 +1,179 @@
+require 'hybrid_platforms_conductor/log'
+
+module HybridPlatformsConductor
+
+  module HpcPlugins
+
+    module Log
+
+      # Save logs on the remote node's file system
+      class RemoteFs < HybridPlatformsConductor::Log
+
+        MARKER_STDOUT = '===== STDOUT ====='
+        MARKER_STDERR = '===== STDERR ====='
+
+        # Get actions to save logs
+        # [API] - This method is mandatory.
+        # [API] - The following API components are accessible:
+        # * *@config* (Config): Main configuration API.
+        # * *@nodes_handler* (NodesHandler): Nodes handler API.
+        # * *@actions_executor* (ActionsExecutor): Actions executor API.
+        #
+        # Parameters::
+        # * *node* (String): Node for which logs are being saved
+        # * *services* (Array<String>): The list of services that have been deployed on this node
+        # * *deployment_info* (Hash<Symbol,Object>): Additional information to attach to the logs
+        # * *exit_status* (Integer or Symbol): Exit status of the deployment
+        # * *stdout* (String): Deployment's stdout
+        # * *stderr* (String): Deployment's stderr
+        # Result::
+        # * Array< Hash<Symbol,Object> >: List of actions to be done
+        def actions_to_save_logs(node, services, deployment_info, exit_status, stdout, stderr)
+          # Create a log file to be scp with all relevant info
+          ssh_user = @actions_executor.connector(:ssh).ssh_user
+          sudo_prefix = ssh_user == 'root' ? '' : "#{@nodes_handler.sudo_on(node)} "
+          log_file = "#{Dir.tmpdir}/hpc_deploy_logs/#{node}_#{Time.now.utc.strftime('%F_%H%M%S')}_#{ssh_user}"
+          [
+            {
+              ruby: proc do
+                FileUtils.mkdir_p File.dirname(log_file)
+                File.write(log_file, <<~EOS)
+                  #{
+                    deployment_info.merge(
+                      debug: log_debug? ? 'Yes' : 'No',
+                      services: services.join(', '),
+                      exit_status: exit_status
+                    ).map { |property, value| "#{property}: #{value}" }.join("\n")
+                  }
+                  #{MARKER_STDOUT}
+                  #{stdout}
+                  #{MARKER_STDERR}
+                  #{stderr}
+                EOS
+              end,
+              remote_bash: "#{sudo_prefix}mkdir -p /var/log/deployments && #{sudo_prefix}chmod 600 /var/log/deployments"
+            },
+            {
+              scp: {
+                log_file => '/var/log/deployments',
+                :sudo => ssh_user != 'root',
+                :owner => 'root',
+                :group => 'root'
+              }
+            },
+            {
+              remote_bash: "#{sudo_prefix}chmod 600 /var/log/deployments/#{File.basename(log_file)}",
+              # Remove temporary files storing logs for security
+              ruby: proc do
+                File.unlink(log_file)
+              end
+            }
+          ]
+        end
+
+        # Get actions to read logs.
+        # If provided, this method can return some actions to be executed that will fetch logs from servers or remote nodes.
+        # By using this method to run actions instead of the synchronous method logs_from, such actions will be run in parallel which can greatly improve time-consuming operations when querying a lot of nodes.
+        # [API] - This method is optional.
+        # [API] - The following API components are accessible:
+        # * *@config* (Config): Main configuration API.
+        # * *@nodes_handler* (NodesHandler): Nodes handler API.
+        # * *@actions_executor* (ActionsExecutor): Actions executor API.
+        #
+        # Parameters::
+        # * *node* (String): Node for which deployment logs are being read
+        # Result::
+        # * Array< Hash<Symbol,Object> >: List of actions to be done
+        def actions_to_read_logs(node)
+          sudo_prefix = @actions_executor.connector(:ssh).ssh_user == 'root' ? '' : "#{@nodes_handler.sudo_on(node)} "
+          [
+            { remote_bash: "#{sudo_prefix}cat /var/log/deployments/`#{sudo_prefix}ls -t /var/log/deployments/ | head -1`" }
+          ]
+        end
+
+        # Get deployment logs from a node.
+        # This method can use the result of actions previously run to read logs, as returned by the actions_to_read_logs method.
+        # [API] - This method is mandatory.
+        # [API] - The following API components are accessible:
+        # * *@config* (Config): Main configuration API.
+        # * *@nodes_handler* (NodesHandler): Nodes handler API.
+        # * *@actions_executor* (ActionsExecutor): Actions executor API.
+        #
+        # Parameters::
+        # * *node* (String): The node we want deployment logs from
+        # * *exit_status* (Integer, Symbol or nil): Exit status of actions to read logs, or nil if no action was returned by actions_to_read_logs
+        # * *stdout* (String or nil): stdout of actions to read logs, or nil if no action was returned by actions_to_read_logs
+        # * *stderr* (String or nil): stderr of actions to read logs, or nil if no action was returned by actions_to_read_logs
+        # Result::
+        # * Hash<Symbol,Object>: Deployment log information:
+        #   * *error* (String): Error string in case deployment logs could not be retrieved. If set then further properties will be ignored. [optional]
+        #   * *services* (Array<String>): List of services deployed on the node
+        #   * *deployment_info* (Hash<Symbol,Object>): Deployment metadata
+        #   * *exit_status* (Integer or Symbol): Deployment exit status
+        #   * *stdout* (String): Deployment stdout
+        #   * *stderr* (String): Deployment stderr
+        def logs_for(node, exit_status, stdout, stderr)
+          # Expected format for stdout:
+          # Property1: Value1
+          # ...
+          # PropertyN: ValueN
+          # ===== STDOUT =====
+          # ...
+          # ===== STDERR =====
+          # ...
+          if exit_status.is_a?(Symbol)
+            { error: "Error: #{exit_status}\n#{stderr}" }
+          else
+            stdout_lines = stdout.split("\n")
+            if stdout_lines.first =~ /No such file or directory/
+              { error: '/var/log/deployments missing' }
+            else
+              stdout_idx = stdout_lines.index(MARKER_STDOUT)
+              stderr_idx = stdout_lines.index(MARKER_STDERR)
+              deploy_info = {}
+              stdout_lines[0..stdout_idx - 1].each do |line|
+                if line =~ /^([^:]+): (.+)$/
+                  key_str, value = $1, $2
+                  key = key_str.to_sym
+                  # Type-cast some values
+                  case key_str
+                  when 'date'
+                    # Date and time values
+                    # Thu Nov 23 18:43:01 UTC 2017
+                    deploy_info[key] = Time.parse("#{value} UTC")
+                  when 'debug'
+                    # Boolean values
+                    # Yes
+                    deploy_info[key] = (value == 'Yes')
+                  when /^diff_files_.+$/, 'services'
+                    # Array of strings
+                    # my_file.txt, other_file.txt
+                    deploy_info[key] = value.split(', ')
+                  else
+                    deploy_info[key] = value
+                  end
+                else
+                  deploy_info[:unknown_lines] = [] unless deploy_info.key?(:unknown_lines)
+                  deploy_info[:unknown_lines] << line
+                end
+              end
+              services = deploy_info.delete(:services)
+              exit_status = deploy_info.delete(:exit_status)
+              {
+                services: services,
+                deployment_info: deploy_info,
+                exit_status: exit_status =~ /^\d+$/ ? Integer(exit_status) : exit_status.to_sym,
+                stdout: stdout_lines[stdout_idx + 1..stderr_idx - 1].join("\n"),
+                stderr: stdout_lines[stderr_idx + 1..-1].join("\n")
+              }
+            end
+          end
+        end
+
+      end
+
+    end
+
+  end
+
+end

data/lib/hybrid_platforms_conductor/hpc_plugins/test/deploy_freshness.rb

@@ -12,27 +12,14 @@ module HybridPlatformsConductor
         MAX_ACCEPTABLE_REFRESH_PERIOD_SECS = 3 * 31 * 24 * 60 * 60 # 3 months
 
         # Check my_test_plugin.rb.sample documentation for signature details.
-        def test_on_node
+        def test_for_node
           now = Time.now
-          {
-            "#{@nodes_handler.sudo_on(@node)} ls -t /var/log/deployments" => proc do |stdout|
-              if stdout.empty?
-                error 'Node has never been deployed using deploy (/var/log/deployments is empty)'
-              elsif stdout.first =~ /No such file or directory/
-                error 'Node has never been deployed using deploy (/var/log/deployments does not exist)'
-              else
-                # Expecting following file names
-                # node-name_2017-12-01_093418_user-name
-                file_match = stdout.first.match(/^#{Regexp.escape(@node)}_(\d{4}-\d{2}-\d{2})_.+$/)
-                if file_match.nil?
-                  error "Invalid chef deployment log file found: #{stdout.first}"
-                else
-                  last_deploy_time = Time.parse(file_match[1])
-                  error "Last deployment has been done on #{last_deploy_time.strftime('%F')}. Should refresh it." if now - last_deploy_time > MAX_ACCEPTABLE_REFRESH_PERIOD_SECS
-                end
-              end
-            end
-          }
+          deploy_info = @deployer.deployment_info_from(@node)[@node]
+          if deploy_info.key?(:error)
+            error "Error while getting deployment info: #{deploy_info[:error]}"
+          elsif Time.now.utc - deploy_info[:deployment_info][:date] > MAX_ACCEPTABLE_REFRESH_PERIOD_SECS
+            error "Last deployment has been done on #{deploy_info[:deployment_info][:date].strftime('%F')}. Should refresh it."
+          end
         end
 
       end

data/lib/hybrid_platforms_conductor/log.rb

@@ -0,0 +1,31 @@
+require 'hybrid_platforms_conductor/logger_helpers'
+require 'hybrid_platforms_conductor/plugin'
+
+module HybridPlatformsConductor
+
+  # Ancestor of all log plugins
+  class Log < Plugin
+
+    # Constructor
+    #
+    # Parameters::
+    # * *logger* (Logger): Logger to be used [default: Logger.new(STDOUT)]
+    # * *logger_stderr* (Logger): Logger to be used for stderr [default: Logger.new(STDERR)]
+    # * *config* (Config): Config to be used. [default: Config.new]
+    # * *nodes_handler* (NodesHandler): Nodes handler to be used. [default: NodesHandler.new]
+    # * *actions_executor* (ActionsExecutor): Actions executor to be used. [default: ActionsExecutor.new]
+    def initialize(
+      logger: Logger.new(STDOUT),
+      logger_stderr: Logger.new(STDERR),
+      config: Config.new,
+      nodes_handler: NodesHandler.new,
+      actions_executor: ActionsExecutor.new
+    )
+      super(logger: logger, logger_stderr: logger_stderr, config: config)
+      @nodes_handler = nodes_handler
+      @actions_executor = actions_executor
+    end
+
+  end
+
+end

data/lib/hybrid_platforms_conductor/version.rb

@@ -1,5 +1,5 @@
 module HybridPlatformsConductor
 
-  VERSION = '32.17.1'
+  VERSION = '32.18.0'
 
 end

data/spec/hybrid_platforms_conductor_test.rb

@@ -5,6 +5,7 @@ require 'hybrid_platforms_conductor/platforms_handler'
 require 'hybrid_platforms_conductor/actions_executor'
 require 'hybrid_platforms_conductor/cmd_runner'
 require 'hybrid_platforms_conductor/deployer'
+require 'hybrid_platforms_conductor/log'
 require 'hybrid_platforms_conductor/nodes_handler'
 require 'hybrid_platforms_conductor/platform_handler'
 require 'hybrid_platforms_conductor/provisioner'
@@ -43,6 +44,8 @@ require 'hybrid_platforms_conductor_test/platform_handler_plugins/test2'
 require 'hybrid_platforms_conductor_test/report_plugin'
 require 'hybrid_platforms_conductor_test/test_action'
 require 'hybrid_platforms_conductor_test/test_connector'
+require 'hybrid_platforms_conductor_test/test_log_plugin'
+require 'hybrid_platforms_conductor_test/test_log_no_read_plugin'
 require 'hybrid_platforms_conductor_test/test_plugins/global'
 require 'hybrid_platforms_conductor_test/test_plugins/node'
 require 'hybrid_platforms_conductor_test/test_plugins/node_check'
@@ -128,16 +131,29 @@ module HybridPlatformsConductorTest
         HybridPlatformsConductorTest::TestPlugins::NodeCheck.only_on_platform_types = nil
         HybridPlatformsConductorTest::TestPlugins::NodeCheck.only_on_nodes = nil
         HybridPlatformsConductorTest::TestPlugins::SeveralChecks.runs = []
+        HybridPlatformsConductorTest::TestLogPlugin.calls = []
+        HybridPlatformsConductorTest::TestLogNoReadPlugin.calls = []
         FileUtils.rm_rf './run_logs'
         FileUtils.rm_rf './testadmin.key.pub'
         FileUtils.rm_rf '/tmp/hpc_ssh'
+        register_plugins(
+          :log,
+          {
+            test_log: HybridPlatformsConductorTest::TestLogPlugin,
+            test_log_no_read: HybridPlatformsConductorTest::TestLogNoReadPlugin
+          },
+          replace: false
+        )
         # Make sure CMDB plugin classes loaded by test framework are not added automatically
-        register_plugins(:cmdb, {
-          config: HybridPlatformsConductor::HpcPlugins::Cmdb::Config,
-          host_ip: HybridPlatformsConductor::HpcPlugins::Cmdb::HostIp,
-          host_keys: HybridPlatformsConductor::HpcPlugins::Cmdb::HostKeys,
-          platform_handlers: HybridPlatformsConductor::HpcPlugins::Cmdb::PlatformHandlers
-        })
+        register_plugins(
+          :cmdb,
+          {
+            config: HybridPlatformsConductor::HpcPlugins::Cmdb::Config,
+            host_ip: HybridPlatformsConductor::HpcPlugins::Cmdb::HostIp,
+            host_keys: HybridPlatformsConductor::HpcPlugins::Cmdb::HostKeys,
+            platform_handlers: HybridPlatformsConductor::HpcPlugins::Cmdb::PlatformHandlers
+          }
+        )
       end
     end
 

data/spec/hybrid_platforms_conductor_test/api/deployer/config_dsl_spec.rb

@@ -3,10 +3,30 @@ describe HybridPlatformsConductor::Deployer do
   context 'checking deployer specific config DSL' do
 
     it 'declares a packaging timeout' do
-      with_repository do |repository|
-        with_platforms('packaging_timeout 666') do
-          expect(test_config.packaging_timeout_secs).to eq 666
-        end
+      with_platforms('packaging_timeout 666') do
+        expect(test_config.packaging_timeout_secs).to eq 666
+      end
+    end
+
+    it 'declares log plugins to be used' do
+      with_test_platforms(
+        { nodes: { 'node1' => {}, 'node2' => {} } },
+        false,
+        <<~EOS
+          send_logs_to %i[log_plugin_1 log_plugin_2]
+          for_nodes('node2') { send_logs_to :log_plugin_3 }
+        EOS
+      ) do
+        expect(test_config.deployment_logs).to eq [
+          {
+            nodes_selectors_stack: [],
+            log_plugins: %i[log_plugin_1 log_plugin_2]
+          },
+          {
+            nodes_selectors_stack: %w[node2],
+            log_plugins: %i[log_plugin_3]
+          }
+        ]
       end
     end
 

data/spec/hybrid_platforms_conductor_test/api/deployer/deploy_spec.rb

@@ -4,238 +4,213 @@ describe HybridPlatformsConductor::Deployer do
 
     deploy_specs_for(check_mode: false)
 
-    # Expect the test services handler to be called to deploy a given list of services
-    #
-    # Parameters::
-    # * *services* (Hash<String, Array<String> >): List of services to be expected, per node name
-    def expect_services_handler_to_deploy(services)
-      expect(test_services_handler).to receive(:deploy_allowed?).with(
-        services: services,
-        secrets: {},
-        local_environment: false
-      ) do
-        nil
-      end
-      expect(test_services_handler).to receive(:package).with(
-        services: services,
-        secrets: {},
-        local_environment: false
-      )
-      expect(test_services_handler).to receive(:prepare_for_deploy).with(
-        services: services,
-        secrets: {},
-        local_environment: false,
-        why_run: false
-      )
-      services.each do |node, services|
-        expect(test_services_handler).to receive(:actions_to_deploy_on).with(node, services, false) do
-          [{ bash: "echo \"Deploying on #{node}\"" }]
+    context 'checking log plugins usage' do
+
+      # Prepare the test platform with test log plugins
+      #
+      # Parameters::
+      # * *platforms_info* (Hash): The platforms info [default = {}]
+      # * *as_git* (Boolean): As a git repository? [default = false]
+      # * *additional_config* (String): Additional config [default = 'send_logs_to :test_log']
+      def with_test_platform_for_deploy_tests(platforms_info = {}, as_git = false, additional_config = 'send_logs_to :test_log')
+        with_test_platform(platforms_info, false, additional_config) do
+          yield
         end
-        expect(test_services_handler).to receive(:log_info_for).with(node, services) do
-          {
-            repo_name_0: 'platform',
-            commit_id_0: '123456',
-            commit_message_0: "Test commit for #{node}: #{services.join(', ')}"
-          }
+      end
+
+      it 'deploys correct logs information on 1 node' do
+        with_test_platform_for_deploy_tests({ nodes: { 'node' => { services: %w[service1 service2] } } }, true) do
+          with_connections_mocked_on ['node'] do
+            test_actions_executor.connector(:ssh).ssh_user = 'test_user'
+            expect_services_handler_to_deploy('node' => %w[service1 service2])
+            expect_actions_executor_runs([
+              # First run, we expect the mutex to be setup, and the deployment actions to be run
+              proc { |actions_per_nodes| expect_actions_to_deploy_on(actions_per_nodes, 'node') },
+              # Second run, we expect the mutex to be released
+              proc { |actions_per_nodes| expect_actions_to_unlock(actions_per_nodes, 'node') },
+              # Third run, we expect logs to be uploaded on the node
+              proc { |actions_per_nodes| expect(actions_per_nodes).to eq('node' => [{ bash: 'echo Save test logs to node' }]) }
+            ])
+            expect(test_deployer.deploy_on('node')).to eq('node' => [0, 'Deploy successful', ''])
+            expect(HybridPlatformsConductorTest::TestLogPlugin.calls).to eq [
+              {
+                method: :actions_to_save_logs,
+                node: 'node',
+                services: %w[service1 service2],
+                deployment_info: {
+                  repo_name_0: 'platform',
+                  commit_id_0: '123456',
+                  commit_message_0: 'Test commit for node: service1, service2',
+                  user: 'test_user'
+                },
+                exit_status: 0,
+                stdout: 'Deploy successful',
+                stderr: ''
+              }
+            ]
+          end
         end
       end
-    end
 
-    it 'deploys correct logs information on 1 node' do
-      with_test_platform({ nodes: { 'node' => { services: %w[service1 service2] } } }, true) do
-        with_connections_mocked_on ['node'] do
-          test_actions_executor.connector(:ssh).ssh_user = 'test_user'
-          expect_services_handler_to_deploy('node' => %w[service1 service2])
-          expect_actions_executor_runs([
-            # First run, we expect the mutex to be setup, and the deployment actions to be run
-            proc { |actions_per_nodes| expect_actions_to_deploy_on(actions_per_nodes, 'node') },
-            # Second run, we expect the mutex to be released
-            proc { |actions_per_nodes| expect_actions_to_unlock(actions_per_nodes, 'node') },
-            # Third run, we expect logs to be uploaded on the node
-            proc do |actions_per_nodes|
-              # Check logs content
-              local_log_file = actions_per_nodes['node'][:scp].first[0]
-              expect(File.exist?(local_log_file)).to eq true
-              expect_logs_to_be(File.read(local_log_file), 'Deploy successful', '',
-                date: /\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d/,
-                user: 'test_user',
-                debug: 'No',
-                repo_name_0: 'platform',
-                commit_id_0: '123456',
-                commit_message_0: 'Test commit for node: service1, service2',
-                services: 'service1, service2',
-                exit_status: '0'
-              )
-              expect_actions_to_upload_logs(actions_per_nodes, 'node')
-            end
-          ])
-          expect(test_deployer.deploy_on('node')).to eq('node' => [0, 'Deploy successful', ''])
+      it 'deploys correct logs information on several nodes' do
+        with_test_platform_for_deploy_tests({ nodes: {
+          'node1' => { services: %w[service1] },
+          'node2' => { services: %w[service2] }
+        } }, true) do
+          with_connections_mocked_on %w[node1 node2] do
+            test_actions_executor.connector(:ssh).ssh_user = 'test_user'
+            expect_services_handler_to_deploy(
+              'node1' => %w[service1],
+              'node2' => %w[service2]
+            )
+            expect_actions_executor_runs([
+              # First run, we expect the mutex to be setup, and the deployment actions to be run
+              proc { |actions_per_nodes| expect_actions_to_deploy_on(actions_per_nodes, %w[node1 node2]) },
+              # Second run, we expect the mutex to be released
+              proc { |actions_per_nodes| expect_actions_to_unlock(actions_per_nodes, %w[node1 node2]) },
+              # Third run, we expect logs to be uploaded on the node
+              proc do |actions_per_nodes|
+                expect(actions_per_nodes).to eq(
+                  'node1' => [{ bash: 'echo Save test logs to node1' }],
+                  'node2' => [{ bash: 'echo Save test logs to node2' }]
+                )
+              end
+            ])
+            expect(test_deployer.deploy_on(%w[node1 node2])).to eq(
+              'node1' => [0, 'Deploy successful', ''],
+              'node2' => [0, 'Deploy successful', '']
+            )
+            expect(HybridPlatformsConductorTest::TestLogPlugin.calls).to eq [
+              {
+                method: :actions_to_save_logs,
+                node: 'node1',
+                services: %w[service1],
+                deployment_info: {
+                  repo_name_0: 'platform',
+                  commit_id_0: '123456',
+                  commit_message_0: 'Test commit for node1: service1',
+                  user: 'test_user'
+                },
+                exit_status: 0,
+                stdout: 'Deploy successful',
+                stderr: ''
+              },
+              {
+                method: :actions_to_save_logs,
+                node: 'node2',
+                services: %w[service2],
+                deployment_info: {
+                  repo_name_0: 'platform',
+                  commit_id_0: '123456',
+                  commit_message_0: 'Test commit for node2: service2',
+                  user: 'test_user'
+                },
+                exit_status: 0,
+                stdout: 'Deploy successful',
+                stderr: ''
+              }
+            ]
+          end
         end
       end
-    end
 
-    it 'deploys correct logs information on several nodes' do
-      with_test_platform({ nodes: {
-        'node1' => { services: %w[service1] },
-        'node2' => { services: %w[service2] }
-      } }, true) do
-        with_connections_mocked_on %w[node1 node2] do
-          test_actions_executor.connector(:ssh).ssh_user = 'test_user'
-          expect_services_handler_to_deploy(
-            'node1' => %w[service1],
-            'node2' => %w[service2]
-          )
-          expect_actions_executor_runs([
-            # First run, we expect the mutex to be setup, and the deployment actions to be run
-            proc { |actions_per_nodes| expect_actions_to_deploy_on(actions_per_nodes, %w[node1 node2]) },
-            # Second run, we expect the mutex to be released
-            proc { |actions_per_nodes| expect_actions_to_unlock(actions_per_nodes, %w[node1 node2]) },
-            # Third run, we expect logs to be uploaded on the node
-            proc do |actions_per_nodes|
-              # Check logs content
-              local_log_file1 = actions_per_nodes['node1'][:scp].first[0]
-              expect(File.exist?(local_log_file1)).to eq true
-              expect_logs_to_be(File.read(local_log_file1), 'Deploy successful', '',
-                date: /\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d/,
-                user: 'test_user',
-                debug: 'No',
-                repo_name_0: 'platform',
-                commit_id_0: '123456',
-                commit_message_0: 'Test commit for node1: service1',
-                services: 'service1',
-                exit_status: '0'
-              )
-              local_log_file2 = actions_per_nodes['node2'][:scp].first[0]
-              expect(File.exist?(local_log_file2)).to eq true
-              expect_logs_to_be(File.read(local_log_file2), 'Deploy successful', '',
-                date: /\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d/,
-                user: 'test_user',
-                debug: 'No',
-                repo_name_0: 'platform',
-                commit_id_0: '123456',
-                commit_message_0: 'Test commit for node2: service2',
-                services: 'service2',
-                exit_status: '0'
-              )
-              expect_actions_to_upload_logs(actions_per_nodes, %w[node1 node2])
-            end
-          ])
-          expect(test_deployer.deploy_on(%w[node1 node2])).to eq(
-            'node1' => [0, 'Deploy successful', ''],
-            'node2' => [0, 'Deploy successful', '']
-          )
+      it 'deploys correct logs information on 1 node even when there is a failing deploy' do
+        with_test_platform_for_deploy_tests({ nodes: { 'node' => { services: %w[service1 service2] } } }, true) do
+          with_connections_mocked_on ['node'] do
+            test_actions_executor.connector(:ssh).ssh_user = 'test_user'
+            expect_services_handler_to_deploy('node' => %w[service1 service2])
+            expect_actions_executor_runs([
+              # First run, we expect the mutex to be setup, and the deployment actions to be run
+              proc do |actions_per_nodes|
+                expect_actions_to_deploy_on(
+                  actions_per_nodes,
+                  'node',
+                  mocked_result: { 'node' => [:failed_action, 'Failed deploy stdout', 'Failed deploy stderr'] }
+                )
+              end,
+              # Second run, we expect the mutex to be released
+              proc { |actions_per_nodes| expect_actions_to_unlock(actions_per_nodes, 'node') },
+              # Third run, we expect logs to be uploaded on the node
+              proc { |actions_per_nodes| expect(actions_per_nodes).to eq('node' => [{ bash: 'echo Save test logs to node' }]) }
+            ])
+            expect(test_deployer.deploy_on('node')).to eq('node' => [:failed_action, 'Failed deploy stdout', 'Failed deploy stderr'])
+            expect(HybridPlatformsConductorTest::TestLogPlugin.calls).to eq [
+              {
+                method: :actions_to_save_logs,
+                node: 'node',
+                services: %w[service1 service2],
+                deployment_info: {
+                  repo_name_0: 'platform',
+                  commit_id_0: '123456',
+                  commit_message_0: 'Test commit for node: service1, service2',
+                  user: 'test_user'
+                },
+                exit_status: :failed_action,
+                stdout: 'Failed deploy stdout',
+                stderr: 'Failed deploy stderr'
+              }
+            ]
+          end
         end
       end
-    end
 
-    it 'deploys correct logs information on 1 node even when there is a failing deploy' do
-      with_test_platform({ nodes: { 'node' => { services: %w[service1 service2] } } }, true) do
-        with_connections_mocked_on ['node'] do
-          test_actions_executor.connector(:ssh).ssh_user = 'test_user'
-          expect_services_handler_to_deploy('node' => %w[service1 service2])
+      it 'gets deployment info from log plugins' do
+        with_test_platform_for_deploy_tests({ nodes: { 'node' => {} } }) do |repository|
           expect_actions_executor_runs([
-            # First run, we expect the mutex to be setup, and the deployment actions to be run
+            # Expect the actions to get log files
             proc do |actions_per_nodes|
-              expect_actions_to_deploy_on(
-                actions_per_nodes,
-                'node',
-                mocked_result: { 'node' => [:failed_action, "Failed deploy stdout\n", "Failed deploy stderr\n"] }
-              )
-            end,
-            # Second run, we expect the mutex to be released
-            proc { |actions_per_nodes| expect_actions_to_unlock(actions_per_nodes, 'node') },
-            # Third run, we expect logs to be uploaded on the node
-            proc do |actions_per_nodes|
-              # Check logs content
-              local_log_file = actions_per_nodes['node'][:scp].first[0]
-              expect(File.exist?(local_log_file)).to eq true
-              expect_logs_to_be(File.read(local_log_file), "Failed deploy stdout\n", 'Failed deploy stderr',
-                date: /\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d/,
-                user: 'test_user',
-                debug: 'No',
-                repo_name_0: 'platform',
-                commit_id_0: '123456',
-                commit_message_0: 'Test commit for node: service1, service2',
-                services: 'service1, service2',
-                exit_status: 'failed_action'
-              )
-              expect_actions_to_upload_logs(actions_per_nodes, 'node')
+              expect(actions_per_nodes).to eq('node' => [{ bash: 'echo Read logs for node' }])
+              { 'node' => [42, 'Log files read stdout', 'Log files read stderr'] }
             end
           ])
-          expect(test_deployer.deploy_on('node')).to eq('node' => [:failed_action, "Failed deploy stdout\n", "Failed deploy stderr\n"])
+          expect(test_deployer.deployment_info_from('node')).to eq(
+            'node' => {
+              deployment_info: { user: 'test_user' },
+              exit_status: 666,
+              services: %w[unknown],
+              stderr: 'Deployment test stderr',
+              stdout: 'Deployment test stdout'
+            }
+          )
+          expect(HybridPlatformsConductorTest::TestLogPlugin.calls).to eq [
+            {
+              method: :actions_to_read_logs,
+              node: 'node'
+            },
+            {
+              method: :logs_for,
+              node: 'node',
+              exit_status: 42,
+              stdout: 'Log files read stdout',
+              stderr: 'Log files read stderr'
+            }
+          ]
         end
       end
-    end
-
-    it 'gets deployment info from log files' do
-      with_test_platform({ nodes: { 'node' => {} } }) do |repository|
-        expect_actions_executor_runs([
-          # Expect the actions to get log files
-          proc do |actions_per_nodes|
-            expect(actions_per_nodes).to eq('node' => { remote_bash: 'cd /var/log/deployments && ls -t | head -1 | xargs sed \'/===== STDOUT =====/q\'' })
-            { 'node' => [0, "Property1: Value1\nProperty2: Value2", ''] }
-          end
-        ])
-        expect(test_deployer.deployment_info_from('node')).to eq(
-          'node' => {
-            Property1: 'Value1',
-            Property2: 'Value2'
-          }
-        )
-      end
-    end
 
-    it 'gets deployment info with some properties converted from log files' do
-      with_test_platform({ nodes: { 'node' => {} } }) do |repository|
-        expect_actions_executor_runs([
-          # Expect the actions to get log files
-          proc do |actions_per_nodes|
-            expect(actions_per_nodes).to eq('node' => { remote_bash: 'cd /var/log/deployments && ls -t | head -1 | xargs sed \'/===== STDOUT =====/q\'' })
-            { 'node' => [0, <<~EOS, ''] }
-              date: Thu Nov 23 18:43:01 UTC 2017
-              debug: Yes
-              diff_files_0: file1, file2, file3
-              services: service1, service2, service3
-            EOS
-          end
-        ])
-        expect(test_deployer.deployment_info_from('node')).to eq(
-          'node' => {
-            date: Time.parse('2017-11-23 18:43:01 UTC'),
-            debug: true,
-            diff_files_0: %w[file1 file2 file3],
-            services: %w[service1 service2 service3]
-          }
-        )
-      end
-    end
-
-    it 'gets deployment info from several log files' do
-      with_test_platform({ nodes: { 'node1' => {}, 'node2' => {} } }) do |repository|
-        expect_actions_executor_runs([
-          # Expect the actions to get log files
-          proc do |actions_per_nodes|
-            expect(actions_per_nodes).to eq(
-              'node1' => { remote_bash: 'cd /var/log/deployments && ls -t | head -1 | xargs sed \'/===== STDOUT =====/q\'' },
-              'node2' => { remote_bash: 'cd /var/log/deployments && ls -t | head -1 | xargs sed \'/===== STDOUT =====/q\'' }
-            )
+      it 'gets deployment info from log plugins not having actions_to_read_logs' do
+        with_test_platform_for_deploy_tests({ nodes: { 'node' => {} } }, false, 'send_logs_to :test_log_no_read') do |repository|
+          expect(test_deployer.deployment_info_from('node')).to eq(
+            'node' => {
+              deployment_info: { user: 'test_user' },
+              exit_status: 666,
+              services: %w[unknown],
+              stderr: 'Deployment test stderr',
+              stdout: 'Deployment test stdout'
+            }
+          )
+          expect(HybridPlatformsConductorTest::TestLogNoReadPlugin.calls).to eq [
             {
-              'node1' => [0, "Property1: Value1\nProperty2: Value2", ''],
-              'node2' => [0, "Property3: Value3\nProperty4: Value4", '']
+              method: :logs_for,
+              node: 'node',
+              exit_status: nil,
+              stdout: nil,
+              stderr: nil
             }
-          end
-        ])
-        expect(test_deployer.deployment_info_from(%w[node1 node2])).to eq(
-          'node1' => {
-            Property1: 'Value1',
-            Property2: 'Value2'
-          },
-          'node2' => {
-            Property3: 'Value3',
-            Property4: 'Value4'
-          }
-        )
+          ]
+        end
       end
+
     end
 
   end