hybrid_platforms_conductor 32.16.4 → 33.0.1

data/spec/hybrid_platforms_conductor_test/api/actions_executor/actions/scp_spec.rb

@@ -1,6 +1,6 @@
 describe HybridPlatformsConductor::ActionsExecutor do
 
-  context 'checking actions\' plugin scp' do
+  context 'when checking actions\' plugin scp' do
 
     it 'executes remote SCP' do
       with_test_platform_for_action_plugins do
@@ -32,10 +32,12 @@ describe HybridPlatformsConductor::ActionsExecutor do
 
     it 'executes remote SCP on several files' do
       with_test_platform_for_action_plugins do
-        test_actions_executor.execute_actions('node' => { scp: {
-          'from1' => 'to1',
-          'from2' => 'to2'
-        } })
+        test_actions_executor.execute_actions(
+          'node' => { scp: {
+            'from1' => 'to1',
+            'from2' => 'to2'
+          } }
+        )
         expect(test_actions_executor.connector(:test_connector).calls).to eq [
           [:connectable_nodes_from, ['node']],
           [:with_connection_to, ['node'], { no_exception: true }],
@@ -47,10 +49,12 @@ describe HybridPlatformsConductor::ActionsExecutor do
 
     it 'executes remote SCP with sudo' do
       with_test_platform_for_action_plugins do
-        test_actions_executor.execute_actions('node' => { scp: {
-          'from' => 'to',
-          sudo: true
-        } })
+        test_actions_executor.execute_actions(
+          'node' => { scp: {
+            'from' => 'to',
+            sudo: true
+          } }
+        )
         expect(test_actions_executor.connector(:test_connector).calls).to eq [
           [:connectable_nodes_from, ['node']],
           [:with_connection_to, ['node'], { no_exception: true }],
@@ -61,11 +65,13 @@ describe HybridPlatformsConductor::ActionsExecutor do
 
     it 'executes remote SCP with different owner and group' do
       with_test_platform_for_action_plugins do
-        test_actions_executor.execute_actions('node' => { scp: {
-          'from' => 'to',
-          owner: 'new_owner',
-          group: 'new_group'
-        } })
+        test_actions_executor.execute_actions(
+          'node' => { scp: {
+            'from' => 'to',
+            owner: 'new_owner',
+            group: 'new_group'
+          } }
+        )
         expect(test_actions_executor.connector(:test_connector).calls).to eq [
           [:connectable_nodes_from, ['node']],
           [:with_connection_to, ['node'], { no_exception: true }],

data/spec/hybrid_platforms_conductor_test/api/actions_executor/actions_spec.rb

@@ -1,17 +1,15 @@
 describe HybridPlatformsConductor::ActionsExecutor do
 
-  context 'checking actions handling' do
+  context 'when checking actions handling' do
 
     # Instantiate a test platform, with the test action registered in Actions Executor.
     #
     # Parameters::
-    # * Proc: Code called with the environment ready
+    # * *block* (Proc): Code called with the environment ready
     #   * Parameters::
     #     * *repository* (String): Path to the repository
-    def with_test_platform_for_actions
-      with_test_platform_for_executor(nodes: { 'node1' => {}, 'node2' => {}, 'node3' => {} }) do |repository|
-        yield repository
-      end
+    def with_test_platform_for_actions(&block)
+      with_test_platform_for_executor(nodes: { 'node1' => {}, 'node2' => {}, 'node3' => {} }, &block)
     end
 
     it 'executes a simple action on 1 node' do
@@ -40,11 +38,13 @@ describe HybridPlatformsConductor::ActionsExecutor do
 
     it 'executes several actions on 1 node' do
       with_test_platform_for_actions do
-        test_actions_executor.execute_actions('node1' => [
-          { test_action: 'Action 1 executed' },
-          { test_action: 'Action 2 executed' },
-          { test_action: 'Action 3 executed' }
-        ])
+        test_actions_executor.execute_actions(
+          'node1' => [
+            { test_action: 'Action 1 executed' },
+            { test_action: 'Action 2 executed' },
+            { test_action: 'Action 3 executed' }
+          ]
+        )
         expect(action_executions).to eq [
           { node: 'node1', message: 'Action 1 executed' },
           { node: 'node1', message: 'Action 2 executed' },
@@ -71,26 +71,29 @@ describe HybridPlatformsConductor::ActionsExecutor do
     it 'executes several actions of different types' do
       with_test_platform_for_actions do
         actions_executed = []
-        expect(test_actions_executor.execute_actions('node1' => [
-          { ruby: proc do |stdout, stderr|
-            stdout << 'action1_stdout '
-            stderr << 'action1_stderr '
-            actions_executed << 'action1'
-          end },
-          { bash: 'echo action2_stdout' },
-          { ruby: proc do |stdout, stderr|
-            stdout << 'action3_stdout'
-            stderr << 'action3_stderr'
-            actions_executed << 'action3'
-          end }
-        ])).to eq('node1' => [0, "action1_stdout action2_stdout\naction3_stdout", 'action1_stderr action3_stderr'])
+        expect(
+          test_actions_executor.execute_actions(
+            'node1' => [
+              { ruby: proc do |stdout, stderr|
+                stdout << 'action1_stdout '
+                stderr << 'action1_stderr '
+                actions_executed << 'action1'
+              end },
+              { bash: 'echo action2_stdout' },
+              { ruby: proc do |stdout, stderr|
+                stdout << 'action3_stdout'
+                stderr << 'action3_stderr'
+                actions_executed << 'action3'
+              end }
+            ]
+          )
+        ).to eq('node1' => [0, "action1_stdout action2_stdout\naction3_stdout", 'action1_stderr action3_stderr'])
         expect(actions_executed).to eq %w[action1 action3]
       end
     end
 
     it 'executes several actions on 1 node specified using different selectors' do
       with_test_platform_for_actions do
-        actions_executed = []
         test_actions_executor.execute_actions(
           'node1' => { test_action: 'Action 1 executed' },
           '/node1/' => { test_action: 'Action 2 executed' }
@@ -125,11 +128,13 @@ describe HybridPlatformsConductor::ActionsExecutor do
 
     it 'returns errors without failing for actions having command issues' do
       with_test_platform_for_actions do
-        expect(test_actions_executor.execute_actions(
-          'node1' => { test_action: { code: proc { |stdout| stdout << 'Action 1' } } },
-          'node2' => { test_action: { code: proc { raise HybridPlatformsConductor::CmdRunner::UnexpectedExitCodeError, 'Command returned 1' } } },
-          'node3' => { test_action: { code: proc { |stdout| stdout << 'Action 3' } } }
-        )).to eq(
+        expect(
+          test_actions_executor.execute_actions(
+            'node1' => { test_action: { code: proc { |stdout| stdout << 'Action 1' } } },
+            'node2' => { test_action: { code: proc { raise HybridPlatformsConductor::CmdRunner::UnexpectedExitCodeError, 'Command returned 1' } } },
+            'node3' => { test_action: { code: proc { |stdout| stdout << 'Action 3' } } }
+          )
+        ).to eq(
           'node1' => [0, 'Action 1', ''],
           'node2' => [:failed_command, '', "Command returned 1\n"],
           'node3' => [0, 'Action 3', '']
@@ -139,11 +144,13 @@ describe HybridPlatformsConductor::ActionsExecutor do
 
     it 'returns errors without failing for actions having timeout issues' do
       with_test_platform_for_actions do
-        expect(test_actions_executor.execute_actions(
-          'node1' => { test_action: { code: proc { |stdout| stdout << 'Action 1' } } },
-          'node2' => { test_action: { code: proc { raise HybridPlatformsConductor::CmdRunner::TimeoutError } } },
-          'node3' => { test_action: { code: proc { |stdout| stdout << 'Action 3' } } }
-        )).to eq(
+        expect(
+          test_actions_executor.execute_actions(
+            'node1' => { test_action: { code: proc { |stdout| stdout << 'Action 1' } } },
+            'node2' => { test_action: { code: proc { raise HybridPlatformsConductor::CmdRunner::TimeoutError } } },
+            'node3' => { test_action: { code: proc { |stdout| stdout << 'Action 3' } } }
+          )
+        ).to eq(
           'node1' => [0, 'Action 1', ''],
           'node2' => [:timeout, '', ''],
           'node3' => [0, 'Action 3', '']
@@ -153,11 +160,13 @@ describe HybridPlatformsConductor::ActionsExecutor do
 
     it 'returns errors without failing for actions having connection issues' do
       with_test_platform_for_actions do
-        expect(test_actions_executor.execute_actions(
-          'node1' => { test_action: { code: proc { |stdout| stdout << 'Action 1' } } },
-          'node2' => { test_action: { code: proc { raise HybridPlatformsConductor::ActionsExecutor::ConnectionError, 'Can\'t connect' } } },
-          'node3' => { test_action: { code: proc { |stdout| stdout << 'Action 3' } } }
-        )).to eq(
+        expect(
+          test_actions_executor.execute_actions(
+            'node1' => { test_action: { code: proc { |stdout| stdout << 'Action 1' } } },
+            'node2' => { test_action: { code: proc { raise HybridPlatformsConductor::ActionsExecutor::ConnectionError, 'Can\'t connect' } } },
+            'node3' => { test_action: { code: proc { |stdout| stdout << 'Action 3' } } }
+          )
+        ).to eq(
           'node1' => [0, 'Action 1', ''],
           'node2' => [:connection_error, '', "Can't connect\n"],
           'node3' => [0, 'Action 3', '']
@@ -167,11 +176,13 @@ describe HybridPlatformsConductor::ActionsExecutor do
 
     it 'returns errors without failing for actions having unhandled exceptions' do
       with_test_platform_for_actions do
-        expect(test_actions_executor.execute_actions(
-          'node1' => { test_action: { code: proc { |stdout| stdout << 'Action 1' } } },
-          'node2' => { test_action: { code: proc { raise 'Strange error' } } },
-          'node3' => { test_action: { code: proc { |stdout| stdout << 'Action 3' } } }
-        )).to eq(
+        expect(
+          test_actions_executor.execute_actions(
+            'node1' => { test_action: { code: proc { |stdout| stdout << 'Action 1' } } },
+            'node2' => { test_action: { code: proc { raise 'Strange error' } } },
+            'node3' => { test_action: { code: proc { |stdout| stdout << 'Action 3' } } }
+          )
+        ).to eq(
           'node1' => [0, 'Action 1', ''],
           'node2' => [:failed_action, '', "Strange error\n"],
           'node3' => [0, 'Action 3', '']
@@ -182,11 +193,13 @@ describe HybridPlatformsConductor::ActionsExecutor do
     it 'returns errors without failing for actions on nodes having no connectors' do
       with_test_platform_for_actions do
         test_actions_executor.connector(:test_connector).accept_nodes = %w[node1 node3]
-        expect(test_actions_executor.execute_actions(
-          'node1' => { test_action: { need_connector: true, code: proc { |stdout| stdout << 'Action 1' } } },
-          'node2' => { test_action: { need_connector: true, code: proc { |stdout| stdout << 'Action 2' } } },
-          'node3' => { test_action: { need_connector: true, code: proc { |stdout| stdout << 'Action 3' } } }
-        )).to eq(
+        expect(
+          test_actions_executor.execute_actions(
+            'node1' => { test_action: { need_connector: true, code: proc { |stdout| stdout << 'Action 1' } } },
+            'node2' => { test_action: { need_connector: true, code: proc { |stdout| stdout << 'Action 2' } } },
+            'node3' => { test_action: { need_connector: true, code: proc { |stdout| stdout << 'Action 3' } } }
+          )
+        ).to eq(
           'node1' => [0, 'Action 1', ''],
           'node2' => [:no_connector, '', 'Unable to get a connector to node2'],
           'node3' => [0, 'Action 3', '']

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connection_spec.rb

@@ -1,22 +1,22 @@
 describe HybridPlatformsConductor::ActionsExecutor do
 
-  context 'checking connections handling' do
+  context 'when checking connections handling' do
 
     # Get a test platform to test connection, using the test_connector
     #
     # Parameters::
-    # * Proc: Code called with platform setup
+    # * *block* (Proc): Code called with platform setup
     #   * Parameters::
     #     * *repository* (String): Repository where the platform has been setup
-    def with_test_platform_for_connections
-      with_test_platform_for_executor(nodes: {
-        'node1' => {},
-        'node2' => {},
-        'node3' => {},
-        'node4' => {}
-      }) do |repository|
-        yield repository
-      end
+    def with_test_platform_for_connections(&block)
+      with_test_platform_for_executor(
+        nodes: {
+          'node1' => {},
+          'node2' => {},
+          'node3' => {},
+          'node4' => {}
+        }, &block
+      )
     end
 
     it 'connects on a node before executing actions needing connection' do
@@ -25,8 +25,8 @@ describe HybridPlatformsConductor::ActionsExecutor do
         test_actions_executor.execute_actions('node1' => { test_action: { need_connector: true } })
         expect(action_executions).to eq [{ node: 'node1', message: 'Action executed' }]
         expect(test_actions_executor.connector(:test_connector).calls).to eq [
-         [:connectable_nodes_from, ['node1']],
-         [:with_connection_to, ['node1'], { no_exception: true }]
+          [:connectable_nodes_from, ['node1']],
+          [:with_connection_to, ['node1'], { no_exception: true }]
         ]
       end
     end
@@ -50,8 +50,8 @@ describe HybridPlatformsConductor::ActionsExecutor do
           { node: 'node4', message: 'Action executed' }
         ]
         expect(test_actions_executor.connector(:test_connector).calls).to eq [
-         [:connectable_nodes_from, %w[node1 node2 node3 node4]],
-         [:with_connection_to, %w[node1 node2 node3 node4], { no_exception: true }]
+          [:connectable_nodes_from, %w[node1 node2 node3 node4]],
+          [:with_connection_to, %w[node1 node2 node3 node4], { no_exception: true }]
         ]
       end
     end
@@ -67,8 +67,8 @@ describe HybridPlatformsConductor::ActionsExecutor do
           { node: 'node4', message: 'Action executed' }
         ]
         expect(test_actions_executor.connector(:test_connector).calls).to eq [
-         [:connectable_nodes_from, %w[node1 node2 node3 node4]],
-         [:with_connection_to, %w[node1 node2 node3 node4], { no_exception: true }]
+          [:connectable_nodes_from, %w[node1 node2 node3 node4]],
+          [:with_connection_to, %w[node1 node2 node3 node4], { no_exception: true }]
         ]
       end
     end
@@ -87,8 +87,8 @@ describe HybridPlatformsConductor::ActionsExecutor do
           { node: 'node4', message: 'Action executed' }
         ]
         expect(test_actions_executor.connector(:test_connector).calls).to eq [
-         [:connectable_nodes_from, %w[node1 node3]],
-         [:with_connection_to, %w[node1 node3], { no_exception: true }]
+          [:connectable_nodes_from, %w[node1 node3]],
+          [:with_connection_to, %w[node1 node3], { no_exception: true }]
         ]
       end
     end
@@ -119,12 +119,12 @@ describe HybridPlatformsConductor::ActionsExecutor do
           { node: 'node4', message: 'Action executed' }
         ]
         expect(test_actions_executor.connector(:test_connector).calls).to eq [
-         [:connectable_nodes_from, %w[node1 node2 node3 node4]],
-         [:with_connection_to, %w[node1 node3], { no_exception: true }]
+          [:connectable_nodes_from, %w[node1 node2 node3 node4]],
+          [:with_connection_to, %w[node1 node3], { no_exception: true }]
         ]
         expect(test_actions_executor.connector(:test_connector_2).calls).to eq [
-         [:connectable_nodes_from, %w[node2 node4]],
-         [:with_connection_to, %w[node2 node4], { no_exception: true }]
+          [:connectable_nodes_from, %w[node2 node4]],
+          [:with_connection_to, %w[node2 node4], { no_exception: true }]
         ]
       end
     end
@@ -141,12 +141,12 @@ describe HybridPlatformsConductor::ActionsExecutor do
           { node: 'node4', message: 'Action executed' }
         ]
         expect(test_actions_executor.connector(:test_connector).calls).to eq [
-         [:connectable_nodes_from, %w[node1 node2 node3 node4]],
-         [:with_connection_to, %w[node1 node2 node3], { no_exception: true }]
+          [:connectable_nodes_from, %w[node1 node2 node3 node4]],
+          [:with_connection_to, %w[node1 node2 node3], { no_exception: true }]
         ]
         expect(test_actions_executor.connector(:test_connector_2).calls).to eq [
-         [:connectable_nodes_from, %w[node4]],
-         [:with_connection_to, %w[node4], { no_exception: true }]
+          [:connectable_nodes_from, %w[node4]],
+          [:with_connection_to, %w[node4], { no_exception: true }]
         ]
       end
     end
@@ -157,12 +157,12 @@ describe HybridPlatformsConductor::ActionsExecutor do
         test_actions_executor.connector(:test_connector_2).accept_nodes = %w[node2 node4]
         test_actions_executor.with_connections_prepared_to(%w[node1 node2 node3 node4]) do |connected_nodes|
           expect(test_actions_executor.connector(:test_connector).calls).to eq [
-           [:connectable_nodes_from, %w[node1 node2 node3 node4]],
-           [:with_connection_to, %w[node1 node3], { no_exception: false }]
+            [:connectable_nodes_from, %w[node1 node2 node3 node4]],
+            [:with_connection_to, %w[node1 node3], { no_exception: false }]
           ]
           expect(test_actions_executor.connector(:test_connector_2).calls).to eq [
-           [:connectable_nodes_from, %w[node2 node4]],
-           [:with_connection_to, %w[node2 node4], { no_exception: false }]
+            [:connectable_nodes_from, %w[node2 node4]],
+            [:with_connection_to, %w[node2 node4], { no_exception: false }]
           ]
           expect(connected_nodes).to eq(
             'node1' => test_actions_executor.connector(:test_connector),
@@ -190,12 +190,12 @@ describe HybridPlatformsConductor::ActionsExecutor do
         test_actions_executor.connector(:test_connector_2).accept_nodes = %w[node2]
         test_actions_executor.with_connections_prepared_to(%w[node1 node2 node3 node4], no_exception: true) do |connected_nodes|
           expect(test_actions_executor.connector(:test_connector).calls).to eq [
-           [:connectable_nodes_from, %w[node1 node2 node3 node4]],
-           [:with_connection_to, %w[node1 node3], { no_exception: true }]
+            [:connectable_nodes_from, %w[node1 node2 node3 node4]],
+            [:with_connection_to, %w[node1 node3], { no_exception: true }]
           ]
           expect(test_actions_executor.connector(:test_connector_2).calls).to eq [
-           [:connectable_nodes_from, %w[node2 node4]],
-           [:with_connection_to, %w[node2], { no_exception: true }]
+            [:connectable_nodes_from, %w[node2 node4]],
+            [:with_connection_to, %w[node2], { no_exception: true }]
           ]
           expect(connected_nodes).to eq(
             'node1' => test_actions_executor.connector(:test_connector),

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/local/connectable_nodes_spec.rb

@@ -1,8 +1,8 @@
 describe HybridPlatformsConductor::ActionsExecutor do
 
-  context 'checking connector plugin local' do
+  context 'when checking connector plugin local' do
 
-    context 'checking connectable nodes selection' do
+    context 'when checking connectable nodes selection' do
 
       # Return the connector to be tested
       #
@@ -13,12 +13,16 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'selects connectable nodes correctly' do
-        with_test_platform(nodes: {
-          'node1' => { meta: { host_ip: '192.168.42.42' } },
-          'node2' => {},
-          'node3' => { meta: { host_ip: '127.0.0.1', local_node: true } },
-          'node4' => { meta: { local_node: true } }
-        }) do
+        with_test_platform(
+          {
+            nodes: {
+              'node1' => { meta: { host_ip: '192.168.42.42' } },
+              'node2' => {},
+              'node3' => { meta: { host_ip: '127.0.0.1', local_node: true } },
+              'node4' => { meta: { local_node: true } }
+            }
+          }
+        ) do
           expect(test_connector.connectable_nodes_from(%w[node1 node2 node3 node4]).sort).to eq %w[node3 node4].sort
         end
       end

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/local/remote_actions_spec.rb

@@ -1,8 +1,8 @@
 describe HybridPlatformsConductor::ActionsExecutor do
 
-  context 'checking connector plugin local' do
+  context 'when checking connector plugin local' do
 
-    context 'checking remote actions' do
+    context 'when checking remote actions' do
 
       # Return the connector to be tested
       #
@@ -19,7 +19,6 @@ describe HybridPlatformsConductor::ActionsExecutor do
       # * *expected_stdout* (String): Expected stdout after client code execution [default: '']
       # * *expected_stderr* (String): Expected stderr after client code execution [default: '']
       # * *timeout* (Integer or nil): Timeout to prepare the connector for [default: nil]
-      # * *password* (String or nil): Password to set for the node, or nil for none [default: nil]
       # * *additional_config* (String): Additional config [default: '']
       # * Proc: Client code to execute testing
       def with_test_platform_for_remote_testing(
@@ -27,13 +26,11 @@ describe HybridPlatformsConductor::ActionsExecutor do
         expected_stdout: '',
         expected_stderr: '',
         timeout: nil,
-        password: nil,
         additional_config: ''
       )
         with_test_platform(
           { nodes: { 'node' => { meta: { local_node: true } } } },
-          false,
-          additional_config
+          additional_config: additional_config
         ) do
           with_cmd_runner_mocked(expected_cmds) do
             test_connector.with_connection_to(['node']) do
@@ -62,7 +59,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
           expected_cmds: [
             [
               'cd /tmp/hpc_local_workspaces/node ; bash_cmd.bash',
-              proc do |cmd, log_to_file: nil, log_to_stdout: true, log_stdout_to_io: nil, log_stderr_to_io: nil, expected_code: 0, timeout: nil, no_exception: false|
+              proc do |_cmd, log_to_file: nil, log_to_stdout: true, log_stdout_to_io: nil, log_stderr_to_io: nil, expected_code: 0, timeout: nil, no_exception: false|
                 expect(timeout).to eq 5
                 [0, '', '']
               end