hybrid_platforms_conductor 32.16.1 → 32.17.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f01de7476f9279e990b054d1b5709c1a549ea2a2069f3a12ace8b40d639451b0
-  data.tar.gz: f6336d1668fe315ac99bd1268fc91514b1644663633a6299654808597d8d202b
+  metadata.gz: 8d66286a0b94c89bde4c7557a1b707158095363ccb854e3af5bdf951fe9065ee
+  data.tar.gz: fa1976b8f50dd96a1717ec596540f3ae0cbb35c3b0d44b55e46e53f40e8a460d
 SHA512:
-  metadata.gz: 5a931593af6eb20bf83eb478a2a438612dbcf3acf0f0e3cc93541c163b593a0aad88fd59f56340411d4cd95fe60618e58ae5ba845a44e42b0123394c93cab713
-  data.tar.gz: 5708d46f33bbfa53a0ddd48607b23c93468b7cdb588ba1d969c997047944e89ff8303009f63c54438db02b23b8633b3fdef9989a49527fdcca812d1cf6ce8ddd
+  metadata.gz: 2f2e172771aa4925c790d2faa57aaeca5da59914806787f8b19774af9a58ffb3e76766b66997e55a97602e05eeb7395f04c1f866c7a0acb17656adb87fdab8a2
+  data.tar.gz: f61b8ede205e1cbbb863b2261fb7f8ad01d57b3cc319eec1fada0dcbcb99ce14384a5d74bbfaf86ef0aa5e3c0fbd5568933bf5ddf0c99e7deaa5e3db900e7e28

data/CHANGELOG.md

@@ -1,3 +1,51 @@
+# [v32.17.1](https://github.com/sweet-delights/hybrid-platforms-conductor/compare/v32.17.0...v32.17.1) (2021-06-03 16:20:09)
+
+### Patches
+
+* [[Hotfix] Don't run remote nodes tests on local nodes](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/fe8e34a4d74f21d4903c14b1e156b9730f4b5fee)
+
+# [v32.17.0](https://github.com/sweet-delights/hybrid-platforms-conductor/compare/v32.16.4...v32.17.0) (2021-06-02 12:57:44)
+
+## Global changes
+### Patches
+
+* [[Feature(test_github_ci)] [#61] Add the github_ci test plugin to check for CI/CD of projects on Github](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/a0082efe5c138ca88ca91a3c10f777f47fca5034)
+
+## Changes for test_github_ci
+### Features
+
+* [[Feature(test_github_ci)] [#61] Add the github_ci test plugin to check for CI/CD of projects on Github](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/a0082efe5c138ca88ca91a3c10f777f47fca5034)
+
+# [v32.16.4](https://github.com/sweet-delights/hybrid-platforms-conductor/compare/v32.16.3...v32.16.4) (2021-06-01 13:25:19)
+
+### Patches
+
+* [[Hotfix] Fixed boolean values incorrectly used as strings](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/a107f3e0fe4c1512ce7607a303fdf0753d92ddac)
+
+# [v32.16.3](https://github.com/sweet-delights/hybrid-platforms-conductor/compare/v32.16.2...v32.16.3) (2021-06-01 11:19:50)
+
+## Global changes
+### Patches
+
+* [[Hotfix(platform_handler_serverless_chef)] Fix Chef packaging missing licenses accept](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/69eafc1b23f77de65ba0dd68e5adb7fafb58157e)
+
+## Changes for platform_handler_serverless_chef
+### Patches
+
+* [[Hotfix(platform_handler_serverless_chef)] Fix Chef packaging missing licenses accept](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/69eafc1b23f77de65ba0dd68e5adb7fafb58157e)
+
+# [v32.16.2](https://github.com/sweet-delights/hybrid-platforms-conductor/compare/v32.16.1...v32.16.2) (2021-06-01 09:52:22)
+
+## Global changes
+### Patches
+
+* [[Hotfix(platform_handler_serverless_chef)] Fix Chef Workstation bash steps when run by root](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/1d99d1faa9cf66cd607eacc00205e312fd589715)
+
+## Changes for platform_handler_serverless_chef
+### Patches
+
+* [[Hotfix(platform_handler_serverless_chef)] Fix Chef Workstation bash steps when run by root](https://github.com/sweet-delights/hybrid-platforms-conductor/commit/1d99d1faa9cf66cd607eacc00205e312fd589715)
+
 # [v32.16.1](https://github.com/sweet-delights/hybrid-platforms-conductor/compare/v32.16.0...v32.16.1) (2021-06-01 09:21:47)
 
 ## Global changes

data/docs/plugins.md

@@ -182,6 +182,7 @@ Plugins shipped by default:
 * [`executables`](plugins/test/executables.md)
 * [`file_system_hdfs`](plugins/test/file_system_hdfs.md)
 * [`file_system`](plugins/test/file_system.md)
+* [`github_ci`](plugins/test/github_ci.md)
 * [`hostname`](plugins/test/hostname.md)
 * [`idempotence`](plugins/test/idempotence.md)
 * [`ip`](plugins/test/ip.md)

data/docs/plugins/connector/ssh.md

@@ -70,7 +70,7 @@ end
 | `host_keys` | `Array<String>` | The node's host keys used to generate a `known_hosts` file with those to avoid user confirmations when connecting. |
 | `hostname` | `String` | Host name used to connect in case no IP address can be found in metadata. |
 | `private_ips` | `Array<String>` | IP list to connect in case `host_ip` is not defined in metadata. |
-| `ssh_session_exec` | `String` | If set to the string `false`, then consider that the node does not have any SSH SessionExec capabilities. This will make sure that remote command executions is done using stdin piping on interactive sessions instead of SSH commands execution. |
+| `ssh_session_exec` | `Boolean` | If set to `false`, then consider that the node does not have any SSH SessionExec capabilities. This will make sure that remote command executions is done using stdin piping on interactive sessions instead of SSH commands execution. |
 
 ## Used environment variables
 

data/docs/plugins/test/bitbucket_conf.md

@@ -12,7 +12,7 @@ Define a Bitbucket installation to be targeted.
 It takes the following parameters:
 * **url** (`String`): URL to the Bitbucket server
 * **project** (`String`): Project name from the Bitbucket server, storing repositories
-* **repos** (`Array<String>` or `Symbol`): List of repository names from this project, or :all for all [default: :all]
+* **repos** (`Array<String>` or `Symbol`): List of repository names from this project, or `:all` for all [default: `:all`]
 * **checks** (`Hash<Symbol, Object>`): Checks definition to be perform on those repositories [default: {}]
   * **branch_permissions** (`Array< Hash<Symbol, Object> >`): List of branch permissions to check [optional]
     * **type** (`String`): Type of branch permissions to check. Examples of values are 'fast-forward-only', 'no-deletes', 'pull-request-only'.

data/docs/plugins/test/check_deploy_and_idempotence.md

@@ -49,7 +49,7 @@ end
 
 | Metadata | Type | Usage
 | --- | --- | --- |
-| `root_access_allowed` | `String` | If set to `true`, then skip the test for `root` access being disabled after deployment |
+| `root_access_allowed` | `Boolean` | If set to `true`, then skip the test for `root` access being disabled after deployment |
 
 ## Used environment variables
 

data/docs/plugins/test/connection.md

@@ -16,6 +16,7 @@ None
 
 | Metadata | Type | Usage
 | --- | --- | --- |
+| `local_node` | `Boolean` | Skip this test for nodes having this metadata set to `true` |
 
 ## Used environment variables
 

data/docs/plugins/test/deploy_removes_root_access.md

@@ -17,7 +17,7 @@ None
 
 | Metadata | Type | Usage
 | --- | --- | --- |
-| `root_access_allowed` | `String` | If set to `true`, then skip this test |
+| `root_access_allowed` | `Boolean` | If set to `true`, then skip this test |
 
 ## Used environment variables
 

data/docs/plugins/test/file_system.md

@@ -38,6 +38,7 @@ end
 
 | Metadata | Type | Usage
 | --- | --- | --- |
+| `local_node` | `Boolean` | Skip this test for nodes having this metadata set to `true` |
 
 ## Used environment variables
 

data/docs/plugins/test/github_ci.md

@@ -0,0 +1,48 @@
+# Test plugin: `github_ci`
+
+The `github_ci` test plugin checks that the `master` branch of Github repositories has a successful CI result from its [Github Actions](https://github.com/features/actions).
+
+## Config DSL extension
+
+### `github_repos`
+
+Define Github repositories to be targeted.
+
+It takes the following parameters:
+* **url** (`String`): URL to the Github API [default: `'https://api.github.com'`]
+* **user** (`String`): User or organization name, storing repositories
+* **repos** (`Array<String>` or `Symbol`): List of repository names from this project, or `:all` for all [default: `:all`]
+
+Example:
+```ruby
+github_repos(
+  # Github's user containing repositories
+  user: 'My-Github-User',
+  # List of repositories to check
+  repos: [
+    'my-platform-repo',
+    'my-chef-repo',
+    'my-hpc-plugins'
+  ]
+)
+```
+
+## Used credentials
+
+| Credential | Usage
+| --- | --- |
+| `github` | Used to connect to the Github API. Password should be the Github API token. |
+
+## Used Metadata
+
+| Metadata | Type | Usage
+| --- | --- | --- |
+
+## Used environment variables
+
+| Variable | Usage
+| --- | --- |
+
+## External tools dependencies
+
+None

data/docs/plugins/test/hostname.md

@@ -16,6 +16,7 @@ None
 
 | Metadata | Type | Usage
 | --- | --- | --- |
+| `local_node` | `Boolean` | Skip this test for nodes having this metadata set to `true` |
 
 ## Used environment variables
 

data/docs/plugins/test/ip.md

@@ -16,6 +16,7 @@ None
 
 | Metadata | Type | Usage
 | --- | --- | --- |
+| `local_node` | `Boolean` | Skip this test for nodes having this metadata set to `true` |
 | `private_ips` | `Array<String>` | List of possible private IPs the node should have |
 
 ## Used environment variables

data/docs/plugins/test/jenkins_ci_conf.md

@@ -12,7 +12,7 @@ It takes the following parameters:
 * **url** (`String`): URL to the Bitbucket server
 * **project** (`String`): Project name from the Bitbucket server, storing repositories
 * **jenkins_ci_url** (`String` or `nil`): Corresponding Jenkins CI URL, or nil if none.
-* **repos** (`Array<String>` or `Symbol`): List of repository names from this project, or :all for all [default: :all]
+* **repos** (`Array<String>` or `Symbol`): List of repository names from this project, or `:all` for all [default: `:all`]
 
 Example:
 ```ruby

data/docs/plugins/test/jenkins_ci_masters_ok.md

@@ -12,7 +12,7 @@ It takes the following parameters:
 * **url** (`String`): URL to the Bitbucket server
 * **project** (`String`): Project name from the Bitbucket server, storing repositories
 * **jenkins_ci_url** (`String` or `nil`): Corresponding Jenkins CI URL, or nil if none.
-* **repos** (`Array<String>` or `Symbol`): List of repository names from this project, or :all for all [default: :all]
+* **repos** (`Array<String>` or `Symbol`): List of repository names from this project, or `:all` for all [default: `:all`]
 
 Example:
 ```ruby

data/docs/plugins/test/local_users.md

@@ -37,6 +37,7 @@ check_local_users_do_not_exist %w[olduser1 olduser2]
 
 | Metadata | Type | Usage
 | --- | --- | --- |
+| `local_node` | `Boolean` | Skip this test for nodes having this metadata set to `true` |
 
 ## Used environment variables
 

data/docs/plugins/test/mounts.md

@@ -44,6 +44,7 @@ end
 
 | Metadata | Type | Usage
 | --- | --- | --- |
+| `local_node` | `Boolean` | Skip this test for nodes having this metadata set to `true` |
 
 ## Used environment variables
 

data/docs/plugins/test/orphan_files.md

@@ -27,6 +27,7 @@ end
 
 | Metadata | Type | Usage
 | --- | --- | --- |
+| `local_node` | `Boolean` | Skip this test for nodes having this metadata set to `true` |
 
 ## Used environment variables
 

data/docs/plugins/test/ports.md

@@ -39,6 +39,7 @@ check_closed_ports 25, 110
 | Metadata | Type | Usage
 | --- | --- | --- |
 | `host_ip` | `String` | Host IP address to be tested for port listening |
+| `local_node` | `Boolean` | Skip this test for nodes having this metadata set to `true` |
 
 ## Used environment variables
 

data/docs/plugins/test/spectre.md

@@ -15,6 +15,7 @@ None
 
 | Metadata | Type | Usage
 | --- | --- | --- |
+| `local_node` | `Boolean` | Skip this test for nodes having this metadata set to `true` |
 
 ## Used environment variables
 

data/docs/plugins/test/vulnerabilities.md

@@ -54,6 +54,7 @@ None
 | Metadata | Type | Usage
 | --- | --- | --- |
 | `image` | `String` | The name of the OS image to be used. The [configuration](../../config_dsl.md) should define the image and point it to a directory containing a `oval.json` that will contain definition of OVAL files to be checked for this OS(see above). |
+| `local_node` | `Boolean` | Skip this test for nodes having this metadata set to `true` |
 
 ## Used environment variables
 

data/lib/hybrid_platforms_conductor/common_config_dsl/github.rb

@@ -0,0 +1,62 @@
+require 'octokit'
+require 'hybrid_platforms_conductor/credentials'
+
+module HybridPlatformsConductor
+
+  module CommonConfigDsl
+
+    module Github
+
+      # Initialize the DSL 
+      def init_github
+        # List of Github repositories definitions
+        # Array< Hash<Symbol, Object> >
+        # Each definition is just mapping the signature of #github_repos
+        @github_repos = []
+      end
+
+      # Register new Github repositories
+      #
+      # Parameters::
+      # * *url* (String): URL to the Github API [default: 'https://api.github.com']
+      # * *user* (String): User or organization name, storing repositories
+      # * *repos* (Array<String> or Symbol): List of repository names from this project, or :all for all [default: :all]
+      def github_repos(url: 'https://api.github.com', user:, repos: :all)
+        @github_repos << {
+          url: url,
+          user: user,
+          repos: repos
+        }
+      end
+
+      # Iterate over each Github repository
+      #
+      # Parameters::
+      # * Proc: Code called for each Github repository:
+      #   * Parameters::
+      #     * *github* (Octokit::Client): The client instance accessing the Github API
+      #     * *repo_info* (Hash<Symbol, Object>): The repository info:
+      #       * *name* (String): Repository name.
+      #       * *slug* (String): Repository slug.
+      def for_each_github_repo
+        @github_repos.each do |repo_info|
+          Octokit.configure do |c|
+            c.api_endpoint = repo_info[:url]
+          end
+          Credentials.with_credentials_for(:github, @logger, @logger_stderr, url: repo_info[:url]) do |_github_user, github_token|
+            client = Octokit::Client.new(access_token: github_token)
+            (repo_info[:repos] == :all ? client.repositories(repo_info[:user]).map { |repo| repo[:name] } : repo_info[:repos]).each do |name|
+              yield client, {
+                name: name,
+                slug: "#{repo_info[:user]}/#{name}"
+              }
+            end
+          end
+        end
+      end
+
+    end
+
+  end
+
+end

data/lib/hybrid_platforms_conductor/deployer.rb

@@ -319,7 +319,7 @@ module HybridPlatformsConductor
         )
         instance.with_running_instance(stop_on_exit: true, destroy_on_exit: !reuse_instance, port: 22) do
           # Test-provisioned nodes have SSH Session Exec capabilities and are not local
-          sub_executable.nodes_handler.override_metadata_of node, :ssh_session_exec, 'true'
+          sub_executable.nodes_handler.override_metadata_of node, :ssh_session_exec, true
           sub_executable.nodes_handler.override_metadata_of node, :local_node, false
           # Test-provisioned nodes use default sudo
           sub_executable.config.sudo_procs.replace(sub_executable.config.sudo_procs.map do |sudo_proc_info|

data/lib/hybrid_platforms_conductor/hpc_plugins/connector/ssh.rb

@@ -238,7 +238,7 @@ module HybridPlatformsConductor
         # * *bash_cmds* (String): Bash commands to execute
         def remote_bash(bash_cmds)
           ssh_cmd =
-            if @nodes_handler.get_ssh_session_exec_of(@node) == 'false'
+            if @nodes_handler.get_ssh_session_exec_of(@node) == false
               # When ExecSession is disabled we need to use stdin directly
               "{ cat | #{ssh_exec} #{ssh_url} -T; } <<'HPC_EOF'\n#{bash_cmds}\nHPC_EOF"
             else
@@ -300,7 +300,7 @@ module HybridPlatformsConductor
         # * *owner* (String or nil): Owner to be used when copying the files, or nil for current one [default: nil]
         # * *group* (String or nil): Group to be used when copying the files, or nil for current one [default: nil]
         def remote_copy(from, to, sudo: false, owner: nil, group: nil)
-          if @nodes_handler.get_ssh_session_exec_of(@node) == 'false'
+          if @nodes_handler.get_ssh_session_exec_of(@node) == false
             # We don't have ExecSession, so don't use ssh, but scp instead.
             if sudo
               # We need to first copy the file in an accessible directory, and then sudo mv
@@ -513,7 +513,7 @@ module HybridPlatformsConductor
                     if current_users.empty?
                       log_debug "[ ControlMaster - #{ssh_url} ] - Creating SSH ControlMaster..."
                       exit_status = nil
-                      if @nodes_handler.get_ssh_session_exec_of(node) == 'false'
+                      if @nodes_handler.get_ssh_session_exec_of(node) == false
                         # Here we have to create a ControlMaster using an interactive session, as the SSH server prohibits ExecSession, and so command executions.
                         # We'll do that using another terminal spawned in the background.
                         if ENV['hpc_interactive'] == 'false'

data/lib/hybrid_platforms_conductor/hpc_plugins/platform_handler/serverless_chef.rb

@@ -84,7 +84,7 @@ module HybridPlatformsConductor
                 expected_match.nil? ? 'unreadable' : expected_match[1]
               end
             log_debug "Current Chef version: #{existing_version}. Required version: #{required_version}"
-            @cmd_runner.run_cmd "curl -L https://omnitruck.chef.io/install.sh | sudo bash -s -- -P chef-workstation -v #{required_version}" unless existing_version == required_version
+            @cmd_runner.run_cmd "curl -L https://omnitruck.chef.io/install.sh | #{@cmd_runner.root? ? '' : 'sudo '}bash -s -- -P chef-workstation -v #{required_version}" unless existing_version == required_version
           end
         end
 
@@ -175,11 +175,11 @@ module HybridPlatformsConductor
                 end
                 lock_file = "#{File.dirname(policy_file)}/#{File.basename(policy_file, '.rb')}.lock.json"
                 # If the policy lock file does not exist, generate it
-                @cmd_runner.run_cmd "cd #{@repository_path} && /opt/chef-workstation/bin/chef install #{policy_file}" unless File.exist?("#{@repository_path}/#{lock_file}")
+                @cmd_runner.run_cmd "cd #{@repository_path} && /opt/chef-workstation/bin/chef install #{policy_file} --chef-license accept" unless File.exist?("#{@repository_path}/#{lock_file}")
                 extra_cp_data_bags = File.exist?("#{@repository_path}/data_bags") ? " && cp -ar data_bags/ #{package_dir}/" : ''
                 @cmd_runner.run_cmd "cd #{@repository_path} && \
-                  sudo rm -rf #{package_dir} && \
-                  /opt/chef-workstation/bin/chef export #{policy_file} #{package_dir}#{extra_cp_data_bags}"
+                  #{@cmd_runner.root? ? '' : 'sudo '}rm -rf #{package_dir} && \
+                  /opt/chef-workstation/bin/chef export #{policy_file} #{package_dir} --chef-license accept#{extra_cp_data_bags}"
               end
               unless @cmd_runner.dry_run
                 # Create secrets file
@@ -236,7 +236,7 @@ module HybridPlatformsConductor
           client_options << '--why-run' if use_why_run
           if @nodes_handler.get_use_local_chef_of(node)
             # Just run the chef-client directly from the packaged repository
-            [{ bash: "cd #{package_dir} && sudo SSL_CERT_DIR=/etc/ssl/certs /opt/chef-workstation/bin/chef-client #{client_options.join(' ')}" }]
+            [{ bash: "cd #{package_dir} && #{@cmd_runner.root? ? '' : 'sudo '}SSL_CERT_DIR=/etc/ssl/certs /opt/chef-workstation/bin/chef-client #{client_options.join(' ')}" }]
           else
             # Upload the package and run it from the node
             package_name = File.basename(package_dir)

data/lib/hybrid_platforms_conductor/hpc_plugins/provisioner/podman.rb

@@ -112,7 +112,7 @@ module HybridPlatformsConductor
         # Result::
         # * String: The Podman command
         def podman_cmd
-          @podman_cmd = @cmd_runner.root? ? 'podman' : 'sudo podman' unless defined?(@podman_cmd)
+          @podman_cmd = "#{@cmd_runner.root? ? '' : 'sudo '}podman" unless defined?(@podman_cmd)
           @podman_cmd
         end
 

data/lib/hybrid_platforms_conductor/hpc_plugins/test/check_deploy_and_idempotence.rb

@@ -54,7 +54,7 @@ module HybridPlatformsConductor
                 instance.stop
                 instance.with_running_instance(port: 22) do
 
-                  unless @nodes_handler.get_root_access_allowed_of(@node) == 'true'
+                  unless @nodes_handler.get_root_access_allowed_of(@node)
                     # ===== Deploy removes root access
                     # Check that we can't connect with root
                     ssh_ok = false

data/lib/hybrid_platforms_conductor/hpc_plugins/test/connection.rb

@@ -1,3 +1,5 @@
+require 'hybrid_platforms_conductor/test_only_remote_node'
+
 module HybridPlatformsConductor
 
   module HpcPlugins
@@ -5,7 +7,7 @@ module HybridPlatformsConductor
     module Test
 
       # Test that the connection works by simply outputing something
-      class Connection < HybridPlatformsConductor::Test
+      class Connection < TestOnlyRemoteNode
 
         TEST_CONNECTION_STRING = 'Test connection - ok'
 

data/lib/hybrid_platforms_conductor/hpc_plugins/test/deploy_removes_root_access.rb

@@ -12,7 +12,7 @@ module HybridPlatformsConductor
 
         # Check my_test_plugin.rb.sample documentation for signature details.
         def test_for_node
-          unless @nodes_handler.get_root_access_allowed_of(@node) == 'true'
+          unless @nodes_handler.get_root_access_allowed_of(@node)
             @deployer.with_test_provisioned_instance(@config.tests_provisioner_id, @node, environment: 'deploy_removes_root_access', reuse_instance: log_debug?) do |deployer, instance|
               # Check that we can connect with root
               ssh_ok = false

data/lib/hybrid_platforms_conductor/hpc_plugins/test/file_system.rb

@@ -1,3 +1,4 @@
+require 'hybrid_platforms_conductor/test_only_remote_node'
 require 'hybrid_platforms_conductor/common_config_dsl/file_system_tests'
 
 module HybridPlatformsConductor
@@ -7,7 +8,7 @@ module HybridPlatformsConductor
     module Test
 
       # Perform various tests on a node's file system
-      class FileSystem < HybridPlatformsConductor::Test
+      class FileSystem < TestOnlyRemoteNode
 
         self.extend_config_dsl_with CommonConfigDsl::FileSystemTests, :init_file_system_tests
 

data/lib/hybrid_platforms_conductor/hpc_plugins/test/github_ci.rb

@@ -0,0 +1,32 @@
+require 'hybrid_platforms_conductor/common_config_dsl/github'
+
+module HybridPlatformsConductor
+
+  module HpcPlugins
+
+    module Test
+
+      # Check that all repositories have a successful Github CI
+      class GithubCi < HybridPlatformsConductor::Test
+
+        self.extend_config_dsl_with CommonConfigDsl::Github, :init_github
+
+        # Check my_test_plugin.rb.sample documentation for signature details.
+        def test
+          @config.for_each_github_repo do |client, repo_info|
+            log_debug "Checking CI for Github repository #{repo_info[:slug]}"
+            last_status = client.repository_workflow_runs(repo_info[:slug])[:workflow_runs].
+              select { |run| run[:head_branch] == 'master' }.
+              sort_by { |run| run[:created_at] }.
+              last[:conclusion]
+            error "Last workflow status for repository #{repo_info[:slug]} is #{last_status}" unless last_status == 'success'
+          end
+        end
+
+      end
+
+    end
+
+  end
+
+end

data/lib/hybrid_platforms_conductor/hpc_plugins/test/hostname.rb

@@ -1,3 +1,5 @@
+require 'hybrid_platforms_conductor/test_only_remote_node'
+
 module HybridPlatformsConductor
 
   module HpcPlugins
@@ -5,7 +7,7 @@ module HybridPlatformsConductor
     module Test
 
       # Test that the hostname is correct
-      class Hostname < HybridPlatformsConductor::Test
+      class Hostname < TestOnlyRemoteNode
 
         # Check my_test_plugin.rb.sample documentation for signature details.
         def test_on_node

data/lib/hybrid_platforms_conductor/hpc_plugins/test/ip.rb

@@ -1,3 +1,5 @@
+require 'hybrid_platforms_conductor/test_only_remote_node'
+
 module HybridPlatformsConductor
 
   module HpcPlugins
@@ -5,7 +7,7 @@ module HybridPlatformsConductor
     module Test
 
       # Test that the private IP address is correct
-      class Ip < HybridPlatformsConductor::Test
+      class Ip < TestOnlyRemoteNode
 
         # Check my_test_plugin.rb.sample documentation for signature details.
         def test_on_node

data/lib/hybrid_platforms_conductor/hpc_plugins/test/local_users.rb

@@ -1,3 +1,5 @@
+require 'hybrid_platforms_conductor/test_only_remote_node'
+
 module HybridPlatformsConductor
 
   module HpcPlugins
@@ -5,7 +7,7 @@ module HybridPlatformsConductor
     module Test
 
       # Test that the node's local users
-      class LocalUsers < HybridPlatformsConductor::Test
+      class LocalUsers < TestOnlyRemoteNode
 
         # Config DSL extension for this test plugin
         module ConfigDslExtension

data/lib/hybrid_platforms_conductor/hpc_plugins/test/mounts.rb

@@ -1,3 +1,5 @@
+require 'hybrid_platforms_conductor/test_only_remote_node'
+
 module HybridPlatformsConductor
 
   module HpcPlugins
@@ -5,7 +7,7 @@ module HybridPlatformsConductor
     module Test
 
       # Various tests on mounts
-      class Mounts < HybridPlatformsConductor::Test
+      class Mounts < TestOnlyRemoteNode
 
         # Config DSL extension for this test plugin
         module ConfigDslExtension

data/lib/hybrid_platforms_conductor/hpc_plugins/test/orphan_files.rb

@@ -1,3 +1,5 @@
+require 'hybrid_platforms_conductor/test_only_remote_node'
+
 module HybridPlatformsConductor
 
   module HpcPlugins
@@ -5,7 +7,7 @@ module HybridPlatformsConductor
     module Test
 
       # Test that the node has no orphan files
-      class OrphanFiles < HybridPlatformsConductor::Test
+      class OrphanFiles < TestOnlyRemoteNode
 
         # Config DSL extension for this test plugin
         module ConfigDslExtension

data/lib/hybrid_platforms_conductor/hpc_plugins/test/ports.rb

@@ -1,3 +1,5 @@
+require 'hybrid_platforms_conductor/test_only_remote_node'
+
 module HybridPlatformsConductor
 
   module HpcPlugins
@@ -5,7 +7,7 @@ module HybridPlatformsConductor
     module Test
 
       # Various tests on ports
-      class Ports < HybridPlatformsConductor::Test
+      class Ports < TestOnlyRemoteNode
 
         # Config DSL extension for this test plugin
         module ConfigDslExtension

data/lib/hybrid_platforms_conductor/hpc_plugins/test/spectre.rb

@@ -1,3 +1,5 @@
+require 'hybrid_platforms_conductor/test_only_remote_node'
+
 module HybridPlatformsConductor
 
   module HpcPlugins
@@ -5,7 +7,7 @@ module HybridPlatformsConductor
     module Test
 
       # Test that the vulnerabilities Spectre and Meltdown are patched
-      class Spectre < HybridPlatformsConductor::Test
+      class Spectre < TestOnlyRemoteNode
 
         VULNERABILITIES_TO_CHECK = {
           'CVE-2017-5753' => 'Spectre Variant 1',

data/lib/hybrid_platforms_conductor/hpc_plugins/test/vulnerabilities.rb

@@ -1,4 +1,5 @@
 require 'nokogiri'
+require 'hybrid_platforms_conductor/test_only_remote_node'
 
 module HybridPlatformsConductor
 
@@ -17,7 +18,7 @@ module HybridPlatformsConductor
       #     Each final OVAL URL can be directly an XML file, either raw or compressed with .gz or .bz2.
       #     This is useful to follow repository links, such as jFrog or web servers serving common file systems structure storing several versions of the OVAL file.
       # * *reported_severities* (Array<String> or nil): List of severities to report, if any (use Unknown when the severity is not known), or nil for all [default: nil]
-      class Vulnerabilities < HybridPlatformsConductor::Test
+      class Vulnerabilities < TestOnlyRemoteNode
 
         # Known compression methods, per file extension, and their corresponding uncompress bash script
         KNOWN_COMPRESSIONS = {

data/lib/hybrid_platforms_conductor/test_only_remote_node.rb

@@ -0,0 +1,18 @@
+module HybridPlatformsConductor
+
+  # Ancestor for all tests that should be run just on remote nodes
+  class TestOnlyRemoteNode < Test
+
+    # Limit the list of nodes for these tests.
+    #
+    # Result::
+    # * Array<String or Regex> or nil: List of nodes allowed for this test, or nil for all. Regular expressions matching node names can also be used.
+    def self.only_on_nodes
+      # Just 1 node per service and platform
+      Test.nodes_handler.prefetch_metadata_of Test.nodes_handler.known_nodes, :local_node
+      Test.nodes_handler.known_nodes.select { |node| !Test.nodes_handler.get_local_node_of(node) }
+    end
+
+  end
+
+end

data/lib/hybrid_platforms_conductor/version.rb

@@ -1,5 +1,5 @@
 module HybridPlatformsConductor
 
-  VERSION = '32.16.1'
+  VERSION = '32.17.1'
 
 end

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/ssh/connections_spec.rb

@@ -29,7 +29,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'creates an SSH master to 1 node not having Session Exec capabilities' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42', ssh_session_exec: 'false' } } }) do
+        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42', ssh_session_exec: false } } }) do
           with_cmd_runner_mocked(
             [
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
@@ -45,7 +45,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       end
 
       it 'can\'t create an SSH master to 1 node not having Session Exec capabilities when hpc_interactive is false' do
-        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42', ssh_session_exec: 'false' } } }) do
+        with_test_platform(nodes: { 'node' => { meta: { host_ip: '192.168.42.42', ssh_session_exec: false } } }) do
           ENV['hpc_interactive'] = 'false'
           with_cmd_runner_mocked(
             [
@@ -69,7 +69,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       it 'fails without creating exception when creating an SSH master to 1 node not having Session Exec capabilities when hpc_interactive is false and we use no_exception' do
         with_test_platform(nodes: {
           'node1' => { meta: { host_ip: '192.168.42.1' } },
-          'node2' => { meta: { host_ip: '192.168.42.2', ssh_session_exec: 'false' } },
+          'node2' => { meta: { host_ip: '192.168.42.2', ssh_session_exec: false } },
           'node3' => { meta: { host_ip: '192.168.42.3' } }
         }) do
           ENV['hpc_interactive'] = 'false'

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioner_spec.rb

@@ -54,8 +54,8 @@ describe HybridPlatformsConductor::Deployer do
       with_test_platform(
         {
           nodes: {
-            'node1' => { meta: { host_ip: '192.168.42.1', ssh_session_exec: 'false' } },
-            'node2' => { meta: { host_ip: '192.168.42.2', ssh_session_exec: 'false' } }
+            'node1' => { meta: { host_ip: '192.168.42.1', ssh_session_exec: false } },
+            'node2' => { meta: { host_ip: '192.168.42.2', ssh_session_exec: false } }
           }
         },
         false,
@@ -75,8 +75,8 @@ describe HybridPlatformsConductor::Deployer do
           block.call
         end
         test_deployer.with_test_provisioned_instance(:test_provisioner, 'node1', environment: 'hpc_testing_provisioner') do |sub_test_deployer, test_instance|
-          expect(sub_test_deployer.instance_eval { @nodes_handler.get_ssh_session_exec_of('node1') }).to eq 'true'
-          expect(sub_test_deployer.instance_eval { @nodes_handler.get_ssh_session_exec_of('node2') }).to eq 'false'
+          expect(sub_test_deployer.instance_eval { @nodes_handler.get_ssh_session_exec_of('node1') }).to eq true
+          expect(sub_test_deployer.instance_eval { @nodes_handler.get_ssh_session_exec_of('node2') }).to eq false
           ssh_transforms = test_instance.instance_eval { @config.ssh_connection_transforms }
           expect(ssh_transforms.size).to eq 1
           expect(ssh_transforms[0][:nodes_selectors_stack]).to eq [%w[node2]]

data/spec/hybrid_platforms_conductor_test/api/platform_handlers/serverless_chef/packaging_spec.rb

@@ -26,7 +26,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
         if install
           [
             [
-              "cd #{repository} && /opt/chef-workstation/bin/chef install #{policy_file}",
+              "cd #{repository} && /opt/chef-workstation/bin/chef install #{policy_file} --chef-license accept",
               proc do
                 # Mock the run_list stored in the lock file
                 File.write(
@@ -44,8 +44,9 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
         end +
         if export
           [
+            ['whoami', proc { [0, 'test_user', ''] }, { optional: true }],
             [
-              /^cd #{Regexp.escape(repository)} &&\s+sudo rm -rf dist\/#{Regexp.escape(env)}\/#{Regexp.escape(policy)} &&\s+\/opt\/chef-workstation\/bin\/chef export #{Regexp.escape(policy_file)} dist\/#{Regexp.escape(env)}\/#{Regexp.escape(policy)}#{data_bags ? " && cp -ar data_bags/ dist/#{Regexp.escape(env)}/#{Regexp.escape(policy)}/" : ''}$/,
+              /^cd #{Regexp.escape(repository)} &&\s+sudo rm -rf dist\/#{Regexp.escape(env)}\/#{Regexp.escape(policy)} &&\s+\/opt\/chef-workstation\/bin\/chef export #{Regexp.escape(policy_file)} dist\/#{Regexp.escape(env)}\/#{Regexp.escape(policy)} --chef-license accept#{data_bags ? " && cp -ar data_bags/ dist/#{Regexp.escape(env)}/#{Regexp.escape(policy)}/" : ''}$/,
               proc do
                 FileUtils.mkdir_p "#{repository}/dist/#{env}/#{policy}"
                 FileUtils.cp_r("#{repository}/data_bags", "#{repository}/dist/#{env}/#{policy}/") if data_bags

data/spec/hybrid_platforms_conductor_test/api/tests_runner/test_plugins/github_ci_spec.rb

@@ -0,0 +1,72 @@
+describe HybridPlatformsConductor::TestsRunner do
+
+  context 'checking test plugins' do
+
+    context 'checking github_ci' do
+
+      it 'iterates over defined Github repos' do
+        with_repository do |repository|
+          platforms = <<~EOS
+            github_repos(
+              url: 'https://my_gh.my_domain.com',
+              user: 'GH-User1',
+              repos: [
+                'repo1',
+                'repo2'
+              ]
+            )
+            github_repos(
+              user: 'GH-User2',
+              repos: [
+                'repo3',
+                'repo4'
+              ]
+            )
+          EOS
+          with_platforms platforms do
+            repos = []
+            test_config.for_each_github_repo do |github, repo_info|
+              repos << {
+                github_url: github.api_endpoint,
+                repo_info: repo_info
+              }
+            end
+            expect(repos).to eq [
+              {
+                github_url: 'https://my_gh.my_domain.com/',
+                repo_info: {
+                  name: 'repo1',
+                  slug: 'GH-User1/repo1'
+                }
+              },
+              {
+                github_url: 'https://my_gh.my_domain.com/',
+                repo_info: {
+                  name: 'repo2',
+                  slug: 'GH-User1/repo2'
+                }
+              },
+              {
+                github_url: 'https://api.github.com/',
+                repo_info: {
+                  name: 'repo3',
+                  slug: 'GH-User2/repo3'
+                }
+              },
+              {
+                github_url: 'https://api.github.com/',
+                repo_info: {
+                  name: 'repo4',
+                  slug: 'GH-User2/repo4'
+                }
+              }
+            ]
+          end
+        end
+      end
+
+    end
+
+  end
+
+end

data/spec/hybrid_platforms_conductor_test/helpers/connector_ssh_helpers.rb

@@ -136,7 +136,7 @@ module HybridPlatformsConductorTest
         session_exec: true
       )
         with_test_platform(
-          { nodes: { 'node' => { meta: { host_ip: '192.168.42.42', ssh_session_exec: session_exec ? 'true' : 'false' } } } },
+          { nodes: { 'node' => { meta: { host_ip: '192.168.42.42', ssh_session_exec: session_exec } } } },
           false,
           additional_config
         ) do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hybrid_platforms_conductor
 version: !ruby/object:Gem::Version
-  version: 32.16.1
+  version: 32.17.1
 platform: ruby
 authors:
 - Muriel Salvan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-06-01 00:00:00.000000000 Z
+date: 2021-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: range_operators
@@ -248,6 +248,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.16'
+- !ruby/object:Gem::Dependency
+  name: octokit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.21'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.21'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -345,6 +359,7 @@ extra_rdoc_files:
 - docs/plugins/provisioner/docker.md
 - docs/plugins/test/spectre.md
 - docs/plugins/test/bitbucket_conf.md
+- docs/plugins/test/github_ci.md
 - docs/plugins/test/vulnerabilities.md
 - docs/plugins/test/deploy_removes_root_access.md
 - docs/plugins/test/private_ips.md
@@ -538,6 +553,7 @@ files:
 - docs/plugins/test/executables.md
 - docs/plugins/test/file_system.md
 - docs/plugins/test/file_system_hdfs.md
+- docs/plugins/test/github_ci.md
 - docs/plugins/test/hostname.md
 - docs/plugins/test/idempotence.md
 - docs/plugins/test/ip.md
@@ -640,6 +656,7 @@ files:
 - lib/hybrid_platforms_conductor/common_config_dsl/bitbucket.rb
 - lib/hybrid_platforms_conductor/common_config_dsl/confluence.rb
 - lib/hybrid_platforms_conductor/common_config_dsl/file_system_tests.rb
+- lib/hybrid_platforms_conductor/common_config_dsl/github.rb
 - lib/hybrid_platforms_conductor/common_config_dsl/idempotence_tests.rb
 - lib/hybrid_platforms_conductor/config.rb
 - lib/hybrid_platforms_conductor/confluence.rb
@@ -690,6 +707,7 @@ files:
 - lib/hybrid_platforms_conductor/hpc_plugins/test/executables.rb
 - lib/hybrid_platforms_conductor/hpc_plugins/test/file_system.rb
 - lib/hybrid_platforms_conductor/hpc_plugins/test/file_system_hdfs.rb
+- lib/hybrid_platforms_conductor/hpc_plugins/test/github_ci.rb
 - lib/hybrid_platforms_conductor/hpc_plugins/test/hostname.rb
 - lib/hybrid_platforms_conductor/hpc_plugins/test/idempotence.rb
 - lib/hybrid_platforms_conductor/hpc_plugins/test/ip.rb
@@ -729,6 +747,7 @@ files:
 - lib/hybrid_platforms_conductor/services_handler.rb
 - lib/hybrid_platforms_conductor/test.rb
 - lib/hybrid_platforms_conductor/test_by_service.rb
+- lib/hybrid_platforms_conductor/test_only_remote_node.rb
 - lib/hybrid_platforms_conductor/test_report.rb
 - lib/hybrid_platforms_conductor/tests_runner.rb
 - lib/hybrid_platforms_conductor/thycotic.rb
@@ -819,6 +838,7 @@ files:
 - spec/hybrid_platforms_conductor_test/api/tests_runner/platform_spec.rb
 - spec/hybrid_platforms_conductor_test/api/tests_runner/reports_spec.rb
 - spec/hybrid_platforms_conductor_test/api/tests_runner/test_plugins/bitbucket_conf_spec.rb
+- spec/hybrid_platforms_conductor_test/api/tests_runner/test_plugins/github_ci_spec.rb
 - spec/hybrid_platforms_conductor_test/api/tests_runner/test_reports_plugins/confluence_spec.rb
 - spec/hybrid_platforms_conductor_test/cmdb_plugins/test_cmdb.rb
 - spec/hybrid_platforms_conductor_test/cmdb_plugins/test_cmdb2.rb