hungarian_algorithm_c 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a54ee73466778776258aa0601cd5a7f8c0ff8ae6
-  data.tar.gz: 66cfd028102d917ef159e45fda5836a9128d4dfa
+  metadata.gz: daf9bc75e8c20f1067c5bdc4aee13b650d96b90c
+  data.tar.gz: 2283bba92d3a9c8d96e006fde88ead8ae363e798
 SHA512:
-  metadata.gz: cd8765887857a796dcedbf341058dd9630028762b37bafd3d5c16a3b3e0cf9edb605c1d3ee80374ef8971ec00c7c4df2fca70cc1a2cc7abf98a5020efa1d1381
-  data.tar.gz: fed0e9c37a870840477081d59beb4871cc0cb921decdc9bc025c7f92c3ccf530a00e8039adb894278e6d87e6764b9db12b97910626eea7e7e187dfb202dbadb1
+  metadata.gz: 9ddc4a8d3a594d644e50b1f6ca82d0baa692ea88f0c4ab034f4c1efb97e5de280e1830faf442a4b77c71806a31ec9c89bac2e00a15f88d1319b7b58ec59871da
+  data.tar.gz: 72176924f4375d2dc5e63d562a89befeb0aa6f4d4ec30a60f27b40ba6dca40cc1582dac2a4bdc8b424b1d7c0542af3d22ba01275959a2d00a60f5b2d412c9cdc

data/README.md

@@ -44,6 +44,8 @@ HungarianAlgorithmC.find_pairings(costs)
 #=> [[0, 0], [1, 2], [2, 1]]
 ```
 
+**Note**: Your cost matrix should not have `Float::INFINITY` or _very very large_ numbers as those will not be interpreted appropriately [here](ext/hungarian_algorithm_c/hungarian_algorithm_c.c#L56).
+
 ## Acknowledgements
 
 The C code uses the implementation by [Cyrill Stachniss](ext/hungarian_algorithm_c/libhungarian).

data/ext/hungarian_algorithm_c/hungarian_algorithm_c.c

@@ -53,7 +53,7 @@ VALUE pairs(VALUE self, VALUE flattened_array_ruby, VALUE row_size_val) {
 
   int index;
   for (index = 0; index < array_size; index++) {
-    long double element = 100 * NUM2DBL(rb_ary_entry(flattened_array_ruby, index));
+    long double element = NUM2DBL(rb_ary_entry(flattened_array_ruby, index));
     long long int rounded_element = element;
     array_c[index] = rounded_element;
   }

data/lib/hungarian_algorithm_c/version.rb

@@ -1,3 +1,3 @@
 module HungarianAlgorithmC
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/spec/hungarian_algorithm_c_spec.rb

@@ -25,6 +25,17 @@ RSpec.describe HungarianAlgorithmC do
           [0, 0]
         ])
       end
+
+      context 'matrix contains Floa::INFINITY' do
+        let(:matrix_with_costs) { [
+          [4, 3],
+          [3, Float::INFINITY]
+        ] }
+
+        it 'should not crash' do
+          should be_a Array
+        end
+      end
     end
 
     context '3x3 array' do
@@ -41,22 +52,6 @@ RSpec.describe HungarianAlgorithmC do
           [2, 1]
         ])
       end
-
-      context 'with very large numbers' do
-        let(:matrix_with_costs) { [
-          [4, 1, 7],
-          [Float::INFINITY, 3, 9],
-          [1, 2, 13]
-        ] }
-
-        it 'should output minimum cost pairs' do
-          should match_array([
-            [0, 2],
-            [1, 0],
-            [2, 1]
-          ])
-        end
-      end
     end
 
     context '4x4 array' do
@@ -76,12 +71,12 @@ RSpec.describe HungarianAlgorithmC do
         ])
       end
 
-      context 'with very large numbers' do
+      context 'with large numbers' do
         let(:matrix_with_costs) { [
-          [Float::INFINITY, 3, 10000000000000000000000000000000000, 3],
-          [10, 2, Float::INFINITY, 6],
-          [10, 3, 34, Float::INFINITY],
-          [99999999999999999999999, 13, 15, 6000000000000000]
+          [1_000_000, 2_000_000, 3, 3_000_000],
+          [9_000_000, 1, 4_000_000, 5_000_000],
+          [2_000_000, 1_000_000, 1_000_000, 4],
+          [1, 8_000_000, 3_000_000, 44]
         ] }
 
         it 'should output minimum cost pairs' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hungarian_algorithm_c
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Syed Humza Shah
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-04 00:00:00.000000000 Z
+date: 2017-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler