humid 0.0.5 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a783b726d5542a0abfc94fc1918aad0212c13ac7b6db8b8efd90c5452a222b2e
-  data.tar.gz: b9c3719ace7b00d210c992b48f9c4ee02010e81d19c30aa47e8bf6fdd9e9373b
+  metadata.gz: 6c4f5090d85ea4b1c4998f6c8533816a8875039f2ffe5b5785e3e571092445c6
+  data.tar.gz: 844410054db5d2c89fa3fc1fd3ac4d64f83605cf4a157573ebd6d172b01d0a7f
 SHA512:
-  metadata.gz: d29027f962022c6f8d5aeaf09c11730d572a32f8936e025fc04c3490921ac51468f6567e99f29aeb090a344150fa5edce2bbe14e83c18bfe9afc62e89fb34a87
-  data.tar.gz: 9ceb09c4bebef88f71f3b9c229c9317526a1d5cd5100dce4a270aad383334401a14baa7e108417170c5c3cad122523e9539733404d4c9a3cdf6f7bb8c2ec5dbf
+  metadata.gz: 574e6c64e749180f964a3d9ffe4dd91f18179408901b4b26960b2ef3c9bbe12c601e0879fc97bb60b340ed0270be627aaf0cc92d18827deda5f45dd515d952c4
+  data.tar.gz: b1511fc86f5655ac063bf6d927866bd00096c7ddca23e822e2cd3dbe03a97d1e4f62288f1242c9b436e67695402c2a61a59e4f096a0dc0f3dbf450ac0fbdc250

data/README.md

@@ -1,11 +1,10 @@
 # Humid
-[![Build
-Status](https://circleci.com/gh/thoughtbot/humid.svg?style=shield)](https://circleci.com/gh/thoughtbot/humid)
 
-Humid is a lightweight wrapper around [mini_racer] and [webpacker] used to
-generate Server Side Rendered (SSR) pages from your javascript application.
-While it was built for React, it can work with any JS function that returns a
-HTML string.
+![Build Status](https://github.com/thoughtbot/humid/actions/workflows/build.yml/badge.svg?branch=main)
+
+Humid is a lightweight wrapper around [mini_racer] used to generate Server
+Side Rendered (SSR) pages from your js-bundling builds. While it was built
+for React, it can work with any JS function that returns a HTML string.
 
 ## Caution
 
@@ -34,16 +33,16 @@ Add an initializer to configure
 
 ```ruby
 Humid.configure do |config|
-  # Name of your webpacker pack file located in `app/javascript/packs/`. You
-  # should use a separate pack from your `application.js`.
+  # Path to your build file located in `app/assets/builds/`. You should use a
+  # separate build apart from your `application.js`.
   #
-  # Defaults to "server_rendering.js"
-  config.server_rendering_pack = "server_rendering.js"
+  # Required
+  config.application_path = Rails.root.join('app', 'assets', 'builds', 'server_rendering.js')
 
-  # Name of your webpacker pack source map.
+  # Path to your source map file
   #
-  # Defaults to `false`
-  config.use_source_map = true
+  # Optional
+  config.source_map_path = Rails.root.join('app', 'assets', 'builds', 'server_rendering.js.map')
 
   # Raise errors if JS rendering failed. If false, the error will be
   # logged out to Rails log and Humid.render will return an empty string
@@ -55,8 +54,8 @@ Humid.configure do |config|
   # `console.log` and friends (`warn`, `error`) are delegated to
   # the respective logger levels on the ruby side.
   #
-  # Defaults to `Logger.new(STDOUT)`
-  config.logger = Rails.logger
+  # Defaults to `nil`
+  config.logger = Rails.env.development? ? Rails.logger : nil
 
   # Options passed to mini_racer.
   #
@@ -67,19 +66,32 @@ Humid.configure do |config|
   }
 end
 
-# Common development options
-if Rails.env.development? || Rails.env.test?
+# Capybara defines its own puma config which is set up to run a single puma process
+# with a thread pool. This ensures that a context gets created on that process.
+if Rails.env.test?
   # Use single_threaded mode for Spring and other forked envs.
   MiniRacer::Platform.set_flags! :single_threaded
+  Humid.create_context
+end
+```
 
-  # If you're using Puma in single mode:
+Then add to your `config/puma.rb`
+
+```
+workers ENV.fetch("WEB_CONCURRENCY") { 1 }
+
+on_worker_boot do
   Humid.create_context
 end
+
+on_worker_shutdown do
+  Humid.dispose
+end
 ```
 
 If you'd like support for source map support, you will need to
-1. Ensure `config.use_source_map` is set to `true`
-2. Add the following to your `server_rendering.js` pack.
+1. Add the following to your entry file, e.g, `server_rendering.js`.
+2. set `config.source_map_path`.
 
 ```javascript
 require("source-map-support").install({
@@ -91,6 +103,7 @@ require("source-map-support").install({
   }
 });
 ```
+A [sample] webpack.config is available for reference.
 
 ## The mini_racer environment.
 
@@ -112,7 +125,8 @@ respective methods on the configured logger.
 
 ## Usage
 
-Pass your HTML render function to `setHumidRenderer`
+In your entry file, e.g, `server_rendering.js`, pass your HTML render function
+to `setHumidRenderer`. There is no need to require the function.
 
 ```javascript
 // Set a factory function that will create a new instance of our app
@@ -129,7 +143,7 @@ setHumidRenderer((json) => {
 And finally call `render` from ERB.
 
 ```ruby
-<%= Humid.render(initial_state) %>
+<%= Humid.render(initial_state).html_safe %>
 ```
 
 Instrumentation is included:
@@ -141,7 +155,8 @@ Completed 200 OK in 14ms (Views: 0.2ms | Humid SSR: 11.0ms | ActiveRecord: 2.7ms
 ### Puma
 
 `mini_racer` is thread safe, but not fork safe. To use with web servers that
-employ forking, use `Humid.create_context` only on forked processes.
+employ forking, use `Humid.create_context` only on forked processes. On
+production, There should be no context created on the master process.
 
 ```ruby
 # Puma
@@ -156,41 +171,20 @@ end
 
 ### Server-side libraries that detect node.js envs.
 You may need webpacker to create aliases for server friendly libraries that can
-not detect the `mini_racer` environment.
+not detect the `mini_racer` environment. For example, in `webpack.config.js`.
 
 ```diff
- // config/webpack/production.js
- // config/webpack/development.js
- // config/webpack/test.js
-
- process.env.NODE_ENV = process.env.NODE_ENV || 'development'
-
- const environment = require('./environment')
-+const path = require('path')
-+const ConfigObject = require('@rails/webpacker/package/config_types/config
-
--module.exports = environment.toWebpackConfig()
-+const webConfig = environment.toWebpackConfig()
-+const ssrConfig = new ConfigObject(webConfig.toObject())
-+
-+ssrConfig.delete('entry')
-+ssrConfig.merge({
-+  entry: {
-+    server_rendering: webConfig.entry.server_rendering
-+  },
-+  resolve: {
-+    alias: {
-+      'html-dom-parser': path.resolve(__dirname, '../../node_modules/html-dom-parser/lib/html-to-dom-server')
-+    }
-+  }
-+})
-+
-+delete webConfig.entry.server_rendering
-+module.exports = [ssrConfig, webConfig]
+...
+  resolve: {
+    alias: {
+      'html-dom-parser': path.resolve(__dirname, '../../node_modules/html-dom-parser/lib/html-to-dom-server')
+    }
+  }
+...
 ```
 
 ## Writing universal code
-[Vue has an amazing resource][vue_ssr] on how to write universal code. Below
+[Vue has a resource][vue_ssr] on how to write universal code. Below
 are a few highlights that are important to keep in mind.
 
 ### State
@@ -202,19 +196,17 @@ every call.
 This provides better isolation, but as it is still a shared context, polluting
 `global` is still possible. Be careful of modifying `global` in your code.
 
-### Polyfills
+### Missing browser APIs
 
-Polyfills will fail when using in the `mini_racer` environment because of missing
-browser APIs. Account for this by moving the `require` to `componentDidMount`
-in your component.
+Polyfills and some libraries that depend on browser APIs will fail in the
+`mini_racer` environment because of missing browser APIs. Account for this by
+moving the `require` to `useEffect` in your component.
 
 ```
-componentDidMount() {
-  const dialogPolyfill = require('dialog-polyfill').default
-  dialogPolyfill.registerDialog(this.dialog.current)
-  this.dialog.current.open = this.props.open
-  this.dialog.current.showModal()
-}
+  useEffect(() => {
+    const svgPanZoom = require('svg-pan-zoom')
+    //...
+  }, [])
 ```
 
 ## Contributing
@@ -223,23 +215,28 @@ Please see [CONTRIBUTING.md](/CONTRIBUTING.md).
 
 ## License
 
-Humid is Copyright © 2021-2021 Johny Ho.
+Humid is Copyright © 2021-2024 Johny Ho.
 It is free software, and may be redistributed under the terms specified in the
 [LICENSE](/LICENSE.md) file.
 
+<!-- START /templates/footer.md -->
 ## About thoughtbot
 
-![thoughtbot](https://thoughtbot.com/brand_assets/93:44.svg)
+![thoughtbot](https://thoughtbot.com/thoughtbot-logo-for-readmes.svg)
 
-Humid is maintained and funded by thoughtbot, inc.
+This repo is maintained and funded by thoughtbot, inc.
 The names and logos for thoughtbot are trademarks of thoughtbot, inc.
 
 We love open source software!
-See [our other projects][community] or
-[hire us][hire] to design, develop, and grow your product.
+See [our other projects][community].
+We are [available for hire][hire].
 
 [community]: https://thoughtbot.com/community?utm_source=github
-[hire]: https://thoughtbot.com?utm_source=github
+[hire]: https://thoughtbot.com/hire-us?utm_source=github
+
+
+<!-- END /templates/footer.md -->
+
 [mini_racer]: https://github.com/rubyjs/mini_racer
-[webpacker]: https://github.com/rails/webpacker
 [vue_ssr]: https://ssr.vuejs.org/
+[sample]: ./webpack.config.js

data/lib/humid/controller_runtime.rb

@@ -1,4 +1,4 @@
-module Humid
+class Humid
   module ControllerRuntime
     extend ActiveSupport::Concern
 

data/lib/humid/log_subscriber.rb

@@ -1,4 +1,4 @@
-module Humid
+class Humid
   class LogSubscriber < ActiveSupport::LogSubscriber
     thread_cattr_accessor :humid_runtime
 

data/lib/humid/version.rb

@@ -1,3 +1,3 @@
-module Humid
-  VERSION = "0.0.5".freeze
+class Humid
+  VERSION = "0.1.0".freeze
 end

data/lib/humid.rb

@@ -1,144 +1,109 @@
 require "mini_racer"
 require "logger"
-require "webpacker"
 require "active_support"
 require "active_support/core_ext"
 require "humid/log_subscriber"
 require "humid/controller_runtime"
 require "humid/version"
 
-module Humid
-  extend self
-  include ActiveSupport::Configurable
+class Humid
+  @@context = nil
 
   class RenderError < StandardError
   end
 
   class FileNotFound < StandardError
   end
+  
+  class_attribute :config
 
-  @@context = nil
-
-  config_accessor :server_rendering_pack do
-    "server_rendering.js"
-  end
-
-  config_accessor :use_source_map do
-    false
-  end
-
-  config_accessor :raise_render_errors do
-    true
-  end
-
-  config_accessor :logger do
-    Logger.new(STDOUT)
-  end
-
-  config_accessor :context_options do
-    {}
-  end
-
-  def remove_functions
-    <<~JS
-      delete this.setTimeout;
-      delete this.setInterval;
-      delete this.clearTimeout;
-      delete this.clearInterval;
-      delete this.setImmediate;
-      delete this.clearImmediate;
-    JS
-  end
-
-  def logger
-    config.logger
-  end
-
-  def renderer
-    <<~JS
-      var __renderer;
-      function setHumidRenderer(fn) {
-        __renderer = fn;
-      }
-    JS
-  end
+  self.config = ActiveSupport::OrderedOptions.new.merge({
+    raise_render_errors: true,
+    context_options: {},
+  })
 
-  def handle_stale_files
-    if Webpacker.compiler.stale?
-      Webpacker.compiler.compile
+  class << self
+    def configure
+      yield config
     end
 
-    public_path = Webpacker.config.public_path
-    server_rendering_pack = config.server_rendering_pack
-    source_path = public_path.join(Webpacker.manifest.lookup(server_rendering_pack)[1..-1])
-    filename = File.basename(source_path.to_s)
+    def remove_functions
+      <<~JS
+        delete this.setTimeout;
+        delete this.setInterval;
+        delete this.clearTimeout;
+        delete this.clearInterval;
+        delete this.setImmediate;
+        delete this.clearImmediate;
+      JS
+    end
 
-    if @@current_filename != filename
-      dispose
-      create_context
+    def logger
+      config.logger
     end
-  end
 
-  def context
-    if @@context && Webpacker.env.development?
-      handle_stale_files
+    def renderer
+      <<~JS
+        var __renderer;
+        function setHumidRenderer(fn) {
+          __renderer = fn;
+        }
+      JS
     end
 
-    @@context
-  end
+    def context
+      @@context
+    end
 
-  def dispose
-    if @@context
-      @@context.dispose
-      @@context = nil
+    def dispose
+      if @@context
+        @@context.dispose
+        @@context = nil
+      end
     end
-  end
 
-  def create_context
-    ctx = MiniRacer::Context.new(config.context_options)
-    ctx.attach("console.log", proc { |err| logger.debug(err.to_s) })
-    ctx.attach("console.info", proc { |err| logger.info(err.to_s) })
-    ctx.attach("console.error", proc { |err| logger.error(err.to_s) })
-    ctx.attach("console.warn", proc { |err| logger.warn(err.to_s) })
+    def create_context
+      ctx = MiniRacer::Context.new(**config.context_options)
 
-    js = ""
-    js << remove_functions
-    js << renderer
-    ctx.eval(js)
+      if logger
+        ctx.attach("console.log", proc { |err| logger.debug(err.to_s) })
+        ctx.attach("console.info", proc { |err| logger.info(err.to_s) })
+        ctx.attach("console.error", proc { |err| logger.error(err.to_s) })
+        ctx.attach("console.warn", proc { |err| logger.warn(err.to_s) })
+      end
 
-    public_path = Webpacker.config.public_path
+      js = ""
+      js << remove_functions
+      js << renderer
+      ctx.eval(js)
 
-    webpack_source_file = Webpacker.manifest.lookup(config.server_rendering_pack)
-    if webpack_source_file.nil?
-      raise FileNotFound.new("Humid could not find a built pack for #{config.server_rendering_pack}")
-    end
+      source_path = config.application_path
+      map_path = config.source_map_path
 
-    if config.use_source_map
-      webpack_source_map = Webpacker.manifest.lookup("#{config.server_rendering_pack}.map")
-      map_path = public_path.join(webpack_source_map[1..-1])
-      ctx.attach("readSourceMap", proc { File.read(map_path) })
-    end
+      if map_path
+        ctx.attach("readSourceMap", proc { File.read(map_path) })
+      end
 
-    source_path = public_path.join(webpack_source_file[1..-1])
-    filename = File.basename(source_path.to_s)
-    @@current_filename = filename
-    ctx.eval(File.read(source_path), filename: filename)
+      filename = File.basename(source_path.to_s)
+      @@current_filename = filename
+      ctx.eval(File.read(source_path), filename: filename)
 
-    @@context = ctx
-  end
+      @@context = ctx
+    end
 
-  def render(*args)
-    ActiveSupport::Notifications.instrument("render.humid") do
-      context.call("__renderer", *args)
-    rescue MiniRacer::RuntimeError => e
-      message = ([e.message] + e.backtrace.filter {|x| x.starts_with? "JavaScript"}).join("\n")
-      render_error = Humid::RenderError.new(message)
-
-      if config.raise_render_errors
-        raise render_error
-      else
-        config.logger.error(render_error.inspect)
-        ""
+    def render(*args)
+      ActiveSupport::Notifications.instrument("render.humid") do
+        context.call("__renderer", *args)
+      rescue MiniRacer::RuntimeError => e
+        message = ([e.message] + e.backtrace.filter { |x| x.starts_with? "JavaScript" }).join("\n")
+        render_error = Humid::RenderError.new(message)
+
+        if config.raise_render_errors
+          raise render_error
+        else
+          config.logger.error(render_error.inspect)
+          ""
+        end
       end
     end
   end

metadata

@@ -1,29 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: humid
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.1.0
 platform: ruby
 authors:
 - Johny Ho
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-07-31 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: webpacker
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '4.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: mini_racer
   requirement: !ruby/object:Gem::Requirement
@@ -41,73 +26,17 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '6.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '6.0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '12.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.8'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.8'
-- !ruby/object:Gem::Dependency
-  name: byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '9.0'
-  type: :development
+        version: '8.0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '9.0'
-- !ruby/object:Gem::Dependency
-  name: rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '6.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '8.0'
 description: Javascript SSR rendering for Rails
 email: jho406@gmail.com
 executables: []
@@ -119,14 +48,10 @@ files:
 - lib/humid/controller_runtime.rb
 - lib/humid/log_subscriber.rb
 - lib/humid/version.rb
-- spec/controller_runtime_spec.rb
-- spec/log_subscriber_spec.rb
-- spec/render_spec.rb
 homepage: https://github.com/thoughtbot/humid/
 licenses:
 - MIT
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -141,11 +66,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Javascript SSR rendering for Rails
-test_files:
-- spec/render_spec.rb
-- spec/log_subscriber_spec.rb
-- spec/controller_runtime_spec.rb
+test_files: []

data/spec/controller_runtime_spec.rb

@@ -1,79 +0,0 @@
-require_relative "./support/helper"
-
-describe Humid::ControllerRuntime do
-  controller_runtime = Humid::ControllerRuntime
-
-  def set_metric value
-    Humid::LogSubscriber.runtime = value
-  end
-
-  def clear_metric!
-    Humid::LogSubscriber.reset_runtime = 0
-  end
-
-  reference_controller_class = Class.new {
-    def process_action *_
-      @process_action = true
-    end
-
-    def cleanup_view_runtime *_
-      @cleanup_view_runtime.call
-    end
-
-    def append_info_to_payload *_
-      @append_info_to_payload = true
-    end
-
-    def self.log_process_action *_
-      @log_process_action.call
-    end
-  }
-
-  controller_class = Class.new reference_controller_class do
-    include controller_runtime
-
-    def logger
-      Logger.new(STDOUT)
-    end
-  end
-
-  let(:controller) { controller_class.new }
-
-  it "resets the metric before each action" do
-    set_metric 42
-    controller.send(:process_action, "foo")
-    expect(Humid::LogSubscriber.runtime).to be(0)
-    expect(controller.instance_variable_get("@process_action")).to be(true)
-  end
-
-  it "strips the metric of other sources of the runtime" do
-    set_metric 1
-    controller.instance_variable_set "@cleanup_view_runtime", -> {
-      controller.instance_variable_set "@cleanup_view_runtime", true
-      set_metric 13
-      42
-    }
-    returned = controller.send :cleanup_view_runtime
-    expect(controller.instance_variable_get("@cleanup_view_runtime")).to be(true)
-    expect(controller.humid_runtime).to eq(14)
-    expect(returned).to be(29)
-  end
-
-  it "appends the metric to payload" do
-    payload = {}
-    set_metric 42
-    controller.send :append_info_to_payload, payload
-    expect(controller.instance_variable_get("@append_info_to_payload")).to be(true)
-    expect(payload[:humid_runtime]).to eq(42)
-  end
-
-  it "adds metric to log message" do
-    controller_class.instance_variable_set "@log_process_action", -> {
-      controller_class.instance_variable_set "@log_process_action", true
-      []
-    }
-    messages = controller_class.log_process_action humid_runtime: 42.101
-    expect(controller_class.instance_variable_get("@log_process_action")).to be(true)
-    expect(messages).to eq(["Humid SSR: 42.1ms"])
-  end
-end

data/spec/log_subscriber_spec.rb

@@ -1,54 +0,0 @@
-require_relative "./support/helper"
-require "active_support/log_subscriber/test_helper"
-require "byebug"
-
-RSpec.describe Humid::LogSubscriber do
-  around(:each) do |example|
-    app_path = File.expand_path("./testapp", File.dirname(__FILE__))
-    Dir.chdir(app_path) do
-      example.run
-    end
-  end
-
-  before(:each) do
-    Humid::LogSubscriber.reset_runtime
-  end
-
-  context ".runtime" do
-    it "is returns the runtime from the thread local" do
-      expect(Humid::LogSubscriber.runtime).to eql 0
-      key = "attr_Humid::LogSubscriber_humid_runtime"
-      Thread.current[key] = 3
-      expect(Humid::LogSubscriber.runtime).to eql 3
-    end
-  end
-
-  context ".runtime=" do
-    it "sets the runtime in a thread-safe manner" do
-      expect(Humid::LogSubscriber.runtime).to eql 0
-      Humid::LogSubscriber.runtime = 3
-      key = "attr_Humid::LogSubscriber_humid_runtime"
-      expect(Thread.current[key]).to eql 3
-    end
-  end
-
-  context ".reset_runtime" do
-    it "resets the runtime" do
-      Humid::LogSubscriber.runtime = 3
-      key = "attr_Humid::LogSubscriber_humid_runtime"
-      expect(Thread.current[key]).to eql 3
-
-      Humid::LogSubscriber.reset_runtime
-      expect(Thread.current[key]).to eql 0
-      expect(Humid::LogSubscriber.runtime).to eql 0
-    end
-  end
-
-  it "is attached" do
-    allow(Humid.config).to receive("server_rendering_pack") { "simple.js" }
-    Humid.create_context
-    expect(Humid::LogSubscriber.runtime).to eql(0)
-    Humid.render
-    expect(Humid::LogSubscriber.runtime).to be > 0
-  end
-end

data/spec/render_spec.rb

@@ -1,188 +0,0 @@
-require_relative "./support/helper"
-
-RSpec.describe "Humid" do
-  around(:each) do |example|
-    app_path = File.expand_path("./testapp", File.dirname(__FILE__))
-    Dir.chdir(app_path) do
-      example.run
-    end
-  end
-
-  describe "create_context" do
-    after(:each) do
-      Humid.dispose
-    end
-
-    it "creates a context with initial js" do
-      allow(Humid.config).to receive("server_rendering_pack") { "simple.js" }
-      Humid.create_context
-
-      expect(Humid.context).to be_kind_of(MiniRacer::Context)
-    end
-
-    context "When the file can not be found" do
-      it "raises" do
-        allow(Humid.config).to receive("server_rendering_pack") { "does_not_exist.js" }
-
-        expect {
-          Humid.create_context
-        }.to raise_error(Humid::FileNotFound, "Humid could not find a built pack for does_not_exist.js")
-      end
-    end
-
-    it "does not have timeouts, immediates, and intervals" do
-      allow(Humid.config).to receive("server_rendering_pack") { "simple.js" }
-
-      Humid.create_context
-
-      expect {
-        Humid.context.eval("setTimeout()")
-      }.to raise_error(MiniRacer::RuntimeError, "ReferenceError: setTimeout is not defined")
-      expect {
-        Humid.context.eval("setInterval()")
-      }.to raise_error(MiniRacer::RuntimeError, "ReferenceError: setInterval is not defined")
-      expect {
-        Humid.context.eval("clearTimeout()")
-      }.to raise_error(MiniRacer::RuntimeError, "ReferenceError: clearTimeout is not defined")
-      expect {
-        Humid.context.eval("setImmediate()")
-      }.to raise_error(MiniRacer::RuntimeError, "ReferenceError: setImmediate is not defined")
-      expect {
-        Humid.context.eval("clearImmediate()")
-      }.to raise_error(MiniRacer::RuntimeError, "ReferenceError: clearImmediate is not defined")
-    end
-
-    it "proxies to Rails logger" do
-      allow(Humid.config).to receive("server_rendering_pack") { "simple.js" }
-      Humid.create_context
-      expect(Humid.logger).to receive(:info).with("hello")
-
-      Humid.context.eval("console.info('hello')")
-    end
-  end
-
-  describe "context" do
-    it "returns the created context" do
-      allow(Humid.config).to receive("server_rendering_pack") { "simple.js" }
-
-      Humid.create_context
-
-      expect(Humid.context).to be_kind_of(MiniRacer::Context)
-    end
-
-    context "when the js is stale and env is NOT dev`" do
-      it "does not recompile the JS" do
-        allow(Webpacker).to receive_message_chain("env.development?") { false }
-        allow(Webpacker).to receive_message_chain("compiler.stale?") { true }
-        allow(Humid.config).to receive("server_rendering_pack") { "simple.js" }
-
-        Humid.create_context
-        prev_context = Humid.context
-        expect(prev_context).to be_kind_of(MiniRacer::Context)
-
-        allow(Webpacker).to receive_message_chain("compiler.stale?") { true }
-
-        next_context = Humid.context
-
-        expect(prev_context).to eql(next_context)
-        expect(next_context).to be_kind_of(MiniRacer::Context)
-      end
-    end
-
-    context "when the env is development" do
-      it "compiles the JS when stale" do
-        allow(Webpacker).to receive_message_chain("env.development?") { true }
-        allow(Webpacker).to receive_message_chain("compiler.stale?") { true }
-        allow(Webpacker).to receive_message_chain("compiler.compile")
-        allow(Humid.config).to receive("server_rendering_pack") { "simple.js" }
-
-        Humid.create_context
-        prev_context = Humid.context
-        expect(prev_context).to be_kind_of(MiniRacer::Context)
-
-        allow(Webpacker).to receive_message_chain("compiler.stale?") { true }
-        # This simulates a changing file
-        allow(Humid.config).to receive("server_rendering_pack") { "simple_changed.js" }
-
-        next_context = Humid.context
-
-        expect(prev_context).to_not eql(next_context)
-        expect(next_context).to be_kind_of(MiniRacer::Context)
-      end
-
-      it "creates a new context when webpack-devserver already handled JS staleness" do
-        allow(Webpacker).to receive_message_chain("env.development?") { true }
-        allow(Webpacker).to receive_message_chain("compiler.stale?") { true }
-        allow(Webpacker).to receive_message_chain("compiler.compile")
-        allow(Humid.config).to receive("server_rendering_pack") { "simple.js" }
-
-        Humid.create_context
-        prev_context = Humid.context
-        expect(Humid.render).to eql("hello")
-        expect(prev_context).to be_kind_of(MiniRacer::Context)
-
-        allow(Webpacker).to receive_message_chain("compiler.stale?") { false }
-        # This simulates a changing file
-        allow(Humid.config).to receive("server_rendering_pack") { "simple_changed.js" }
-
-        next_context = Humid.context
-
-        expect(prev_context).to_not eql(next_context)
-        expect(next_context).to be_kind_of(MiniRacer::Context)
-        expect(Humid.render).to eql("hello changed")
-      end
-    end
-  end
-
-  describe "render" do
-    it "returns a js output" do
-      allow(Humid.config).to receive("server_rendering_pack") { "simple.js" }
-      Humid.create_context
-
-      expect(Humid.render).to eql("hello")
-    end
-
-    it "applys args to the func" do
-      allow(Humid.config).to receive("server_rendering_pack") { "args.js" }
-      Humid.create_context
-
-      args = ["a", 1, 2, [], {}]
-
-      expect(Humid.render(*args)).to eql({"0" => "a", "1" => 1, "2" => 2, "3" => [], "4" => {}})
-    end
-
-    it "can use source maps to see errors" do
-      allow(Humid.config).to receive("server_rendering_pack") { "reporting.js" }
-      allow(Humid.config).to receive("use_source_map") { true }
-
-      Humid.create_context
-
-      expect {
-        Humid.render
-      }.to raise_error { |error|
-        expect(error).to be_a(Humid::RenderError)
-        message = <<~MSG
-          Error: ^^ Look! These stack traces map to the actual source code :)
-          JavaScript at throwSomeError (/webpack:/app/javascript/packs/components/error-causing-component.js:2:1)
-          JavaScript at ErrorCausingComponent (/webpack:/app/javascript/packs/components/error-causing-component.js:8:1)
-          JavaScript at /webpack:/app/javascript/packs/reporting.js:18:1
-        MSG
-
-        expect(error.message).to eql message.strip
-      }
-    end
-
-    it "siliences render errors to the log" do
-      allow(Humid.config).to receive("server_rendering_pack") { "reporting.js" }
-      allow(Humid.config).to receive("raise_render_errors") { false }
-      allow(Humid.config).to receive("use_source_map") { true }
-
-      Humid.create_context
-
-      expect(Humid.logger).to receive(:error)
-      output = Humid.render
-
-      expect(output).to eql("")
-    end
-  end
-end