human_number 0.1.7 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3bc432b4b82fa70b18804f6db6080c10cf33c95e410c7ee9bb2335c99b053f8d
-  data.tar.gz: e2aa145ec5319d06c8ff98748ee8a696f6a0a999a571440931fc55e34681f78d
+  metadata.gz: b40f4d307a6d79e38dd1e45276c6df0334d28081dfb3cdddce89d943732e9aab
+  data.tar.gz: f25564f84991e593d68de48fd88b79e1ef64baaa473d962428b5008b61a25c93
 SHA512:
-  metadata.gz: 123d58896c01e0297e7dde721df49e8036e4ced81185b508aa34750cf6b869487449b454fa9149d6816a05284f058bdf8ec6bf674ae52fbee6487ac880b8af42
-  data.tar.gz: e58469487228d201d424006a2d9a75aec5e8c73dedc3a7580c3e0ed716b20600d07f1055ec2993668aa38f422237b353e6f24091ba4a789c36ee4924e1546d35
+  metadata.gz: 030e86e5855e634e6aafb8940834f58a290276a7c2096e1da12b44eb9bbd667803c1a2239822d091f69aa6fb1165c4eb4187268e0911ee6a78a407f80c1ba6c1
+  data.tar.gz: 612b2da8d6f9abbd5d06695701e5b2943879d4a8610885f717f2acfe28577fba1e082597a1dee03c07464e58e4996cf00a3c78e54b8def050cdfa1750a74395d

data/CHANGELOG.md

@@ -5,7 +5,31 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.1.0] - 2024-01-31
+## [0.1.9] - 2025-08-05
+
+### Changed
+- **East Asian separator formatting**: Japanese numbers now use culturally appropriate spacing
+  - Japanese: `'12億3456万7890円'` (no spaces between units)
+  - Korean/Chinese: `'12억 3456만 7890원'` (spaces maintained as default)
+- **Locale-based separator configuration**: Added `number.human.decimal_units.separator` for customizable unit separators
+
+## [0.1.8] - 2025-08-05
+
+### Fixed
+- **I18n fallback contamination**: Resolved currency symbol cross-contamination where Korean won symbols (원) appeared for other currencies like CAD due to I18n fallback behavior
+- **Translation missing errors**: Fixed missing translation errors for various currency/locale combinations
+- **Rails configuration warnings**: Eliminated Rails configuration warnings in test environment
+
+### Changed
+- **Currency native locale mappings**: Corrected CURRENCY_NATIVE_LOCALES to use only accurate locale associations (e.g., CAD now maps to en-CA/fr-CA only, not generic en/fr)
+- **Locale file organization**: Moved locale files from `config/locales/` to `lib/locales/` for better gem structure
+
+### Improved
+- **Rails-i18n integration**: Enhanced loading order and initialization to prevent locale conflicts
+- **Test infrastructure**: Updated RSpec mocks and test expectations for better reliability
+- **I18n isolation**: Added `fallback: false` parameter to prevent cross-locale pollution
+
+## [0.1.0] - 2025-07-31
 
 ### Added
 
@@ -86,4 +110,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - **Formatters::Currency**: Currency symbol and format string application
 - **Clean separation**: Number formatting independent of currency concerns
 
+[0.1.9]: https://github.com/ether-moon/human_number/releases/tag/v0.1.9
+[0.1.8]: https://github.com/ether-moon/human_number/releases/tag/v0.1.8
 [0.1.0]: https://github.com/ether-moon/human_number/releases/tag/v0.1.0

data/README.md

@@ -158,9 +158,14 @@ HumanNumber.human_number(1_000_000_000, locale: :en) #=> "1B"
 HumanNumber.human_number(1_234_567, locale: :ko) #=> "120만"  
 HumanNumber.human_number(1_234_567, locale: :ja) #=> "120万"
 HumanNumber.human_number(100_000_000, locale: :ko) #=> "1억"
+
+# Complete mode shows cultural spacing differences
+HumanNumber.human_number(12_345_678, locale: :ko, max_digits: nil) #=> "1234만 5678"  # Korean: spaces
+HumanNumber.human_number(12_345_678, locale: :ja, max_digits: nil) #=> "1234万5678"   # Japanese: no spaces
 ```
 
-**Units:** 만/万 (ten thousand), 억/億 (hundred million), 조/兆 (trillion)
+**Units:** 만/万 (ten thousand), 억/億 (hundred million), 조/兆 (trillion)  
+**Cultural spacing:** Japanese uses no spaces between units, Korean/Chinese use spaces (configurable via locale files)
 
 ### Indian System (lakh/crore)
 **Used by:** Hindi (hi), Urdu (ur), Bengali (bn), Indian English (en-IN)

data/lib/human_number/formatters/number.rb

@@ -419,6 +419,11 @@ module HumanNumber
         ].freeze
 
         class << self
+          def format_number(number, locale:, abbr_units: true, min_unit: nil, max_digits: 2, trim_zeros: true)
+            @current_locale = locale.to_sym
+            super
+          end
+
           private
 
           def unit_definitions
@@ -437,6 +442,18 @@ module HumanNumber
           def apply_symbol_formatting_rules(symbol, _abbr_units)
             symbol
           end
+
+          # Apply culturally appropriate separators for East Asian languages
+          def finalize_result(number, formatted_parts)
+            separator = lookup_decimal_separator(@current_locale)
+            combined_result = formatted_parts.join(separator)
+            number.negative? ? "-#{combined_result}" : combined_result
+          end
+
+          # Look up separator from locale file, default to space
+          def lookup_decimal_separator(locale)
+            I18n.t("#{I18N_DECIMAL_UNITS_KEY}.separator", locale: locale, default: SPACE_SEPARATOR)
+          end
         end
       end
 

data/lib/human_number/locale_support.rb

@@ -12,30 +12,30 @@ module HumanNumber
     CURRENCY_NATIVE_LOCALES = {
       "KRW" => [:ko],
       "JPY" => [:ja],
-      "USD" => [:en],
+      "USD" => %i[en en-US],
       "EUR" => %i[de fr es it nl],
-      "GBP" => %i[en en-GB],
-      "CAD" => %i[en en-CA fr fr-CA],
+      "GBP" => %i[en-GB],
+      "CAD" => %i[en-CA fr-CA],
       "CNY" => %i[zh zh-CN],
       "CHF" => %i[de fr it],
-      "INR" => %i[hi en],
+      "INR" => %i[hi en-IN],
       "RUB" => [:ru],
-      "BRL" => %i[pt pt-BR],
-      "MXN" => [:es],
-      "AUD" => %i[en en-AU],
-      "NZD" => %i[en en-NZ],
+      "BRL" => %i[pt-BR],
+      "MXN" => %i[es-MX],
+      "AUD" => %i[en-AU],
+      "NZD" => %i[en-NZ],
       "SEK" => [:sv],
       "NOK" => %i[no nb],
       "DKK" => [:da],
-      "SGD" => %i[en en-SG zh zh-SG],
-      "HKD" => %i[zh zh-HK en en-HK],
-      "ZAR" => %i[en en-ZA af],
+      "SGD" => %i[en-SG zh-SG],
+      "HKD" => %i[zh-HK en-HK],
+      "ZAR" => %i[en-ZA af],
       "TRY" => [:tr],
-      "ARS" => %i[es es-AR],
+      "ARS" => %i[es-AR],
       "IDR" => [:id],
       "THB" => [:th],
-      "MYR" => %i[ms en en-MY],
-      "PHP" => %i[en en-PH tl],
+      "MYR" => %i[ms en-MY],
+      "PHP" => %i[en-PH tl],
       "VND" => [:vi],
     }.freeze
 
@@ -44,18 +44,6 @@ module HumanNumber
 
     module_function
 
-    # Returns the primary locale for displaying a currency.
-    # If the user's locale matches a native locale for the currency, use it.
-    # Otherwise, use the first native locale for the currency.
-    #
-    # @param currency_code [String] ISO 4217 currency code (e.g., 'USD', 'EUR')
-    # @param user_locale [Symbol] User's preferred locale
-    # @return [Symbol] Primary locale for currency display
-    def primary_locale_for_currency(currency_code, user_locale)
-      locales = native_locales_for_currency(currency_code)
-      (locales.include?(user_locale.to_sym) ? user_locale.to_sym : locales.first) || :en
-    end
-
     # Returns the locale to use for currency precision rules in standard formatting.
     # Always returns the currency's primary native locale to ensure consistent
     # precision (e.g., USD always shows 2 decimals, JPY shows 0 decimals).
@@ -114,16 +102,23 @@ module HumanNumber
       return nil if native_locales_for_currency(currency_code).empty?
 
       # For native locales and supported keys, try native formatting first
-      if native_locale?(currency_code, locale) && SUPPORTED_NATIVE_CURRENCY_KEYS.include?(key)
-        native_key = native_currency_key(key)
-        return I18n.t(native_key, locale:) if I18n.exists?(native_key, locale)
+      # Additional validation: only currencies that actually have native symbols
+      if SUPPORTED_NATIVE_CURRENCY_KEYS.include?(key)
+        if native_locale?(currency_code, locale)
+          native_key = native_currency_key(key)
+          return I18n.t(native_key, locale:) if I18n.exists?(native_key, locale, fallback: false)
+        else
+          # For currency symbols (:unit) and format, use currency's native locale to ensure consistency
+          # (e.g., USD always shows "$1,234.56" format, regardless of display locale)
+          target_locale = native_locales_for_currency(currency_code).first || :en
+          standard_key = currency_key(key)
+          return I18n.t(standard_key, locale: target_locale, default: currency_code)
+        end
       end
 
-      # Fallback to standard currency formatting using currency's primary locale
-      currency_locale = primary_locale_for_currency(currency_code, locale)
+      # For other keys, use user's requested locale
       standard_key = currency_key(key)
-
-      I18n.t(standard_key, locale: currency_locale)
+      I18n.t(standard_key, locale:)
     end
   end
 end

data/lib/human_number/railtie.rb

@@ -16,8 +16,8 @@ module HumanNumber
       end
     end
 
-    initializer "human_number.load_locale_data" do
-      I18n.load_path += Dir[File.expand_path("../../config/locales/*.yml", __dir__)]
+    initializer "human_number.load_locale_data", after: "rails-i18n" do
+      I18n.load_path += Dir[File.expand_path("../locales/*.yml", __dir__)]
     end
   end
 end

data/lib/human_number/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module HumanNumber
-  VERSION = "0.1.7"
+  VERSION = "0.1.9"
 end

data/lib/human_number.rb

@@ -4,9 +4,6 @@ require "i18n"
 require "action_view"
 require "rails-i18n"
 
-# Ensure Rails I18n locales are available
-I18n.load_path += Dir[File.expand_path("**/*.yml", Gem.loaded_specs["rails-i18n"].full_gem_path)]
-
 require_relative "human_number/version"
 require_relative "human_number/locale_support"
 require_relative "human_number/formatters/number"
@@ -15,9 +12,6 @@ require_relative "human_number/formatters/currency"
 module HumanNumber
   class Error < StandardError; end
 
-  # Load locale files
-  I18n.load_path += Dir[File.expand_path("../config/locales/*.yml", __dir__)]
-
   extend ActionView::Helpers::NumberHelper
 
   class << self
@@ -213,4 +207,9 @@ module HumanNumber
   end
 end
 
+# Load locale files for all environments to ensure availability
+# locale_files = Dir[File.expand_path("locales/*.yml", __dir__)]
+# I18n.load_path += locale_files unless (I18n.load_path & locale_files).any?
+# I18n.backend.reload! if I18n.backend.respond_to?(:reload!)
+
 require_relative "human_number/railtie" if defined?(Rails::Railtie)

data/{config → lib}/locales/ja.yml

@@ -8,6 +8,7 @@ ja:
         unit: "¥"
     human:
       decimal_units:
+        separator: ""
         abbr_units:
           thousand: "千"
           ten_thousand: "万"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: human_number
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.9
 platform: ruby
 authors:
 - Ether Moon
@@ -77,20 +77,6 @@ files:
 - Makefile
 - README.md
 - Rakefile
-- config/locales/bn.yml
-- config/locales/de.yml
-- config/locales/en-GB.yml
-- config/locales/en-IN.yml
-- config/locales/en.yml
-- config/locales/es.yml
-- config/locales/fr.yml
-- config/locales/hi.yml
-- config/locales/ja.yml
-- config/locales/ko.yml
-- config/locales/ur.yml
-- config/locales/zh-CN.yml
-- config/locales/zh-TW.yml
-- config/locales/zh.yml
 - human_number.gemspec
 - lib/human_number.rb
 - lib/human_number/formatters/currency.rb
@@ -99,6 +85,20 @@ files:
 - lib/human_number/rails/helpers.rb
 - lib/human_number/railtie.rb
 - lib/human_number/version.rb
+- lib/locales/bn.yml
+- lib/locales/de.yml
+- lib/locales/en-GB.yml
+- lib/locales/en-IN.yml
+- lib/locales/en.yml
+- lib/locales/es.yml
+- lib/locales/fr.yml
+- lib/locales/hi.yml
+- lib/locales/ja.yml
+- lib/locales/ko.yml
+- lib/locales/ur.yml
+- lib/locales/zh-CN.yml
+- lib/locales/zh-TW.yml
+- lib/locales/zh.yml
 - scripts/build_and_publish.sh
 homepage: https://github.com/ether-moon/human_number
 licenses: