hubstep 1.0.2 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0efe830ada901d3c3898e361c861fe5e5c577e7d
-  data.tar.gz: f2e97b7fe95134a38fcd907f0e5685ee6cafe214
+  metadata.gz: a6cc1685cc178b797ff9f372fc95976ce9e71955
+  data.tar.gz: 6d0ee36b0061e338830a3216db25522ec32422e7
 SHA512:
-  metadata.gz: 365d9a8283621ae309e5e9937c1cc7fa4f72d915bb81dbe62ff0b0f1ad0277c0d28e1e5e8af7783dd22df83a9feb82bf4b3de85bc0ce5de40a0fb2d3d2886e9d
-  data.tar.gz: 748d1e752f58ac43ad81a477c571635f3e4615468bed8c322e2d7e4b45394e0a8dc6b7e0bcf4400d2b05bccba45dfc11d8f2aaf28d6b3283e01296b36e77d164
+  metadata.gz: a957015bb8f033702b83a843d234caa6c4b155e497cfaae7e5264bac6b2960953ae4538b54caf808630eb8a7721ff6221798c128a3016a51d56ef1c49bd4d722
+  data.tar.gz: d384d0b3ecf91fae640bc56984fa8405a2dc5df1e8bacf7fb85d739d1b308a53ee2ada32318cf29ada67739812c291c77529ffd0513e9981eb19348adc9b9827

data/hubstep.gemspec

@@ -31,5 +31,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rack-test", "~> 0.6"
   spec.add_development_dependency "activesupport", "~> 4.0"
   spec.add_development_dependency "faraday", "~> 0.10"
+  spec.add_development_dependency "failbot", "~> 2.0.0"
+  spec.add_development_dependency "webmock", "~> 2.3.1"
   spec.add_development_dependency "pry-byebug"
 end

data/lib/hubstep/failbot.rb

@@ -12,8 +12,9 @@ module LightStep
         class HTTPError < StandardError; end
 
         # There's no way to call through to the normal implementation while getting
-        # access to the response object, so we just copy all the code here.
-        def report(report) # rubocop:disable Metrics/AbcSize
+        # access to the request/response objects, so we just copy all the code
+        # here.
+        def report(report) # rubocop:disable Metrics/AbcSize,Metrics/MethodLength
           p report if @verbose >= 3
 
           https = Net::HTTP.new(@host, @port)
@@ -23,6 +24,9 @@ module LightStep
           req["Content-Type"] = "application/json"
           req["Connection"] = "keep-alive"
           req.body = report.to_json
+
+          ::Failbot.push(request_body: req.body)
+
           res = https.request(req)
 
           puts res.to_s, res.body if @verbose >= 3
@@ -32,6 +36,7 @@ module LightStep
           nil
         ensure
           ::Failbot.report!($ERROR_INFO) if $ERROR_INFO
+          ::Failbot.pop
         end
 
         def track_error(res)

data/lib/hubstep/rack/middleware.rb

@@ -24,10 +24,15 @@ module HubStep
       #             returns true, the tracer will be enabled for the duration
       #             of the request. If the Proc returns false, the tracer will
       #             be disabled for the duration of the request.
-      def initialize(app, tracer, enable_if)
+      # include_urls - Boolean specifying whether the `http.url` tag should be
+      #                added to the spans this middleware creates. URLs can
+      #                contain sensitive information, so they are omitted by
+      #                default.
+      def initialize(app, tracer:, enable_if:, include_urls: false)
         @app = app
         @tracer = tracer
         @enable_if = enable_if
+        @include_urls = include_urls
       end
 
       def call(env)
@@ -68,9 +73,11 @@ module HubStep
         tags = {
           "component" => "rack",
           "span.kind" => "server",
-          "http.url" => request.url,
           "http.method" => request.request_method,
         }
+        if @include_urls
+          tags["http.url"] = request.url
+        end
         id = request_id(request)
         if id
           tags["guid:github_request_id"] = id

data/lib/hubstep/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module HubStep
-  VERSION = "1.0.2"
+  VERSION = "2.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hubstep
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 2.0.0
 platform: ruby
 authors:
 - GitHub
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-12-19 00:00:00.000000000 Z
+date: 2016-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lightstep
@@ -122,6 +122,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
+- !ruby/object:Gem::Dependency
+  name: failbot
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.0.0
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.3.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.3.1
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement