hubstep 0.1.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 12049128293bd8dd6ebfd5a63eb7bab3d0d07307
-  data.tar.gz: 335afba8aa1d6a9f4376ce9af4309fe410491e5e
+  metadata.gz: c22f34ac228b96f97da79906e29da1fcd3bdfe5e
+  data.tar.gz: 88446428797ff70c345ae63ca52853d4cb4bbc49
 SHA512:
-  metadata.gz: fad83ef49dc17ffb0a16ed7244ce3723d396cc5248832f0ddbb95efa5a4df207645c93fea20e1902639dcb3a70e9bc8ff028f71f419a344db19fe206479f366e
-  data.tar.gz: 2babb2d26a745b96661f5c65833dfb316228f23ef812ec7d918d17259e687c3a2c2553d678caad9b8cae0632e6649c4e3235b9e2cf7bc49fbd52372c3df1748c
+  metadata.gz: eb1c73bb2a4208720038d164a08a4b0be533693cd1a2bd5b332db16d48d54cba02e0f5f9b58ea5d65d8a107809066674427cb38476d74f56332cc0c4411550d8
+  data.tar.gz: d4f1b84bf2e291b724f900be0f3fe228e49d5f792a2bbc061c6b56039c06edd4dfadc98b6b298f52c81af58e87cb6f9e90cc3a5c7ae950622c3acdb78763b332

data/CONTRIBUTING.md

@@ -0,0 +1,33 @@
+## Contributing
+
+[fork]: https://github.com/github/hubstep/fork
+[pr]: https://github.com/github/hubstep/compare
+[style]: https://github.com/styleguide/ruby
+[code-of-conduct]: CODE_OF_CONDUCT.md
+
+Hi there! We're thrilled that you'd like to contribute to this project. Your help is essential for keeping it great.
+
+Please note that this project is released with a [Contributor Code of Conduct][code-of-conduct]. By participating in this project you agree to abide by its terms.
+
+## Submitting a pull request
+
+0. [Fork][fork] and clone the repository
+0. Configure and install the dependencies: `script/bootstrap`
+0. Make sure the tests pass on your machine: `rake`
+0. Create a new branch: `git checkout -b my-branch-name`
+0. Make your change, add tests, and make sure the tests still pass
+0. Push to your fork and [submit a pull request][pr]
+0. Pat your self on the back and wait for your pull request to be reviewed and merged.
+
+Here are a few things you can do that will increase the likelihood of your pull request being accepted:
+
+- Follow the [style guide][style].
+- Write tests.
+- Keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests.
+- Write a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
+
+## Resources
+
+- [Contributing to Open Source on GitHub](https://guides.github.com/activities/contributing-to-open-source/)
+- [Using Pull Requests](https://help.github.com/articles/using-pull-requests/)
+- [GitHub Help](https://help.github.com)

data/lib/hubstep/rack/middleware.rb

@@ -6,6 +6,17 @@ module HubStep
   module Rack
     # Rack middleware for wrapping a request in a span.
     class Middleware
+      SPAN = "#{name}.span"
+
+      # Get the span that represents this request
+      #
+      # env - a Rack env Hash
+      #
+      # Returns a Span.
+      def self.get_span(env)
+        env[SPAN]
+      end
+
       # Create a Middleware
       #
       # tracer    - a HubStep::Tracer instance
@@ -31,24 +42,28 @@ module HubStep
 
       def trace(env)
         @tracer.span("Rack #{env["REQUEST_METHOD"]}") do |span|
-          span.configure do
-            add_tags(span, ::Rack::Request.new(env))
-          end
+          env[SPAN] = span
+
+          span.configure { record_request(span, env) }
 
           result = yield
 
-          span.set_tag("http.status_code", result[0].to_s)
+          span.configure { record_response(span, *result) }
 
           result
         end
       end
 
-      def add_tags(span, request)
-        tags(request).each do |key, value|
+      def record_request(span, env)
+        tags(::Rack::Request.new(env)).each do |key, value|
           span.set_tag(key, value)
         end
       end
 
+      def record_response(span, status, _headers, _body)
+        span.set_tag("http.status_code", status)
+      end
+
       def tags(request)
         tags = {
           "component" => "rack",

data/lib/hubstep/tracer.rb

@@ -47,17 +47,6 @@ module HubStep
       self.enabled = original
     end
 
-    # Get the topmost span in the stack
-    #
-    # This is the span that has no parent span; the rest of the spans in the
-    # stack descend from it.
-    #
-    # Returns a LightStep::Span or InertSpan.
-    def top_span
-      span = @spans.first if enabled?
-      span || InertSpan.instance
-    end
-
     # Get the bottommost span in the stack
     #
     # This is the span that has no children.

data/lib/hubstep/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module HubStep
-  VERSION = "0.1.1"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hubstep
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Adam Roben
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-12-16 00:00:00.000000000 Z
+date: 2016-12-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lightstep
@@ -148,6 +148,7 @@ files:
 - ".ruby-version"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE.txt
 - README.md