hubstats 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c81117f077e962453994f09ec5e806c32fb4b0c3
-  data.tar.gz: 9400a593fd42d99fcc32a05a437a53ee5a620937
+  metadata.gz: 6ca209ff034e4e98eaebfb65c7fb913529a72355
+  data.tar.gz: 27996253e2e5c609a77a54172fe8f500ab91f001
 SHA512:
-  metadata.gz: 1dd16f156ddf9c069529ab49b371abc7c3a328169b72e3d8390f34b01a02b10138ad02a154de9c67e6158f17cd85405bfdd0a9e59ba81c8440f5c14f4ed57145
-  data.tar.gz: 9db16e4c561c99cdcb7186750aa2012f0cc29890d9fa161486d55f36683b0656390160aaaedfbfecdcda8385cde74bf820a2bd8bb03cbcc8095dfe6ecf0a66be
+  metadata.gz: b1719923f5bf0643da5c1603df631a94ece351896b7a54f8ad4b75729456654d93add03695fa9b54a865e53ba305b1881f1330ffd8c4a0bc7a642b350e845747
+  data.tar.gz: c142369081e7940210c779e3831bd450171075ad5c46133d14c019bc1ed832c7a95810bf9b98faf368094d967bec09fe94914ffc636430cbc9d1abb6cce253de

data/CHANGELOG.markdown

@@ -1,3 +1,8 @@
+#### v0.9.0
+* Add a way to show a QA Signoff count on Users list page
+
+  > Emma Sax: Unknown User: https://github.com/sportngin/hubstats/pull/110
+
 #### v0.8.0
 * Do not show ignored users on lists, in stats, etc
 

data/app/assets/javascripts/hubstats/users.js

@@ -26,6 +26,10 @@ $(document).ready(function() {
     toggleOrder(queryParameters,$(this).attr('id'));
   });
 
+  $("#signoffs").on("click", function(){
+    toggleOrder(queryParameters,$(this).attr('id'));
+  });
+
   $("#netadditions").on("click", function(){
     toggleOrder(queryParameters,$(this).attr('id'));
   });

data/app/controllers/hubstats/qa_signoffs_controller.rb

@@ -0,0 +1,28 @@
+require_dependency "hubstats/application_controller"
+
+module Hubstats
+  class QaSignoffsController < Hubstats::BaseController
+
+    # Public - Will list all of the QA Signoffs that belong to any specific user(s)
+    #
+    # Returns - the QA Signoff data
+    def index
+      @qa_signoffs = Hubstats::QaSignoff.includes(:repo, :pull_request, :user)
+        .belonging_to_users(params[:users])
+        .belonging_to_repos(params[:repos])
+        .group_by(params[:group])
+        .paginate(:page => params[:page], :per_page => 15)
+
+      grouping(params[:group], @qa_signoffs)
+    end 
+
+    # Public - Will show the particular QA Signoff selected
+    #
+    # Returns - the specific details of the QA Signoff
+    def show
+      @repo = Hubstats::Repo.where(id: params[:repo_id]).first
+      @pull_request = Hubstats::PullRequest.where(id: params[:pull_request_id]).first
+      @user = Hubstats::User.where(id: params[:user_id]).first
+    end
+  end
+end

data/app/controllers/hubstats/users_controller.rb

@@ -36,6 +36,7 @@ module Hubstats
       @pull_count = Hubstats::PullRequest.belonging_to_user(@user.id).merged_in_date_range(@start_date, @end_date).count(:all)
       @deploys = Hubstats::Deploy.belonging_to_user(@user.id).deployed_in_date_range(@start_date, @end_date).order("deployed_at DESC").limit(20)
       @deploy_count = Hubstats::Deploy.belonging_to_user(@user.id).deployed_in_date_range(@start_date, @end_date).count(:all)
+      @qa_signoff_count = Hubstats::QaSignoff.belonging_to_user(@user.id).signed_within_date_range(@start_date, @end_date).count(:all)
       @comment_count = Hubstats::Comment.belonging_to_user(@user.id).created_in_date_range(@start_date, @end_date).count(:all)
       @net_additions = Hubstats::PullRequest.merged_in_date_range(@start_date, @end_date).belonging_to_user(@user.id).sum(:additions).to_i -
                        Hubstats::PullRequest.merged_in_date_range(@start_date, @end_date).belonging_to_user(@user.id).sum(:deletions).to_i
@@ -55,6 +56,9 @@ module Hubstats
         pull_count: @pull_count,
         deploy_count: @deploy_count,
         comment_count: @comment_count,
+        qa_signoff_count: @qa_signoff_count
+      }
+      @stats_row_two = {
         avg_additions: @additions.round.to_i,
         avg_deletions: @deletions.round.to_i,
         net_additions: @net_additions

data/app/models/hubstats/pull_request.rb

@@ -161,7 +161,7 @@ module Hubstats
     end
 
     # Public - Adds/remove a label based on the the webhook action
-    # @param payload Webhook payload#
+    # @param payload Webhook
     # @return The list of labels after the update
     def update_label(payload)
       return unless payload[:label]

data/app/models/hubstats/qa_signoff.rb

@@ -0,0 +1,49 @@
+module Hubstats
+  class QaSignoff < ActiveRecord::Base
+
+    def self.record_timestamps; false; end
+    
+    # Various checks that can be used to filter, sort, and find info about QA Signoffs.
+    scope :signed_within_date_range, lambda {|start_date, end_date| where("hubstats_qa_signoffs.signed_at BETWEEN ? AND ?", start_date, end_date)}
+    scope :belonging_to_repo, lambda {|repo_id| where(repo_id: repo_id)}
+    scope :belonging_to_user, lambda {|user_id| where(user_id: user_id)}
+    scope :belonging_to_pull_request, lambda {|pr_id| where(pull_request_id: pr_id)}
+    scope :belonging_to_repos, lambda {|repo_id| where(repo_id: repo_id.split(',')) if repo_id}
+    scope :belonging_to_users, lambda {|user_id| where(user_id: user_id.split(',')) if user_id}
+    scope :belonging_to_pull_requests, lambda {|pr_id| where(pull_request_id: pr_id.split(',')) if pr_id}
+    scope :distincter, -> { select("DISTINCT hubstats_qa_signoffs.*") }
+    scope :with_repo_name, -> { select('DISTINCT hubstats_repos.name as repo_name, hubstats_qa_signoffs.*').joins("LEFT JOIN hubstats_repos ON hubstats_repos.id = hubstats_qa_signoffs.repo_id") }
+    scope :with_user_name, -> { select('DISTINCT hubstats_users.login as user_name, hubstats_qa_signoffs.*').joins("LEFT JOIN hubstats_users ON hubstats_users.id = hubstats_qa_signoffs.user_id") }
+    scope :with_pull_request_name, -> { select('DISTINCT hubstats_pull_requests.title as pr_name, hubstats_qa_signoffs.*').joins("LEFT JOIN hubstats_pull_requests ON hubstats_pull_requests.id = hubstats_qa_signoffs.pull_request_id") }
+
+    belongs_to :user
+    belongs_to :repo
+    belongs_to :pull_request
+
+    # Public - Makes a new QA Signoff with the data that is passed in.
+    #
+    # repo_id - the id of the repository
+    # pr_id - the id of the pull request
+    # user_id - the id of the user who added the label
+    #
+    # Returns - the QA Signoff
+    def self.first_or_create(repo_id, pr_id, user_id)
+      QaSignoff.create(user_id: user_id,
+                       repo_id: repo_id,
+                       pull_request_id: pr_id,
+                       label_name: 'qa-approved',
+                       signed_at: Time.now.getutc)
+    end
+
+    # Public - Deletes the QA Signoff of the PR that is passed in.
+    #
+    # repo_id - the id of the repository the PR belongs to
+    # pr_id - the id of the PR the signoff was deleted from
+    #
+    # Returns - the deleted QA Signoff
+    def self.remove_signoff(repo_id, pr_id)
+      signoff = Hubstats::QaSignoff.where(repo_id: repo_id).where(pull_request_id: pr_id).first
+      signoff.destroy if signoff
+    end
+  end
+end

data/app/models/hubstats/user.rb

@@ -34,6 +34,19 @@ module Hubstats
        .joins(sanitize_sql_array(["LEFT JOIN hubstats_comments ON hubstats_comments.user_id = hubstats_users.id AND (hubstats_comments.created_at BETWEEN ? AND ?)", start_date, end_date]))
        .group("hubstats_users.id")
     }
+
+    # Public - Counts all of the QA Signoffs for selected user that were signed between the start_date and end_date.
+    # 
+    # start_date - the start of the date range
+    # end_date - the end of the data range
+    # 
+    # Returns - count of QA Signoffs
+    scope :qa_signoffs_count, lambda {|start_date, end_date|
+      select("hubstats_users.id as user_id")
+       .select("IFNULL(COUNT(DISTINCT hubstats_qa_signoffs.id),0) AS qa_signoff_count")
+       .joins(sanitize_sql_array(["LEFT JOIN hubstats_qa_signoffs ON hubstats_qa_signoffs.user_id = hubstats_users.id AND (hubstats_qa_signoffs.signed_at BETWEEN ? AND ?)", start_date, end_date]))
+       .group("hubstats_users.id")
+    }
  
     # Public - Counts all of the merged pull requests for selected user that occurred between the start_date and end_date.
     # 
@@ -48,16 +61,17 @@ module Hubstats
       .group("hubstats_users.id")
     }
 
-    # Public - Counts all of the merged pull requests, deploys, and comments that occurred between the start_date and end_date that belong to a user.
+    # Public - Counts all of the merged pull requests, deploys, QA Signoffs, and comments that occurred between the start_date and end_date that belong to a user.
     #
     # start_date - the start of the date range
     # end_date - the end of the data range
     #
-    # Returns - the count of deploys, pull requests, and comments
+    # Returns - the count of deploys, pull requests, QA Signoffs, and comments
     scope :pull_comment_deploy_count, lambda {|start_date, end_date|
-      select("hubstats_users.*, pull_request_count, comment_count, deploy_count")
+      select("hubstats_users.*, pull_request_count, comment_count, qa_signoff_count, deploy_count")
       .joins("LEFT JOIN (#{pull_requests_count(start_date, end_date).to_sql}) AS pull_requests ON pull_requests.user_id = hubstats_users.id")
       .joins("LEFT JOIN (#{comments_count(start_date, end_date).to_sql}) AS comments ON comments.user_id = hubstats_users.id")
+      .joins("LEFT JOIN (#{qa_signoffs_count(start_date, end_date).to_sql}) AS qa_signoffs ON qa_signoffs.user_id = hubstats_users.id")
       .joins("LEFT JOIN (#{deploys_count(start_date, end_date).to_sql}) AS deploys ON deploys.user_id = hubstats_users.id")
       .group("hubstats_users.id")
     }
@@ -88,6 +102,19 @@ module Hubstats
       .group("hubstats_users.id")
     }
 
+    # Public - Counts all of the QA Signoffs for selected user that were signed between the start_date and end_date and belong to the repos.
+    # 
+    # start_date - the start of the date range
+    # end_date - the end of the data range
+    # 
+    # Returns - count of QA Signoffs
+    scope :qa_signoffs_count_by_repo, lambda {|start_date, end_date, repo_id|
+      select("hubstats_users.id as user_id")
+      .select("COUNT(DISTINCT hubstats_qa_signoffs.id) AS qa_signoff_count")
+      .joins(sanitize_sql_array(["LEFT JOIN hubstats_qa_signoffs ON hubstats_qa_signoffs.user_id = hubstats_users.id AND (hubstats_qa_signoffs.signed_at BETWEEN ? AND ?) AND (hubstats_qa_signoffs.repo_id LIKE ?)", start_date, end_date, repo_id]))
+      .group("hubstats_users.id")
+    }
+
     # Public - Counts all of the pull requests for selected user that occurred between the start_date and end_date and belong to the repos.
     # 
     # start_date - the start of the date range
@@ -101,17 +128,18 @@ module Hubstats
       .group("hubstats_users.id")
     }
 
-    # Public - Counts all of the merged pull requests, deploys, and comments that belong to a repository and belong to a user and occurred between 
+    # Public - Counts all of the merged pull requests, deploys, QA Signoffs and comments that belong to a repository and belong to a user and occurred between 
     # the start_date and end_date.
     #
     # start_date - the start of the date range
     # end_date - the end of the data range
     #
-    # Returns - the count of deploys, pull requests, and comments
+    # Returns - the count of deploys, pull requests, QA Signoffs, and comments
     scope :pull_comment_deploy_count_by_repo, lambda {|start_date, end_date, repo_id|
-      select("hubstats_users.*, pull_request_count, comment_count, deploy_count")
+      select("hubstats_users.*, pull_request_count, comment_count, qa_signoff_count, deploy_count")
       .joins("LEFT JOIN (#{pull_requests_count_by_repo(start_date, end_date, repo_id).to_sql}) AS pull_requests ON pull_requests.user_id = hubstats_users.id")
       .joins("LEFT JOIN (#{comments_count_by_repo(start_date, end_date, repo_id).to_sql}) AS comments ON comments.user_id = hubstats_users.id")
+      .joins("LEFT JOIN (#{qa_signoffs_count_by_repo(start_date, end_date, repo_id).to_sql}) AS qa_signoffs ON qa_signoffs.user_id = hubstats_users.id")
       .joins("LEFT JOIN (#{deploys_count_by_repo(start_date, end_date, repo_id).to_sql}) AS deploys ON deploys.user_id = hubstats_users.id")
       .group("hubstats_users.id")
     }
@@ -131,7 +159,7 @@ module Hubstats
       .group("hubstats_users.id")
     }
 
-    # Public - Joins all of the metrics together for selected repository: average additions and deletions, comments, pull requests, and deploys.
+    # Public - Joins all of the metrics together for selected repository: average additions and deletions, comments, pull requests, QA Signoffs and deploys.
     # However, will only count those that also have something to do with the repos passed in.
     # 
     # start_date - the start of the date range
@@ -139,25 +167,27 @@ module Hubstats
     # 
     # Returns - all of the stats about the user
     scope :with_all_metrics_repos, lambda {|start_date, end_date, repos|
-      select("hubstats_users.*, deploy_count, pull_request_count, comment_count, additions, deletions")
+      select("hubstats_users.*, deploy_count, pull_request_count, comment_count, qa_signoff_count, additions, deletions")
       .joins("LEFT JOIN (#{net_additions_count(start_date, end_date).to_sql}) AS net_additions ON net_additions.user_id = hubstats_users.id")
       .joins("LEFT JOIN (#{pull_requests_count_by_repo(start_date, end_date, repos).to_sql}) AS pull_requests ON pull_requests.user_id = hubstats_users.id")
       .joins("LEFT JOIN (#{comments_count_by_repo(start_date, end_date, repos).to_sql}) AS comments ON comments.user_id = hubstats_users.id")
+      .joins("LEFT JOIN (#{qa_signoffs_count_by_repo(start_date, end_date, repos).to_sql} AS qa_signoffs ON qa_signoffs.user_id = hubstats_users.id")
       .joins("LEFT JOIN (#{deploys_count_by_repo(start_date, end_date, repos).to_sql}) AS deploys ON deploys.user_id = hubstats_users.id")
       .group("hubstats_users.id")
     }
 
-    # Public - Joins all of the metrics together for selected user: average additions and deletions, comments, pull requests, and deploys.
+    # Public - Joins all of the metrics together for selected user: average additions and deletions, comments, pull requests, QA Signoffs and deploys.
     # 
     # start_date - the start of the date range
     # end_date - the end of the data range
     # 
     # Returns - all of the stats about the user
     scope :with_all_metrics, lambda {|start_date, end_date|
-      select("hubstats_users.*, deploy_count, pull_request_count, comment_count, additions, deletions")
+      select("hubstats_users.*, deploy_count, pull_request_count, comment_count, qa_signoff_count, additions, deletions")
       .joins("LEFT JOIN (#{net_additions_count(start_date, end_date).to_sql}) AS net_additions ON net_additions.user_id = hubstats_users.id")
       .joins("LEFT JOIN (#{pull_requests_count(start_date, end_date).to_sql}) AS pull_requests ON pull_requests.user_id = hubstats_users.id")
       .joins("LEFT JOIN (#{comments_count(start_date, end_date).to_sql}) AS comments ON comments.user_id = hubstats_users.id")
+      .joins("LEFT JOIN (#{qa_signoffs_count(start_date, end_date).to_sql}) AS qa_signoffs ON qa_signoffs.user_id = hubstats_users.id")
       .joins("LEFT JOIN (#{deploys_count(start_date, end_date).to_sql}) AS deploys ON deploys.user_id = hubstats_users.id")
       .group("hubstats_users.id")
     }
@@ -219,6 +249,8 @@ module Hubstats
           order("pull_request_count #{order}")
         when 'comments'
           order("comment_count #{order}")
+        when 'signoffs'
+          order("qa_signoff_count #{order}")
         when 'netadditions'
           order("additions - deletions #{order}")
         when 'name'

data/app/views/hubstats/partials/_quick_stats_one.html.erb

@@ -43,6 +43,12 @@
     <h4> Comments </h4>
   </div>
 <% end %>
+<% if @stats_row_one.has_key? :qa_signoff_count %>
+  <div class="col col-lg-2 col-md-3 col-sm-3 col-xs-3 text-center">
+    <h1><%= @stats_row_one[:qa_signoff_count] %> </h1>
+    <h4> QA Signoffs </h4>
+  </div>
+<% end %>
 <% if @stats_row_one.has_key? :review_count %>
   <div class="col col-lg-2 col-md-3 col-sm-3 col-xs-3 text-center">
      <h1> <%= @stats_row_one[:review_count] %> </h1>

data/app/views/hubstats/partials/_quick_stats_two.html.erb

@@ -43,6 +43,12 @@
     <h4> Comments </h4>
   </div>
 <% end %>
+<% if @stats_row_two.has_key? :qa_signoff_count %>
+  <div class="col col-lg-2 col-md-3 col-sm-3 col-xs-3 text-center">
+    <h1><%= @stats_row_one[:qa_signoff_count] %> </h1>
+    <h4> QA Signoffs </h4>
+  </div>
+<% end %>
 <% if @stats_row_two.has_key? :review_count %>
   <div class="col col-lg-2 col-md-3 col-sm-3 col-xs-3 text-center">
      <h1> <%= @stats_row_two[:review_count] %> </h1>

data/app/views/hubstats/partials/_user.html.erb

@@ -4,7 +4,7 @@
   <div class="user-image col-lg-1 col-md-1 col-sm-1" >
     <img src= <%= user.avatar_url%> alt= <%= user.login %> >
   </div>
-  <div class="user-info col-lg-3 col-md-3 col-sm-3">
+  <div class="user-info col-lg-2 col-md-2 col-sm-2">
     <h4> 
       <%= link_to user.login, user_path(user) %>
     </h4>
@@ -38,6 +38,13 @@
     </div>
   </div>
   <div class="col-lg-2 col-md-2 col-sm-2">
+    <div class="text-center">
+      <span class="text-large"><%= user.qa_signoff_count %></span>
+      <span class="mega-octicon octicon-checklist"></span>
+    </div>
+  </div>
+
+  <div class="col-lg-1 col-md-1 col-sm-1">
     <div class="text-center">
       <span class="text-large"><%= user.additions - user.deletions %></span>
     </div>

data/app/views/hubstats/tables/_users.html.erb

@@ -2,7 +2,7 @@
 <% if @users.length > 0 %>
   <div class="users">
     <div class="row single-user header">
-      <div class="col-lg-4 col-md-4 col-sm-4">
+      <div class="col-lg-3 col-md-3 col-sm-3">
         <a class="header desc" id="name"> GitHub Username <span class="octicon"></span> </a>
       </div>
       <div class="col-lg-2 col-md-2 col-sm-2">
@@ -15,6 +15,9 @@
         <a class="header desc" id="comments"> Comments <span class="octicon"></span></a>
       </div>
       <div class="col-lg-2 col-md-2 col-sm-2">
+        <a class="header desc" id="signoffs"> QA Signoffs <span class="octicon"></span></a>
+      </div>
+      <div class="col-lg-1 col-md-1 col-sm-1">
         <a class="header desc" id="netadditions"> Net Additions <span class="octicon"></span></a>
       </div>
     </div>

data/app/views/hubstats/users/show.html.erb

@@ -14,7 +14,15 @@
     </h4>
 
     <!-- Show all of the stats about the user -->
-    <%= render 'hubstats/partials/quick_stats_one' %>
+
+    <%= render 'hubstats/partials/quick_stats_one' %>    
+    <br>
+    <br>
+    <br>
+    <br>
+    <br>
+    <br>
+    <%= render 'hubstats/partials/quick_stats_two' %>
   </div>
 
   <div class="row">

data/db/migrate/20161215163228_add_qa_signoff.rb

@@ -0,0 +1,14 @@
+class AddQaSignoff < ActiveRecord::Migration
+  def change
+    create_table :hubstats_qa_signoffs do |t|
+      t.belongs_to :user
+      t.belongs_to :repo
+      t.belongs_to :pull_request
+      t.string :label_name
+    end
+
+    add_index :hubstats_qa_signoffs, :user_id
+    add_index :hubstats_qa_signoffs, :repo_id
+    add_index :hubstats_qa_signoffs, :pull_request_id
+  end
+end

data/db/migrate/20161215193059_signed_column_for_signoff.rb

@@ -0,0 +1,5 @@
+class SignedColumnForSignoff < ActiveRecord::Migration
+  def change
+  	add_column :hubstats_qa_signoffs, :signed_at, :datetime
+  end
+end

data/lib/hubstats/events_handler.rb

@@ -22,7 +22,8 @@ module Hubstats
       end
     end
 
-    # Public - Gets the information for the PR, creates/updates the new PR, grabs the labels, and makes new labels
+    # Public - Gets the information for the PR, creates/updates the new PR, grabs the labels, and makes new labels;
+    #  if the label qa-approved is added or removed, a new QA Signoff record will be made
     #
     # payload - the information that we will use to get data off of
     #
@@ -31,7 +32,12 @@ module Hubstats
       pull_request = payload[:pull_request]
       pull_request[:repository] = payload[:repository]
       new_pull = Hubstats::PullRequest.create_or_update(pull_request.with_indifferent_access)
-      if payload[:action].include?('labeled')
+      if payload[:github_action].include?('labeled')
+        if payload[:github_action].include?('unlabeled') && payload[:label][:name].include?('qa-approved')
+          Hubstats::QaSignoff.remove_signoff(payload[:repository][:id], payload[:pull_request][:id])
+        elsif payload[:label][:name].include?('qa-approved')
+          Hubstats::QaSignoff.first_or_create(payload[:repository][:id], payload[:pull_request][:id], payload[:sender][:id])
+        end
         new_pull.update_label(payload)
       else
         repo_name = Hubstats::Repo.where(id: new_pull.repo_id).first.full_name

data/lib/hubstats/version.rb

@@ -1,3 +1,3 @@
 module Hubstats
-  VERSION = "0.8.0"
+  VERSION = "0.9.0"
 end

data/spec/lib/hubstats/events_handler_spec.rb

@@ -15,6 +15,7 @@ module Hubstats
       end
 
       it 'should add labels to pull request' do
+        payload[:github_action] = 'created'
         allow(PullRequest).to receive(:create_or_update) {pull}
         allow(Repo).to receive(:where) {[repo,repo]}
         allow(GithubAPI).to receive(:get_labels_for_pull) {[{name: 'low'}, {name: 'high'}]}
@@ -23,7 +24,7 @@ module Hubstats
       end
 
       it 'should add new labels to pull requests' do
-        payload[:action] = 'labeled'
+        payload[:github_action] = 'labeled'
         payload[:label] = {name: 'new_label'}
         allow(PullRequest).to receive(:create_or_update) {pull}
         allow(Repo).to receive(:where) {[repo,repo]}
@@ -33,7 +34,7 @@ module Hubstats
       end
 
       it 'should remove old labels from pull requests' do
-        payload[:action] = 'unlabeled'
+        payload[:github_action] = 'unlabeled'
         payload[:label] = {name: 'old_label'}
         allow(PullRequest).to receive(:create_or_update) {pull}
         allow(Repo).to receive(:where) {[repo,repo]}

data/spec/models/hubstats/qa_signoff_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+module Hubstats
+  describe QaSignoff, :type => :model do
+    it 'should create and return a QA Signoff' do
+      signoff = QaSignoff.first_or_create(123, 456, 789)
+      expect(signoff.user_id).to eq(789)
+      expect(signoff.repo_id).to eq(123)
+      expect(signoff.pull_request_id).to eq(456)
+    end
+
+    it 'should remove a signoff' do
+      signoff = QaSignoff.first_or_create(123, 456, 789)
+      expect(Hubstats::QaSignoff.where(pull_request_id: 456).count).to eq(1)
+      QaSignoff.remove_signoff(123, 456)
+      expect(Hubstats::QaSignoff.where(pull_request_id: 456)).to eq([])
+    end
+  end
+end

data/test/dummy/db/schema.rb

@@ -11,14 +11,13 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20160113182419) do
+ActiveRecord::Schema.define(version: 20161215193314) do
 
   create_table "hubstats_comments", force: :cascade do |t|
     t.string   "html_url",         limit: 255
     t.string   "url",              limit: 255
     t.string   "pull_request_url", limit: 255
     t.integer  "path",             limit: 4
-    t.string   "body_string",      limit: 255
     t.string   "kind",             limit: 255
     t.integer  "user_id",          limit: 4
     t.integer  "pull_request_id",  limit: 4
@@ -82,6 +81,18 @@ ActiveRecord::Schema.define(version: 20160113182419) do
   add_index "hubstats_pull_requests", ["team_id"], name: "index_hubstats_pull_requests_on_team_id", using: :btree
   add_index "hubstats_pull_requests", ["user_id"], name: "index_hubstats_pull_requests_on_user_id", using: :btree
 
+  create_table "hubstats_qa_signoffs", force: :cascade do |t|
+    t.integer  "user_id",         limit: 4
+    t.integer  "repo_id",         limit: 4
+    t.integer  "pull_request_id", limit: 4
+    t.string   "label_name",      limit: 255
+    t.datetime "signed_at"
+  end
+
+  add_index "hubstats_qa_signoffs", ["pull_request_id"], name: "index_hubstats_qa_signoffs_on_pull_request_id", using: :btree
+  add_index "hubstats_qa_signoffs", ["repo_id"], name: "index_hubstats_qa_signoffs_on_repo_id", using: :btree
+  add_index "hubstats_qa_signoffs", ["user_id"], name: "index_hubstats_qa_signoffs_on_user_id", using: :btree
+
   create_table "hubstats_repos", force: :cascade do |t|
     t.string   "name",       limit: 255
     t.string   "full_name",  limit: 255

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hubstats
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Elliot Hursh
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-19 00:00:00.000000000 Z
+date: 2016-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -226,6 +226,7 @@ files:
 - app/controllers/hubstats/deploys_controller.rb
 - app/controllers/hubstats/events_controller.rb
 - app/controllers/hubstats/pull_requests_controller.rb
+- app/controllers/hubstats/qa_signoffs_controller.rb
 - app/controllers/hubstats/repos_controller.rb
 - app/controllers/hubstats/teams_controller.rb
 - app/controllers/hubstats/users_controller.rb
@@ -239,6 +240,7 @@ files:
 - app/models/hubstats/deploy.rb
 - app/models/hubstats/label.rb
 - app/models/hubstats/pull_request.rb
+- app/models/hubstats/qa_signoff.rb
 - app/models/hubstats/repo.rb
 - app/models/hubstats/team.rb
 - app/models/hubstats/user.rb
@@ -302,6 +304,8 @@ files:
 - db/migrate/20160113181700_copy_body_string_to_body_text.rb
 - db/migrate/20160113182307_rename_body_to_body_string.rb
 - db/migrate/20160113182356_rename_body_text_to_body.rb
+- db/migrate/20161215163228_add_qa_signoff.rb
+- db/migrate/20161215193059_signed_column_for_signoff.rb
 - db/seeds.rb
 - hubstats.gemspec
 - lib/generators/hubstats/install_generator.rb
@@ -339,6 +343,7 @@ files:
 - spec/models/hubstats/deploy_spec.rb
 - spec/models/hubstats/label_spec.rb
 - spec/models/hubstats/pull_request_spec.rb
+- spec/models/hubstats/qa_signoff_spec.rb
 - spec/models/hubstats/repo_spec.rb
 - spec/models/hubstats/team_spec.rb
 - spec/models/hubstats/user_spec.rb
@@ -427,6 +432,7 @@ test_files:
 - spec/models/hubstats/deploy_spec.rb
 - spec/models/hubstats/label_spec.rb
 - spec/models/hubstats/pull_request_spec.rb
+- spec/models/hubstats/qa_signoff_spec.rb
 - spec/models/hubstats/repo_spec.rb
 - spec/models/hubstats/team_spec.rb
 - spec/models/hubstats/user_spec.rb