hubspot-ruby 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 371e11640e32bc9b2ba0bb54f3fbdfd3b84dcb5f4be69fd0d4e89163fdf544bb
-  data.tar.gz: 8f27026960fb8cc21c1f25c76dba6a26e4c33be192a635728a939284f52bea09
+  metadata.gz: 2bf3e6e8fbd83defe0525c7d692eb797d2650eeb6919ffdc5c55505345da233e
+  data.tar.gz: 7880ed3f94d9ce4784668a20eb254635e72484e2d0dfba9cb2b988cfc5846756
 SHA512:
-  metadata.gz: bed3f9319a9dc8db09aa7a050d3724055e502cece3a2b3400c19fb7125fb4a38c1cf5366deff6e22f7ff34fc9db69d380c29e4f18df69763d422941efcd47019
-  data.tar.gz: 64b3ddc122391b6d3fd44ec0cbe123ae92b306a632ebce366a9a43ee7acee0ef705e919c8d05661d6906e6d2454435352fc5b5c7422bd58d9320adc92ac5f4f7
+  metadata.gz: 14385b0ece499e0092dd3de5de1de3b6fcb89c5acc90407a597c0a06658489302e9f7199def1ccb4dc58c118371fe4481e142060ad319c52cee99f55d4bf16ea
+  data.tar.gz: ce08579ea8415650d1599fff9cc31e6c14da1bbd90eea8974a9ef16c961b803de838bd0d5fd8a97e559140ce0b9e21cdf0b6fd3bb0769e09402272a5227799ac

data/hubspot-ruby.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = "hubspot-ruby"
-  s.version = "0.6.0"
+  s.version = "0.6.1"
   s.require_paths = ["lib"]
   s.authors = ["Andrew DiMichele", "Chris Bisnett"]
   s.description = "hubspot-ruby is a wrapper for the HubSpot REST API"

data/lib/hubspot-ruby.rb

@@ -16,6 +16,7 @@ require 'hubspot/topic'
 require 'hubspot/deal'
 require 'hubspot/deal_pipeline'
 require 'hubspot/deal_properties'
+require 'hubspot/deprecator'
 require 'hubspot/owner'
 require 'hubspot/engagement'
 require 'hubspot/subscription'

data/lib/hubspot/deprecator.rb

@@ -0,0 +1,7 @@
+module Hubspot
+  class Deprecator
+    def self.build(version: "1.0")
+      ActiveSupport::Deprecation.new(version, "hubspot-ruby")
+    end
+  end
+end

data/lib/hubspot/railtie.rb

@@ -4,6 +4,7 @@ module Hubspot
   class Railtie < Rails::Railtie
     rake_tasks do
       spec = Gem::Specification.find_by_name('hubspot-ruby')
+      load "#{spec.gem_dir}/lib/tasks/hubspot.rake"
     end
   end
 end

data/lib/hubspot/utils.rb

@@ -15,6 +15,8 @@ module Hubspot
       end
 
       def dump_properties(klass, hapikey=ENV['HUBSPOT_API_KEY'], filter={})
+        Hubspot::Deprecator.build.deprecation_warning("Hubspot::Utils.dump_properties")
+
         with_hapikey(hapikey) do
           { 'groups'     => klass.groups({}, filter),
             'properties' => klass.all({}, filter).select { |p| !p['hubspotDefined'] }
@@ -23,6 +25,8 @@ module Hubspot
       end
 
       def restore_properties(klass, hapikey=ENV['HUPSPOT_API_KEY'], properties={}, dry_run=false)
+        Hubspot::Deprecator.build.deprecation_warning("Hubspot::Utils.restore_properties")
+
         existing_properties                       = dump_properties(klass, hapikey)
         skip, new_groups, new_props, update_props = compare_property_lists(klass, properties, existing_properties)
         puts '', 'Dry Run - Changes will not be applied' if dry_run

data/lib/tasks/hubspot.rake

@@ -3,6 +3,8 @@ require 'hubspot-ruby'
 namespace :hubspot do
   desc 'Dump properties to file'
   task :dump_properties, [:kind, :file, :hapikey, :include, :exclude] do |_, args|
+    Hubspot::Deprecator.build.deprecation_warning("hubspot:dump_properties")
+
     hapikey = args[:hapikey] || ENV['HUBSPOT_API_KEY']
     kind = args[:kind]
     unless %w(contact deal).include?(kind)
@@ -21,6 +23,8 @@ namespace :hubspot do
 
   desc 'Restore properties from file'
   task :restore_properties, [:kind, :file, :hapikey, :dry_run] do |_, args|
+    Hubspot::Deprecator.build.deprecation_warning("hubspot:restore_properties")
+
     hapikey = args[:hapikey] || ENV['HUBSPOT_API_KEY']
     if args[:file].blank?
       raise ArgumentError, ':file is a required parameter'

data/spec/lib/hubspot/deprecator_spec.rb

@@ -0,0 +1,15 @@
+RSpec.describe Hubspot::Deprecator do
+  describe ".build" do
+    it "returns an instance of ActiveSupport::Deprecation" do
+      deprecator = Hubspot::Deprecator.build
+
+      expect(deprecator).to be_an_instance_of(ActiveSupport::Deprecation)
+    end
+
+    it "uses the correct gem name" do
+      deprecator = Hubspot::Deprecator.build
+
+      expect(deprecator.gem_name).to eq("hubspot-ruby")
+    end
+  end
+end

data/spec/lib/hubspot/utils_spec.rb

@@ -126,4 +126,39 @@ describe Hubspot::Utils do
       end
     end
   end
+
+  describe ".dump_properties" do
+    it "prints a deprecation warning" do
+      VCR.use_cassette("dump_deal_properties_and_groups") do
+        api_key = "demo"
+
+        output = capture_stderr do
+          Hubspot::Utils.dump_properties(Hubspot::DealProperties, api_key)
+        end
+
+        expected_warning = "Hubspot::Utils.dump_properties is deprecated"
+        expect(output).to include(expected_warning)
+      end
+    end
+  end
+
+  describe ".restore_properties" do
+    it "prints a deprecation warning" do
+      VCR.use_cassette("restore_deal_properties_and_groups") do
+        api_key = "demo"
+        properties = {"groups" => {}, "properties" => {}}
+
+        output = capture_stderr do
+          Hubspot::Utils.restore_properties(
+            Hubspot::DealProperties,
+            api_key,
+            properties
+          )
+        end
+
+        expected_warning = "Hubspot::Utils.restore_properties is deprecated"
+        expect(output).to include(expected_warning)
+      end
+    end
+  end
 end

data/spec/lib/tasks/hubspot_spec.rb

@@ -20,6 +20,18 @@ RSpec.describe "hubspot rake tasks", type: :rake do
       end
     end
 
+    it "prints a deprecation warning" do
+      VCR.use_cassette("dump_contact_properties_and_groups") do
+        file = Tempfile.new ""
+
+        output = capture_stderr do
+          invoke_rake_task("hubspot:dump_properties", ["contact", file, hapikey])
+        end
+
+        expect(output).to include("hubspot:dump_properties is deprecated")
+      end
+    end
+
     context "given an unknown class" do
       it "raises an error" do
         file = Tempfile.new ""
@@ -55,6 +67,21 @@ RSpec.describe "hubspot rake tasks", type: :rake do
       end
     end
 
+    it "prints a deprecation warning" do
+      VCR.use_cassette("restore_contact_properties_and_groups") do
+        file = build_file_with_matching_properties("contact")
+
+        output = capture_stderr do
+          invoke_rake_task(
+            "hubspot:restore_properties",
+            ["contact", file, hapikey]
+          )
+        end
+
+        expect(output).to include("hubspot:restore_properties is deprecated")
+      end
+    end
+
     context "when a file is not provided" do
       it "raises an error" do
         missing_file = ""
@@ -89,12 +116,4 @@ RSpec.describe "hubspot rake tasks", type: :rake do
     invoke_rake_task("hubspot:dump_properties", ["contact", file, hapikey])
     file
   end
-
-  def capture_stdout
-    previous, $stdout = $stdout, StringIO.new
-    yield
-    $stdout.string
-  ensure
-    $stdout = previous
-  end
 end

data/spec/support/capture_output.rb

@@ -0,0 +1,21 @@
+module CaptureOutput
+  def capture_stderr
+    previous, $stderr = $stderr, StringIO.new
+    yield
+    $stderr.string
+  ensure
+    $stderr = previous
+  end
+
+  def capture_stdout
+    previous, $stdout = $stdout, StringIO.new
+    yield
+    $stdout.string
+  ensure
+    $stdout = previous
+  end
+end
+
+RSpec.configure do |config|
+  config.include CaptureOutput
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hubspot-ruby
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Andrew DiMichele
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-28 00:00:00.000000000 Z
+date: 2018-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -219,6 +219,7 @@ files:
 - lib/hubspot/deal.rb
 - lib/hubspot/deal_pipeline.rb
 - lib/hubspot/deal_properties.rb
+- lib/hubspot/deprecator.rb
 - lib/hubspot/engagement.rb
 - lib/hubspot/exceptions.rb
 - lib/hubspot/form.rb
@@ -242,6 +243,7 @@ files:
 - spec/lib/hubspot/deal_pipeline_spec.rb
 - spec/lib/hubspot/deal_properties_spec.rb
 - spec/lib/hubspot/deal_spec.rb
+- spec/lib/hubspot/deprecator_spec.rb
 - spec/lib/hubspot/engagement_spec.rb
 - spec/lib/hubspot/form_spec.rb
 - spec/lib/hubspot/owner_spec.rb
@@ -250,6 +252,7 @@ files:
 - spec/lib/hubspot/utils_spec.rb
 - spec/lib/tasks/hubspot_spec.rb
 - spec/spec_helper.rb
+- spec/support/capture_output.rb
 - spec/support/cassette_helper.rb
 - spec/support/hubspot_api_helpers.rb
 - spec/support/rake.rb