hubspot-ruby 0.1.7 → 0.1.8

data/spec/lib/hubspot/deal_spec.rb

@@ -71,6 +71,7 @@ describe Hubspot::Deal do
     let(:deal) {Hubspot::Deal.create!(62515, [8954037], [27136], {amount: 30})}
 
     it 'should remove from hubspot' do
+      pending
       expect(Hubspot::Deal.find(deal.deal_id)).to_not be_nil
 
       expect(deal.destroy!).to be_true
@@ -79,4 +80,14 @@ describe Hubspot::Deal do
       expect(Hubspot::Deal.find(deal.deal_id)).to be_nil
     end
   end
+
+  describe '#[]' do
+    subject{ Hubspot::Deal.new(example_deal_hash) }
+
+    it 'should get a property' do
+      subject.properties.each do |property, value|
+        expect(subject[property]).to eql value
+      end
+    end
+  end
 end

data/spec/lib/hubspot/form_spec.rb

@@ -1,18 +1,165 @@
 describe Hubspot::Form do
-  describe "#url" do
-    let(:form_guid){ "abcd-efgh-1234-5678" }
-    subject{ Hubspot::Form.new(form_guid) }
+  let(:example_form_hash) do
+    VCR.use_cassette("form_example", record: :none) do
+      HTTParty.get("https://api.hubapi.com/contacts/v1/forms/561d9ce9-bb4c-45b4-8e32-21cdeaa3a7f0/?hapikey=demo").parsed_response
+    end
+  end
+
+  describe '#initialize' do
+    subject { Hubspot::Form.new(example_form_hash) }
+    
+    it { should be_an_instance_of Hubspot::Form }
+    its(:guid) { should be_a(String) }
+    its(:properties) { should be_a(Hash) }
+  end 
+
+  before { Hubspot.configure(hapikey: "demo", portal_id: '62515') }
+
+  describe '.all' do
+    cassette 'find_all_forms'
+
+    it 'returns all forms' do
+      forms = Hubspot::Form.all
+      expect(forms.count).to be > 20  
+
+      form = forms.first 
+      expect(form).to be_a(Hubspot::Form)  
+    end
+  end
+
+  describe '.find' do
+    cassette "form_find"
+    subject { Hubspot::Form.find(guid) }
+
+    context 'when the form is found' do
+      let(:guid) { '561d9ce9-bb4c-45b4-8e32-21cdeaa3a7f0' }
+      it { should be_an_instance_of Hubspot::Form }
+      its(:fields) { should_not be_empty }
+    end
+
+    context 'when the form is not found' do
+      it 'raises an error' do 
+        expect { Hubspot::Form.find(-1) }.to raise_error(Hubspot::RequestError) 
+      end
+    end 
+  end
+
+  describe '.create' do
+    subject{ Hubspot::Form.create!(params) }
+    
+    context 'with all required parameters' do 
+      cassette 'create_form'
+
+      let(:params) do 
+        { 
+          name: "Demo Form #{Time.now.to_i}",
+          action: "",
+          method: "POST",
+          cssClass: "hs-form stacked",
+          redirect: "",
+          submitText: "Sign Up",
+          followUpId: "",
+          leadNurturingCampaignId: "",
+          notifyRecipients: "",
+          embeddedCode: "" 
+        }
+      end
+      it { should be_an_instance_of Hubspot::Form }
+      its(:guid) { should be_a(String) }
+    end 
+    
+    context 'without all required parameters' do
+      cassette 'fail_to_create_form'
+
+      it 'raises an error' do 
+        expect { Hubspot::Form.create!({}) }.to raise_error(Hubspot::RequestError)
+      end
+    end
+  end
+
+  describe '#fields' do
+    context 'returning all the fields' do
+      cassette 'fields_among_form'
 
-    context "when a portal_id is configured" do
-      before { Hubspot.configure hapikey: "demo", portal_id: "62515" }
-      its(:url){ should == "https://forms.hubspot.com/uploads/form/v2/62515/abcd-efgh-1234-5678" }
+      let(:form) { Hubspot::Form.new(example_form_hash) }
+
+      it 'returns by default the fields property if present' do
+        fields = form.fields
+        fields.should_not be_empty
+      end
+
+      it 'updates the fields property and returns it' do 
+        fields = form.fields(bypass_cache: true)
+        fields.should_not be_empty
+      end
     end
 
-    context "when a portal_id is not configured" do
-      before { Hubspot.configure hapikey: "demo" }
-      it "raises an exception" do
-        expect{ subject.url }.to raise_error Hubspot::ConfigurationError
+    context 'returning an uniq field' do 
+      cassette 'field_among_form'
+
+      let(:form) { Hubspot::Form.new(example_form_hash) }
+    
+      it 'returns by default the field if present as a property' do
+        field = form.fields(only: :email)
+        expect(field).to be_a(Hash)
+        expect(field['name']).to be == 'email'
+      end
+
+      it 'makes an API request if specified' do 
+        field = form.fields(only: :email, bypass_cache: true)
+        expect(field).to be_a(Hash)
+        expect(field['name']).to be == 'email'
       end
     end
   end
+
+  describe '#submit' do 
+    cassette 'form_submit_data'
+
+    let(:form) { Hubspot::Form.find('561d9ce9-bb4c-45b4-8e32-21cdeaa3a7f0') }
+
+    it 'returns true if the form submission is successfull' do 
+      params = { }
+      result = form.submit(params)
+      result.should be true
+    end
+
+    it 'returns false in case of errors' do 
+      Hubspot.configure(hapikey: "demo", portal_id: '62514')
+      params = { }
+      result = form.submit(params)
+      result.should be false
+    end
+  end
+
+  describe '#update!' do 
+    cassette "form_update"
+    
+    new_name = "updated form name 1424709912"
+    redirect = 'http://hubspot.com'
+
+    let(:form) { Hubspot::Form.find('561d9ce9-bb4c-45b4-8e32-21cdeaa3a7f0') }
+    let(:params) { { name: new_name, redirect: redirect } }
+    subject { form.update!(params) }
+
+    it { should be_an_instance_of Hubspot::Form }
+    it 'updates properties' do 
+      subject.properties['name'].should be == new_name
+      subject.properties['redirect'].should be == redirect
+    end
+  end
+
+  describe '#destroy!' do 
+    cassette "form_destroy"
+
+    # NOTE: form previous created via the create! method
+    let(:form) { Hubspot::Form.find('8291bdd1-0681-4d99-b5f7-76ffffb4f98d') }
+    subject{ form.destroy! }
+    it { should be_true }
+    
+    it "should be destroyed" do
+      subject
+      form.destroyed?.should be_true
+    end
+  end
 end

data/spec/lib/hubspot/utils_spec.rb

@@ -28,71 +28,4 @@ describe Hubspot::Utils do
     it{ should include({"property" => "firstname", "value" => "Bob"}) }
     it{ should include({"property" => "lastname", "value" => "Smith"}) }
   end
-
-  describe ".generate_url" do
-    let(:path){ "/test/:email/profile" }
-    let(:params){{email: "test"}}
-    let(:options){{}}
-    subject{ Hubspot::Utils.generate_url(path, params, options) }
-    before{ Hubspot.configure(hapikey: "demo", portal_id: "62515") }
-
-    it "doesn't modify params" do
-      expect{ subject }.to_not change{params}
-    end
-
-    context "with a portal_id param" do
-      let(:path){ "/test/:portal_id/profile" }
-      let(:params){{}}
-      it{ should == "https://api.hubapi.com/test/62515/profile?hapikey=demo" }
-    end
-
-    context "when configure hasn't been called" do
-      before{ Hubspot::Config.reset! }
-      it "raises a config exception" do
-        expect{ subject }.to raise_error Hubspot::ConfigurationError
-      end
-    end
-
-    context "with interpolations but no params" do
-      let(:params){{}}
-      it "raises an interpolation exception" do
-        expect{ subject }.to raise_error Hubspot::MissingInterpolation
-      end
-    end
-
-    context "with an interpolated param" do
-      let(:params){ {email: "email@address.com"} }
-      it{ should == "https://api.hubapi.com/test/email@address.com/profile?hapikey=demo" }
-    end
-
-    context "with multiple interpolated params" do
-      let(:path){ "/test/:email/:id/profile" }
-      let(:params){{email: "email@address.com", id: 1234}}
-      it{ should == "https://api.hubapi.com/test/email@address.com/1234/profile?hapikey=demo" }
-    end
-
-    context "with query params" do
-      let(:params){{email: "email@address.com", id: 1234}}
-      it{ should == "https://api.hubapi.com/test/email@address.com/profile?id=1234&hapikey=demo" }
-
-      context "containing a time" do
-        let(:start_time) { Time.now }
-        let(:params){{email: "email@address.com", id: 1234, start: start_time}}
-        it{ should == "https://api.hubapi.com/test/email@address.com/profile?id=1234&start=#{start_time.to_i * 1000}&hapikey=demo" }
-      end
-
-      context "containing a range" do
-        let(:start_time) { Time.now }
-        let(:end_time) { Time.now + 1.year }
-        let(:params){{email: "email@address.com", id: 1234, created__range: start_time..end_time }}
-        it{ should == "https://api.hubapi.com/test/email@address.com/profile?id=1234&created__range=#{start_time.to_i * 1000}&created__range=#{end_time.to_i * 1000}&hapikey=demo" }
-      end
-    end
-
-    context "with options" do
-
-      let(:options){ {base_url: "https://cool.com", hapikey: false} }
-      it{ should == "https://cool.com/test/test/profile"}
-    end
-  end
 end

data/spec/live/deals_integration_spec.rb

@@ -0,0 +1,35 @@
+describe "Deals API Live test", live: true do
+
+  before do
+    Hubspot.configure hapikey: "demo"
+  end
+
+  it 'should create, find, update and destroy' do
+    contact = Hubspot::Contact.find_by_email("create_delete_test@hsgemtest.com") rescue nil
+    contact ||= Hubspot::Contact.create!("create_delete_test@hsgemtest.com")
+
+    expect(contact).to be_present
+
+    deal = Hubspot::Deal.create!(62515, [], [contact.vid], { amount: 30, dealstage: 'closedwon' })
+    expect(deal).to be_present
+
+    expect(deal['dealstage']).to eql 'closedwon'
+
+    deal.update!({dealstage: 'closedlost'})
+
+    expect(deal['dealstage']).to eql 'closedlost'
+    expect(deal['amount']).to eql '30'
+
+    #to be sure it was updated
+    updated_deal = Hubspot::Deal.find(deal.deal_id)
+
+    expect(updated_deal['dealstage']).to eql 'closedlost'
+    expect(updated_deal['amount']).to eql '30'
+
+    expect(deal.destroy!).to be true
+    expect(contact.destroy!).to be true
+
+    # cant find anymore
+    expect { Hubspot::Deal.find(deal.deal_id) }.to raise_error
+  end
+end

data/spec/spec_helper.rb

@@ -7,6 +7,7 @@ require 'simplecov'
 SimpleCov.root GEM_ROOT
 SimpleCov.start do
   add_filter "/spec/"
+  add_filter "/.bundle/"
 end
 
 require 'rspec'
@@ -39,4 +40,5 @@ RSpec.configure do |config|
   end
 
   config.extend CassetteHelper
+  config.extend TestsHelper
 end

data/spec/support/tests_helper.rb

@@ -0,0 +1,17 @@
+module TestsHelper
+  def expect_count_and_offset(&block)  
+    it 'returns only the number of objects specified by count' do
+      result = block.call(count: 2)
+      expect(result.size).to eql 2
+
+      result = block.call(count: 4)
+      expect(result.size).to eql 4
+    end
+
+    it 'returns objects by a specified offset' do
+      non_offset_objects = block.call(count: 2)  	
+      objects_with_offset = block.call(count: 2, offset: 2)
+      expect(non_offset_objects).to_not eql objects_with_offset
+    end
+  end
+end

metadata

@@ -1,195 +1,195 @@
 --- !ruby/object:Gem::Specification
 name: hubspot-ruby
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Andrew DiMichele
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-12 00:00:00.000000000 Z
+date: 2015-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.10.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rr
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '1.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '1.10'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: awesome_print
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: hubspot-ruby is a wrapper for the HubSpot REST API
@@ -200,8 +200,8 @@ extra_rdoc_files:
 - LICENSE.txt
 - README.md
 files:
-- .document
-- .rspec
+- ".document"
+- ".rspec"
 - Gemfile
 - Gemfile.lock
 - Guardfile
@@ -213,13 +213,17 @@ files:
 - lib/hubspot-ruby.rb
 - lib/hubspot/blog.rb
 - lib/hubspot/config.rb
+- lib/hubspot/connection.rb
 - lib/hubspot/contact.rb
+- lib/hubspot/contact_list.rb
+- lib/hubspot/contact_properties.rb
 - lib/hubspot/deal.rb
 - lib/hubspot/exceptions.rb
 - lib/hubspot/form.rb
 - lib/hubspot/topic.rb
 - lib/hubspot/utils.rb
 - lib/hubspot/version.rb
+- spec/fixtures/vcr_cassettes/add_contacts_to_lists.yml
 - spec/fixtures/vcr_cassettes/blog_list.yml
 - spec/fixtures/vcr_cassettes/blog_posts.yml
 - spec/fixtures/vcr_cassettes/blog_posts_list.yml
@@ -230,31 +234,64 @@ files:
 - spec/fixtures/vcr_cassettes/contact_destroy.yml
 - spec/fixtures/vcr_cassettes/contact_example.yml
 - spec/fixtures/vcr_cassettes/contact_find_by_email.yml
+- spec/fixtures/vcr_cassettes/contact_find_by_email_batch_mode.yml
 - spec/fixtures/vcr_cassettes/contact_find_by_id.yml
+- spec/fixtures/vcr_cassettes/contact_find_by_id_batch_mode.yml
 - spec/fixtures/vcr_cassettes/contact_find_by_utk.yml
+- spec/fixtures/vcr_cassettes/contact_find_by_utk_batch_mode.yml
+- spec/fixtures/vcr_cassettes/contact_list_batch_find.yml
+- spec/fixtures/vcr_cassettes/contact_list_destroy.yml
+- spec/fixtures/vcr_cassettes/contact_list_example.yml
+- spec/fixtures/vcr_cassettes/contact_list_find.yml
+- spec/fixtures/vcr_cassettes/contact_list_refresh.yml
+- spec/fixtures/vcr_cassettes/contact_list_update.yml
 - spec/fixtures/vcr_cassettes/contact_update.yml
+- spec/fixtures/vcr_cassettes/contacts_among_list.yml
+- spec/fixtures/vcr_cassettes/create_form.yml
+- spec/fixtures/vcr_cassettes/create_list.yml
+- spec/fixtures/vcr_cassettes/create_list_with_filters.yml
 - spec/fixtures/vcr_cassettes/deal_create.yml
 - spec/fixtures/vcr_cassettes/deal_example.yml
 - spec/fixtures/vcr_cassettes/deal_find.yml
 - spec/fixtures/vcr_cassettes/destroy_deal.yml
+- spec/fixtures/vcr_cassettes/fail_to_create_form.yml
+- spec/fixtures/vcr_cassettes/fail_to_create_list.yml
+- spec/fixtures/vcr_cassettes/field_among_form.yml
+- spec/fixtures/vcr_cassettes/fields_among_form.yml
 - spec/fixtures/vcr_cassettes/find_all_contacts.yml
+- spec/fixtures/vcr_cassettes/find_all_dynamic_lists.yml
+- spec/fixtures/vcr_cassettes/find_all_forms.yml
+- spec/fixtures/vcr_cassettes/find_all_lists.yml
+- spec/fixtures/vcr_cassettes/find_all_recent_contacts.yml
 - spec/fixtures/vcr_cassettes/find_all_recent_updated_deals.yml
+- spec/fixtures/vcr_cassettes/find_all_stastic_lists.yml
+- spec/fixtures/vcr_cassettes/form_destroy.yml
+- spec/fixtures/vcr_cassettes/form_example.yml
+- spec/fixtures/vcr_cassettes/form_find.yml
 - spec/fixtures/vcr_cassettes/form_post.yml
+- spec/fixtures/vcr_cassettes/form_submit_data.yml
+- spec/fixtures/vcr_cassettes/form_update.yml
 - spec/fixtures/vcr_cassettes/one_month_blog_posts_filter_state.yml
 - spec/fixtures/vcr_cassettes/one_month_blog_posts_list.yml
+- spec/fixtures/vcr_cassettes/remove_contacts_from_lists.yml
 - spec/fixtures/vcr_cassettes/topic_list.yml
 - spec/fixtures/vcr_cassettes/topics_list.yml
 - spec/lib/hubspot-ruby_spec.rb
 - spec/lib/hubspot/blog_spec.rb
 - spec/lib/hubspot/config_spec.rb
+- spec/lib/hubspot/connection_spec.rb
+- spec/lib/hubspot/contact_list_spec.rb
+- spec/lib/hubspot/contact_properties_spec.rb
 - spec/lib/hubspot/contact_spec.rb
 - spec/lib/hubspot/deal_spec.rb
 - spec/lib/hubspot/form_spec.rb
 - spec/lib/hubspot/topic_spec.rb
 - spec/lib/hubspot/utils_spec.rb
 - spec/live/contacts_integration_spec.rb
+- spec/live/deals_integration_spec.rb
 - spec/spec_helper.rb
 - spec/support/cassette_helper.rb
+- spec/support/tests_helper.rb
 homepage: http://github.com/omadahealth/hubspot-ruby
 licenses: []
 metadata: {}
@@ -264,17 +301,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: hubspot-ruby is a wrapper for the HubSpot REST API