hubspot-api-ruby 0.9.0 → 0.10.0

data/spec/lib/hubspot/contact_list_spec.rb

@@ -1,7 +1,18 @@
 describe Hubspot::ContactList do
+  # uncomment if you need to create test data in your panel.
+  # note that sandboxes have a limit of 5 dynamic lists
+  # before(:all) do
+  #   VCR.use_cassette("create_all_lists") do
+  #     25.times { Hubspot::ContactList.create!(name: SecureRandom.hex) }
+  #     3.times { Hubspot::ContactList.create!(name: SecureRandom.hex, dynamic: true, filters: [[{ operator: "EQ", value: "@hubspot", property: "twitterhandle", type: "string"}]]) }
+  #   end
+  # end
+
   let(:example_contact_list_hash) do
     VCR.use_cassette("contact_list_example") do
-      HTTParty.get("https://api.hubapi.com/contacts/v1/lists/124897?hapikey=demo").parsed_response
+      headers = { Authorization: "Bearer #{ENV.fetch('HUBSPOT_ACCESS_TOKEN')}" }
+      response = HTTParty.get("https://api.hubapi.com/contacts/v1/lists/static?count=1", headers: headers).parsed_response
+      response['lists'].first
     end
   end
 
@@ -9,12 +20,6 @@ describe Hubspot::ContactList do
     Hubspot::ContactList.create!(name: "static list #{SecureRandom.hex}")
   end
 
-  let(:example_contact_hash) do
-    VCR.use_cassette("contact_example") do
-      HTTParty.get("https://api.hubapi.com/contacts/v1/contact/email/testingapis@hubspot.com/profile?hapikey=demo").parsed_response
-    end
-  end
-
   shared_examples "count and offset" do |params|
     it 'returns only the number of objects specified by count' do
       result = instance_exec(count: 2, &params[:block])
@@ -38,7 +43,7 @@ describe Hubspot::ContactList do
     its(:id) { should be_an(Integer) }
     its(:portal_id) { should be_a(Integer) }
     its(:name) { should_not be_empty }
-    its(:dynamic) { should be true }
+    its(:dynamic) { should be false }
     its(:properties) { should be_a(Hash) }
   end
 
@@ -57,12 +62,6 @@ describe Hubspot::ContactList do
       end
     end
 
-    it 'returns by default 20 contact lists' do
-      expect(list.contacts.count).to eql 20
-      contact = list.contacts.first
-      expect(contact).to be_a(Hubspot::Contact)
-    end
-
     it 'returns by default 20 contact lists with paging data' do
       contact_data = list.contacts({bypass_cache: true, paged: true})
       contacts = contact_data['contacts']
@@ -73,15 +72,10 @@ describe Hubspot::ContactList do
       expect(contacts.count).to eql 20
       contact = contacts.first
       expect(contact).to be_a(Hubspot::Contact)
-    end
-
-    it 'add default properties to the contacts returned' do
-      contact = list.contacts.first
       expect(contact.email).to_not be_empty
     end
 
     it_behaves_like 'count and offset', {block: ->(r) { Hubspot::ContactList.find(list.id).contacts(r) }}
-
   end
 
   describe '.create' do
@@ -119,13 +113,6 @@ describe Hubspot::ContactList do
   end
 
   describe '.all' do
-    before(:all) do
-      VCR.use_cassette("create_all_lists") do
-        25.times { Hubspot::ContactList.create!(name: SecureRandom.hex) }
-        25.times { Hubspot::ContactList.create!(name: SecureRandom.hex, dynamic: true, filters: [[{ operator: "EQ", value: "@hubspot", property: "twitterhandle", type: "string"}]]) }
-      end
-    end
-
     context 'all list types' do
       cassette 'find_all_lists'
 
@@ -146,7 +133,7 @@ describe Hubspot::ContactList do
 
       it 'returns by defaut all the static contact lists' do
         lists = Hubspot::ContactList.all(static: true)
-        expect(lists.count).to be > 20
+        expect(lists.count).to be > 2
 
         list = lists.first
         expect(list).to be_a(Hubspot::ContactList)
@@ -159,7 +146,7 @@ describe Hubspot::ContactList do
 
       it 'returns by defaut all the dynamic contact lists' do
         lists = Hubspot::ContactList.all(dynamic: true)
-        expect(lists.count).to be > 20
+        expect(lists.count).to be > 2
 
         list = lists.first
         expect(list).to be_a(Hubspot::ContactList)
@@ -173,7 +160,7 @@ describe Hubspot::ContactList do
       cassette "contact_list_find"
       subject { Hubspot::ContactList.find(id) }
 
-      let(:list) { Hubspot::ContactList.create!(name: SecureRandom.hex) }
+      let(:list) { Hubspot::ContactList.new(example_contact_list_hash) }
 
       context 'when the contact list is found' do
         let(:id) { list.id.to_i }
@@ -188,7 +175,7 @@ describe Hubspot::ContactList do
 
       context 'Wrong parameter type given' do
         it 'raises an error' do
-          expect { Hubspot::ContactList.find(static_list) }.to raise_error(Hubspot::InvalidParams)
+          expect { Hubspot::ContactList.find({ foo: :bar }) }.to raise_error(Hubspot::InvalidParams)
         end
       end
 
@@ -287,12 +274,13 @@ describe Hubspot::ContactList do
 
     context 'static list' do
       it 'returns true if removes all contacts in batch mode' do
-        contacts = static_list.contacts(count: 2)
-        expect(static_list.remove([contacts.first, contacts.last])).to be true
+        list = Hubspot::ContactList.new(example_contact_list_hash)
+        contacts = list.contacts(count: 2)
+        expect(list.remove([contacts.first, contacts.last])).to be true
       end
 
       it 'returns false if the contact cannot be removed' do
-        contact_not_present_in_list = Hubspot::Contact.new(example_contact_hash)
+        contact_not_present_in_list = Hubspot::Contact.new(1234)
         expect(static_list.remove(contact_not_present_in_list)).to be false
       end
     end

data/spec/lib/hubspot/contact_spec.rb

@@ -209,7 +209,7 @@ RSpec.describe Hubspot::Contact do
 
       let!(:contact1) { create :contact }
 
-      subject { contact1.merge(1) }
+      subject { contact1.merge(contact1.id) }
 
       it 'raises an error' do
         expect {

data/spec/lib/hubspot/custom_event_spec.rb

@@ -1,7 +1,8 @@
 RSpec.describe Hubspot::CustomEvent do
-  let(:portal_id) { '62515' }
-  let(:sent_portal_id) { portal_id }
-  before { Hubspot.configure(hapikey: 'demo', custom_event_prefix: 'foobar') }
+  before do
+    Hubspot.configure(access_token: ENV.fetch("HUBSPOT_ACCESS_TOKEN"), portal_id: ENV.fetch("HUBSPOT_PORTAL_ID"),
+                      custom_event_prefix: 'foobar')
+  end
 
   describe '.trigger' do
     let(:event_name) { 'my_awesome_event' }
@@ -9,7 +10,7 @@ RSpec.describe Hubspot::CustomEvent do
     let(:properties) { { prop_foo: 'bar' } }
     let(:options) { {} }
     let(:base_url) { 'https://api.hubapi.com' }
-    let(:url) { "#{base_url}/events/v3/send?hapikey=demo" }
+    let(:url) { "#{base_url}/events/v3/send" }
 
     subject { described_class.trigger(event_name, email, properties, options) }
 

data/spec/lib/hubspot/engagement_spec.rb

@@ -1,22 +1,14 @@
 describe Hubspot::Engagement do
-
   let(:contact) { Hubspot::Contact.create("#{SecureRandom.hex}@hubspot.com") }
   let(:engagement) { Hubspot::EngagementNote.create!(contact.id, "foo") }
-  let(:example_engagement_hash) do
-    VCR.use_cassette("engagement_example") do
-      HTTParty.get("https://api.hubapi.com/engagements/v1/engagements/3981023?hapikey=demo").parsed_response
-    end
-  end
-  let(:example_associated_engagement_hash) do
-    VCR.use_cassette("engagement_associated_example") do
-      HTTParty.get("https://api.hubapi.com/engagements/v1/engagements/58699206?hapikey=demo").parsed_response
-    end
-  end
 
   # http://developers.hubspot.com/docs/methods/contacts/get_contact
 
   describe "#initialize" do
     subject{ Hubspot::Engagement.new(example_engagement_hash) }
+
+    let(:example_engagement_hash) { { 'engagement' => { 'id' => 3981023, 'portalId' => 62515, 'associations' => {} } } }
+
     it  { should be_an_instance_of Hubspot::Engagement }
     its (:id) { should == 3981023 }
   end

data/spec/lib/hubspot/event_spec.rb

@@ -1,7 +1,8 @@
 describe Hubspot::Event do
-  let(:portal_id) { '62515' }
+  let(:portal_id) { ENV.fetch("HUBSPOT_PORTAL_ID") }
   let(:sent_portal_id) { portal_id }
-  before { Hubspot.configure(hapikey: 'demo', portal_id: portal_id) }
+
+  before { Hubspot.configure(access_token: ENV.fetch("HUBSPOT_ACCESS_TOKEN"), portal_id: portal_id) }
 
   describe '.trigger' do
     let(:event_id) { '000000001625' }

data/spec/lib/hubspot/file_spec.rb

@@ -1,12 +1,23 @@
-describe Hubspot do
-  describe Hubspot::File do
-    before { Hubspot.configure(hapikey: "demo") }
-    describe ".find_by_id" do
-      it "should fetch specific file" do
-        VCR.use_cassette("file_find") do
-          file = Hubspot::File.find_by_id(5323360053)
-          file.id.should eq(5323360053)
-        end
+describe Hubspot::File do
+  let(:example_file_hash) do
+    VCR.use_cassette('file_example') do
+      headers = { Authorization: "Bearer #{ENV.fetch('HUBSPOT_ACCESS_TOKEN')}" }
+      body = {
+        file: File.open(File::NULL, 'r'),
+        options: { access: 'PRIVATE', ttl: 'P1M', overwrite: false }.to_json,
+        folderPath: '/'
+      }
+      url = 'https://api.hubapi.com/filemanager/api/v3/files/upload'
+      HTTParty.post(url, body: body, headers: headers).parsed_response
+    end
+  end
+
+  describe ".find_by_id" do
+    it "should fetch specific file" do
+      VCR.use_cassette("file_find") do
+        id = example_file_hash['objects'].first['id']
+        file = Hubspot::File.find_by_id(id)
+        file.id.should eq(id)
       end
     end
   end

data/spec/lib/hubspot/form_spec.rb

@@ -1,7 +1,9 @@
 describe Hubspot::Form do
   let(:example_form_hash) do
     VCR.use_cassette('form_example') do
-      HTTParty.get("https://api.hubapi.com#{Hubspot::Form::FORMS_PATH}/038e819c-5262-4c13-8550-8cabe38c4309/?hapikey=demo").parsed_response
+      guid = Hubspot::Form.all.first.guid
+      headers = { Authorization: "Bearer #{ENV.fetch('HUBSPOT_ACCESS_TOKEN')}" }
+      HTTParty.get("https://api.hubapi.com#{Hubspot::Form::FORMS_PATH}/#{guid}", headers: headers).parsed_response
     end
   end
 
@@ -29,8 +31,6 @@ describe Hubspot::Form do
   end
 
   describe '.all' do
-    before { Hubspot.configure(hapikey: 'demo') }
-
     cassette 'find_all_forms'
 
     it 'returns all forms' do
@@ -42,8 +42,6 @@ describe Hubspot::Form do
   end
 
   describe '.find' do
-    before { Hubspot.configure(hapikey: 'demo') }
-
     cassette 'form_find'
     subject { Hubspot::Form.find(Hubspot::Form.all.first.guid) }
 
@@ -79,7 +77,6 @@ describe Hubspot::Form do
   end
 
   describe '#fields' do
-    before { Hubspot.configure(hapikey: 'demo') }
     context 'returning all the fields' do
       cassette 'fields_among_form'
 
@@ -119,11 +116,11 @@ describe Hubspot::Form do
   describe '#submit' do
     cassette 'form_submit_data'
 
-    let(:form) { Hubspot::Form.create!(create_params) }
+    let(:form) { Hubspot::Form.all.first }
 
     context 'with a valid portal id' do
       before do
-        Hubspot.configure(hapikey: ENV.fetch("HUBSPOT_HAPI_KEY"), portal_id: ENV.fetch("HUBSPOT_PORTAL_ID"))
+        Hubspot.configure(access_token: ENV.fetch("HUBSPOT_ACCESS_TOKEN"), portal_id: ENV.fetch("HUBSPOT_PORTAL_ID"))
       end
 
       it 'returns true if the form submission is successful' do
@@ -135,7 +132,7 @@ describe Hubspot::Form do
 
     context 'with an invalid portal id' do
       before do
-        Hubspot.configure(hapikey: ENV.fetch("HUBSPOT_HAPI_KEY"), portal_id: "xxx")
+        Hubspot.configure(access_token: ENV.fetch("HUBSPOT_ACCESS_TOKEN"), portal_id: "xxx")
       end
 
       it 'returns false in case of errors' do
@@ -149,7 +146,7 @@ describe Hubspot::Form do
       let(:f) { Hubspot::Form.new('guid' => form.guid) }
 
       before do
-        Hubspot.configure(hapikey: ENV.fetch("HUBSPOT_HAPI_KEY"), portal_id: ENV.fetch("HUBSPOT_PORTAL_ID"))
+        Hubspot.configure(access_token: ENV.fetch("HUBSPOT_ACCESS_TOKEN"), portal_id: ENV.fetch("HUBSPOT_PORTAL_ID"))
       end
 
       it 'returns true if the form submission is successful' do
@@ -170,8 +167,8 @@ describe Hubspot::Form do
     let(:params) { { name: new_name, redirect: redirect } }
     subject { form.update!(params) }
 
-    it { should be_an_instance_of Hubspot::Form }
     it 'updates properties' do
+      should be_an_instance_of Hubspot::Form
       subject.properties['name'].should start_with('updated form name ')
       subject.properties['redirect'].should be == redirect
     end

data/spec/lib/hubspot/meeting_spec.rb

@@ -1,6 +1,12 @@
 RSpec.describe Hubspot::Meeting do
 
-  let(:hubspot_owner_id) { 123 }
+  let(:hubspot_owner_id) do
+    VCR.use_cassette('meeting_owner') do
+      headers = { Authorization: "Bearer #{ENV.fetch('HUBSPOT_ACCESS_TOKEN')}" }
+      owners = HTTParty.get('https://api.hubapi.com/owners/v2/owners', headers: headers).parsed_response
+      owners.first['ownerId']
+    end
+  end
   let(:hs_meeting_title) { 'hs_meeting_title' }
   let(:hs_meeting_body) { 'hs_meeting_body' }
   let(:hs_meeting_start_time) { DateTime.strptime('2022-05-03T10:00:00+01:00', '%Y-%m-%dT%H:%M:%S%z') }

data/spec/lib/hubspot/owner_spec.rb

@@ -1,12 +1,11 @@
 describe Hubspot::Owner do
   let(:example_owners) do
     VCR.use_cassette('owner_example') do
-      HTTParty.get('https://api.hubapi.com/owners/v2/owners?hapikey=demo&portalId=62515').parsed_response
+      headers = { Authorization: "Bearer #{ENV.fetch('HUBSPOT_ACCESS_TOKEN')}" }
+      HTTParty.get('https://api.hubapi.com/owners/v2/owners', headers: headers).parsed_response
     end
   end
 
-  before { Hubspot.configure(hapikey: 'demo') }
-
   describe '.all' do
     cassette 'owner_all'
 

data/spec/lib/hubspot/utils_spec.rb

@@ -1,4 +1,6 @@
 describe Hubspot::Utils do
+  API_HEADERS = { Authorization: "Bearer #{ENV.fetch('HUBSPOT_ACCESS_TOKEN')}" }.freeze
+
   describe ".properties_to_hash" do
     let(:properties) do
       {
@@ -32,13 +34,13 @@ describe Hubspot::Utils do
   describe '.compare_property_lists for ContactProperties' do
     let(:example_groups) do
       VCR.use_cassette('contact_properties/groups_example') do
-        HTTParty.get('https://api.hubapi.com/contacts/v2/groups?hapikey=demo').parsed_response
+        HTTParty.get('https://api.hubapi.com/contacts/v2/groups', headers: API_HEADERS).parsed_response
       end
     end
 
     let(:example_properties) do
       VCR.use_cassette('contact_properties/properties_example') do
-        HTTParty.get('https://api.hubapi.com/contacts/v2/properties?hapikey=demo').parsed_response
+        HTTParty.get('https://api.hubapi.com/contacts/v2/properties', headers: API_HEADERS).parsed_response
       end
     end
 
@@ -81,13 +83,13 @@ describe Hubspot::Utils do
   describe '.compare_property_lists for DealProperties' do
     let(:example_groups) do
       VCR.use_cassette('deal_groups_example') do
-        HTTParty.get('https://api.hubapi.com/deals/v1/groups?hapikey=demo').parsed_response
+        HTTParty.get('https://api.hubapi.com/deals/v1/groups', headers: API_HEADERS).parsed_response
       end
     end
 
     let(:example_properties) do
       VCR.use_cassette('deal_properties_example') do
-        HTTParty.get('https://api.hubapi.com/deals/v1/properties?hapikey=demo').parsed_response
+        HTTParty.get('https://api.hubapi.com/deals/v1/properties', headers: API_HEADERS).parsed_response
       end
     end
 
@@ -126,39 +128,4 @@ describe Hubspot::Utils do
       end
     end
   end
-
-  describe ".dump_properties" do
-    it "prints a deprecation warning" do
-      VCR.use_cassette("dump_deal_properties_and_groups") do
-        api_key = "demo"
-
-        output = capture_stderr do
-          Hubspot::Utils.dump_properties(Hubspot::DealProperties, api_key)
-        end
-
-        expected_warning = "Hubspot::Utils.dump_properties is deprecated"
-        expect(output).to include(expected_warning)
-      end
-    end
-  end
-
-  describe ".restore_properties" do
-    it "prints a deprecation warning" do
-      VCR.use_cassette("restore_deal_properties_and_groups") do
-        api_key = "demo"
-        properties = {"groups" => {}, "properties" => {}}
-
-        output = capture_stderr do
-          Hubspot::Utils.restore_properties(
-            Hubspot::DealProperties,
-            api_key,
-            properties
-          )
-        end
-
-        expected_warning = "Hubspot::Utils.restore_properties is deprecated"
-        expect(output).to include(expected_warning)
-      end
-    end
-  end
 end

data/spec/lib/hubspot-ruby_spec.rb

@@ -1,7 +1,7 @@
 RSpec.describe Hubspot do
   describe ".configure" do
     it "delegates .configure to Hubspot::Config.configure" do
-      options = { hapikey: "demo" }
+      options = { access_token: "demo" }
       allow(Hubspot::Config).to receive(:configure).with(options)
 
       Hubspot.configure(options)

data/spec/spec_helper.rb

@@ -30,11 +30,11 @@ Dir["#{RSPEC_ROOT}/shared_examples/**/*.rb"].each {|f| require f}
 
 RSpec.configure do |config|
   config.before(:all) do
-    Hubspot.configure(hapikey: ENV.fetch("HUBSPOT_HAPI_KEY"))
+    Hubspot.configure(access_token: ENV.fetch("HUBSPOT_ACCESS_TOKEN"))
   end
 
   config.before(:each) do
-    Hubspot.configure(hapikey: ENV.fetch("HUBSPOT_HAPI_KEY"))
+    Hubspot.configure(access_token: ENV.fetch("HUBSPOT_ACCESS_TOKEN"))
   end
 
   # config.after(:each) do

data/spec/support/vcr.rb

@@ -10,4 +10,5 @@ VCR.configure do |c|
   c.default_cassette_options = { record: vcr_record_mode }
   c.filter_sensitive_data("<HAPI_KEY>") { ENV.fetch("HUBSPOT_HAPI_KEY") }
   c.filter_sensitive_data("<PORTAL_ID>") { ENV.fetch("HUBSPOT_PORTAL_ID") }
+  c.filter_sensitive_data("<ACCESS_TOKEN>") { ENV.fetch("HUBSPOT_ACCESS_TOKEN") }
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hubspot-api-ruby
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.10.0
 platform: ruby
 authors:
 - Jonathan
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-06-29 00:00:00.000000000 Z
+date: 2022-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -294,7 +294,6 @@ files:
 - lib/hubspot/subscription.rb
 - lib/hubspot/topic.rb
 - lib/hubspot/utils.rb
-- lib/tasks/hubspot.rake
 - spec/factories/companies.rb
 - spec/factories/contacts.rb
 - spec/lib/hubspot-ruby_spec.rb
@@ -321,21 +320,18 @@ files:
 - spec/lib/hubspot/properties_spec.rb
 - spec/lib/hubspot/resource_spec.rb
 - spec/lib/hubspot/utils_spec.rb
-- spec/lib/tasks/hubspot_spec.rb
 - spec/shared_examples/saveable_resource.rb
 - spec/shared_examples/updateable_resource.rb
 - spec/spec_helper.rb
-- spec/support/capture_output.rb
 - spec/support/cassette_helper.rb
 - spec/support/hubspot_api_helpers.rb
-- spec/support/rake.rb
 - spec/support/vcr.rb
 homepage: https://github.com/captaincontrat/hubspot-api-ruby
 licenses:
 - MIT
 metadata:
   changelog_uri: https://github.com/captaincontrat/hubspot-api-ruby/blob/master/History.md
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -351,7 +347,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.2.32
-signing_key:
+signing_key: 
 specification_version: 4
 summary: hubspot-api-ruby is a wrapper for the HubSpot REST API
 test_files: []

data/lib/tasks/hubspot.rake

@@ -1,53 +0,0 @@
-require 'hubspot-api-ruby'
-
-namespace :hubspot do
-  desc 'Dump properties to file'
-  task :dump_properties, [:kind, :file, :hapikey, :include, :exclude] do |_, args|
-    Hubspot::Deprecator.build.deprecation_warning("hubspot:dump_properties")
-
-    hapikey = args[:hapikey] || ENV['HUBSPOT_API_KEY']
-    kind = args[:kind]
-    unless %w(contact deal).include?(kind)
-      raise ArgumentError, ':kind must be either "contact" or "deal"'
-    end
-    klass = kind == 'contact' ? Hubspot::ContactProperties : Hubspot::DealProperties
-    props = Hubspot::Utils::dump_properties(klass, hapikey, build_filter(args))
-    if args[:file].blank?
-      puts JSON.pretty_generate(props)
-    else
-      File.open(args[:file], 'w') do |f|
-        f.write(JSON.pretty_generate(props))
-      end
-    end
-  end
-
-  desc 'Restore properties from file'
-  task :restore_properties, [:kind, :file, :hapikey, :dry_run] do |_, args|
-    Hubspot::Deprecator.build.deprecation_warning("hubspot:restore_properties")
-
-    hapikey = args[:hapikey] || ENV['HUBSPOT_API_KEY']
-    if args[:file].blank?
-      raise ArgumentError, ':file is a required parameter'
-    end
-    kind = args[:kind]
-    unless %w(contact deal).include?(kind)
-      raise ArgumentError, ':kind must be either "contact" or "deal"'
-    end
-    klass = kind == 'contact' ? Hubspot::ContactProperties : Hubspot::DealProperties
-    file = File.read(args[:file])
-    props = JSON.parse(file)
-    Hubspot::Utils.restore_properties(klass, hapikey, props, args[:dry_run] != 'false')
-  end
-
-  private
-
-  def build_filter(args)
-    { include: val_to_array(args[:include]),
-      exclude: val_to_array(args[:exclude])
-    }
-  end
-
-  def val_to_array(val)
-    val.blank? ? val : val.split(/\W+/)
-  end
-end