hubrise_app 1.1.1 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 752df0a174985157db351f3086761ff039dbeed5f8fc99e11aa9427438d1fdae
-  data.tar.gz: 4e563cb2b305f54bc88cfe3e197c7b00eb537060b01aa1b703a0261ca8736835
+  metadata.gz: f60a817d70a55f7234ecdf8e886bc63c867c329c1e53f69f7a0356e049a1f266
+  data.tar.gz: d79c09f12c0f64a0e6d73baab22eb79cede8df9f73a90546cf93aefc5812f036
 SHA512:
-  metadata.gz: 34248f447c609c2965bf013ead89c9399325d71578767aa21d1e5f9ccb4ceac2789dfa504f9dc25e030db89b11c537a9f0beb5abc2ef7bcaa3c8d535fd76db65
-  data.tar.gz: b28e0a2d75bf14d46f300bbc2b78b5429c7a9c4baee544e69b78d9ec34a609b089e5c28a67113790f9c56e8c01cfed58c2d0f131ad267ef0071f306e22819e04
+  metadata.gz: 90c46db6e581ac2d9d46f66d24fafa37c40148459934213b3b406b193f86864f76855889c84261cfec88edc755b60e3429cd7a6e41e198902b6040c5e9a6da7d
+  data.tar.gz: e3c52b7505ed1b9acdc1202c873298366ac77ed705efb80ac4255171565d8dba1bf94685fc1d35619fd278a64275d880deb2f77cc4b075ba5f18650c57c4cb59

data/README.md

@@ -1,6 +1,5 @@
 ![](https://github.com/hubrise/ruby-app/workflows/spec/badge.svg)
 
-
 ## Installation
 
 Refer to https://github.com/HubRise/ruby-app/tree/master/spec/dummy/ for examples
@@ -11,6 +10,7 @@ Refer to https://github.com/HubRise/ruby-app/tree/master/spec/dummy/ for example
 4. Mount engine routes with `mount HubriseApp::Engine => "/"`
 5. Define `hubrise_open_path` rails route (e.g. `get :hubrise_open, to: "application#open"`)
 6. Inherit your `ApplicationController` and apply fundamental `before_actions`:
+
 ```
 class ApplicationController < HubriseApp::ApplicationController
   before_action :ensure_authenticated!
@@ -28,6 +28,7 @@ This gem provides a framework for a Hubrise App with a Resource Based Access.
 This means that each Hubrise User will be able to create a connection (App Instance) to multiple Accounts and Locations. And this connection will be shared with any other Hubrise User that has access to the same reseources on Hubrise side automatically.
 
 ### Note
+
 The main app's scopes (`account_scope` and `location_scope`) must not include any kind of `profile` access. Otherwise it will make no sense to share the connection with other users.
 
 ## Documentation
@@ -36,6 +37,7 @@ The framework is based on 3 different Oauth Workflows: `Connect Workflow`, `Logi
 And 4 main entities: `User`, `AppInstance`, `Account`, `Location`.
 
 ### Connect Workflow
+
 Usualy this workflow gets triggered by clicking the "Install" button from the Hubrise App Market.
 It requests the main connection with the `location_scope` or `account_scope` (which are specified by developer during app creation).
 
@@ -47,16 +49,16 @@ Note: this workflow is not responsible for creating a `User` record, it **only**
 
 - If there's no user logged in - the `Login Workflow` is triggered right away by redirecting to login oauth url.
 
-
 Code: https://github.com/HubRise/ruby-app/tree/master/app/controllers/hubrise_app/oauth_controller/action_connect_callback.rb
 
 ### Login Workflow
+
 Usualy this workflow gets triggered after `Connect Workflow` or by the `ensure_authenticated!` filter for any anon access.
 It requests `profile_with_email` scope.
 Once completed - a new `User` gets persisted in the DB with a profile `access_token` and redirected to `hubrise_open_path`.
 
-
 ### Authorize Workflow
+
 This workflow gets triggered by `ensure_app_instance_found!` whenever a logged in user does not have access (or it is expired) to `AppInstance` specified by `app_instance_id` param.
 If `app_instance_id` is not specified - its considered to be a broken request and a fatal error message is shown.
 
@@ -64,8 +66,8 @@ Note: when a user opens already installed app by clicking the button from Hubris
 
 This `app_instance_id` param is carried on from request to request using `default_url_options`: https://github.com/HubRise/ruby-app/tree/master/app/controllers/hubrise_app/application_controller/app_instance_methods.rb#L26
 
-
 A use case:
+
 1. UserA installs an app for Account1 - an `AppInstance` with `hr_id=abcd` being created
 2. UserA adds UserB as a manager to Account1 (via Hubrise Manager user roles table)
 3. UserB opens the installed app by clicking the button in the dashboard. It redirects to `open_url` with `app_instance_id=abcd`
@@ -73,9 +75,38 @@ A use case:
 5. UserB hits the `ensure_app_instance_found!` wall and agrees - a `UserAppInstace` being created for the user and `AppInstance` with `hr_id=abcd`
 6. UserB now has access to the `AppInstance`
 
-
 ## Extension
+
 TODO
 
+## Publish changes to this gem
+
+1. Make sure all local changes are committed.
+
+2. Increase version in `lib/hubrise_app/version.rb`
+
+3. Tag the repository:
+
+```bash
+VERSION=1.2.1
+bundle install
+git add Gemfile.lock
+git add lib/hubrise_app/version.rb
+git commit -m "Version $VERSION"
+git tag v$VERSION
+git push --tags
+git push
+```
+
+4. Build & publish:
+
+```bash
+rm -f hubrise_app-*.gem
+gem build hubrise_app
+gem push hubrise_app-*.gem
+rm -f hubrise_app-*.gem
+``` 
+
 ## License
+
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/Rakefile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 begin
   require "bundler/setup"
 rescue LoadError
@@ -23,10 +24,10 @@ require "bundler/gem_tasks"
 
 require "rake/testtask"
 
-Rake::TestTask.new(:test) do |t|
-  t.libs << "test"
-  t.pattern = "test/**/*_test.rb"
+Rake::TestTask.new(:spec) do |t|
+  t.libs << "spec"
+  t.pattern = "spec/**/*_spec.rb"
   t.verbose = false
 end
 
-task default: :test
+task default: :spec

data/app/controllers/hubrise_app/application_controller/app_instance_methods.rb

@@ -1,28 +1,34 @@
-module HubriseApp::ApplicationController::AppInstanceMethods
-  extend ActiveSupport::Concern
-  included do
-    helper_method :current_app_instance
-  end
+# frozen_string_literal: true
+module HubriseApp
+  class ApplicationController
+    module AppInstanceMethods
+      extend ActiveSupport::Concern
+      included do
+        helper_method :current_app_instance
+      end
 
-  def hr_app_instance_id
-    params[:app_instance_id]
-  end
+      def hr_app_instance_id
+        params[:app_instance_id]
+      end
 
-  def current_app_instance
-    if current_user
-      @app_instance ||= HubriseApp::Services::ResolveAppInstance.run(current_user.app_instances, hr_app_instance_id, self)
-    end
-  end
+      def current_app_instance
+        if current_user
+          @app_instance ||= HubriseApp::Services::ResolveAppInstance.run(current_user.app_instances, hr_app_instance_id,
+                                                                         self)
+        end
+      end
 
-  def ensure_app_instance_found!
-    if hr_app_instance_id.blank?
-      render(plain: "Something went wrong. Please try to reopen from Hubrise Dashboard.")
-    elsif current_app_instance.nil?
-      redirect_to(build_hubrise_oauth_authorize_url, allow_other_host: true)
-    end
-  end
+      def ensure_app_instance_found!
+        if hr_app_instance_id.blank?
+          render(plain: "Something went wrong. Please try to reopen from Hubrise Dashboard.")
+        elsif current_app_instance.nil?
+          redirect_to(build_hubrise_oauth_authorize_url, allow_other_host: true)
+        end
+      end
 
-  def default_url_options
-    super.merge(app_instance_id: hr_app_instance_id || current_app_instance&.hr_id)
+      def default_url_options
+        super.merge(app_instance_id: hr_app_instance_id || current_app_instance&.hr_id)
+      end
+    end
   end
 end

data/app/controllers/hubrise_app/application_controller/hubrise_gateway_methods.rb

@@ -1,25 +1,30 @@
-module HubriseApp::ApplicationController::HubriseGatewayMethods
-  def hubrise_gateway
-    @hubrise_gateway ||= HubriseApp::HubriseGateway.new
-  end
+# frozen_string_literal: true
+module HubriseApp
+  class ApplicationController
+    module HubriseGatewayMethods
+      def hubrise_gateway
+        @hubrise_gateway ||= HubriseApp::HubriseGateway.new
+      end
 
-  def build_hubrise_oauth_login_url
-    hubrise_gateway.build_login_authorization_url(build_hubrise_oauth_login_callback_url)
-  end
+      def build_hubrise_oauth_login_url
+        hubrise_gateway.build_login_authorization_url(build_hubrise_oauth_login_callback_url)
+      end
 
-  def build_hubrise_oauth_authorize_url
-    hubrise_gateway.build_app_authorization_url(hr_app_instance_id, build_hubrise_oauth_authorize_callback_url)
-  end
+      def build_hubrise_oauth_authorize_url
+        hubrise_gateway.build_app_authorization_url(hr_app_instance_id, build_hubrise_oauth_authorize_callback_url)
+      end
 
-  def build_hubrise_oauth_login_callback_url
-    hubrise_app.hubrise_oauth_login_callback_url
-  end
+      def build_hubrise_oauth_login_callback_url
+        hubrise_app.hubrise_oauth_login_callback_url
+      end
 
-  def build_hubrise_oauth_authorize_callback_url
-    hubrise_app.hubrise_oauth_authorize_callback_url
-  end
+      def build_hubrise_oauth_authorize_callback_url
+        hubrise_app.hubrise_oauth_authorize_callback_url
+      end
 
-  def build_hubrise_open_url
-    main_app.hubrise_open_path
+      def build_hubrise_open_url
+        main_app.hubrise_open_path
+      end
+    end
   end
 end

data/app/controllers/hubrise_app/application_controller/session_methods.rb

@@ -1,33 +1,38 @@
-module HubriseApp::ApplicationController::SessionMethods
-  extend ActiveSupport::Concern
-  included do
-    protect_from_forgery with: :reset_session
-    helper_method :current_user, :logged_in?
-  end
+# frozen_string_literal: true
+module HubriseApp
+  class ApplicationController
+    module SessionMethods
+      extend ActiveSupport::Concern
+      included do
+        protect_from_forgery with: :reset_session
+        helper_method :current_user, :logged_in?
+      end
 
-  def login(user)
-    session[:user_id] = user.id
-    @current_user  = user
-  end
+      def login(user)
+        session[:user_id] = user.id
+        @current_user = user
+      end
 
-  def logout
-    session[:user_id] = nil
-  end
+      def logout
+        session[:user_id] = nil
+      end
 
-  def current_user
-    @current_user ||= User.where(id: session[:user_id]).take
-  end
+      def current_user
+        @current_user ||= User.where(id: session[:user_id]).take
+      end
 
-  def logged_in?
-    !!current_user
-  end
+      def logged_in?
+        !!current_user
+      end
 
-  def ensure_authenticated!
-    unless logged_in?
-      redirect_to(build_hubrise_oauth_login_url, allow_other_host: true)
-      return
-    end
+      def ensure_authenticated!
+        unless logged_in?
+          redirect_to(build_hubrise_oauth_login_url, allow_other_host: true)
+          return
+        end
 
-    yield if block_given?
+        yield if block_given?
+      end
+    end
   end
 end

data/app/controllers/hubrise_app/application_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HubriseApp
   class ApplicationController < ActionController::Base
     include AppInstanceMethods

data/app/controllers/hubrise_app/callback_controller/action_disconnect.rb

@@ -1,5 +1,10 @@
-module HubriseApp::CallbackController::ActionDisconnect
-  def disconnect
-    head 200
+# frozen_string_literal: true
+module HubriseApp
+  class CallbackController
+    module ActionDisconnect
+      def disconnect
+        head(200)
+      end
+    end
   end
 end

data/app/controllers/hubrise_app/callback_controller/action_event.rb

@@ -1,5 +1,10 @@
-module HubriseApp::CallbackController::ActionEvent
-  def event
-    head 200
+# frozen_string_literal: true
+module HubriseApp
+  class CallbackController
+    module ActionEvent
+      def event
+        head(200)
+      end
+    end
   end
 end

data/app/controllers/hubrise_app/callback_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HubriseApp
   class CallbackController < ApplicationController
     skip_before_action :verify_authenticity_token

data/app/controllers/hubrise_app/oauth_controller/action_authorize_callback.rb

@@ -1,12 +1,17 @@
-module HubriseApp::OauthController::ActionAuthorizeCallback
-  # authorize access to specific app_instance (expirable)
-  def authorize_callback
-    ensure_authenticated! do
-      if current_app_instance
-        HubriseApp::Services::AssignAppInstance.run(current_user, current_app_instance, self)
-        redirect_to(build_hubrise_open_url)
-      else
-        render(plain: "Something went wrong. Please try to reinstall the app")
+# frozen_string_literal: true
+module HubriseApp
+  class OauthController
+    module ActionAuthorizeCallback
+      # authorize access to specific app_instance (expirable)
+      def authorize_callback
+        ensure_authenticated! do
+          if current_app_instance
+            HubriseApp::Services::AssignAppInstance.run(current_user, current_app_instance, self)
+            redirect_to(build_hubrise_open_url)
+          else
+            render(plain: "Something went wrong. Please try to reinstall the app")
+          end
+        end
       end
     end
   end

data/app/controllers/hubrise_app/oauth_controller/action_connect_callback.rb

@@ -1,12 +1,17 @@
-module HubriseApp::OauthController::ActionConnectCallback
-  def connect_callback
-    @app_instance = HubriseApp::Services::ConnectAppInstance.run(api_client_from_oauth_code, self)
+# frozen_string_literal: true
+module HubriseApp
+  class OauthController
+    module ActionConnectCallback
+      def connect_callback
+        @app_instance = HubriseApp::Services::ConnectAppInstance.run(api_client_from_oauth_code, self)
 
-    if logged_in?
-      HubriseApp::Services::AssignAppInstance.run(current_user, @app_instance, self)
-      redirect_to(build_hubrise_open_url)
-    else
-      redirect_to(build_hubrise_oauth_login_url, allow_other_host: true)
+        if logged_in?
+          HubriseApp::Services::AssignAppInstance.run(current_user, @app_instance, self)
+          redirect_to(build_hubrise_open_url)
+        else
+          redirect_to(build_hubrise_oauth_login_url, allow_other_host: true)
+        end
+      end
     end
   end
 end

data/app/controllers/hubrise_app/oauth_controller/action_login_callback.rb

@@ -1,7 +1,12 @@
-module HubriseApp::OauthController::ActionLoginCallback
-  def login_callback
-    user = HubriseApp::Refresher::User.from_api_client(api_client_from_oauth_code)
-    login(user)
-    redirect_to(build_hubrise_open_url)
+# frozen_string_literal: true
+module HubriseApp
+  class OauthController
+    module ActionLoginCallback
+      def login_callback
+        user = HubriseApp::Refresher::User.from_api_client(api_client_from_oauth_code)
+        login(user)
+        redirect_to(build_hubrise_open_url)
+      end
+    end
   end
 end

data/app/controllers/hubrise_app/oauth_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HubriseApp
   class OauthController < ApplicationController
     include ActionLoginCallback
@@ -8,8 +9,8 @@ module HubriseApp
 
     def current_app_instance
       @app_instance ||= HubriseApp::Services::ResolveAppInstance.run(
-                          AppInstance, api_client_from_oauth_code.app_instance_id, self
-                        )
+        AppInstance, api_client_from_oauth_code.app_instance_id, self
+      )
     end
 
     def api_client_from_oauth_code

data/app/controllers/hubrise_app/sessions_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HubriseApp
   class SessionsController < ApplicationController
     before_action :ensure_authenticated!

data/app/lib/hubrise_app/hubrise_gateway.rb

@@ -1,58 +1,61 @@
-class HubriseApp::HubriseGateway
-  HUBRISE_LOGIN_SCOPE = "profile_with_email".freeze
+# frozen_string_literal: true
+module HubriseApp
+  class HubriseGateway
+    HUBRISE_LOGIN_SCOPE = "profile_with_email"
 
-  def initialize(config = HubriseApp::CONFIG)
-    @config = config
-  end
+    def initialize(config = HubriseApp::CONFIG)
+      @config = config
+    end
 
-  def build_api_client(params = {})
-    HubriseClient::V1.new(
-      @config[:hubrise_client_id],
-      @config[:hubrise_client_secret],
-      params.merge(
-        oauth_host: @config[:hubrise_oauth_host],
-        oauth_port: @config[:hubrise_oauth_port],
-        api_host: @config[:hubrise_api_host],
-        api_port: @config[:hubrise_api_port],
-        use_https: @config[:hubrise_use_https]
+    def build_api_client(params = {})
+      HubriseClient::V1.new(
+        @config[:hubrise_client_id],
+        @config[:hubrise_client_secret],
+        params.merge(
+          oauth_host: @config[:hubrise_oauth_host],
+          oauth_port: @config[:hubrise_oauth_port],
+          api_host: @config[:hubrise_api_host],
+          api_port: @config[:hubrise_api_port],
+          use_https: @config[:hubrise_use_https]
+        )
       )
-    )
-  end
+    end
 
-  def build_api_client_from_app_instance(app_instance)
-    build_api_client(
-      access_token: app_instance.access_token,
-      app_instance_id: app_instance.hr_id,
-      account_id: app_instance.hr_account_id,
-      location_id: app_instance.hr_location_id,
-      catalog_id: app_instance.hr_catalog_id,
-      customer_list_id: app_instance.hr_customer_list_id
-    )
-  end
+    def build_api_client_from_app_instance(app_instance)
+      build_api_client(
+        access_token: app_instance.access_token,
+        app_instance_id: app_instance.hr_id,
+        account_id: app_instance.hr_account_id,
+        location_id: app_instance.hr_location_id,
+        catalog_id: app_instance.hr_catalog_id,
+        customer_list_id: app_instance.hr_customer_list_id
+      )
+    end
 
-  def build_api_client_from_authorization_code(authorization_code)
-    build_api_client.tap do |api_client|
-      api_client.authorize!(authorization_code)
+    def build_api_client_from_authorization_code(authorization_code)
+      build_api_client.tap do |api_client|
+        api_client.authorize!(authorization_code)
+      end
     end
-  end
 
-  def build_login_authorization_url(redirect_uri)
-    build_api_client.build_authorization_url(redirect_uri, HUBRISE_LOGIN_SCOPE)
-  end
+    def build_login_authorization_url(redirect_uri)
+      build_api_client.build_authorization_url(redirect_uri, HUBRISE_LOGIN_SCOPE)
+    end
 
-  def build_app_authorization_url(hr_app_instance_id, redirect_uri)
-    build_api_client.build_authorization_url(redirect_uri, nil, app_instance_id: hr_app_instance_id)
-  end
+    def build_app_authorization_url(hr_app_instance_id, redirect_uri)
+      build_api_client.build_authorization_url(redirect_uri, nil, app_instance_id: hr_app_instance_id)
+    end
 
-  def valid_hmac?(body, request_hmac)
-    calculated_hmac = OpenSSL::HMAC.hexdigest(
-                        OpenSSL::Digest.new("sha256"),
-                        @config[:hubrise_client_secret],
-                        body
-                      )
-    ActiveSupport::SecurityUtils.secure_compare(
-      calculated_hmac,
-      request_hmac || ""
-    )
+    def valid_hmac?(body, request_hmac)
+      calculated_hmac = OpenSSL::HMAC.hexdigest(
+        OpenSSL::Digest.new("sha256"),
+        @config[:hubrise_client_secret],
+        body
+      )
+      ActiveSupport::SecurityUtils.secure_compare(
+        calculated_hmac,
+        request_hmac || ""
+      )
+    end
   end
 end

data/app/lib/hubrise_app/refresher/account.rb

@@ -1,14 +1,17 @@
-module HubriseApp::Refresher
-  class Account < Base
-    class << self
-      def fetch_attributes(resource, api_client)
-        {
-          api_data: if api_client.location_id
-                      api_client.get_location(api_client.location_id).data["account"]
-                    else
-                      api_client.get_account(resource.hr_id).data
-                    end.except("id")
-        }
+# frozen_string_literal: true
+module HubriseApp
+  module Refresher
+    class Account < Base
+      class << self
+        def fetch_attributes(resource, api_client)
+          {
+            api_data: if api_client.location_id
+                        api_client.get_location(api_client.location_id).data["account"]
+                      else
+                        api_client.get_account(resource.hr_id).data
+                      end.except("id"),
+          }
+        end
       end
     end
   end

data/app/lib/hubrise_app/refresher/app_instance.rb

@@ -1,23 +1,26 @@
-module HubriseApp::Refresher
-  class AppInstance < Base
-    class << self
-      def run(resource, api_client, *refresher_args)
-        resource.update!(
-          access_token: api_client.access_token,
-          account: HubriseApp::Refresher::Account.from_api_client(
-            api_client, *refresher_args
-          ),
-          location: HubriseApp::Refresher::Location.from_api_client(
-            api_client, *refresher_args
-          ),
-          catalog: HubriseApp::Refresher::Catalog.from_api_client(
-            api_client, *refresher_args
-          ),
-          customer_list: HubriseApp::Refresher::CustomerList.from_api_client(
-            api_client, *refresher_args
+# frozen_string_literal: true
+module HubriseApp
+  module Refresher
+    class AppInstance < Base
+      class << self
+        def run(resource, api_client, *refresher_args)
+          resource.update!(
+            access_token: api_client.access_token,
+            account: HubriseApp::Refresher::Account.from_api_client(
+              api_client, *refresher_args
+            ),
+            location: HubriseApp::Refresher::Location.from_api_client(
+              api_client, *refresher_args
+            ),
+            catalog: HubriseApp::Refresher::Catalog.from_api_client(
+              api_client, *refresher_args
+            ),
+            customer_list: HubriseApp::Refresher::CustomerList.from_api_client(
+              api_client, *refresher_args
+            )
           )
-        )
-        resource
+          resource
+        end
       end
     end
   end

data/app/lib/hubrise_app/refresher/base.rb

@@ -1,45 +1,50 @@
-class HubriseApp::Refresher::Base
-  REFRESH_THRESHOLD = 1.day
-
-  class << self
-    def from_api_client(api_client, *args)
-      hr_id = api_client.public_send(id_key)
-      if hr_id
-        run(
-          model_factory.find_or_initialize_by(hr_id: hr_id),
-          api_client,
-          *args
-        )
+# frozen_string_literal: true
+module HubriseApp
+  module Refresher
+    class Base
+      REFRESH_THRESHOLD = 1.day
+
+      class << self
+        def from_api_client(api_client, *args)
+          hr_id = api_client.public_send(id_key)
+          if hr_id
+            run(
+              model_factory.find_or_initialize_by(hr_id:),
+              api_client,
+              *args
+            )
+          end
+        end
+
+        def run(resource, api_client, force: false)
+          return resource if !stale?(resource) && !force
+
+          resource.update!(
+            fetch_attributes(resource, api_client).merge(
+              refreshed_at: Time.now,
+            )
+          )
+          resource
+        end
+
+        protected
+
+        def fetch_attributes(_resource, _api_client)
+          {}
+        end
+
+        def stale?(resource)
+          resource.refreshed_at.nil? || Time.now - resource.refreshed_at > REFRESH_THRESHOLD
+        end
+
+        def model_factory
+          const_get("::" + name.demodulize)
+        end
+
+        def id_key
+          name.demodulize.underscore + "_id"
+        end
       end
     end
-
-    def run(resource, api_client, force: false)
-      return resource if !stale?(resource) && !force
-
-      resource.update!(
-        fetch_attributes(resource, api_client).merge(
-          refreshed_at: Time.now,
-        )
-      )
-      resource
-    end
-
-    protected
-
-    def fetch_attributes(_resource, _api_client)
-      {}
-    end
-
-    def stale?(resource)
-      resource.refreshed_at.nil? || Time.now - resource.refreshed_at > REFRESH_THRESHOLD
-    end
-
-    def model_factory
-      const_get("::" + self.name.demodulize)
-    end
-
-    def id_key
-      self.name.demodulize.underscore + "_id"
-    end
   end
 end

data/app/lib/hubrise_app/refresher/catalog.rb

@@ -1,12 +1,15 @@
-module HubriseApp::Refresher
-  class Catalog < Base
-    class << self
-      def fetch_attributes(resource, api_client)
-        {
-          api_data: api_client.get_catalog(resource.hr_id, hide_data: true)
-                              .data
-                              .except("id")
-        }
+# frozen_string_literal: true
+module HubriseApp
+  module Refresher
+    class Catalog < Base
+      class << self
+        def fetch_attributes(resource, api_client)
+          {
+            api_data: api_client.get_catalog(resource.hr_id, hide_data: true)
+              .data
+              .except("id"),
+          }
+        end
       end
     end
   end

data/app/lib/hubrise_app/refresher/customer_list.rb

@@ -1,12 +1,15 @@
-module HubriseApp::Refresher
-  class CustomerList < Base
-    class << self
-      def fetch_attributes(resource, api_client)
-        {
-          api_data: api_client.get_customer_list(resource.hr_id)
-                              .data
-                              .except("id")
-        }
+# frozen_string_literal: true
+module HubriseApp
+  module Refresher
+    class CustomerList < Base
+      class << self
+        def fetch_attributes(resource, api_client)
+          {
+            api_data: api_client.get_customer_list(resource.hr_id)
+              .data
+              .except("id"),
+          }
+        end
       end
     end
   end

data/app/lib/hubrise_app/refresher/location.rb

@@ -1,12 +1,15 @@
-module HubriseApp::Refresher
-  class Location < Base
-    class << self
-      def fetch_attributes(resource, api_client)
-        {
-          api_data: api_client.get_location(resource.hr_id)
-                              .data
-                              .except("id", "account")
-        }
+# frozen_string_literal: true
+module HubriseApp
+  module Refresher
+    class Location < Base
+      class << self
+        def fetch_attributes(resource, api_client)
+          {
+            api_data: api_client.get_location(resource.hr_id)
+              .data
+              .except("id", "account"),
+          }
+        end
       end
     end
   end

data/app/lib/hubrise_app/refresher/user.rb

@@ -1,15 +1,18 @@
-module HubriseApp::Refresher
-  class User < Base
-    class << self
-      def fetch_attributes(resource, api_client)
-        api_data = api_client.get_user.data
-        {
-          access_token: api_client.access_token,
-          email: api_data["email"],
-          first_name: api_data["first_name"],
-          last_name: api_data["last_name"],
-          locales: api_data["locales"]
-        }
+# frozen_string_literal: true
+module HubriseApp
+  module Refresher
+    class User < Base
+      class << self
+        def fetch_attributes(_resource, api_client)
+          api_data = api_client.get_user.data
+          {
+            access_token: api_client.access_token,
+            email: api_data["email"],
+            first_name: api_data["first_name"],
+            last_name: api_data["last_name"],
+            locales: api_data["locales"],
+          }
+        end
       end
     end
   end

data/app/lib/hubrise_app/services/assign_app_instance.rb

@@ -1,8 +1,13 @@
-class HubriseApp::Services::AssignAppInstance
-  def self.run(hr_user, hr_app_instance, _ctx)
-    UserAppInstance.find_or_initialize_by(
-      hr_app_instance_id: hr_app_instance.hr_id,
-      hr_user_id: hr_user.hr_id
-    ).update!(refreshed_at: Time.now)
+# frozen_string_literal: true
+module HubriseApp
+  module Services
+    class AssignAppInstance
+      def self.run(hr_user, hr_app_instance, _ctx)
+        UserAppInstance.find_or_initialize_by(
+          hr_app_instance_id: hr_app_instance.hr_id,
+          hr_user_id: hr_user.hr_id
+        ).update!(refreshed_at: Time.now)
+      end
+    end
   end
 end

data/app/lib/hubrise_app/services/connect_app_instance.rb

@@ -1,5 +1,10 @@
-class HubriseApp::Services::ConnectAppInstance
-  def self.run(api_client, _ctx)
-    HubriseApp::Refresher::AppInstance.from_api_client(api_client)
+# frozen_string_literal: true
+module HubriseApp
+  module Services
+    class ConnectAppInstance
+      def self.run(api_client, _ctx)
+        HubriseApp::Refresher::AppInstance.from_api_client(api_client)
+      end
+    end
   end
 end

data/app/lib/hubrise_app/services/resolve_app_instance.rb

@@ -1,5 +1,10 @@
-class HubriseApp::Services::ResolveAppInstance
-  def self.run(scope, id, _ctx)
-    scope.where(hr_id: id).take
+# frozen_string_literal: true
+module HubriseApp
+  module Services
+    class ResolveAppInstance
+      def self.run(scope, id, _ctx)
+        scope.where(hr_id: id).take
+      end
+    end
   end
 end

data/app/models/account.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 class Account < HubriseApp::AccountBase
 end

data/app/models/app_instance.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 class AppInstance < HubriseApp::AppInstanceBase
 end

data/app/models/catalog.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 class Catalog < HubriseApp::CatalogBase
 end

data/app/models/customer_list.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 class CustomerList < HubriseApp::CustomerListBase
 end

data/app/models/hubrise_app/account_base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HubriseApp
   class AccountBase < HubriseApp::ApplicationRecord
     self.abstract_class = true

data/app/models/hubrise_app/app_instance_base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HubriseApp
   class AppInstanceBase < HubriseApp::ApplicationRecord
     self.abstract_class = true

data/app/models/hubrise_app/application_record.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HubriseApp
   class ApplicationRecord < ActiveRecord::Base
     self.abstract_class = true

data/app/models/hubrise_app/catalog_base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HubriseApp
   class CatalogBase < HubriseApp::ApplicationRecord
     self.abstract_class = true

data/app/models/hubrise_app/customer_list_base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HubriseApp
   class CustomerListBase < HubriseApp::ApplicationRecord
     self.abstract_class = true

data/app/models/hubrise_app/location_base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HubriseApp
   class LocationBase < HubriseApp::ApplicationRecord
     self.abstract_class = true

data/app/models/hubrise_app/user_app_instance_base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HubriseApp
   class UserAppInstanceBase < HubriseApp::ApplicationRecord
     self.abstract_class = true

data/app/models/hubrise_app/user_base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HubriseApp
   class UserBase < HubriseApp::ApplicationRecord
     self.abstract_class = true

data/app/models/location.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 class Location < HubriseApp::LocationBase
 end

data/app/models/user.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 class User < HubriseApp::UserBase
 end

data/app/models/user_app_instance.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 class UserAppInstance < HubriseApp::UserAppInstanceBase
 end

data/config/initializers/hubrise_app_config.rb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 HubriseApp::CONFIG = HubriseApp::ConfigLoader.load

data/config/routes.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 HubriseApp::Engine.routes.draw do
   namespace :hubrise_oauth, controller: "/hubrise_app/oauth" do
     get :connect_callback

data/lib/hubrise_app/engine.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HubriseApp
   class Engine < ::Rails::Engine
     isolate_namespace HubriseApp

data/lib/hubrise_app/spec_support.rb

@@ -1,3 +1,6 @@
-class HubriseApp::SpecSupport
-  FACTORIES_PATH = File.expand_path("../../spec/factories", __dir__)
+# frozen_string_literal: true
+module HubriseApp
+  class SpecSupport
+    FACTORIES_PATH = File.expand_path("../../spec/factories", __dir__)
+  end
 end

data/lib/hubrise_app/version.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module HubriseApp
-  VERSION = "1.1.1".freeze
+  VERSION = "1.2.1"
 end

data/lib/hubrise_app.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "hubrise_app/engine"
 require "hubrise_client"
 

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: hubrise_app
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.1
 platform: ruby
 authors:
 - Antoine Monnier
 - Nick Save
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-07-21 00:00:00.000000000 Z
+date: 2024-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hubrise_client
@@ -17,30 +17,30 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.6
+        version: 2.0.10
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.6
+        version: 2.0.10
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.2.2
+        version: 7.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.2.2
-description: 
-email: 
+        version: 7.0.0
+description:
+email:
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -62,7 +62,6 @@ files:
 - app/controllers/hubrise_app/oauth_controller/action_connect_callback.rb
 - app/controllers/hubrise_app/oauth_controller/action_login_callback.rb
 - app/controllers/hubrise_app/sessions_controller.rb
-- app/lib/hubrise_app/config_loader.rb
 - app/lib/hubrise_app/hubrise_gateway.rb
 - app/lib/hubrise_app/refresher/account.rb
 - app/lib/hubrise_app/refresher/app_instance.rb
@@ -106,7 +105,7 @@ homepage: https://github.com/HubRise/ruby-app
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -121,8 +120,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.3.26
+signing_key:
 specification_version: 4
 summary: Rails engine to bootstrap a HubRise-based application
 test_files: []

data/app/lib/hubrise_app/config_loader.rb

@@ -1,5 +0,0 @@
-class HubriseApp::ConfigLoader
-  def self.load
-    Rails.application.config_for("hubrise_app/config").deep_symbolize_keys
-  end
-end