hubless 0.2.0 → 0.3.0

data/BLACKLIST.yml

@@ -0,0 +1,4 @@
+---
+- sqlite3-ruby
+- libxml-ruby
+- .*-ruby

data/README.markdown

@@ -21,7 +21,6 @@ Search your local gem repository for gems installed from GitHub that have since
 	To uninstall these GitHub gems run:
 	gem uninstall thoughtbot-shoulda -v 2.10.1
 	gem uninstall thoughtbot-factory_girl -v 1.2.1
-	gem uninstall sqlite3-ruby -v 1.2.4
 	gem uninstall rubyist-aasm -v 2.1.1
 	gem uninstall relevance-rcov -v 0.8.6
 	gem uninstall mojombo-chronic -v 0.3.0
@@ -32,7 +31,6 @@ Search your local gem repository for gems installed from GitHub that have since
 	To reinstall these gems from Gemcutter run:
 	gem install shoulda -v 2.10.1
 	gem install factory_girl -v 1.2.1
-	gem install ruby -v 1.2.4
 	gem install aasm -v 2.1.1
 	gem install rcov -v 0.8.6
 	gem install chronic -v 0.3.0
@@ -40,6 +38,12 @@ Search your local gem repository for gems installed from GitHub that have since
 	gem install metric_fu -v 1.1.5
 	gem install whenever -v 0.3.6
 
+## Blacklist
+
+Hubless now has a blacklist of gems with unfortunate names, that should not be reinstalled. For example: [sqlite3-ruby](http://github.com/sqlite3/ruby).
+
+If you encounter any of these gems, please fork this project, add them to BLACKLIST.yml and submit a Pull Request. Thanks!
+
 ## Copyright
 
 Copyright (c) 2010 Greg Sterndale. See LICENSE for details.

data/VERSION

@@ -1 +1 @@
-0.2.0
+0.3.0

data/hubless.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{hubless}
-  s.version = "0.2.0"
+  s.version = "0.3.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Greg Sterndale"]
-  s.date = %q{2010-01-17}
+  s.date = %q{2010-01-19}
   s.default_executable = %q{hubless}
   s.description = %q{Search your local gem repository for gems installed from GitHub that have since moved to Gemcutter}
   s.email = %q{greg@plectix.com}
@@ -21,6 +21,7 @@ Gem::Specification.new do |s|
   s.files = [
     ".document",
      ".gitignore",
+     "BLACKLIST.yml",
      "LICENSE",
      "README.markdown",
      "Rakefile",

data/lib/gem_description.rb

@@ -6,12 +6,14 @@ class Hubless
 
   class GemDescription
 
+    BLACKLIST = File.join(File.dirname(__FILE__), '..', 'BLACKLIST.yml')
+
     attr_reader :name
     attr_accessor :version
 
     # GemDescriptions of all gems installed locally
     def self.local_gems
-      @@local_gems ||= Gem.cache.map {|g| new(g.first) }.sort!{|x,y| y.name <=> x.name }
+      @@local_gems ||= Gem.cache.map {|g| new(g.first) }.sort!{|x,y| x.name <=> y.name }
     end
 
     # New GemDescription from a one-liner or options Hash
@@ -33,6 +35,11 @@ class Hubless
       @name = str
     end
 
+    # Does this name appear on the blacklist
+    def blacklisted?
+      ! self.class.blacklist.detect{|b| /\A#{b}\Z/i =~ self.name }.nil?
+    end
+
     # Does a repo exist on GitHub that matches this gem
     def github?
       if @is_github.nil?
@@ -83,6 +90,10 @@ class Hubless
 
   protected
 
+    def self.blacklist
+      @@blacklist ||= YAML.load_file(BLACKLIST)
+    end
+
     def clear
       @is_gemcutter = @is_github = nil
     end

data/lib/hubless.rb

@@ -51,18 +51,18 @@ class Hubless
 
   def uninstall_instructions
     @@io.puts("\nTo uninstall these GitHub gems run:")
-    self.gems.each {|g| @@io.puts(g.uninstall_cmd) if g.github? && g.gemcutter? }
+    self.gems.each {|g| @@io.puts(g.uninstall_cmd) if g.github? && g.gemcutter? && !g.blacklisted? }
   end
 
   def install_instructions
     @@io.puts("\nTo reinstall these gems from Gemcutter run:")
-    self.gems.each {|g| @@io.puts(g.install_cmd) if g.github? && g.gemcutter? }
+    self.gems.each {|g| @@io.puts(g.install_cmd) if g.github? && g.gemcutter? && !g.blacklisted? }
   end
 
   def install_gems
     @@io.puts("\nInstalling gems:")
     self.gems.each do |g|
-      if g.github? && g.gemcutter?
+      if g.github? && g.gemcutter? && !g.blacklisted?
         cmd = g.install_cmd
         @@io.puts cmd
         raise GemInstallError unless Kernel.system(cmd)

data/test/test_gem_description.rb

@@ -43,6 +43,19 @@ class TestGemDescription < Test::Unit::TestCase
     assert_equal name, gem_description.name
   end
 
+  def test_blacklisted?
+    legit_name    = 'my-github_and_gemcutter_gem'
+    illigit_name1 = 'github-exploit'
+    illigit_name2 = '.*-ruby'
+    YAML.expects(:load_file).once.with(Hubless::GemDescription::BLACKLIST).returns([illigit_name1, illigit_name2])
+    legit_gem_description    = Hubless::GemDescription.new(:name => legit_name)
+    illigit_gem1_description = Hubless::GemDescription.new(:name => illigit_name1)
+    illigit_gem2_description = Hubless::GemDescription.new(:name => 'foo-ruby')
+    assert ! legit_gem_description.blacklisted?
+    assert illigit_gem1_description.blacklisted?
+    assert illigit_gem2_description.blacklisted?
+  end
+
   def test_github_name
     user = 'my'
     repo = 'github_and_gemcutter_gem'

data/test/test_hubless.rb

@@ -66,9 +66,9 @@ class TestHubless < Test::Unit::TestCase
 
   def test_uninstall_instructions
     local_gems = [
-        mock(:uninstall_cmd => 'foo', :github? => true, :gemcutter? => true),
-        mock(:uninstall_cmd => 'bar', :github? => true, :gemcutter? => true),
-        mock(:uninstall_cmd => 'abc', :github? => true, :gemcutter? => true),
+        mock(:uninstall_cmd => 'foo', :github? => true, :gemcutter? => true, :blacklisted? => false),
+        mock(:uninstall_cmd => 'bar', :github? => true, :gemcutter? => true, :blacklisted? => false),
+        mock(:github? => true, :gemcutter? => true, :blacklisted? => true),
         mock(:github? => true, :gemcutter? => false),
         mock(:github? => false)
       ]
@@ -76,16 +76,15 @@ class TestHubless < Test::Unit::TestCase
     @io.expects(:puts).with{|s| s =~ /To uninstall these GitHub gems run:/ }
     @io.expects(:puts).once.with{|s| s =~ /foo/ }
     @io.expects(:puts).once.with{|s| s =~ /bar/ }
-    @io.expects(:puts).once.with{|s| s =~ /abc/ }
     hubless = Hubless.new
     hubless.uninstall_instructions
   end
 
   def test_install_instructions
     local_gems = [
-        mock(:install_cmd => 'foo', :github? => true, :gemcutter? => true),
-        mock(:install_cmd => 'bar', :github? => true, :gemcutter? => true),
-        mock(:install_cmd => 'abc', :github? => true, :gemcutter? => true),
+        mock(:install_cmd => 'foo', :github? => true, :gemcutter? => true, :blacklisted? => false),
+        mock(:install_cmd => 'bar', :github? => true, :gemcutter? => true, :blacklisted? => false),
+        mock(:github? => true, :gemcutter? => true, :blacklisted? => true),
         mock(:github? => true, :gemcutter? => false),
         mock(:github? => false)
       ]
@@ -93,16 +92,15 @@ class TestHubless < Test::Unit::TestCase
     @io.expects(:puts).with{|s| s =~ /To reinstall these gems from Gemcutter run:/ }
     @io.expects(:puts).once.with{|s| s =~ /foo/ }
     @io.expects(:puts).once.with{|s| s =~ /bar/ }
-    @io.expects(:puts).once.with{|s| s =~ /abc/ }
     hubless = Hubless.new
     hubless.install_instructions
   end
 
   def test_install_gems
     local_gems = [
-        mock(:install_cmd => 'foo', :github? => true, :gemcutter? => true),
-        mock(:install_cmd => 'bar', :github? => true, :gemcutter? => true),
-        mock(:install_cmd => 'abc', :github? => true, :gemcutter? => true),
+        mock(:install_cmd => 'foo', :github? => true, :gemcutter? => true, :blacklisted? => false),
+        mock(:install_cmd => 'bar', :github? => true, :gemcutter? => true, :blacklisted? => false),
+        mock(:github? => true, :gemcutter? => true, :blacklisted? => true),
         mock(:github? => true, :gemcutter? => false),
         mock(:github? => false)
       ]
@@ -110,15 +108,13 @@ class TestHubless < Test::Unit::TestCase
     @io.expects(:puts).with{|s| s =~ /Installing gems:/ }
     @io.expects(:puts).once.with{|s| s =~ /foo/ }
     @io.expects(:puts).once.with{|s| s =~ /bar/ }
-    @io.expects(:puts).once.with{|s| s =~ /abc/ }
     Kernel.expects(:system).once.with{|s| s =~ /foo/ }.returns(true)
     Kernel.expects(:system).once.with{|s| s =~ /bar/ }.returns(true)
-    Kernel.expects(:system).once.with{|s| s =~ /abc/ }.returns(true)
     hubless = Hubless.new
     hubless.install_gems
     
     local_gems = [
-        mock(:install_cmd => 'foo', :github? => true, :gemcutter? => true)
+        mock(:install_cmd => 'foo', :github? => true, :gemcutter? => true, :blacklisted? => false)
       ]
     Hubless::GemDescription.expects(:local_gems).once.returns(local_gems)
     @io.expects(:puts).with{|s| s =~ /Installing gems:/ }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: hubless
 version: !ruby/object:Gem::Version 
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors: 
 - Greg Sterndale
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-17 00:00:00 -05:00
+date: 2010-01-19 00:00:00 -05:00
 default_executable: hubless
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -34,6 +34,7 @@ extra_rdoc_files:
 files: 
 - .document
 - .gitignore
+- BLACKLIST.yml
 - LICENSE
 - README.markdown
 - Rakefile