hub_kernel 0.12.0 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 229fcc87e3137795f02b73e3f0be126e9809181b14446e09e8a1a050fa83420e
-  data.tar.gz: 2347fa14b7911dda34f7e1cbebb924eb10f99f8da0e5e086f112f78aa79440b9
+  metadata.gz: 595e557959d0639e93e97244f510db28bd024e524fbca3bbdf0223546e7ee52d
+  data.tar.gz: d01f6e5c5d3d06c9fb3cb8bf3d7ed92f2b321952d99b3f04d19af77f14ffe388
 SHA512:
-  metadata.gz: e432500a7d6b4dc4c0e7a4061d74dfc81108435a640d4098afaa0a9ca58518790b75d94ba5e5d49e28c87e88925a1b6369f36968cc5b9fafb31480034730ecde
-  data.tar.gz: fbf852ad51486ad330f5b7b0cefa7f36d599c7c713a0a95e2cffcbd689e41ea0042550a00e24c66a19778507e32ff992001aa90828ea10f6c8ed2d4f6d74f644
+  metadata.gz: 988f17639404b44e3e25772160c14a504541abd2981f21587357ddd8175419784553143cb42e63b66adbbc07102a0a8488f735711cfd724fd26e3e180a370295
+  data.tar.gz: cfa7009ca3d343f8da7c0429802c7b32df0a3d4a39af4260f43ef25e8f28d35b07254b27094233bbb860cef39832b4bad52e1669941a4dccbc16dd432e3c833b

data/README.md

@@ -180,7 +180,8 @@ class HubCrossingsTest < ActiveSupport::TestCase
       owners: { supplies: %w[Shop::Purchase Shop::PurchasesController], finance: %w[Shop::Expense], shop: %w[Shop::Home] },
       shared: %w[Shop::BaseController],
       host_layer: :shop,
-      interfaces: { supplies: "Shop::Hubs::Supplies", finance: "Shop::Hubs::Finance" }
+      interfaces: { supplies: "Shop::Hubs::Supplies", finance: "Shop::Hubs::Finance" },
+      namespaces: { billing: %w[Billing] }
     )
   end
 end
@@ -189,6 +190,9 @@ end
 - A constant inside another hub's class counts as naming that class.
 - A name no hub owns, such as a namespace, is not a crossing, and neither is a class on
   the `shared` list.
+- `namespaces` gives a hub every class under a namespace, such as a hub gem's `Billing`,
+  so its classes need not be listed one by one. A class listed by name in `owners`
+  belongs to its listed hub even under another hub's namespace.
 - A view belongs to the hub that owns its controller, then to the hub that owns the
   record its folder is named after, and otherwise to the `host_layer`.
 - The host's layer may name any hub's interface module, and a hub naming another hub's
@@ -199,6 +203,9 @@ end
 - It also fails naming each class defined in the files it reads that no hub owns, such as
   "No hub owns Shop::Refund", and each class the map gives to two hubs, such as "Two hubs
   own Shop::Receipt".
+- It fails naming each class the map names that no longer exists in the app, such as "The
+  map names Shop::Ghost, which does not exist", so a renamed or removed class does not
+  stay in the map.
 
 ## Installation
 Add this line to your application's Gemfile:

data/lib/hub_kernel/conformance/crossings.rb

@@ -34,6 +34,11 @@ module HubKernel
           twice = the_crossings.claimed_twice
           assert twice.empty?, twice.map { |name| "Two hubs own #{name}" }.join("\n")
         end
+
+        test "every class the map names exists" do
+          missing = the_crossings.missing_classes
+          assert missing.empty?, missing.map { |name| "The map names #{name}, which does not exist" }.join("\n")
+        end
       end
 
       def crossing_paths = (Dir.glob(crossing_files, base: crossing_root) - crossing_exceptions).sort

data/lib/hub_kernel/crossings.rb

@@ -2,11 +2,12 @@ require "active_support/core_ext/string/inflections"
 
 module HubKernel
   class Crossings
-    def initialize(owners:, shared: [], host_layer: nil, interfaces: {})
+    def initialize(owners:, shared: [], host_layer: nil, interfaces: {}, namespaces: {})
       @owners = owners
       @shared = shared
       @host_layer = host_layer
       @interfaces = interfaces
+      @namespaces = namespaces
     end
 
     def in(path, source)
@@ -22,6 +23,8 @@ module HubKernel
 
     def claimed_twice = @owners.values.flatten.tally.select { |_name, hubs| hubs > 1 }.keys
 
+    def missing_classes = @owners.values.flatten.uniq.reject(&:safe_constantize)
+
     private
 
     def class_of(path) = path.sub(%r{\Aapp/[^/]+/}, "").delete_suffix(".rb").camelize
@@ -34,10 +37,20 @@ module HubKernel
 
     def owned_class_in(name)
       parts = name.split("::")
-      parts.size.downto(1).map { |size| parts.first(size).join("::") }.find { |candidate| owner_of(candidate) }
+      listed = parts.size.downto(1).map { |size| parts.first(size).join("::") }.find { |candidate| listed_owner_of(candidate) }
+      listed || class_under_namespace(name)
+    end
+
+    def class_under_namespace(name)
+      space = @namespaces.values.flatten.find { |namespace| name.start_with?("#{namespace}::") }
+      space && "#{space}::#{name.delete_prefix("#{space}::").split("::").first}"
     end
 
-    def owner_of(class_name) = @interfaces.key(class_name) || @owners.find { |_hub, classes| classes.include?(class_name) }&.first
+    def listed_owner_of(class_name) = @interfaces.key(class_name) || @owners.find { |_hub, classes| classes.include?(class_name) }&.first
+
+    def owner_of(class_name) = listed_owner_of(class_name) || owner_of_namespace(class_name)
+
+    def owner_of_namespace(class_name) = @namespaces.find { |_hub, spaces| spaces.any? { |space| class_name.start_with?("#{space}::") } }&.first
 
     def owner_of_file(path)
       return owner_of_view_folder(File.dirname(path.delete_prefix("app/views/")).camelize) if path.start_with?("app/views/")

data/lib/hub_kernel/version.rb

@@ -1,3 +1,3 @@
 module HubKernel
-  VERSION = "0.12.0"
+  VERSION = "0.14.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hub_kernel
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.14.0
 platform: ruby
 authors:
 - tylercschneider